@valbuild/server 0.144.4 → 0.144.5

package/CHANGELOG.md

@@ -1,5 +1,19 @@
 # @valbuild/server
 
+## 0.144.5
+
+### Patch Changes
+
+- [#839](https://github.com/valbuild/val/pull/839) [`39e8db3`](https://github.com/valbuild/val/commit/39e8db34cf56c6c43ffff0d3acfe8e0839fa55a9) Thanks [@freekh](https://github.com/freekh)! - A publish that breaks a page no longer stops everyone else publishing. On val.build, the changes it had are held back: the Publish button says how many, and publishes go without them until someone presses Try again or Discard on the failed publish.
+
+  Publish can be pressed while this tab is still building the last publish. The new publish waits its turn and is built when the current one ends.
+
+  Discarding a change that is being published now says so, instead of failing silently. From there you can cancel the publish, which then discards the change, or wait for the publish to end.
+
+- Updated dependencies [[`39e8db3`](https://github.com/valbuild/val/commit/39e8db34cf56c6c43ffff0d3acfe8e0839fa55a9)]:
+  - @valbuild/ui@0.144.5
+  - @valbuild/shared@0.144.5
+
 ## 0.144.4
 
 ### Patch Changes

package/dist/declarations/src/ValOps.d.ts

@@ -1029,6 +1029,13 @@ export type OrderedPatches = {
      * service. Only `ValOpsHttp` fills it.
      */
     publishingPatches?: PatchId[];
+    /**
+     * Of these patches, the ones a publish that failed on its content holds back
+     * from later publishes, until Try again or Discard: they are pending, and
+     * not ready to publish. Absent where publishing is not done in jobs, and
+     * from an older content service. Only `ValOpsHttp` fills it.
+     */
+    heldBackPatches?: PatchId[];
     error?: GenericErrorMessage;
     errors?: PatchReadError[];
     unauthorized?: boolean;
@@ -1048,6 +1055,8 @@ export type OrderedPatchesMetadata = {
     patchGroups?: OrderedPatches["patchGroups"];
     /** See {@link OrderedPatches.publishingPatches}. */
     publishingPatches?: OrderedPatches["publishingPatches"];
+    /** See {@link OrderedPatches.heldBackPatches}. */
+    heldBackPatches?: OrderedPatches["heldBackPatches"];
     error?: GenericErrorMessage;
     errors?: OrderedPatches["errors"];
     unauthorized?: boolean;

package/dist/declarations/src/ValOpsHttp.d.ts

@@ -373,6 +373,8 @@ export declare class ValOpsHttp extends ValOps {
         appliedPatches: PatchId[];
         /** Of `patches`, the ones a running publish holds. See {@link OrderedPatches.publishingPatches}. */
         publishingPatches?: PatchId[];
+        /** Of `patches`, the ones a failed publish holds back. See {@link OrderedPatches.heldBackPatches}. */
+        heldBackPatches?: PatchId[];
         /** The head of the chain. See {@link OrderedPatchesMetadata.headPatchId}. */
         headPatchId?: PatchId | null;
         /** The chain version of that head. See {@link OrderedPatchesMetadata.headVersion}. */

package/dist/valbuild-server.cjs.dev.js

@@ -9413,6 +9413,8 @@ const GetApplicablePatches = z.z.object({
   headVersion: z.z.number().optional(),
   /** Of `patches`, the ones a running publish holds. See `OrderedPatches.publishingPatches`. */
   publishingPatches: z.z.array(internal.PatchId).optional(),
+  /** Of `patches`, the ones a failed publish holds back. See `OrderedPatches.heldBackPatches`. */
+  heldBackPatches: z.z.array(internal.PatchId).optional(),
   commits: z.z.array(z.z.object({
     commitSha: z.z.string(),
     /*
@@ -9505,7 +9507,9 @@ const DeletePatchesResponse = z.z.object({
   deleted: z.z.array(PatchId),
   errors: z.z.array(z.z.object({
     message: z.z.string(),
-    patchId: PatchId
+    patchId: PatchId,
+    /** The publish job holding it, when that is why it was not deleted. */
+    publishJobId: z.z.string().optional()
   })).optional(),
   /**
    * The chain version each branch the delete changed is now at, keyed by
@@ -10445,6 +10449,10 @@ class ValOpsHttp extends ValOps {
       ...(allPatchData.publishingPatches !== undefined ? {
         publishingPatches: allPatchData.publishingPatches
       } : {}),
+      // Absent from a content service that does not say, as above.
+      ...(allPatchData.heldBackPatches !== undefined ? {
+        heldBackPatches: allPatchData.heldBackPatches
+      } : {}),
       /*
        * The CHAIN head, not the publish head below. Spread: absent is a content
        * service that does not report it, which is not the same as `null`.
@@ -10877,6 +10885,9 @@ class ValOpsHttp extends ValOps {
             } : {}),
             ...(data.publishingPatches !== undefined ? {
               publishingPatches: data.publishingPatches
+            } : {}),
+            ...(data.heldBackPatches !== undefined ? {
+              heldBackPatches: data.heldBackPatches
             } : {})
           };
         }
@@ -15717,7 +15728,14 @@ const ValServer = (valModules, options, callbacks) => {
               message: "Failed to delete patches",
               errors: Object.entries(deleteRes.errors).map(([id, error]) => ({
                 patchId: id,
-                ...error
+                ...error,
+                /*
+                 * Kept, so the Studio can say the change is being published
+                 * and offer to cancel that publish: content names the job.
+                 */
+                ...("publishJobId" in error && typeof error.publishJobId === "string" ? {
+                  publishJobId: error.publishJobId
+                } : {})
               }))
             }
           };
@@ -19005,8 +19023,18 @@ function createValApiRouter(route, valServerPromise, convert) {
           }
         };
       }
+      const resDef = apiEndpoint.res;
       if (res.status === 500) {
         var _res$json;
+        /*
+         * A failure the route declares goes out as declared, as a success
+         * does below. DELETE /patches says which change was not discarded and
+         * which publish holds it, and collapsed to its message the Studio
+         * could only say "Failed to delete patches" -- not why, nor offer to
+         * cancel that publish. Anything undeclared is still reduced to its
+         * message.
+         */
+        if (resDef !== null && resDef !== void 0 && resDef.safeParse(res).success) return res;
         return {
           status: 500,
           json: {
@@ -19014,7 +19042,6 @@ function createValApiRouter(route, valServerPromise, convert) {
           }
         };
       }
-      const resDef = apiEndpoint.res;
       if (resDef) {
         const responseResult = resDef.safeParse(res);
         if (!responseResult.success) {

package/dist/valbuild-server.cjs.prod.js

@@ -9413,6 +9413,8 @@ const GetApplicablePatches = z.z.object({
   headVersion: z.z.number().optional(),
   /** Of `patches`, the ones a running publish holds. See `OrderedPatches.publishingPatches`. */
   publishingPatches: z.z.array(internal.PatchId).optional(),
+  /** Of `patches`, the ones a failed publish holds back. See `OrderedPatches.heldBackPatches`. */
+  heldBackPatches: z.z.array(internal.PatchId).optional(),
   commits: z.z.array(z.z.object({
     commitSha: z.z.string(),
     /*
@@ -9505,7 +9507,9 @@ const DeletePatchesResponse = z.z.object({
   deleted: z.z.array(PatchId),
   errors: z.z.array(z.z.object({
     message: z.z.string(),
-    patchId: PatchId
+    patchId: PatchId,
+    /** The publish job holding it, when that is why it was not deleted. */
+    publishJobId: z.z.string().optional()
   })).optional(),
   /**
    * The chain version each branch the delete changed is now at, keyed by
@@ -10445,6 +10449,10 @@ class ValOpsHttp extends ValOps {
       ...(allPatchData.publishingPatches !== undefined ? {
         publishingPatches: allPatchData.publishingPatches
       } : {}),
+      // Absent from a content service that does not say, as above.
+      ...(allPatchData.heldBackPatches !== undefined ? {
+        heldBackPatches: allPatchData.heldBackPatches
+      } : {}),
       /*
        * The CHAIN head, not the publish head below. Spread: absent is a content
        * service that does not report it, which is not the same as `null`.
@@ -10877,6 +10885,9 @@ class ValOpsHttp extends ValOps {
             } : {}),
             ...(data.publishingPatches !== undefined ? {
               publishingPatches: data.publishingPatches
+            } : {}),
+            ...(data.heldBackPatches !== undefined ? {
+              heldBackPatches: data.heldBackPatches
             } : {})
           };
         }
@@ -15717,7 +15728,14 @@ const ValServer = (valModules, options, callbacks) => {
               message: "Failed to delete patches",
               errors: Object.entries(deleteRes.errors).map(([id, error]) => ({
                 patchId: id,
-                ...error
+                ...error,
+                /*
+                 * Kept, so the Studio can say the change is being published
+                 * and offer to cancel that publish: content names the job.
+                 */
+                ...("publishJobId" in error && typeof error.publishJobId === "string" ? {
+                  publishJobId: error.publishJobId
+                } : {})
               }))
             }
           };
@@ -19005,8 +19023,18 @@ function createValApiRouter(route, valServerPromise, convert) {
           }
         };
       }
+      const resDef = apiEndpoint.res;
       if (res.status === 500) {
         var _res$json;
+        /*
+         * A failure the route declares goes out as declared, as a success
+         * does below. DELETE /patches says which change was not discarded and
+         * which publish holds it, and collapsed to its message the Studio
+         * could only say "Failed to delete patches" -- not why, nor offer to
+         * cancel that publish. Anything undeclared is still reduced to its
+         * message.
+         */
+        if (resDef !== null && resDef !== void 0 && resDef.safeParse(res).success) return res;
         return {
           status: 500,
           json: {
@@ -19014,7 +19042,6 @@ function createValApiRouter(route, valServerPromise, convert) {
           }
         };
       }
-      const resDef = apiEndpoint.res;
       if (resDef) {
         const responseResult = resDef.safeParse(res);
         if (!responseResult.success) {

package/dist/valbuild-server.esm.js

@@ -9376,6 +9376,8 @@ const GetApplicablePatches = z.object({
   headVersion: z.number().optional(),
   /** Of `patches`, the ones a running publish holds. See `OrderedPatches.publishingPatches`. */
   publishingPatches: z.array(PatchId$1).optional(),
+  /** Of `patches`, the ones a failed publish holds back. See `OrderedPatches.heldBackPatches`. */
+  heldBackPatches: z.array(PatchId$1).optional(),
   commits: z.array(z.object({
     commitSha: z.string(),
     /*
@@ -9468,7 +9470,9 @@ const DeletePatchesResponse = z.object({
   deleted: z.array(PatchId),
   errors: z.array(z.object({
     message: z.string(),
-    patchId: PatchId
+    patchId: PatchId,
+    /** The publish job holding it, when that is why it was not deleted. */
+    publishJobId: z.string().optional()
   })).optional(),
   /**
    * The chain version each branch the delete changed is now at, keyed by
@@ -10408,6 +10412,10 @@ class ValOpsHttp extends ValOps {
       ...(allPatchData.publishingPatches !== undefined ? {
         publishingPatches: allPatchData.publishingPatches
       } : {}),
+      // Absent from a content service that does not say, as above.
+      ...(allPatchData.heldBackPatches !== undefined ? {
+        heldBackPatches: allPatchData.heldBackPatches
+      } : {}),
       /*
        * The CHAIN head, not the publish head below. Spread: absent is a content
        * service that does not report it, which is not the same as `null`.
@@ -10840,6 +10848,9 @@ class ValOpsHttp extends ValOps {
             } : {}),
             ...(data.publishingPatches !== undefined ? {
               publishingPatches: data.publishingPatches
+            } : {}),
+            ...(data.heldBackPatches !== undefined ? {
+              heldBackPatches: data.heldBackPatches
             } : {})
           };
         }
@@ -15680,7 +15691,14 @@ const ValServer = (valModules, options, callbacks) => {
               message: "Failed to delete patches",
               errors: Object.entries(deleteRes.errors).map(([id, error]) => ({
                 patchId: id,
-                ...error
+                ...error,
+                /*
+                 * Kept, so the Studio can say the change is being published
+                 * and offer to cancel that publish: content names the job.
+                 */
+                ...("publishJobId" in error && typeof error.publishJobId === "string" ? {
+                  publishJobId: error.publishJobId
+                } : {})
               }))
             }
           };
@@ -18968,8 +18986,18 @@ function createValApiRouter(route, valServerPromise, convert) {
           }
         };
       }
+      const resDef = apiEndpoint.res;
       if (res.status === 500) {
         var _res$json;
+        /*
+         * A failure the route declares goes out as declared, as a success
+         * does below. DELETE /patches says which change was not discarded and
+         * which publish holds it, and collapsed to its message the Studio
+         * could only say "Failed to delete patches" -- not why, nor offer to
+         * cancel that publish. Anything undeclared is still reduced to its
+         * message.
+         */
+        if (resDef !== null && resDef !== void 0 && resDef.safeParse(res).success) return res;
         return {
           status: 500,
           json: {
@@ -18977,7 +19005,6 @@ function createValApiRouter(route, valServerPromise, convert) {
           }
         };
       }
-      const resDef = apiEndpoint.res;
       if (resDef) {
         const responseResult = resDef.safeParse(res);
         if (!responseResult.success) {

package/package.json

@@ -16,7 +16,7 @@
     "./package.json": "./package.json"
   },
   "types": "dist/valbuild-server.cjs.d.ts",
-  "version": "0.144.4",
+  "version": "0.144.5",
   "devDependencies": {
     "@prettier/sync": "^0.6.1",
     "@types/jest": "^30.0.0",
@@ -31,8 +31,8 @@
     "zod": "^4.4.3",
     "zod-validation-error": "^5.0.0",
     "@valbuild/core": "0.144.0",
-    "@valbuild/shared": "0.144.4",
-    "@valbuild/ui": "0.144.4"
+    "@valbuild/ui": "0.144.5",
+    "@valbuild/shared": "0.144.5"
   },
   "engines": {
     "node": "^20.19.0 || >=22"