@valbuild/server 0.125.0 → 0.126.0

package/CHANGELOG.md

@@ -1,5 +1,130 @@
 # @valbuild/server
 
+## 0.126.0
+
+### Patch Changes
+
+- [#664](https://github.com/valbuild/val/pull/664) [`5bfd630`](https://github.com/valbuild/val/commit/5bfd630b63dee2189e238f20fe72ecc5537160f7) Thanks [@freekh](https://github.com/freekh)! - Show the git message on deployments Val did not publish
+
+  The deploy feed could only name a publish when Val itself had made the commit:
+  the message came off Val's own `ValCommit`, and every other deployment — a
+  developer's push, a merged pull request, a revert — showed a seven-character
+  sha. On most projects those are the majority, so "what went out at 14:02?" had
+  no answer in the Studio.
+
+  A deployment can now carry its own `commitMessage`, which the Studio uses
+  wherever there is no Val commit to prefer. It is optional and nullable, so a
+  content service that does not report messages is unaffected — those publishes
+  keep showing the short sha, exactly as before.
+
+  Deployment rows also show only the subject line of a message now. A git message
+  is a subject, a blank line and a body, and the rows are one truncated line — so
+  a real push arrived as "Subject The body went on like this…". The classic
+  Draft changes view still has the whole message in its tooltip.
+
+- [#652](https://github.com/valbuild/val/pull/652) [`f2fe70d`](https://github.com/valbuild/val/commit/f2fe70dab2b65000dfaf289f09c70b4a8291467a) Thanks [@freekh](https://github.com/freekh)! - `s.union` is now `s.discriminatedUnion` and `s.enum`.
+
+  `s.union` did two unrelated jobs and worked out which one you meant from its
+  first argument: a string key meant a tagged union of objects, literal schemas
+  meant a set of allowed strings. Those are now two schemas with two names.
+
+  ```ts
+  // A fixed set of strings — presents as a dropdown
+  s.enum("primary", "secondary", "ghost"); // Schema<"primary" | "secondary" | "ghost">
+
+  // One of several object shapes, told apart by a tag field
+  s.discriminatedUnion(
+    "type",
+    s.object({ type: s.literal("hero"), heading: s.string() }),
+    s.object({ type: s.literal("quote"), text: s.string() }),
+  );
+  ```
+
+  `s.enum` takes the strings directly, so the `s.literal(...)` wrapper is gone.
+
+  **`s.union` still works** — it is deprecated, and it builds exactly the schema
+  above, so nothing has to change today:
+
+  ```ts
+  s.union(s.literal("one"), s.literal("two")); // → s.enum("one", "two")
+  s.union("type", pageA, pageB); // → s.discriminatedUnion("type", pageA, pageB)
+  ```
+
+  The two are different kinds of node, and that is the reason for the split. A
+  discriminated union is a container: the selected variant's fields are the fields
+  being edited, and everything that walks a schema descends through it. An enum is
+  a leaf — a string with a closed domain — so nothing recurses into it. Told apart
+  only by the shape of `key`, every consumer had to re-derive which one it was
+  holding; each now has its own serialized type (`"discriminated-union"` and
+  `"enum"`) and Val Studio has a field per kind rather than one field that
+  branches.
+
+  Two behaviour changes fall out of the split, both of them fixes:
+
+  - A value that is not a string at all now fails an enum's validation with a
+    type error. `s.union` of literals only ever checked the value against its
+    literals when the value WAS a string, so a number or an object where an enum
+    was declared validated clean.
+  - An enum field now shows its validation errors in Val Studio where the field
+    is opened on its own — the module editor and the canvas's fields column — and
+    gets the compact error layout inside an inline list row. It is a leaf now, so
+    it goes through the same error rendering as every other leaf field; the string
+    union bypassed it and showed nothing in those places.
+
+  Several latent crashes in the old `s.union` are fixed on the way past, all of
+  them cases where it threw a `TypeError` instead of reporting:
+
+  - A required discriminated union holding `null` now reports a type error rather
+    than throwing, and resolving a path underneath a nullable one that is `null`
+    gives the error the API promises instead of a crash.
+  - `s.literal("")` is a legal discriminator tag, and `s.enum("")` a legal value.
+    Both used to be treated as absent by a truthiness check — in path resolution,
+    in stega encoding, and in the message that lists a union's valid tags. The
+    editor's dropdowns handle them too: an empty value is reserved by the select
+    component and had to be mapped around.
+  - A variant that omits the discriminator entirely is now reported as the schema
+    error it is, instead of throwing while the check looked for it.
+  - An enum's value is now indexed for search, like every other string leaf. The
+    old string union was never indexed at all, so searching for one of its values
+    could not find the field.
+  - A nullable discriminated union set to `null` no longer renders a spinner that
+    never resolves.
+
+  `s.discriminatedUnion` also requires at least one variant, as `s.enum` requires
+  at least one value: a union with nothing to select is not a thing to write, and
+  everything downstream reads the first variant where it needs any.
+
+  If you read serialized schemas yourself, that is the breaking part: `type` is no
+  longer `"union"`, an enum carries `values: string[]` instead of a `key` plus
+  `items` of literal schemas, and `UnionSchema` is no longer a class.
+  `SerializedUnionSchema`, `SerializedStringUnionSchema`,
+  `SerializedObjectUnionSchema` and `UnionSchema` remain as deprecated type
+  aliases.
+
+- [#666](https://github.com/valbuild/val/pull/666) [`5c18c99`](https://github.com/valbuild/val/commit/5c18c99ecc84651f82123481fc042063db953833) Thanks [@freekh](https://github.com/freekh)! - `next build` no longer warns `module.createRequire failed parsing argument.`
+
+  Every Next app that bundles `@valbuild/server` into its Val API route got this
+  on every build, twice, with an import trace that led from `route.ts` down into
+  `valbuild-server.esm.js` and stopped there:
+
+  ```
+  ⚠ ./node_modules/.../@valbuild/server/dist/valbuild-server.esm.js
+  module.createRequire failed parsing argument.
+  ```
+
+  Nothing was wrong. webpack special-cases a `createRequire` binding imported from
+  `node:module` and tries to resolve the call's argument at build time; the two
+  calls in this package take a path inside the user's project, known only at
+  runtime, so there was nothing to resolve and nothing the warning could tell
+  anyone. Both now go through a helper that reaches the same function through the
+  `Module` class, which that analysis does not tag. Runtime behaviour is
+  unchanged, and a lint rule keeps the direct import from coming back.
+
+- Updated dependencies [[`719ad6b`](https://github.com/valbuild/val/commit/719ad6b607bcf136d0dbde9e90bf4b8a843561a4), [`9830277`](https://github.com/valbuild/val/commit/9830277e9aaca8da3030f629c2656ec58da47e45), [`64bfd0a`](https://github.com/valbuild/val/commit/64bfd0a6c85832ea5169b53e47087f22e193df36), [`7782979`](https://github.com/valbuild/val/commit/7782979e9b52f2015a6e72dc981e630d4f8c78e2), [`5bfd630`](https://github.com/valbuild/val/commit/5bfd630b63dee2189e238f20fe72ecc5537160f7), [`ccbcda6`](https://github.com/valbuild/val/commit/ccbcda60b3e3c465071229ae1ba28ac735483e63), [`f2fe70d`](https://github.com/valbuild/val/commit/f2fe70dab2b65000dfaf289f09c70b4a8291467a), [`755e1a3`](https://github.com/valbuild/val/commit/755e1a3953775cb8d2c2dce87d6810d3dc329640), [`c6b1ec8`](https://github.com/valbuild/val/commit/c6b1ec84f1883750a4cfe5f70470b177621e971f), [`656f680`](https://github.com/valbuild/val/commit/656f680043c640f678625a64e690389ab23a0a69), [`610a041`](https://github.com/valbuild/val/commit/610a0414b120b521f38a2eb1182b3778bf778b2b), [`171208a`](https://github.com/valbuild/val/commit/171208a20177e68ed5a8b1a6fdaabfe893a6aa5f)]:
+  - @valbuild/ui@0.126.0
+  - @valbuild/shared@0.126.0
+  - @valbuild/core@0.126.0
+
 ## 0.125.0
 
 ### Patch Changes

package/dist/valbuild-server.cjs.dev.js

@@ -696,6 +696,32 @@ const getCompilerOptions = (rootDir, parseConfigHost) => {
   return parsedConfigFile.options;
 };
 
+/**
+ * Node's `require`, resolving as if from `filename`.
+ *
+ * Use this instead of importing `createRequire` from `node:module` directly.
+ * webpack special-cases a `createRequire` binding imported from `module` /
+ * `node:module`: it tries to resolve the call's argument at build time, and
+ * when the argument is not a literal it gives up with
+ *
+ *     module.createRequire failed parsing argument.
+ *
+ * Our argument is never a literal — it is a path inside the user's project,
+ * known only at runtime — so there is nothing for that analysis to find, and
+ * nothing the warning can tell anyone. It is emitted on every build of every
+ * Next app that bundles `@valbuild/server` into its Val API route, which is
+ * all of them. Reaching `createRequire` through the `Module` class is the same
+ * function and is not what webpack tags, so the call is invisible to it.
+ *
+ * It has to stay a real `node:module` import: jest's module registry hands out
+ * its own `node:module`, and a `require` obtained around it (via
+ * `process.getBuiltinModule`, say) would resolve against the real filesystem
+ * rather than the registry the tests run in.
+ */
+function createNodeRequire(filename) {
+  return node_module.Module.createRequire(filename);
+}
+
 /**
  * The filesystem seam `loadValModules` reads through.
  *
@@ -829,7 +855,7 @@ function loadModule(absPath, cache, compilerOptions, host) {
   // Insert into the cache before evaluating so cyclic imports resolve.
   cache[absPath] = moduleObj;
   const dirName = path__namespace["default"].dirname(absPath);
-  const realRequire = node_module.Module.createRequire(absPath);
+  const realRequire = createNodeRequire(absPath);
   const customRequire = spec => {
     var _ts$resolveModuleName;
     if (isStubbedSpecifier(spec)) {
@@ -1136,7 +1162,7 @@ function findNestedJsonValuesRecords(schema, path = []) {
       case "array":
         rec(current.item, currentPath.concat("*"));
         return;
-      case "union":
+      case "discriminated-union":
         for (let i = 0; i < current.items.length; i++) {
           rec(current.items[i], currentPath.concat(`union[${i}]`));
         }
@@ -7015,7 +7041,11 @@ const GetApplicablePatches = z.z.object({
     commitSha: z.z.string(),
     deploymentState: z.z.string(),
     createdAt: z.z.string(),
-    updatedAt: z.z.string()
+    updatedAt: z.z.string(),
+    // The git message, where the content service knows it. See
+    // `ValDeployment`: this is the only source for a deployment that Val
+    // did not publish, and zod would otherwise strip it here.
+    commitMessage: z.z.string().nullable().optional()
   })).optional()
 });
 const FilesResponse = z.z.object({
@@ -7616,7 +7646,8 @@ class ValOpsHttp extends ValOps {
                 deploymentId: deployment.deploymentId,
                 deploymentState: deployment.deploymentState,
                 createdAt: deployment.createdAt,
-                updatedAt: deployment.updatedAt
+                updatedAt: deployment.updatedAt,
+                commitMessage: deployment.commitMessage
               });
             }
           }
@@ -15386,7 +15417,7 @@ async function evalValConfigFile(projectRoot, configFileName) {
     },
     fileName: valConfigPath
   });
-  const projectRootRequire = node_module.createRequire(valConfigPath);
+  const projectRootRequire = createNodeRequire(valConfigPath);
   const exportsObj = {};
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const sandbox = {

package/dist/valbuild-server.cjs.prod.js

@@ -696,6 +696,32 @@ const getCompilerOptions = (rootDir, parseConfigHost) => {
   return parsedConfigFile.options;
 };
 
+/**
+ * Node's `require`, resolving as if from `filename`.
+ *
+ * Use this instead of importing `createRequire` from `node:module` directly.
+ * webpack special-cases a `createRequire` binding imported from `module` /
+ * `node:module`: it tries to resolve the call's argument at build time, and
+ * when the argument is not a literal it gives up with
+ *
+ *     module.createRequire failed parsing argument.
+ *
+ * Our argument is never a literal — it is a path inside the user's project,
+ * known only at runtime — so there is nothing for that analysis to find, and
+ * nothing the warning can tell anyone. It is emitted on every build of every
+ * Next app that bundles `@valbuild/server` into its Val API route, which is
+ * all of them. Reaching `createRequire` through the `Module` class is the same
+ * function and is not what webpack tags, so the call is invisible to it.
+ *
+ * It has to stay a real `node:module` import: jest's module registry hands out
+ * its own `node:module`, and a `require` obtained around it (via
+ * `process.getBuiltinModule`, say) would resolve against the real filesystem
+ * rather than the registry the tests run in.
+ */
+function createNodeRequire(filename) {
+  return node_module.Module.createRequire(filename);
+}
+
 /**
  * The filesystem seam `loadValModules` reads through.
  *
@@ -829,7 +855,7 @@ function loadModule(absPath, cache, compilerOptions, host) {
   // Insert into the cache before evaluating so cyclic imports resolve.
   cache[absPath] = moduleObj;
   const dirName = path__namespace["default"].dirname(absPath);
-  const realRequire = node_module.Module.createRequire(absPath);
+  const realRequire = createNodeRequire(absPath);
   const customRequire = spec => {
     var _ts$resolveModuleName;
     if (isStubbedSpecifier(spec)) {
@@ -1136,7 +1162,7 @@ function findNestedJsonValuesRecords(schema, path = []) {
       case "array":
         rec(current.item, currentPath.concat("*"));
         return;
-      case "union":
+      case "discriminated-union":
         for (let i = 0; i < current.items.length; i++) {
           rec(current.items[i], currentPath.concat(`union[${i}]`));
         }
@@ -7015,7 +7041,11 @@ const GetApplicablePatches = z.z.object({
     commitSha: z.z.string(),
     deploymentState: z.z.string(),
     createdAt: z.z.string(),
-    updatedAt: z.z.string()
+    updatedAt: z.z.string(),
+    // The git message, where the content service knows it. See
+    // `ValDeployment`: this is the only source for a deployment that Val
+    // did not publish, and zod would otherwise strip it here.
+    commitMessage: z.z.string().nullable().optional()
   })).optional()
 });
 const FilesResponse = z.z.object({
@@ -7616,7 +7646,8 @@ class ValOpsHttp extends ValOps {
                 deploymentId: deployment.deploymentId,
                 deploymentState: deployment.deploymentState,
                 createdAt: deployment.createdAt,
-                updatedAt: deployment.updatedAt
+                updatedAt: deployment.updatedAt,
+                commitMessage: deployment.commitMessage
               });
             }
           }
@@ -15386,7 +15417,7 @@ async function evalValConfigFile(projectRoot, configFileName) {
     },
     fileName: valConfigPath
   });
-  const projectRootRequire = node_module.createRequire(valConfigPath);
+  const projectRootRequire = createNodeRequire(valConfigPath);
   const exportsObj = {};
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const sandbox = {

package/dist/valbuild-server.esm.js

@@ -7,7 +7,7 @@ import * as path from 'path';
 import path__default from 'path';
 import fs, { promises } from 'fs';
 import vm from 'node:vm';
-import { Module, createRequire } from 'node:module';
+import { Module } from 'node:module';
 import { resolveSchemaSourceFixForError, Patch, getErrorMessageFromUnknownJson, JSONValue, PatchGroup, newestCommitSha, SerializedSchema, VAL_ENABLE_COOKIE_NAME, VAL_STATE_COOKIE, VAL_SESSION_COOKIE, Api } from '@valbuild/shared/internal';
 import { createUIRequestHandler } from '@valbuild/ui/server';
 import crypto$1 from 'crypto';
@@ -662,6 +662,32 @@ const getCompilerOptions = (rootDir, parseConfigHost) => {
   return parsedConfigFile.options;
 };
 
+/**
+ * Node's `require`, resolving as if from `filename`.
+ *
+ * Use this instead of importing `createRequire` from `node:module` directly.
+ * webpack special-cases a `createRequire` binding imported from `module` /
+ * `node:module`: it tries to resolve the call's argument at build time, and
+ * when the argument is not a literal it gives up with
+ *
+ *     module.createRequire failed parsing argument.
+ *
+ * Our argument is never a literal — it is a path inside the user's project,
+ * known only at runtime — so there is nothing for that analysis to find, and
+ * nothing the warning can tell anyone. It is emitted on every build of every
+ * Next app that bundles `@valbuild/server` into its Val API route, which is
+ * all of them. Reaching `createRequire` through the `Module` class is the same
+ * function and is not what webpack tags, so the call is invisible to it.
+ *
+ * It has to stay a real `node:module` import: jest's module registry hands out
+ * its own `node:module`, and a `require` obtained around it (via
+ * `process.getBuiltinModule`, say) would resolve against the real filesystem
+ * rather than the registry the tests run in.
+ */
+function createNodeRequire(filename) {
+  return Module.createRequire(filename);
+}
+
 /**
  * The filesystem seam `loadValModules` reads through.
  *
@@ -795,7 +821,7 @@ function loadModule(absPath, cache, compilerOptions, host) {
   // Insert into the cache before evaluating so cyclic imports resolve.
   cache[absPath] = moduleObj;
   const dirName = path__default.dirname(absPath);
-  const realRequire = Module.createRequire(absPath);
+  const realRequire = createNodeRequire(absPath);
   const customRequire = spec => {
     var _ts$resolveModuleName;
     if (isStubbedSpecifier(spec)) {
@@ -1102,7 +1128,7 @@ function findNestedJsonValuesRecords(schema, path = []) {
       case "array":
         rec(current.item, currentPath.concat("*"));
         return;
-      case "union":
+      case "discriminated-union":
         for (let i = 0; i < current.items.length; i++) {
           rec(current.items[i], currentPath.concat(`union[${i}]`));
         }
@@ -6981,7 +7007,11 @@ const GetApplicablePatches = z.object({
     commitSha: z.string(),
     deploymentState: z.string(),
     createdAt: z.string(),
-    updatedAt: z.string()
+    updatedAt: z.string(),
+    // The git message, where the content service knows it. See
+    // `ValDeployment`: this is the only source for a deployment that Val
+    // did not publish, and zod would otherwise strip it here.
+    commitMessage: z.string().nullable().optional()
   })).optional()
 });
 const FilesResponse = z.object({
@@ -7582,7 +7612,8 @@ class ValOpsHttp extends ValOps {
                 deploymentId: deployment.deploymentId,
                 deploymentState: deployment.deploymentState,
                 createdAt: deployment.createdAt,
-                updatedAt: deployment.updatedAt
+                updatedAt: deployment.updatedAt,
+                commitMessage: deployment.commitMessage
               });
             }
           }
@@ -15352,7 +15383,7 @@ async function evalValConfigFile(projectRoot, configFileName) {
     },
     fileName: valConfigPath
   });
-  const projectRootRequire = createRequire(valConfigPath);
+  const projectRootRequire = createNodeRequire(valConfigPath);
   const exportsObj = {};
   // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const sandbox = {

package/package.json

@@ -16,7 +16,7 @@
     "./package.json": "./package.json"
   },
   "types": "dist/valbuild-server.cjs.d.ts",
-  "version": "0.125.0",
+  "version": "0.126.0",
   "devDependencies": {
     "@prettier/sync": "^0.6.1",
     "@types/jest": "^30.0.0"
@@ -29,9 +29,9 @@
     "typescript": "^6.0.3",
     "zod": "^4.4.3",
     "zod-validation-error": "^5.0.0",
-    "@valbuild/core": "0.125.0",
-    "@valbuild/shared": "0.125.0",
-    "@valbuild/ui": "0.125.0"
+    "@valbuild/core": "0.126.0",
+    "@valbuild/shared": "0.126.0",
+    "@valbuild/ui": "0.126.0"
   },
   "engines": {
     "node": "^20.19.0 || >=22"