@valbuild/server 0.113.0 → 0.115.0

package/dist/declarations/src/ValOps.d.ts

@@ -372,13 +372,6 @@ export declare abstract class ValOps {
     } | {
         errorType: "patch-head-conflict";
     }>>;
-    abstract getCommitSummary(preparedCommit: PreparedCommit): Promise<{
-        commitSummary: string | null;
-        error?: undefined;
-    } | {
-        commitSummary?: undefined;
-        error: GenericErrorMessage;
-    }>;
     abstract onInit(baseSha: BaseSha, schemaSha: SchemaSha): Promise<void>;
     abstract fetchPatches<ExcludePatchOps extends boolean>(filters: {
         patchIds?: PatchId[];

package/dist/declarations/src/ValOpsFS.d.ts

@@ -43,13 +43,6 @@ export declare class ValOpsFS extends ValOps {
         statusCode: 401 | 500;
         error: GenericErrorMessage;
     }>;
-    getCommitSummary(): Promise<{
-        commitSummary: string | null;
-        error?: undefined;
-    } | {
-        commitSummary?: undefined;
-        error: GenericErrorMessage;
-    }>;
     getStat(params: {
         baseSha: BaseSha;
         schemaSha: SchemaSha;

package/dist/declarations/src/ValOpsHttp.d.ts

@@ -46,13 +46,6 @@ export declare class ValOpsHttp extends ValOps {
         statusCode: 401 | 500;
         error: GenericErrorMessage;
     }>;
-    getCommitSummary(preparedCommit: PreparedCommit): Promise<{
-        commitSummary: string | null;
-        error?: undefined;
-    } | {
-        commitSummary?: undefined;
-        error: GenericErrorMessage;
-    }>;
     getStat(params: {
         baseSha: BaseSha;
         schemaSha: SchemaSha;
@@ -127,12 +120,6 @@ export declare class ValOpsHttp extends ValOps {
         errors?: undefined;
         deleted?: undefined;
     }>;
-    getCommitMessage(preparedCommit: PreparedCommit): Promise<{
-        commitSummary: string;
-        error?: undefined;
-    } | {
-        error: GenericErrorMessage;
-    }>;
     commit(prepared: PreparedCommit, message: string, committer: AuthorId, filesDirectory: string, newBranch?: string): Promise<{
         isNotFastForward?: boolean;
         updatedFiles: string[];

package/dist/declarations/src/ValRouter.d.ts

@@ -114,6 +114,32 @@ type ValServerOverrides = Partial<{
     disableCache?: boolean;
 }>;
 export declare function createValServer(valModules: ValModules, route: string, opts: ValApiOptions, config: ValConfig, callbacks: ValServerCallbacks, formatter?: (code: string, filePath: string) => string | Promise<string>): Promise<ValServer>;
+/**
+ * Hosts we send credentials to, and what each one puts at risk. They differ:
+ * only `valBuildUrl` hands back the app token that becomes the session cookie,
+ * so a single shared sentence would overstate one and understate the other.
+ */
+type CredentialBearingUrl = "valBuildUrl" | "valContentUrl";
+/**
+ * Returns a warning if `url` would send credentials somewhere they can be read
+ * off the wire, or null if it is fine.
+ *
+ * Both URLs default to https, but each is overridable - `opts.valBuildUrl` /
+ * `VAL_BUILD_URL`, `opts.valContentUrl` / `VAL_CONTENT_URL` - and neither
+ * override has ever been scheme-checked. Point one at a plain http host and the
+ * api key goes out in clear text, and whatever comes back is whatever the
+ * network says: for `valBuildUrl` that includes the app token this server
+ * re-signs into the session cookie.
+ *
+ * Loopback over http is exempt: that is a val.build running on the developer's
+ * own machine, and there is no network to be on the wrong side of.
+ *
+ * This warns rather than throws. Both overrides are set by the operator, not by
+ * an attacker, so this is a misconfiguration to surface - not untrusted input to
+ * reject - and refusing to boot would break anyone deliberately pointing at an
+ * internal http host today.
+ */
+export declare function insecureUrlWarning(name: CredentialBearingUrl, url: string): string | null;
 export declare function safeReadGit(cwd: string): Promise<{
     commit?: string;
     branch?: string;

package/dist/declarations/src/getValidationErrorFileRef.d.ts

@@ -5,4 +5,4 @@ import { ValidationError } from "@valbuild/core";
  * There is no schema in hand here — a `ValidationError` carries only the value
  * it flagged — so the shape is all there is to go on.
  */
-export declare function getValidationErrorFileRef(validationError: ValidationError): string | null;
+export declare function getValidationErrorFileRef(validationError: ValidationError): any;

package/dist/declarations/src/index.d.ts

@@ -25,8 +25,8 @@ export { checkRemoteRef, downloadFileFromRemote, getCachedRemoteFileDir, getCach
 export { hasRemoteFileSchema } from "@valbuild/core";
 export { getFileExt } from "./getFileExt.js";
 export { evalValConfigFile, findAndEvalValConfigFile, } from "./evalValConfigFile.js";
-export { startValLogin, awaitValLoginConfirmation, persistPersonalAccessToken, ValLoginError, DEFAULT_LOGIN_HOST, DEFAULT_LOGIN_MAX_DURATION, DEFAULT_LOGIN_POLL_INTERVAL, } from "./login.js";
-export type { ValLoginErrorCode, ValLoginResult, ValLoginSession, } from "./login.js";
+export { startValLogin, awaitValLoginConfirmation, persistPersonalAccessToken, ValLoginError, DEFAULT_LOGIN_HOST, DEFAULT_LOGIN_EXPIRES_IN_SECONDS, DEFAULT_LOGIN_POLL_INTERVAL_SECONDS, } from "./login.js";
+export type { ValLoginErrorCode, ValLoginResult, ValDeviceAuthorization, } from "./login.js";
 export { createModulePathMap, createJsonEntryPathMap, getModulePathRange, } from "./modulePathMap.js";
 export { findJsonEntryFilePath } from "./jsonEntryLocation.js";
 export { classifyJsonValuesOp, rebaseContentOp } from "./patch/jsonValuesPatch.js";

package/dist/declarations/src/login.d.ts

@@ -1,5 +1,15 @@
 /**
- * The Val login device flow, as reusable primitives.
+ * The Val login flow, as reusable primitives.
+ *
+ * This is an RFC 8628 device authorization grant. The shape that matters:
+ * {@link ValDeviceAuthorization.deviceCode} is a secret this process holds and
+ * polls with, while {@link ValDeviceAuthorization.userCode} is the short string
+ * the human reads out of the terminal and types into a browser. Only the device
+ * code can collect a token.
+ *
+ * Keep them apart. Show the user code; never print, log or put the device code
+ * in a URL. An earlier version of this flow used one value for both jobs, which
+ * meant anyone who saw the verification link could collect the token it led to.
  *
  * The CLI wraps these with terminal output, and `@valbuild/language-server`
  * wraps them with LSP `window/showDocument` and progress reporting. Neither the
@@ -16,6 +26,10 @@ export type ValLoginErrorCode =
  | "unexpected-response"
 /** The server returned a 5xx. */
  | "server-error"
+/** The user declined the login in the browser. */
+ | "access-denied"
+/** The login was not approved before the code expired. */
+ | "expired"
 /** The user did not complete the login within the allotted time. */
  | "timeout"
 /** The caller aborted the flow. */
@@ -25,12 +39,23 @@ export declare class ValLoginError extends Error {
     readonly details?: string | undefined;
     constructor(code: ValLoginErrorCode, message: string, details?: string | undefined);
 }
-/** A login attempt that is waiting for the user to confirm in a browser. */
-export type ValLoginSession = {
-    /** Opaque token used to poll for confirmation. */
-    nonce: string;
-    /** URL the user must open to confirm the login. */
-    url: string;
+/** A login attempt that is waiting for the user to approve it in a browser. */
+export type ValDeviceAuthorization = {
+    /**
+     * Secret. Polls for the token. Do not display, log or transmit anywhere but
+     * the token endpoint.
+     */
+    deviceCode: string;
+    /** Short code for the user to compare and type. Safe to display. */
+    userCode: string;
+    /** Where the user goes to enter {@link userCode}. */
+    verificationUri: string;
+    /** {@link verificationUri} with the code prefilled, for convenience. */
+    verificationUriComplete: string;
+    /** Seconds until the code stops being approvable. */
+    expiresInSeconds: number;
+    /** Minimum seconds between polls, per the server. */
+    intervalSeconds: number;
 };
 export type ValLoginResult = {
     profile: {
@@ -39,24 +64,26 @@ export type ValLoginResult = {
     pat: string;
 };
 /**
- * Begin a login attempt. The caller is responsible for getting
- * {@link ValLoginSession.url} in front of the user.
+ * Begin a login attempt. The caller is responsible for getting the user code
+ * and verification URL in front of the user.
  */
 export declare function startValLogin(options?: {
     host?: string;
-}): Promise<ValLoginSession>;
-export declare const DEFAULT_LOGIN_MAX_DURATION: number;
-export declare const DEFAULT_LOGIN_POLL_INTERVAL = 1000;
+    deviceName?: string;
+}): Promise<ValDeviceAuthorization>;
+/** Fallbacks for a server that omits the optional RFC 8628 timing fields. */
+export declare const DEFAULT_LOGIN_EXPIRES_IN_SECONDS = 600;
+export declare const DEFAULT_LOGIN_POLL_INTERVAL_SECONDS = 5;
 /**
- * Poll until the user confirms the login in their browser.
+ * Poll until the user approves the login in their browser.
  *
  * Accepts an `AbortSignal` so an editor can cancel the flow when the user
- * dismisses the prompt, instead of leaving a poll loop running for 5 minutes.
+ * dismisses the prompt, instead of leaving a poll loop running to expiry.
  */
-export declare function awaitValLoginConfirmation(nonce: string, options?: {
+export declare function awaitValLoginConfirmation(authorization: ValDeviceAuthorization, options?: {
     host?: string;
+    /** Defaults to the authorization's own `expiresInSeconds`. */
     maxDurationMs?: number;
-    pollIntervalMs?: number;
     signal?: AbortSignal;
     /** Wall clock, injectable for tests. */
     now?: () => number;

package/dist/declarations/src/patchStore.d.ts

@@ -1,4 +1,4 @@
-import { ModuleFilePath, PatchId } from "@valbuild/core";
+import { PatchId } from "@valbuild/core";
 import { z } from "zod";
 import type { AuthorId, BaseSha } from "./ValOps.js";
 import { PatchLogEntry, PatchLogProblem } from "./patchLog.js";
@@ -32,14 +32,14 @@ export declare const FSPatch: z.ZodObject<{
     patch: z.ZodArray<z.ZodDiscriminatedUnion<[z.ZodObject<{
         op: z.ZodLiteral<"add">;
         path: z.ZodArray<z.ZodString>;
-        value: z.ZodType<import("@valbuild/core/patch").JSONValue, unknown, z.core.$ZodTypeInternals<import("@valbuild/core/patch").JSONValue, unknown>>;
+        value: z.ZodType<JSONValueT, unknown, z.core.$ZodTypeInternals<JSONValueT, unknown>>;
     }, z.core.$strict>, z.ZodObject<{
         op: z.ZodLiteral<"remove">;
         path: z.ZodTuple<[z.ZodString], z.ZodString>;
     }, z.core.$strict>, z.ZodObject<{
         op: z.ZodLiteral<"replace">;
         path: z.ZodArray<z.ZodString>;
-        value: z.ZodType<import("@valbuild/core/patch").JSONValue, unknown, z.core.$ZodTypeInternals<import("@valbuild/core/patch").JSONValue, unknown>>;
+        value: z.ZodType<JSONValueT, unknown, z.core.$ZodTypeInternals<JSONValueT, unknown>>;
     }, z.core.$strict>, z.ZodObject<{
         op: z.ZodLiteral<"move">;
         from: z.ZodTuple<[z.ZodString], z.ZodString>;
@@ -51,15 +51,15 @@ export declare const FSPatch: z.ZodObject<{
     }, z.core.$strict>, z.ZodObject<{
         op: z.ZodLiteral<"test">;
         path: z.ZodArray<z.ZodString>;
-        value: z.ZodType<import("@valbuild/core/patch").JSONValue, unknown, z.core.$ZodTypeInternals<import("@valbuild/core/patch").JSONValue, unknown>>;
+        value: z.ZodType<JSONValueT, unknown, z.core.$ZodTypeInternals<JSONValueT, unknown>>;
     }, z.core.$strict>, z.ZodObject<{
         op: z.ZodLiteral<"file">;
         path: z.ZodArray<z.ZodString>;
         filePath: z.ZodString;
-        value: z.ZodType<import("@valbuild/core/patch").JSONValue, unknown, z.core.$ZodTypeInternals<import("@valbuild/core/patch").JSONValue, unknown>>;
+        value: z.ZodType<JSONValueT, unknown, z.core.$ZodTypeInternals<JSONValueT, unknown>>;
         remote: z.ZodBoolean;
         nestedFilePath: z.ZodOptional<z.ZodArray<z.ZodString>>;
-        metadata: z.ZodOptional<z.ZodType<import("@valbuild/core/patch").JSONValue, unknown, z.core.$ZodTypeInternals<import("@valbuild/core/patch").JSONValue, unknown>>>;
+        metadata: z.ZodOptional<z.ZodType<JSONValueT, unknown, z.core.$ZodTypeInternals<JSONValueT, unknown>>>;
     }, z.core.$strict>], "op">>;
     patchId: z.ZodString;
     baseSha: z.ZodString & z.ZodType<BaseSha, string, z.core.$ZodTypeInternals<BaseSha, string>>;