@valbuild/cli 0.102.0 → 0.103.0

package/src/listUnusedFiles.ts

@@ -1,10 +1,4 @@
-import {
-  FILE_REF_PROP,
-  ModuleFilePath,
-  ModulePath,
-  SourcePath,
-  VAL_EXTENSION,
-} from "@valbuild/core";
+import { ModuleFilePath, ModulePath, SourcePath } from "@valbuild/core";
 import { createService } from "@valbuild/server";
 import { glob } from "fast-glob";
 import path from "path";
@@ -49,7 +43,7 @@ export async function listUnusedFiles({ root }: { root?: string }) {
             if (isFileRef(value)) {
               const absoluteFilePathUsedByVal = path.join(
                 projectRoot,
-                ...value[FILE_REF_PROP].split("/"),
+                ...value.path.split("/"),
               );
               filesUsedByVal.push(absoluteFilePathUsedByVal);
             }
@@ -78,18 +72,17 @@ export async function listUnusedFiles({ root }: { root?: string }) {
   return;
 }
 
-function isFileRef(
-  value: unknown,
-): value is { [FILE_REF_PROP]: string; [VAL_EXTENSION]: "file" } {
-  if (!value) return false;
-  if (typeof value !== "object") return false;
-  if (FILE_REF_PROP in value && VAL_EXTENSION in value) {
-    if (
-      value[VAL_EXTENSION] === "file" &&
-      typeof value[FILE_REF_PROP] === "string"
-    ) {
-      return true;
-    }
-  }
-  return false;
+/**
+ * Whether a flagged validation value names a file.
+ *
+ * A `ValidationError` carries no schema, so the shape is all there is to go on —
+ * the same heuristic this whole function documents as a TODO.
+ */
+function isFileRef(value: unknown): value is { path: string } {
+  return (
+    !!value &&
+    typeof value === "object" &&
+    "path" in value &&
+    typeof value.path === "string"
+  );
 }

package/src/runValidation.test.ts

@@ -372,12 +372,12 @@ describe("runValidation", () => {
           .flatMap((e) => e.fixes ?? []);
         expect(allFixes).not.toContain("image:add-metadata");
       }
+      // The fix writes the fields it read from the bytes next to `path`.
       expect(result.source).toMatchObject({
-        metadata: {
-          width: 1,
-          height: 1,
-          mimeType: "image/png",
-        },
+        path: "/public/val/image.png",
+        width: 1,
+        height: 1,
+        mimeType: "image/png",
       });
     } finally {
       service.dispose();