@vaadin/vaadin-select 2.4.0-alpha1 → 2.4.3

package/@types/interfaces.d.ts

@@ -1,3 +1,3 @@
 import { SelectElement } from '../src/vaadin-select.js';
 
-export type SelectRenderer = (root: HTMLElement, select: SelectElement) => void;
+export type SelectRenderer = (root: HTMLElement, select?: SelectElement) => void;

package/README.md

@@ -1,21 +1,18 @@
-[![npm version](https://badgen.net/npm/v/@vaadin/vaadin-select)](https://www.npmjs.com/package/@vaadin/vaadin-select)
-[![Bower version](https://badgen.net/github/release/vaadin/vaadin-select)](https://github.com/vaadin/vaadin-select/releases)
-[![Published on webcomponents.org](https://img.shields.io/badge/webcomponents.org-published-blue.svg)](https://www.webcomponents.org/element/vaadin/vaadin-select)
-[![Build Status](https://travis-ci.org/vaadin/vaadin-select.svg?branch=master)](https://travis-ci.org/vaadin/vaadin-select)
-[![Coverage Status](https://coveralls.io/repos/github/vaadin/vaadin-select/badge.svg?branch=master)](https://coveralls.io/github/vaadin/vaadin-select?branch=master)
-[![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/vaadin/web-components?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)
+# <vaadin-select>
 
-[![Published on Vaadin  Directory](https://img.shields.io/badge/Vaadin%20Directory-published-00b4f0.svg)](https://vaadin.com/directory/component/vaadinvaadin-select)
-[![Stars on vaadin.com/directory](https://img.shields.io/vaadin-directory/star/vaadinvaadin-select.svg)](https://vaadin.com/directory/component/vaadinvaadin-select)
+> ⚠️ Starting from Vaadin 20, the source code and issues for this component are migrated to the [`vaadin/web-components`](https://github.com/vaadin/web-components/tree/master/packages/vaadin-select) monorepository.
+> This repository contains the source code and releases of `<vaadin-select>` for the Vaadin versions 10 to 19.
 
-# &lt;vaadin-select&gt;
+[&lt;vaadin-select&gt;](https://vaadin.com/components/vaadin-select) is a Web Component similar to a native browser select element, part of the [Vaadin components](https://vaadin.com/components).
 
-[Live Demo ↗](https://cdn.vaadin.com/vaadin-select/2.0.0-beta1/demo)
+[Live Demo ↗](https://vaadin.com/components/vaadin-select/html-examples)
 |
-[API documentation ↗](https://cdn.vaadin.com/vaadin-select/2.0.0-beta1/#/elements/vaadin-select)
+[API documentation ↗](https://vaadin.com/components/vaadin-select/html-api)
 
-
-[&lt;vaadin-select&gt;](https://vaadin.com/components/vaadin-select) is a Web Component similar to a native browser select element, part of the [Vaadin components](https://vaadin.com/components).
+[![npm version](https://badgen.net/npm/v/@vaadin/vaadin-select)](https://www.npmjs.com/package/@vaadin/vaadin-select)
+[![Published on webcomponents.org](https://img.shields.io/badge/webcomponents.org-published-blue.svg)](https://www.webcomponents.org/element/vaadin/vaadin-select)
+[![Published on Vaadin Directory](https://img.shields.io/badge/Vaadin%20Directory-published-00b4f0.svg)](https://vaadin.com/directory/component/vaadinvaadin-select)
+[![Discord](https://img.shields.io/discord/732335336448852018?label=discord)](https://discord.gg/PHmkCKC)
 
 <!--
 ```

package/package.json

@@ -10,7 +10,7 @@
   "repository": "vaadin/vaadin-select",
   "homepage": "https://vaadin.com/components",
   "name": "@vaadin/vaadin-select",
-  "version": "2.4.0-alpha1",
+  "version": "2.4.3",
   "main": "vaadin-select.js",
   "author": "Vaadin Ltd",
   "license": "Apache-2.0",
@@ -36,19 +36,18 @@
     "@polymer/iron-resizable-behavior": "^3.0.0",
     "@vaadin/vaadin-control-state-mixin": "^2.2.1",
     "@vaadin/vaadin-themable-mixin": "^1.6.1",
-    "@vaadin/vaadin-text-field": "^2.8.0-alpha1",
-    "@vaadin/vaadin-list-box": "^1.4.0-alpha1",
+    "@vaadin/vaadin-text-field": "^2.8.0",
+    "@vaadin/vaadin-list-box": "^1.4.0",
     "@vaadin/vaadin-list-mixin": "^2.5.0",
-    "@vaadin/vaadin-item": "^2.3.0-alpha1",
+    "@vaadin/vaadin-item": "^2.3.0",
     "@vaadin/vaadin-overlay": "^3.5.0",
     "@vaadin/vaadin-lumo-styles": "^1.6.0",
     "@vaadin/vaadin-material-styles": "^1.3.2",
     "@vaadin/vaadin-element-mixin": "^2.4.1"
   },
-  "scripts": {
-    "generate-typings": "gen-typescript-declarations --outDir . --verify"
-  },
   "devDependencies": {
+    "@web-padawan/gen-typescript-declarations": "^1.6.2",
+    "web-component-tester": "6.9.2",
     "@polymer/iron-test-helpers": "^3.0.0",
     "@polymer/iron-component-page": "^4.0.0",
     "@polymer/iron-form": "^3.0.0",
@@ -56,7 +55,11 @@
     "@webcomponents/webcomponentsjs": "^2.0.0",
     "wct-browser-legacy": "^1.0.1",
     "@vaadin/vaadin-demo-helpers": "^3.1.0",
-    "@vaadin/vaadin-button": "^2.4.0-alpha1",
+    "@vaadin/vaadin-button": "^2.4.0",
     "@vaadin/vaadin-icons": "^4.3.1"
+  },
+  "scripts": {
+    "generate-typings": "gen-typescript-declarations --outDir . --verify",
+    "test": "wct --npm"
   }
 }

package/src/vaadin-select.d.ts

@@ -144,6 +144,7 @@ declare class SelectElement extends
 
   /**
    * The error message to display when the select value is invalid
+   * @attr {string} error-message
    */
   errorMessage: string;
 
@@ -193,6 +194,7 @@ declare class SelectElement extends
 
   /**
    * String used for the helper text.
+   * @attr {string} helper-text
    */
   helperText: string|null|undefined;
 

package/src/vaadin-select.js

@@ -178,7 +178,7 @@ class SelectElement extends
   }
 
   static get version() {
-    return '2.4.0-alpha1';
+    return '2.4.3';
   }
 
   static get properties() {
@@ -208,6 +208,7 @@ class SelectElement extends
 
       /**
        * The error message to display when the select value is invalid
+       * @attr {string} error-message
        * @type {string}
        */
       errorMessage: {
@@ -284,6 +285,7 @@ class SelectElement extends
 
       /**
        * String used for the helper text.
+       * @attr {string} helper-text
        */
       helperText: {
         type: String,
@@ -362,7 +364,12 @@ class SelectElement extends
     this._nativeInput.setAttribute('tabindex', -1);
     this._nativeInput.style.pointerEvents = 'none';
 
-    this.focusElement.addEventListener('click', e => this.opened = !this.readonly);
+    this.focusElement.addEventListener('click', (e) => {
+      const isHelperClick = Array.from(e.composedPath()).some((node) => {
+        return node.nodeType === Node.ELEMENT_NODE && node.getAttribute('slot') === 'helper';
+      });
+      this.opened = !this.readonly && !isHelperClick;
+    });
     this.focusElement.addEventListener('keydown', e => this._onKeyDown(e));
 
     this._observer = new FlattenedNodesObserver(this, info => this._setTemplateFromNodes(info.addedNodes));
@@ -398,6 +405,10 @@ class SelectElement extends
    * Manually invoke existing renderer.
    */
   render() {
+    if (!this._overlayElement) {
+      return;
+    }
+
     this._overlayElement.render();
     if (this._menuElement && this._menuElement.items) {
       this._updateSelectedItem(this.value, this._menuElement.items);
@@ -555,13 +566,9 @@ class SelectElement extends
       this._setPosition();
       window.addEventListener('scroll', this._boundSetPosition, true);
     } else if (wasOpened) {
-      if (this._phone) {
-        this._setFocused(false);
-      } else {
-        this.focusElement.focus();
-        if (this._openedWithFocusRing) {
-          this.focusElement.setAttribute('focus-ring', '');
-        }
+      this.focusElement.focus();
+      if (this._openedWithFocusRing) {
+        this.focusElement.setAttribute('focus-ring', '');
       }
       this.validate();
       window.removeEventListener('scroll', this._boundSetPosition, true);

package/vaadin-select.d.ts

@@ -12,3 +12,4 @@
 // tslint:disable:variable-name Describing an API that's defined elsewhere.
 
 export * from './src/vaadin-select.js';
+export * from './@types/interfaces';