@vaadin/vaadin-overlay 23.2.2 → 23.3.0-alpha2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/vaadin-overlay",
-  "version": "23.2.2",
+  "version": "23.3.0-alpha2",
   "publishConfig": {
     "access": "public"
   },
@@ -35,20 +35,20 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "~23.2.2",
-    "@vaadin/vaadin-lumo-styles": "~23.2.2",
-    "@vaadin/vaadin-material-styles": "~23.2.2",
-    "@vaadin/vaadin-themable-mixin": "~23.2.2"
+    "@vaadin/component-base": "23.3.0-alpha2",
+    "@vaadin/vaadin-lumo-styles": "23.3.0-alpha2",
+    "@vaadin/vaadin-material-styles": "23.3.0-alpha2",
+    "@vaadin/vaadin-themable-mixin": "23.3.0-alpha2"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
     "@polymer/iron-overlay-behavior": "^3.0.0",
-    "@vaadin/button": "~23.2.2",
-    "@vaadin/radio-group": "~23.2.2",
+    "@vaadin/button": "23.3.0-alpha2",
+    "@vaadin/radio-group": "23.3.0-alpha2",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "~23.2.2",
+    "@vaadin/text-field": "23.3.0-alpha2",
     "lit": "^2.0.0",
     "sinon": "^13.0.2"
   },
-  "gitHead": "a98818979098f4542ce557a58858fb6dad910a25"
+  "gitHead": "ae61027c62ffa7f7d70cfc50e43f333addfc74b6"
 }

package/src/vaadin-overlay-position-mixin.js

@@ -15,6 +15,16 @@ const PROP_NAMES_HORIZONTAL = {
   end: 'right',
 };
 
+const targetResizeObserver = new ResizeObserver((entries) => {
+  setTimeout(() => {
+    entries.forEach((entry) => {
+      if (entry.target.__overlay) {
+        entry.target.__overlay._updatePosition();
+      }
+    });
+  });
+});
+
 /**
  * @polymerMixin
  */
@@ -132,8 +142,15 @@ export const PositionMixin = (superClass) =>
     __overlayOpenedChanged(opened, positionTarget) {
       this.__removeUpdatePositionEventListeners();
 
-      if (opened && positionTarget) {
-        this.__addUpdatePositionEventListeners();
+      if (positionTarget) {
+        positionTarget.__overlay = null;
+        targetResizeObserver.unobserve(positionTarget);
+
+        if (opened) {
+          this.__addUpdatePositionEventListeners();
+          positionTarget.__overlay = this;
+          targetResizeObserver.observe(positionTarget);
+        }
       }
 
       if (opened) {
@@ -165,6 +182,17 @@ export const PositionMixin = (superClass) =>
         return;
       }
 
+      // Cleanup styles to avoid wrong values after window resize
+      // See https://github.com/vaadin/web-components/issues/4604
+      Object.assign(this.style, {
+        top: '',
+        right: '',
+        bottom: '',
+        left: '',
+        justifyContent: '',
+        alignItems: '',
+      });
+
       const targetRect = this.positionTarget.getBoundingClientRect();
 
       // Detect the desired alignment and update the layout accordingly
@@ -266,12 +294,11 @@ export const PositionMixin = (superClass) =>
 
     /**
      * Returns an object with CSS position properties to set,
-     * e.g. { top: "100px", bottom: "" }
+     * e.g. { top: "100px" }
      */
     // eslint-disable-next-line max-params
     __calculatePositionInOneDimension(targetRect, overlayRect, noOverlap, propNames, overlay, shouldAlignStart) {
       const cssPropNameToSet = shouldAlignStart ? propNames.start : propNames.end;
-      const cssPropNameToClear = shouldAlignStart ? propNames.end : propNames.start;
 
       const currentValue = parseFloat(overlay.style[cssPropNameToSet] || getComputedStyle(overlay)[cssPropNameToSet]);
 
@@ -281,7 +308,6 @@ export const PositionMixin = (superClass) =>
 
       return {
         [cssPropNameToSet]: `${currentValue + diff * (shouldAlignStart ? -1 : 1)}px`,
-        [cssPropNameToClear]: '',
       };
     }
   };

package/src/vaadin-overlay.js

@@ -404,7 +404,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
    * @protected
    */
   _setTemplateFromNodes(nodes) {
-    this.template = nodes.filter((node) => node.localName && node.localName === 'template')[0] || this.template;
+    this.template = nodes.find((node) => node.localName && node.localName === 'template') || this.template;
   }
 
   /**