@vaadin/vaadin-overlay 23.1.0-alpha3 → 23.1.0-beta2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/vaadin-overlay",
-  "version": "23.1.0-alpha3",
+  "version": "23.1.0-beta2",
   "publishConfig": {
     "access": "public"
   },
@@ -35,20 +35,20 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "23.1.0-alpha3",
-    "@vaadin/vaadin-lumo-styles": "23.1.0-alpha3",
-    "@vaadin/vaadin-material-styles": "23.1.0-alpha3",
-    "@vaadin/vaadin-themable-mixin": "23.1.0-alpha3"
+    "@vaadin/component-base": "23.1.0-beta2",
+    "@vaadin/vaadin-lumo-styles": "23.1.0-beta2",
+    "@vaadin/vaadin-material-styles": "23.1.0-beta2",
+    "@vaadin/vaadin-themable-mixin": "23.1.0-beta2"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
     "@polymer/iron-overlay-behavior": "^3.0.0",
-    "@vaadin/button": "23.1.0-alpha3",
-    "@vaadin/radio-group": "23.1.0-alpha3",
+    "@vaadin/button": "23.1.0-beta2",
+    "@vaadin/radio-group": "23.1.0-beta2",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "23.1.0-alpha3",
+    "@vaadin/text-field": "23.1.0-beta2",
     "lit": "^2.0.0",
     "sinon": "^13.0.2"
   },
-  "gitHead": "8c9e64e8dfa158dd52a9bf6da351ff038c88ca85"
+  "gitHead": "f11f9245a0b5e6bf912725a501c27c24b74e7c8d"
 }

package/src/vaadin-overlay-position-mixin.js

@@ -6,12 +6,12 @@
 
 const PROP_NAMES_VERTICAL = {
   start: 'top',
-  end: 'bottom'
+  end: 'bottom',
 };
 
 const PROP_NAMES_HORIZONTAL = {
   start: 'left',
-  end: 'right'
+  end: 'right',
 };
 
 /**
@@ -29,7 +29,7 @@ export const PositionMixin = (superClass) =>
          */
         positionTarget: {
           type: Object,
-          value: null
+          value: null,
         },
 
         /**
@@ -42,7 +42,7 @@ export const PositionMixin = (superClass) =>
          */
         horizontalAlign: {
           type: String,
-          value: 'start'
+          value: 'start',
         },
 
         /**
@@ -54,7 +54,7 @@ export const PositionMixin = (superClass) =>
          */
         verticalAlign: {
           type: String,
-          value: 'top'
+          value: 'top',
         },
 
         /**
@@ -63,7 +63,7 @@ export const PositionMixin = (superClass) =>
          */
         noHorizontalOverlap: {
           type: Boolean,
-          value: false
+          value: false,
         },
 
         /**
@@ -72,15 +72,15 @@ export const PositionMixin = (superClass) =>
          */
         noVerticalOverlap: {
           type: Boolean,
-          value: false
-        }
+          value: false,
+        },
       };
     }
 
     static get observers() {
       return [
         '__positionSettingsChanged(positionTarget, horizontalAlign, verticalAlign, noHorizontalOverlap, noVerticalOverlap)',
-        '__overlayOpenedChanged(opened)'
+        '__overlayOpenedChanged(opened)',
       ];
     }
 
@@ -150,7 +150,7 @@ export const PositionMixin = (superClass) =>
         this.noVerticalOverlap,
         PROP_NAMES_VERTICAL,
         this,
-        shouldAlignStartVertically
+        shouldAlignStartVertically,
       );
 
       // Obtain horizontal positioning properties
@@ -160,7 +160,7 @@ export const PositionMixin = (superClass) =>
         this.noHorizontalOverlap,
         PROP_NAMES_HORIZONTAL,
         this,
-        shouldAlignStartHorizontally
+        shouldAlignStartHorizontally,
       );
 
       // Apply the positioning properties to the overlay
@@ -189,7 +189,7 @@ export const PositionMixin = (superClass) =>
         this.__margins,
         defaultAlignLeft,
         this.noHorizontalOverlap,
-        PROP_NAMES_HORIZONTAL
+        PROP_NAMES_HORIZONTAL,
       );
     }
 
@@ -209,7 +209,7 @@ export const PositionMixin = (superClass) =>
         this.__margins,
         defaultAlignTop,
         this.noVerticalOverlap,
-        PROP_NAMES_VERTICAL
+        PROP_NAMES_VERTICAL,
       );
     }
 
@@ -244,8 +244,8 @@ export const PositionMixin = (superClass) =>
         targetRect[noOverlap === shouldAlignStart ? propNames.end : propNames.start];
 
       return {
-        [cssPropNameToSet]: currentValue + diff * (shouldAlignStart ? -1 : 1) + 'px',
-        [cssPropNameToClear]: ''
+        [cssPropNameToSet]: `${currentValue + diff * (shouldAlignStart ? -1 : 1)}px`,
+        [cssPropNameToClear]: '',
       };
     }
   };

package/src/vaadin-overlay.d.ts

@@ -232,13 +232,13 @@ declare class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(HTML
   addEventListener<K extends keyof OverlayEventMap>(
     type: K,
     listener: (this: OverlayElement, ev: OverlayEventMap[K]) => void,
-    options?: boolean | AddEventListenerOptions
+    options?: boolean | AddEventListenerOptions,
   ): void;
 
   removeEventListener<K extends keyof OverlayEventMap>(
     type: K,
     listener: (this: OverlayElement, ev: OverlayEventMap[K]) => void,
-    options?: boolean | EventListenerOptions
+    options?: boolean | EventListenerOptions,
   ): void;
 }
 

package/src/vaadin-overlay.js

@@ -194,7 +194,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
         type: Boolean,
         notify: true,
         observer: '_openedChanged',
-        reflectToAttribute: true
+        reflectToAttribute: true,
       },
 
       /**
@@ -220,7 +220,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
        */
       template: {
         type: Object,
-        notify: true
+        notify: true,
       },
 
       /**
@@ -229,7 +229,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
        */
       content: {
         type: Object,
-        notify: true
+        notify: true,
       },
 
       /**
@@ -239,7 +239,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
       withBackdrop: {
         type: Boolean,
         value: false,
-        reflectToAttribute: true
+        reflectToAttribute: true,
       },
 
       /**
@@ -256,7 +256,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
         type: Boolean,
         value: false,
         reflectToAttribute: true,
-        observer: '_modelessChanged'
+        observer: '_modelessChanged',
       },
 
       /**
@@ -267,7 +267,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
       hidden: {
         type: Boolean,
         reflectToAttribute: true,
-        observer: '_hiddenChanged'
+        observer: '_hiddenChanged',
       },
 
       /**
@@ -277,7 +277,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
        */
       focusTrap: {
         type: Boolean,
-        value: false
+        value: false,
       },
 
       /**
@@ -286,7 +286,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
        */
       restoreFocusOnClose: {
         type: Boolean,
-        value: false
+        value: false,
       },
 
       /**
@@ -295,22 +295,22 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
        * @type {HTMLElement}
        */
       restoreFocusNode: {
-        type: HTMLElement
+        type: HTMLElement,
       },
 
       /** @private */
       _mouseDownInside: {
-        type: Boolean
+        type: Boolean,
       },
 
       /** @private */
       _mouseUpInside: {
-        type: Boolean
+        type: Boolean,
       },
 
       /** @private */
       _instance: {
-        type: Object
+        type: Object,
       },
 
       /** @private */
@@ -332,7 +332,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
       _oldRenderer: Object,
 
       /** @private */
-      _oldOpened: Boolean
+      _oldOpened: Boolean,
     };
   }
 
@@ -393,7 +393,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
     const clientHeight = document.documentElement.clientHeight;
 
     if (landscape && clientHeight > innerHeight) {
-      this.style.setProperty('--vaadin-overlay-viewport-bottom', clientHeight - innerHeight + 'px');
+      this.style.setProperty('--vaadin-overlay-viewport-bottom', `${clientHeight - innerHeight}px`);
     } else {
       this.style.setProperty('--vaadin-overlay-viewport-bottom', '0');
     }
@@ -413,10 +413,10 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
    * fired before the `vaadin-overlay` will be closed. If canceled the closing of the overlay is canceled as well.
    */
   close(sourceEvent) {
-    var evt = new CustomEvent('vaadin-overlay-close', {
+    const evt = new CustomEvent('vaadin-overlay-close', {
       bubbles: true,
       cancelable: true,
-      detail: { sourceEvent: sourceEvent }
+      detail: { sourceEvent },
     });
     this.dispatchEvent(evt);
     if (!evt.defaultPrevented) {
@@ -483,7 +483,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
    * @private
    */
   _outsideClickListener(event) {
-    if (event.composedPath().indexOf(this.$.overlay) !== -1 || this._mouseDownInside || this._mouseUpInside) {
+    if (event.composedPath().includes(this.$.overlay) || this._mouseDownInside || this._mouseUpInside) {
       this._mouseDownInside = false;
       this._mouseUpInside = false;
       return;
@@ -495,7 +495,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
     const evt = new CustomEvent('vaadin-overlay-outside-click', {
       bubbles: true,
       cancelable: true,
-      detail: { sourceEvent: event }
+      detail: { sourceEvent: event },
     });
     this.dispatchEvent(evt);
 
@@ -519,7 +519,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
       const evt = new CustomEvent('vaadin-overlay-escape-press', {
         bubbles: true,
         cancelable: true,
-        detail: { sourceEvent: event }
+        detail: { sourceEvent: event },
       });
       this.dispatchEvent(evt);
 
@@ -587,7 +587,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
   _shouldAnimate() {
     const name = getComputedStyle(this).getPropertyValue('animation-name');
     const hidden = getComputedStyle(this).getPropertyValue('display') === 'none';
-    return !hidden && name && name != 'none';
+    return !hidden && name && name !== 'none';
   }
 
   /**
@@ -725,7 +725,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
   }
 
   /**
-   * returns true if this is the last one in the opened overlays stack
+   * Returns true if this is the last one in the opened overlays stack
    * @return {boolean}
    * @protected
    */
@@ -842,11 +842,11 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
 
     if (!template._Templatizer) {
       template._Templatizer = templatize(template, this, {
-        forwardHostProp: function (prop, value) {
+        forwardHostProp(prop, value) {
           if (this._instance) {
             this._instance.forwardHostProp(prop, value);
           }
-        }
+        },
       });
     }
 
@@ -862,7 +862,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
 
       let scopeCssText = Array.from(templateRoot.querySelectorAll('style')).reduce(
         (result, style) => result + style.textContent,
-        ''
+        '',
       );
 
       // The overlay root’s :host styles should not apply inside the overlay
@@ -937,7 +937,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
    * @protected
    */
   _getActiveElement() {
-    // document.activeElement can be null
+    // Document.activeElement can be null
     // https://developer.mozilla.org/en-US/docs/Web/API/Document/activeElement
     let active = document.activeElement || document.body;
     while (active.shadowRoot && active.shadowRoot.activeElement) {
@@ -957,7 +957,7 @@ class OverlayElement extends ThemableMixin(DirMixin(ControllerMixin(PolymerEleme
     }
     let n = node;
     const doc = node.ownerDocument;
-    // walk from node to `this` or `document`
+    // Walk from node to `this` or `document`
     while (n && n !== doc && n !== this) {
       n = n.parentNode || n.host;
     }