@vaadin/vaadin-overlay 22.0.0-rc1 → 23.0.0-alpha1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/vaadin-overlay",
-  "version": "22.0.0-rc1",
+  "version": "23.0.0-alpha1",
   "publishConfig": {
     "access": "public"
   },
@@ -34,20 +34,20 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "22.0.0-rc1",
-    "@vaadin/vaadin-lumo-styles": "22.0.0-rc1",
-    "@vaadin/vaadin-material-styles": "22.0.0-rc1",
-    "@vaadin/vaadin-themable-mixin": "22.0.0-rc1"
+    "@vaadin/component-base": "23.0.0-alpha1",
+    "@vaadin/vaadin-lumo-styles": "23.0.0-alpha1",
+    "@vaadin/vaadin-material-styles": "23.0.0-alpha1",
+    "@vaadin/vaadin-themable-mixin": "23.0.0-alpha1"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
     "@polymer/iron-overlay-behavior": "^3.0.0",
-    "@vaadin/button": "22.0.0-rc1",
-    "@vaadin/radio-group": "22.0.0-rc1",
+    "@vaadin/button": "23.0.0-alpha1",
+    "@vaadin/radio-group": "23.0.0-alpha1",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "22.0.0-rc1",
+    "@vaadin/text-field": "23.0.0-alpha1",
     "lit": "^2.0.0",
     "sinon": "^9.2.1"
   },
-  "gitHead": "7b6f44bcd2c0fd415028ace666feeb0fedb1d540"
+  "gitHead": "fbcb07328fdf88260e3b461088d207426b21c710"
 }

package/src/vaadin-overlay.d.ts

@@ -61,8 +61,7 @@ export type OverlayEventMap = HTMLElementEventMap & OverlayElementEventMap;
  *
  * The overlay provides `forwardHostProp` when calling
  * `Polymer.Templatize.templatize` for the template, so that the bindings
- * from the parent scope propagate to the content.  You can also pass
- * custom `instanceProps` object using the `instanceProps` property.
+ * from the parent scope propagate to the content.
  *
  * ```html
  * <vaadin-overlay>
@@ -70,10 +69,6 @@ export type OverlayEventMap = HTMLElementEventMap & OverlayElementEventMap;
  * </vaadin-overlay>
  * ```
  *
- * **NOTE:** when using `instanceProps`: because of the Polymer limitation,
- * every template can only be templatized once, so it is important
- * to set `instanceProps` before the `template` is assigned to the overlay.
- *
  * ### Styling
  *
  * To style the overlay content, use styles in the parent scope:
@@ -136,11 +131,6 @@ declare class OverlayElement extends ThemableMixin(DirMixin(HTMLElement)) {
    */
   template: HTMLTemplateElement | null | undefined;
 
-  /**
-   * Optional argument for `Polymer.Templatize.templatize`.
-   */
-  instanceProps: object | null | undefined;
-
   /**
    * References the content container after the template is stamped.
    */

package/src/vaadin-overlay.js

@@ -55,18 +55,7 @@ import { FocusablesHelper } from './vaadin-focusables-helper.js';
  *
  * The overlay provides `forwardHostProp` when calling
  * `Polymer.Templatize.templatize` for the template, so that the bindings
- * from the parent scope propagate to the content.  You can also pass
- * custom `instanceProps` object using the `instanceProps` property.
- *
- * ```html
- * <vaadin-overlay>
- *   <template>Overlay content</template>
- * </vaadin-overlay>
- * ```
- *
- * **NOTE:** when using `instanceProps`: because of the Polymer limitation,
- * every template can only be templatized once, so it is important
- * to set `instanceProps` before the `template` is assigned to the overlay.
+ * from the parent scope propagate to the content.
  *
  * ### Styling
  *
@@ -227,13 +216,6 @@ class OverlayElement extends ThemableMixin(DirMixin(PolymerElement)) {
         notify: true
       },
 
-      /**
-       * Optional argument for `Polymer.Templatize.templatize`.
-       */
-      instanceProps: {
-        type: Object
-      },
-
       /**
        * References the content container after the template is stamped.
        * @type {!HTMLElement | undefined}
@@ -330,9 +312,6 @@ class OverlayElement extends ThemableMixin(DirMixin(PolymerElement)) {
       /** @private */
       _oldTemplate: Object,
 
-      /** @private */
-      _oldInstanceProps: Object,
-
       /** @private */
       _oldRenderer: Object,
 
@@ -342,7 +321,7 @@ class OverlayElement extends ThemableMixin(DirMixin(PolymerElement)) {
   }
 
   static get observers() {
-    return ['_templateOrRendererChanged(template, renderer, owner, model, instanceProps, opened)'];
+    return ['_templateOrRendererChanged(template, renderer, owner, model, opened)'];
   }
 
   constructor() {
@@ -825,15 +804,13 @@ class OverlayElement extends ThemableMixin(DirMixin(PolymerElement)) {
 
   /**
    * @param {!HTMLTemplateElement} template
-   * @param {object} instanceProps
    * @protected
    */
-  _stampOverlayTemplate(template, instanceProps) {
+  _stampOverlayTemplate(template) {
     this._removeOldContent();
 
     if (!template._Templatizer) {
       template._Templatizer = templatize(template, this, {
-        instanceProps: instanceProps,
         forwardHostProp: function (prop, value) {
           if (this._instance) {
             this._instance.forwardHostProp(prop, value);
@@ -886,7 +863,7 @@ class OverlayElement extends ThemableMixin(DirMixin(PolymerElement)) {
   }
 
   /** @private */
-  _templateOrRendererChanged(template, renderer, owner, model, instanceProps, opened) {
+  _templateOrRendererChanged(template, renderer, owner, model, opened) {
     if (template && renderer) {
       this._removeNewRendererOrTemplate(template, this._oldTemplate, renderer, this._oldRenderer);
       throw new Error('You should only use either a renderer or a template for overlay content');
@@ -896,8 +873,7 @@ class OverlayElement extends ThemableMixin(DirMixin(PolymerElement)) {
     this._oldModel = model;
     this._oldOwner = owner;
 
-    const templateOrInstancePropsChanged = this._oldInstanceProps !== instanceProps || this._oldTemplate !== template;
-    this._oldInstanceProps = instanceProps;
+    const templateChanged = this._oldTemplate !== template;
     this._oldTemplate = template;
 
     const rendererChanged = this._oldRenderer !== renderer;
@@ -915,8 +891,8 @@ class OverlayElement extends ThemableMixin(DirMixin(PolymerElement)) {
       delete this.content._$litPart$;
     }
 
-    if (template && templateOrInstancePropsChanged) {
-      this._stampOverlayTemplate(template, instanceProps);
+    if (template && templateChanged) {
+      this._stampOverlayTemplate(template);
     } else if (renderer && (rendererChanged || openedChanged || ownerOrModelChanged)) {
       if (opened) {
         this.requestContentUpdate();