@vaadin/vaadin-charts 6.3.2 → 6.3.4

package/package.json

@@ -10,10 +10,11 @@
   "repository": "vaadin/vaadin-charts",
   "homepage": "https://vaadin.com/charts",
   "name": "@vaadin/vaadin-charts",
-  "version": "6.3.2",
+  "version": "6.3.4",
   "main": "vaadin-chart.js",
   "author": "Vaadin Ltd",
   "license": "SEE LICENSE IN LICENSE.txt",
+  "cvdlName": "vaadin-chart",
   "bugs": {
     "url": "https://github.com/vaadin/vaadin-charts/issues"
   },
@@ -23,8 +24,6 @@
     "theme"
   ],
   "resolutions": {
-    "es-abstract": "1.17.6",
-    "@types/doctrine": "0.0.3",
     "inherits": "2.0.3",
     "samsam": "1.1.3",
     "supports-color": "3.1.2",
@@ -37,10 +36,9 @@
     "@vaadin/vaadin-license-checker": "^2.1.0",
     "@vaadin/vaadin-element-mixin": "^2.3.2"
   },
-  "scripts": {
-  "generate-typings": "gen-typescript-declarations --outDir . --verify"
-},
-"devDependencies": {
+  "devDependencies": {
+    "@web-padawan/gen-typescript-declarations": "^1.6.2",
+    "web-component-tester": "6.9.2",
     "@polymer/iron-component-page": "^4.0.0",
     "@webcomponents/webcomponentsjs": "^2.0.0",
     "wct-browser-legacy": "^1.0.1",
@@ -56,5 +54,9 @@
     "@vaadin/vaadin-icons": "^4.2.0",
     "@vaadin/vaadin-button": "^2.3.0-alpha1",
     "@vaadin/vaadin-ordered-layout": "^1.3.0"
+  },
+  "scripts": {
+    "generate-typings": "gen-typescript-declarations --outDir . --verify",
+    "test": "wct --npm"
   }
 }

package/src/vaadin-chart.js

@@ -369,26 +369,6 @@ class ChartElement extends ElementMixin(ThemableMixin(PolymerElement)) {
       :host([hidden]) {
         display: none !important;
       }
-
-      /* https://github.com/highcharts/highcharts/issues/4649 */
-      /* https://github.com/vaadin/web-components/issues/2171 */
-      .highcharts-container svg {
-        width: 100% !important;
-      }
-
-      :host(.ff-lt-68) {
-        position: relative;
-        height: 400px;
-      }
-
-      :host(.ff-lt-68) #chart {
-        position: absolute;
-        top: 0;
-        bottom: 0;
-        left: 0;
-        right: 0;
-        overflow: hidden;
-      }
     </style>
     <div id="chart"></div>
     <slot id="slot"></slot>
@@ -400,7 +380,11 @@ class ChartElement extends ElementMixin(ThemableMixin(PolymerElement)) {
   }
 
   static get version() {
-    return '6.3.2';
+    return '6.3.4';
+  }
+
+  static get cvdlName() {
+    return 'vaadin-chart';
   }
 
   static get properties() {
@@ -605,15 +589,6 @@ class ChartElement extends ElementMixin(ThemableMixin(PolymerElement)) {
   constructor() {
     super();
 
-    const isFirefox = window.navigator.userAgent.match(/Firefox\/([0-9]+)\./);
-    if (isFirefox) {
-      const fireFoxVersion = parseInt(isFirefox[1], 10);
-
-      if (fireFoxVersion < 68) {
-        this.classList.add('ff-lt-68');
-      }
-    }
-
     /**
      * List of properties that will always be copied from the chart element to the container div
      **/
@@ -1079,11 +1054,13 @@ class ChartElement extends ElementMixin(ThemableMixin(PolymerElement)) {
         this.__setYAxisProps(yAxes, unit, {max: valueMax});
       }
 
-      const seriesConfiguration = this.__updateOrAddSeriesInstance(seriesElement.options, idxOnChildList);
+      const seriesConfiguration = this.__updateOrAddSeriesInstance(seriesElement.options, idxOnChildList, false);
 
       seriesElement.setSeries(seriesConfiguration);
     }
     this.__removeAxisIfEmpty();
+
+    this.configuration.redraw();
   }
 
   __removeSeries(seriesNodes) {
@@ -1264,20 +1241,22 @@ class ChartElement extends ElementMixin(ThemableMixin(PolymerElement)) {
         return;
       }
 
-      this.configuration.update(this._jsonConfigurationBuffer);
+      this.configuration.update(this._jsonConfigurationBuffer, false);
       if (this._jsonConfigurationBuffer.credits) {
         this.__updateOrAddCredits(this._jsonConfigurationBuffer.credits);
       }
       if (this._jsonConfigurationBuffer.xAxis) {
-        this.__updateOrAddAxes(this._jsonConfigurationBuffer.xAxis, true);
+        this.__updateOrAddAxes(this._jsonConfigurationBuffer.xAxis, true, false);
       }
       if (this._jsonConfigurationBuffer.yAxis) {
-        this.__updateOrAddAxes(this._jsonConfigurationBuffer.yAxis, false);
+        this.__updateOrAddAxes(this._jsonConfigurationBuffer.yAxis, false, false);
       }
       if (this._jsonConfigurationBuffer.series) {
-        this.__updateOrAddSeries(this._jsonConfigurationBuffer.series);
+        this.__updateOrAddSeries(this._jsonConfigurationBuffer.series, false);
       }
       this._jsonConfigurationBuffer = null;
+
+      this.configuration.redraw();
     });
   }
 
@@ -1499,7 +1478,7 @@ class ChartElement extends ElementMixin(ThemableMixin(PolymerElement)) {
     }
   }
 
-  __updateOrAddAxes(axes, isX) {
+  __updateOrAddAxes(axes, isX, redraw) {
     if (!Array.isArray(axes)) {
       axes = [axes];
     }
@@ -1507,28 +1486,28 @@ class ChartElement extends ElementMixin(ThemableMixin(PolymerElement)) {
     for (let i = 0; i < axes.length; i++) {
       const axis = axes[i];
       if (confAxes[i]) {
-        confAxes[i].update(axis);
+        confAxes[i].update(axis, redraw);
       } else {
-        this.configuration.addAxis(axis, isX);
+        this.configuration.addAxis(axis, isX, redraw);
       }
     }
   }
 
-  __updateOrAddSeries(series) {
+  __updateOrAddSeries(series, redraw) {
     if (!Array.isArray(series)) {
       throw new Error('The type of jsonConfiguration.series should be Object[]');
     }
     for (let i = 0; i < series.length; i++) {
       const currentSeries = series[i];
-      this.__updateOrAddSeriesInstance(currentSeries, i);
+      this.__updateOrAddSeriesInstance(currentSeries, i, redraw);
     }
   }
 
-  __updateOrAddSeriesInstance(seriesOptions, position) {
+  __updateOrAddSeriesInstance(seriesOptions, position, redraw) {
     if (this.configuration.series[position]) {
-      this.configuration.series[position].update(seriesOptions);
+      this.configuration.series[position].update(seriesOptions, redraw);
     } else {
-      this.configuration.addSeries(seriesOptions);
+      this.configuration.addSeries(seriesOptions, redraw);
     }
     return this.configuration.series[position];
   }