@vaadin/select 22.0.0-beta1 → 22.0.1

package/README.md

@@ -1,17 +1,14 @@
-# <vaadin-select>
+# @vaadin/select
 
-[Live Demo ↗](https://vaadin.com/components/vaadin-select/html-examples)
-|
-[API documentation ↗](https://vaadin.com/components/vaadin-select/html-api)
+A web component for selecting a single value from a list of options presented in an overlay.
 
-[<vaadin-select>](https://vaadin.com/components/vaadin-select) is a Web Component similar to a native browser select element, part of the [Vaadin components](https://vaadin.com/components).
+[Documentation + Live Demo ↗](https://vaadin.com/docs/latest/ds/components/select)
 
 [![npm version](https://badgen.net/npm/v/@vaadin/vaadin-select)](https://www.npmjs.com/package/@vaadin/vaadin-select)
-[![Published on Vaadin Directory](https://img.shields.io/badge/Vaadin%20Directory-published-00b4f0.svg)](https://vaadin.com/directory/component/vaadinvaadin-select)
 [![Discord](https://img.shields.io/discord/732335336448852018?label=discord)](https://discord.gg/PHmkCKC)
 
 ```html
-<vaadin-select></vaadin-select>
+<vaadin-select label="Sort by"></vaadin-select>
 <script>
   document.querySelector('vaadin-select').renderer = (root) => {
     if (root.firstElementChild) {
@@ -19,55 +16,58 @@
     }
 
     // Note that innerHTML is only used for demo purposes here!
-    // Prefer using a templating library instead.
+    // Consider using Lit or another template library instead.
     root.innerHTML = `
       <vaadin-list-box>
-        <vaadin-item>Option one</vaadin-item>
-        <vaadin-item>Option two</vaadin-item>
-        <vaadin-item>Option three</vaadin-item>
-        <hr>
-        <vaadin-item disabled>Option four</vaadin-item>
+        <vaadin-item value="recent">Most recent first</vaadin-item>
+        <vaadin-item value="rating-desc">Rating: high to low</vaadin-item>
+        <vaadin-item value="rating-asc">Rating: low to high</vaadin-item>
+        <vaadin-item value="price-desc">Price: high to low</vaadin-item>
+        <vaadin-item value="price-asc">Price: low to high</vaadin-item>
       </vaadin-list-box>
     `;
   };
 </script>
 ```
 
-[<img src="https://raw.githubusercontent.com/vaadin/vaadin-select/master/screenshot.gif" width="220" alt="Screenshot of vaadin-select">](https://vaadin.com/components/vaadin-select)
+[<img src="https://raw.githubusercontent.com/vaadin/web-components/master/packages/select/screenshot.png" width="231" alt="Screenshot of vaadin-select">](https://vaadin.com/docs/latest/ds/components/select)
 
 ## Installation
 
-Install `vaadin-select`:
+Install the component:
 
 ```sh
-npm i @vaadin/vaadin-select --save
+npm i @vaadin/select
 ```
 
-Once installed, import it in your application:
+Once installed, import the component in your application:
 
 ```js
-import '@vaadin/vaadin-select/vaadin-select.js';
+import '@vaadin/select';
 ```
 
-## Getting started
+## Themes
 
-Vaadin components use the Lumo theme by default.
+Vaadin components come with two built-in [themes](https://vaadin.com/docs/latest/ds/customization/using-themes), Lumo and Material.
+The [main entrypoint](https://github.com/vaadin/web-components/blob/master/packages/select/vaadin-select.js) of the package uses the Lumo theme.
 
-To use the Material theme, import the correspondent file from the `theme/material` folder.
+To use the Material theme, import the component from the `theme/material` folder:
 
-## Entry points
-
-- The component with the Lumo theme:
-
-  `theme/lumo/vaadin-select.js`
+```js
+import '@vaadin/select/theme/material/vaadin-select.js';
+```
 
-- The component with the Material theme:
+You can also import the Lumo version of the component explicitly:
 
-- `theme/material/vaadin-select.js`
+```js
+import '@vaadin/select/theme/lumo/vaadin-select.js';
+```
 
-- Alias for `theme/lumo/vaadin-select.js`:
+Finally, you can import the un-themed component from the `src` folder to get a minimal starting point:
 
-- `vaadin-select.js`
+```js
+import '@vaadin/select/src/vaadin-select.js';
+```
 
 ## Contributing
 
@@ -77,4 +77,5 @@ Read the [contributing guide](https://vaadin.com/docs/latest/guide/contributing/
 
 Apache License 2.0
 
-Vaadin collects development time usage statistics to improve this product. For details and to opt-out, see https://github.com/vaadin/vaadin-usage-statistics.
+Vaadin collects usage statistics at development time to improve this product.
+For details and to opt-out, see https://github.com/vaadin/vaadin-usage-statistics.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/select",
-  "version": "22.0.0-beta1",
+  "version": "22.0.1",
   "publishConfig": {
     "access": "public"
   },
@@ -34,24 +34,24 @@
   "dependencies": {
     "@polymer/iron-media-query": "^3.0.0",
     "@polymer/polymer": "^3.2.0",
-    "@vaadin/button": "22.0.0-beta1",
-    "@vaadin/component-base": "22.0.0-beta1",
-    "@vaadin/field-base": "22.0.0-beta1",
-    "@vaadin/input-container": "22.0.0-beta1",
-    "@vaadin/item": "22.0.0-beta1",
-    "@vaadin/list-box": "22.0.0-beta1",
-    "@vaadin/vaadin-list-mixin": "22.0.0-beta1",
-    "@vaadin/vaadin-lumo-styles": "22.0.0-beta1",
-    "@vaadin/vaadin-material-styles": "22.0.0-beta1",
-    "@vaadin/vaadin-overlay": "22.0.0-beta1",
-    "@vaadin/vaadin-themable-mixin": "22.0.0-beta1"
+    "@vaadin/button": "^22.0.1",
+    "@vaadin/component-base": "^22.0.1",
+    "@vaadin/field-base": "^22.0.1",
+    "@vaadin/input-container": "^22.0.1",
+    "@vaadin/item": "^22.0.1",
+    "@vaadin/list-box": "^22.0.1",
+    "@vaadin/vaadin-list-mixin": "^22.0.1",
+    "@vaadin/vaadin-lumo-styles": "^22.0.1",
+    "@vaadin/vaadin-material-styles": "^22.0.1",
+    "@vaadin/vaadin-overlay": "^22.0.1",
+    "@vaadin/vaadin-themable-mixin": "^22.0.1"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/polymer-legacy-adapter": "22.0.0-beta1",
-    "@vaadin/testing-helpers": "^0.3.0",
+    "@vaadin/polymer-legacy-adapter": "^22.0.1",
+    "@vaadin/testing-helpers": "^0.3.2",
     "lit": "^2.0.0",
     "sinon": "^9.2.0"
   },
-  "gitHead": "4cf8a9d0504994200c610e44b3676114fef49c1e"
+  "gitHead": "2b0a2bff0369d6020f7cc33ad35506aa2d1f6f68"
 }

package/src/vaadin-select-overlay.js

@@ -4,8 +4,8 @@
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
 import { OverlayElement } from '@vaadin/vaadin-overlay/src/vaadin-overlay.js';
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
 import { PositionMixin } from '@vaadin/vaadin-overlay/src/vaadin-overlay-position-mixin.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 registerStyles(
   'vaadin-select-overlay',

package/src/vaadin-select-value-button.js

@@ -4,7 +4,7 @@
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
 import { Button } from '@vaadin/button/src/vaadin-button.js';
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 registerStyles(
   'vaadin-select-value-button',

package/src/vaadin-select.js

@@ -3,8 +3,11 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
-import { PolymerElement, html } from '@polymer/polymer/polymer-element.js';
 import '@polymer/iron-media-query/iron-media-query.js';
+import '@vaadin/input-container/src/vaadin-input-container.js';
+import './vaadin-select-overlay.js';
+import './vaadin-select-value-button.js';
+import { html, PolymerElement } from '@polymer/polymer/polymer-element.js';
 import { ElementMixin } from '@vaadin/component-base/src/element-mixin.js';
 import { SlotMixin } from '@vaadin/component-base/src/slot-mixin.js';
 import { processTemplates } from '@vaadin/component-base/src/templates.js';
@@ -12,11 +15,7 @@ import { DelegateFocusMixin } from '@vaadin/field-base/src/delegate-focus-mixin.
 import { FieldMixin } from '@vaadin/field-base/src/field-mixin.js';
 import { fieldShared } from '@vaadin/field-base/src/styles/field-shared-styles.js';
 import { inputFieldContainer } from '@vaadin/field-base/src/styles/input-field-container-styles.js';
-import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
-import { registerStyles } from '@vaadin/vaadin-themable-mixin/register-styles.js';
-import '@vaadin/input-container/src/vaadin-input-container.js';
-import './vaadin-select-overlay.js';
-import './vaadin-select-value-button.js';
+import { registerStyles, ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 registerStyles('vaadin-select', [fieldShared, inputFieldContainer], { moduleId: 'vaadin-select-styles' });
 
@@ -344,6 +343,10 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
    * It is not guaranteed that the update happens immediately (synchronously) after it is requested.
    */
   requestContentUpdate() {
+    if (!this._overlayElement) {
+      return;
+    }
+
     this._overlayElement.requestContentUpdate();
 
     // Ensure menu element is set
@@ -380,7 +383,9 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
         this._items.forEach((item) => item.setAttribute('role', 'option'));
       });
       menuElement.addEventListener('selected-changed', () => this.__updateValueButton());
-      menuElement.addEventListener('keydown', (e) => this._onKeyDownInside(e));
+      // Use capture phase to make it possible for `<vaadin-grid-pro-edit-select>`
+      // to override and handle the keydown event before the value change happens.
+      menuElement.addEventListener('keydown', (e) => this._onKeyDownInside(e), true);
       menuElement.addEventListener(
         'click',
         () => {
@@ -484,13 +489,9 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
 
       this._menuElement.focus();
     } else if (wasOpened) {
-      if (this._phone) {
-        this._setFocused(false);
-      } else {
-        this.focus();
-        if (this._openedWithFocusRing) {
-          this.setAttribute('focus-ring', '');
-        }
+      this.focus();
+      if (this._openedWithFocusRing) {
+        this.setAttribute('focus-ring', '');
       }
       this.validate();
     }

package/theme/lumo/vaadin-select-styles.js

@@ -3,33 +3,37 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
 import '@vaadin/vaadin-lumo-styles/sizing.js';
 import '@vaadin/vaadin-lumo-styles/style.js';
 import '@vaadin/vaadin-lumo-styles/font-icons.js';
-import { menuOverlay } from '@vaadin/vaadin-lumo-styles/mixins/menu-overlay.js';
 import { inputFieldShared } from '@vaadin/vaadin-lumo-styles/mixins/input-field-shared.js';
+import { menuOverlay } from '@vaadin/vaadin-lumo-styles/mixins/menu-overlay.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 const select = css`
   :host(:not([theme*='align'])) ::slotted([slot='value']) {
     text-align: start;
   }
 
+  [part='input-field'] {
+    cursor: var(--lumo-clickable-cursor);
+  }
+
   [part='input-field'] ::slotted([slot='value']) {
     font-weight: 500;
   }
 
+  [part='input-field'] ::slotted([slot='value']:not([placeholder])) {
+    color: var(--lumo-body-text-color);
+  }
+
   /* placeholder styles */
-  :host [part='input-field'] ::slotted([slot='value'][placeholder]) {
+  [part='input-field'] ::slotted([slot='value'][placeholder]) {
     color: inherit;
     transition: opacity 0.175s 0.1s;
     opacity: 0.5;
   }
 
-  :host [part='input-field'] ::slotted([slot='value']) {
-    color: var(--lumo-body-text-color);
-  }
-
   [part='toggle-button']::before {
     content: var(--lumo-icons-dropdown);
   }

package/theme/material/vaadin-select-styles.js

@@ -3,10 +3,10 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
 import '@vaadin/vaadin-material-styles/font-icons.js';
-import { menuOverlay } from '@vaadin/vaadin-material-styles/mixins/menu-overlay.js';
 import { inputFieldShared } from '@vaadin/vaadin-material-styles/mixins/input-field-shared.js';
+import { menuOverlay } from '@vaadin/vaadin-material-styles/mixins/menu-overlay.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 const select = css`
   :host {