@vaadin/select 22.0.0-alpha9 → 22.0.0

package/README.md

@@ -1,17 +1,14 @@
-# <vaadin-select>
+# @vaadin/select
 
-[Live Demo ↗](https://vaadin.com/components/vaadin-select/html-examples)
-|
-[API documentation ↗](https://vaadin.com/components/vaadin-select/html-api)
+A web component for selecting a single value from a list of options presented in an overlay.
 
-[<vaadin-select>](https://vaadin.com/components/vaadin-select) is a Web Component similar to a native browser select element, part of the [Vaadin components](https://vaadin.com/components).
+[Documentation + Live Demo ↗](https://vaadin.com/docs/latest/ds/components/select)
 
 [![npm version](https://badgen.net/npm/v/@vaadin/vaadin-select)](https://www.npmjs.com/package/@vaadin/vaadin-select)
-[![Published on Vaadin Directory](https://img.shields.io/badge/Vaadin%20Directory-published-00b4f0.svg)](https://vaadin.com/directory/component/vaadinvaadin-select)
 [![Discord](https://img.shields.io/discord/732335336448852018?label=discord)](https://discord.gg/PHmkCKC)
 
 ```html
-<vaadin-select></vaadin-select>
+<vaadin-select label="Sort by"></vaadin-select>
 <script>
   document.querySelector('vaadin-select').renderer = (root) => {
     if (root.firstElementChild) {
@@ -19,55 +16,58 @@
     }
 
     // Note that innerHTML is only used for demo purposes here!
-    // Prefer using a templating library instead.
+    // Consider using Lit or another template library instead.
     root.innerHTML = `
       <vaadin-list-box>
-        <vaadin-item>Option one</vaadin-item>
-        <vaadin-item>Option two</vaadin-item>
-        <vaadin-item>Option three</vaadin-item>
-        <hr>
-        <vaadin-item disabled>Option four</vaadin-item>
+        <vaadin-item value="recent">Most recent first</vaadin-item>
+        <vaadin-item value="rating-desc">Rating: high to low</vaadin-item>
+        <vaadin-item value="rating-asc">Rating: low to high</vaadin-item>
+        <vaadin-item value="price-desc">Price: high to low</vaadin-item>
+        <vaadin-item value="price-asc">Price: low to high</vaadin-item>
       </vaadin-list-box>
     `;
   };
 </script>
 ```
 
-[<img src="https://raw.githubusercontent.com/vaadin/vaadin-select/master/screenshot.gif" width="220" alt="Screenshot of vaadin-select">](https://vaadin.com/components/vaadin-select)
+[<img src="https://raw.githubusercontent.com/vaadin/web-components/master/packages/select/screenshot.png" width="231" alt="Screenshot of vaadin-select">](https://vaadin.com/docs/latest/ds/components/select)
 
 ## Installation
 
-Install `vaadin-select`:
+Install the component:
 
 ```sh
-npm i @vaadin/vaadin-select --save
+npm i @vaadin/select
 ```
 
-Once installed, import it in your application:
+Once installed, import the component in your application:
 
 ```js
-import '@vaadin/vaadin-select/vaadin-select.js';
+import '@vaadin/select';
 ```
 
-## Getting started
+## Themes
 
-Vaadin components use the Lumo theme by default.
+Vaadin components come with two built-in [themes](https://vaadin.com/docs/latest/ds/customization/using-themes), Lumo and Material.
+The [main entrypoint](https://github.com/vaadin/web-components/blob/master/packages/select/vaadin-select.js) of the package uses the Lumo theme.
 
-To use the Material theme, import the correspondent file from the `theme/material` folder.
+To use the Material theme, import the component from the `theme/material` folder:
 
-## Entry points
-
-- The component with the Lumo theme:
-
-  `theme/lumo/vaadin-select.js`
+```js
+import '@vaadin/select/theme/material/vaadin-select.js';
+```
 
-- The component with the Material theme:
+You can also import the Lumo version of the component explicitly:
 
-- `theme/material/vaadin-select.js`
+```js
+import '@vaadin/select/theme/lumo/vaadin-select.js';
+```
 
-- Alias for `theme/lumo/vaadin-select.js`:
+Finally, you can import the un-themed component from the `src` folder to get a minimal starting point:
 
-- `vaadin-select.js`
+```js
+import '@vaadin/select/src/vaadin-select.js';
+```
 
 ## Contributing
 
@@ -77,4 +77,5 @@ Read the [contributing guide](https://vaadin.com/docs/latest/guide/contributing/
 
 Apache License 2.0
 
-Vaadin collects development time usage statistics to improve this product. For details and to opt-out, see https://github.com/vaadin/vaadin-usage-statistics.
+Vaadin collects usage statistics at development time to improve this product.
+For details and to opt-out, see https://github.com/vaadin/vaadin-usage-statistics.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/select",
-  "version": "22.0.0-alpha9",
+  "version": "22.0.0",
   "publishConfig": {
     "access": "public"
   },
@@ -34,24 +34,24 @@
   "dependencies": {
     "@polymer/iron-media-query": "^3.0.0",
     "@polymer/polymer": "^3.2.0",
-    "@vaadin/button": "22.0.0-alpha9",
-    "@vaadin/component-base": "22.0.0-alpha9",
-    "@vaadin/field-base": "22.0.0-alpha9",
-    "@vaadin/input-container": "22.0.0-alpha9",
-    "@vaadin/item": "22.0.0-alpha9",
-    "@vaadin/list-box": "22.0.0-alpha9",
-    "@vaadin/vaadin-list-mixin": "22.0.0-alpha9",
-    "@vaadin/vaadin-lumo-styles": "22.0.0-alpha9",
-    "@vaadin/vaadin-material-styles": "22.0.0-alpha9",
-    "@vaadin/vaadin-overlay": "22.0.0-alpha9",
-    "@vaadin/vaadin-themable-mixin": "22.0.0-alpha9"
+    "@vaadin/button": "^22.0.0",
+    "@vaadin/component-base": "^22.0.0",
+    "@vaadin/field-base": "^22.0.0",
+    "@vaadin/input-container": "^22.0.0",
+    "@vaadin/item": "^22.0.0",
+    "@vaadin/list-box": "^22.0.0",
+    "@vaadin/vaadin-list-mixin": "^22.0.0",
+    "@vaadin/vaadin-lumo-styles": "^22.0.0",
+    "@vaadin/vaadin-material-styles": "^22.0.0",
+    "@vaadin/vaadin-overlay": "^22.0.0",
+    "@vaadin/vaadin-themable-mixin": "^22.0.0"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/polymer-legacy-adapter": "22.0.0-alpha9",
-    "@vaadin/testing-helpers": "^0.3.0",
+    "@vaadin/polymer-legacy-adapter": "^22.0.0",
+    "@vaadin/testing-helpers": "^0.3.2",
     "lit": "^2.0.0",
     "sinon": "^9.2.0"
   },
-  "gitHead": "6e8c899dc65918f97e3c0acb2076122c4b2ef274"
+  "gitHead": "b668e9b1a975227fbe34beb70d1cd5b03dce2348"
 }

package/src/vaadin-select-overlay.js

@@ -4,8 +4,8 @@
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
 import { OverlayElement } from '@vaadin/vaadin-overlay/src/vaadin-overlay.js';
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
 import { PositionMixin } from '@vaadin/vaadin-overlay/src/vaadin-overlay-position-mixin.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 registerStyles(
   'vaadin-select-overlay',

package/src/vaadin-select-value-button.js

@@ -4,7 +4,7 @@
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
 import { Button } from '@vaadin/button/src/vaadin-button.js';
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 registerStyles(
   'vaadin-select-value-button',

package/src/vaadin-select.d.ts

@@ -92,23 +92,25 @@ export interface SelectEventMap extends HTMLElementEventMap, SelectCustomEventMa
  * `--vaadin-field-default-width`     | Default width of the field   | :host                   | `12em`
  * `--vaadin-select-text-field-width` | Effective width of the field | `vaadin-select-overlay` |
  *
- * The following shadow DOM parts are available for styling:
+ * `<vaadin-select>` provides mostly the same set of shadow DOM parts and state attributes as `<vaadin-text-field>`.
+ * See [`<vaadin-text-field>`](#/elements/vaadin-text-field) for the styling documentation.
  *
- * Part name | Description
+ *
+ * In addition to `<vaadin-text-field>` parts, the following parts are available for theming:
+ *
+ * Part name       | Description
  * ----------------|----------------
  * `toggle-button` | The toggle button
  *
- * The following state attributes are available for styling:
+ * In addition to `<vaadin-text-field>` state attributes, the following state attributes are available for theming:
  *
- * Attribute    | Description | Part name
- * -------------|-------------|------------
- * `opened` | Set when the select is open | :host
- * `invalid` | Set when the element is invalid | :host
- * `focused` | Set when the element is focused | :host
- * `focus-ring` | Set when the element is keyboard focused | :host
- * `readonly` | Set when the select is read only | :host
+ * Attribute | Description                 | Part name
+ * ----------|-----------------------------|-----------
+ * `opened`  | Set when the select is open | :host
  *
- * See [Styling Components](https://vaadin.com/docs/latest/ds/customization/styling-components) documentation.
+ * There are two exceptions in terms of styling compared to `<vaadin-text-field>`:
+ * - the `clear-button` shadow DOM part does not exist in `<vaadin-select>`.
+ * - the `input-prevented` state attribute is not supported by `<vaadin-select>`.
  *
  * ### Internal components
  *
@@ -116,10 +118,14 @@ export interface SelectEventMap extends HTMLElementEventMap, SelectCustomEventMa
  * components are themable:
  *
  * - `<vaadin-select-overlay>` - has the same API as [`<vaadin-overlay>`](#/elements/vaadin-overlay).
+ * - `<vaadin-select-value-button>` - has the same API as [`<vaadin-button>`](#/elements/vaadin-button).
+ * - [`<vaadin-input-container>`](#/elements/vaadin-input-container) - an internal element wrapping the button.
  *
  * Note: the `theme` attribute value set on `<vaadin-select>` is
  * propagated to the internal components listed above.
  *
+ * See [Styling Components](https://vaadin.com/docs/latest/ds/customization/styling-components) documentation.
+ *
  * @fires {Event} change - Fired when the user commits a value change.
  * @fires {CustomEvent} invalid-changed - Fired when the `invalid` property changes.
  * @fires {CustomEvent} opened-changed - Fired when the `opened` property changes.

package/src/vaadin-select.js

@@ -3,8 +3,11 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
-import { PolymerElement, html } from '@polymer/polymer/polymer-element.js';
 import '@polymer/iron-media-query/iron-media-query.js';
+import '@vaadin/input-container/src/vaadin-input-container.js';
+import './vaadin-select-overlay.js';
+import './vaadin-select-value-button.js';
+import { html, PolymerElement } from '@polymer/polymer/polymer-element.js';
 import { ElementMixin } from '@vaadin/component-base/src/element-mixin.js';
 import { SlotMixin } from '@vaadin/component-base/src/slot-mixin.js';
 import { processTemplates } from '@vaadin/component-base/src/templates.js';
@@ -12,11 +15,7 @@ import { DelegateFocusMixin } from '@vaadin/field-base/src/delegate-focus-mixin.
 import { FieldMixin } from '@vaadin/field-base/src/field-mixin.js';
 import { fieldShared } from '@vaadin/field-base/src/styles/field-shared-styles.js';
 import { inputFieldContainer } from '@vaadin/field-base/src/styles/input-field-container-styles.js';
-import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
-import { registerStyles } from '@vaadin/vaadin-themable-mixin/register-styles.js';
-import '@vaadin/input-container/src/vaadin-input-container.js';
-import './vaadin-select-overlay.js';
-import './vaadin-select-value-button.js';
+import { registerStyles, ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 registerStyles('vaadin-select', [fieldShared, inputFieldContainer], { moduleId: 'vaadin-select-styles' });
 
@@ -68,23 +67,25 @@ registerStyles('vaadin-select', [fieldShared, inputFieldContainer], { moduleId:
  * `--vaadin-field-default-width`     | Default width of the field   | :host                   | `12em`
  * `--vaadin-select-text-field-width` | Effective width of the field | `vaadin-select-overlay` |
  *
- * The following shadow DOM parts are available for styling:
+ * `<vaadin-select>` provides mostly the same set of shadow DOM parts and state attributes as `<vaadin-text-field>`.
+ * See [`<vaadin-text-field>`](#/elements/vaadin-text-field) for the styling documentation.
+ *
  *
- * Part name | Description
+ * In addition to `<vaadin-text-field>` parts, the following parts are available for theming:
+ *
+ * Part name       | Description
  * ----------------|----------------
  * `toggle-button` | The toggle button
  *
- * The following state attributes are available for styling:
+ * In addition to `<vaadin-text-field>` state attributes, the following state attributes are available for theming:
  *
- * Attribute    | Description | Part name
- * -------------|-------------|------------
- * `opened`     | Set when the select is open | :host
- * `invalid`    | Set when the element is invalid | :host
- * `focused`    | Set when the element is focused | :host
- * `focus-ring` | Set when the element is keyboard focused | :host
- * `readonly`   | Set when the select is read only | :host
+ * Attribute | Description                 | Part name
+ * ----------|-----------------------------|-----------
+ * `opened`  | Set when the select is open | :host
  *
- * See [Styling Components](https://vaadin.com/docs/latest/ds/customization/styling-components) documentation.
+ * There are two exceptions in terms of styling compared to `<vaadin-text-field>`:
+ * - the `clear-button` shadow DOM part does not exist in `<vaadin-select>`.
+ * - the `input-prevented` state attribute is not supported by `<vaadin-select>`.
  *
  * ### Internal components
  *
@@ -92,10 +93,14 @@ registerStyles('vaadin-select', [fieldShared, inputFieldContainer], { moduleId:
  * components are themable:
  *
  * - `<vaadin-select-overlay>` - has the same API as [`<vaadin-overlay>`](#/elements/vaadin-overlay).
+ * - `<vaadin-select-value-button>` - has the same API as [`<vaadin-button>`](#/elements/vaadin-button).
+ * - [`<vaadin-input-container>`](#/elements/vaadin-input-container) - an internal element wrapping the button.
  *
  * Note: the `theme` attribute value set on `<vaadin-select>` is
  * propagated to the internal components listed above.
  *
+ * See [Styling Components](https://vaadin.com/docs/latest/ds/customization/styling-components) documentation.
+ *
  * @fires {Event} change - Fired when the user commits a value change.
  * @fires {CustomEvent} invalid-changed - Fired when the `invalid` property changes.
  * @fires {CustomEvent} opened-changed - Fired when the `opened` property changes.
@@ -123,7 +128,7 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
       </style>
 
       <div class="vaadin-select-container">
-        <div part="label">
+        <div part="label" on-click="_onClick">
           <slot name="label"></slot>
           <span part="required-indicator" aria-hidden="true" on-click="focus"></span>
         </div>
@@ -338,8 +343,15 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
    * It is not guaranteed that the update happens immediately (synchronously) after it is requested.
    */
   requestContentUpdate() {
+    if (!this._overlayElement) {
+      return;
+    }
+
     this._overlayElement.requestContentUpdate();
 
+    // Ensure menu element is set
+    this._assignMenuElement();
+
     if (this._menuElement && this._menuElement.items) {
       this._updateSelectedItem(this.value, this._menuElement.items);
     }
@@ -362,18 +374,19 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
 
   /** @private */
   _assignMenuElement() {
-    this._menuElement = Array.from(this._overlayElement.content.children).find(
-      (element) => element.localName !== 'style'
-    );
+    const menuElement = this.__getMenuElement();
 
-    if (this._menuElement) {
-      this._menuElement.addEventListener('items-changed', () => {
-        this._items = this._menuElement.items;
+    if (menuElement && menuElement !== this.__lastMenuElement) {
+      this._menuElement = menuElement;
+      menuElement.addEventListener('items-changed', () => {
+        this._items = menuElement.items;
         this._items.forEach((item) => item.setAttribute('role', 'option'));
       });
-      this._menuElement.addEventListener('selected-changed', () => this.__updateValueButton());
-      this._menuElement.addEventListener('keydown', (e) => this._onKeyDownInside(e));
-      this._menuElement.addEventListener(
+      menuElement.addEventListener('selected-changed', () => this.__updateValueButton());
+      // Use capture phase to make it possible for `<vaadin-grid-pro-edit-select>`
+      // to override and handle the keydown event before the value change happens.
+      menuElement.addEventListener('keydown', (e) => this._onKeyDownInside(e), true);
+      menuElement.addEventListener(
         'click',
         () => {
           this.__userInteraction = true;
@@ -382,10 +395,19 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
         true
       );
 
-      this._menuElement.setAttribute('role', 'listbox');
+      menuElement.setAttribute('role', 'listbox');
+
+      // Store the menu element reference
+      this.__lastMenuElement = menuElement;
     }
   }
 
+  /** @private */
+  __getMenuElement() {
+    const content = this._overlayElement && this._overlayElement.content;
+    return content ? Array.from(content.children).find((el) => el.localName !== 'style') : null;
+  }
+
   /** @private */
   _valueChanged(value, oldValue) {
     this.toggleAttribute('has-value', Boolean(value));
@@ -397,12 +419,13 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
     this.validate();
   }
 
-  /** @private */
-  _onClick(e) {
-    const isHelperClick = Array.from(e.composedPath()).some((node) => {
-      return node.nodeType === Node.ELEMENT_NODE && node.getAttribute('slot') === 'helper';
-    });
-    this.opened = !this.readonly && !isHelperClick;
+  /**
+   * Opens the overlay if the field is not read-only.
+   *
+   * @private
+   */
+  _onClick() {
+    this.opened = !this.readonly;
   }
 
   /**
@@ -414,13 +437,16 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
       if (/^(Enter|SpaceBar|\s|ArrowDown|Down|ArrowUp|Up)$/.test(e.key)) {
         e.preventDefault();
         this.opened = true;
-      } else if (/[a-zA-Z0-9]/.test(e.key) && e.key.length === 1) {
+      } else if (/[\p{L}\p{Nd}]/u.test(e.key) && e.key.length === 1) {
         const selected = this._menuElement.selected;
         const currentIdx = selected !== undefined ? selected : -1;
         const newIdx = this._menuElement._searchKey(currentIdx, e.key);
         if (newIdx >= 0) {
           this.__userInteraction = true;
-          this._updateSelectedItem(this._items[newIdx].value, this._items);
+
+          // Announce the value selected with the first letter shortcut
+          this._updateAriaLive(true);
+          this._menuElement.selected = newIdx;
         }
       }
     }
@@ -439,6 +465,9 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
   /** @private */
   _openedChanged(opened, wasOpened) {
     if (opened) {
+      // Avoid multiple announcements when a value gets selected from the dropdown
+      this._updateAriaLive(false);
+
       if (!this._overlayElement || !this._menuElement || !this.focusElement || this.disabled || this.readonly) {
         this.opened = false;
         return;
@@ -460,13 +489,9 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
 
       this._menuElement.focus();
     } else if (wasOpened) {
-      if (this._phone) {
-        this._setFocused(false);
-      } else {
-        this.focus();
-        if (this._openedWithFocusRing) {
-          this.setAttribute('focus-ring', '');
-        }
+      this.focus();
+      if (this._openedWithFocusRing) {
+        this.setAttribute('focus-ring', '');
       }
       this.validate();
     }
@@ -486,6 +511,17 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
     }
   }
 
+  /** @private */
+  _updateAriaLive(ariaLive) {
+    if (this._valueButton) {
+      if (ariaLive) {
+        this._valueButton.setAttribute('aria-live', 'polite');
+      } else {
+        this._valueButton.removeAttribute('aria-live');
+      }
+    }
+  }
+
   /** @private */
   __attachSelectedItem(selected) {
     let labelItem;
@@ -532,10 +568,13 @@ class Select extends DelegateFocusMixin(FieldMixin(SlotMixin(ElementMixin(Themab
 
     const selected = this._items[this._menuElement.selected];
 
+    this._valueButton.removeAttribute('placeholder');
+
     if (!selected) {
       if (this.placeholder) {
         const item = this.__createItem(this.placeholder);
         this.__appendItem(item);
+        this._valueButton.setAttribute('placeholder', '');
       }
     } else {
       this.__attachSelectedItem(selected);

package/theme/lumo/vaadin-select-styles.js

@@ -3,33 +3,37 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
 import '@vaadin/vaadin-lumo-styles/sizing.js';
 import '@vaadin/vaadin-lumo-styles/style.js';
 import '@vaadin/vaadin-lumo-styles/font-icons.js';
-import { menuOverlay } from '@vaadin/vaadin-lumo-styles/mixins/menu-overlay.js';
 import { inputFieldShared } from '@vaadin/vaadin-lumo-styles/mixins/input-field-shared.js';
+import { menuOverlay } from '@vaadin/vaadin-lumo-styles/mixins/menu-overlay.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 const select = css`
   :host(:not([theme*='align'])) ::slotted([slot='value']) {
     text-align: start;
   }
 
+  [part='input-field'] {
+    cursor: var(--lumo-clickable-cursor);
+  }
+
   [part='input-field'] ::slotted([slot='value']) {
     font-weight: 500;
   }
 
+  [part='input-field'] ::slotted([slot='value']:not([placeholder])) {
+    color: var(--lumo-body-text-color);
+  }
+
   /* placeholder styles */
-  :host(:not([has-value])) [part='input-field'] ::slotted([slot='value']) {
+  [part='input-field'] ::slotted([slot='value'][placeholder]) {
     color: inherit;
     transition: opacity 0.175s 0.1s;
     opacity: 0.5;
   }
 
-  :host([has-value]) [part='input-field'] ::slotted([slot='value']) {
-    color: var(--lumo-body-text-color);
-  }
-
   [part='toggle-button']::before {
     content: var(--lumo-icons-dropdown);
   }
@@ -62,6 +66,10 @@ registerStyles(
     :host([focus-ring]) {
       box-shadow: none;
     }
+
+    ::slotted(vaadin-item:hover) {
+      background-color: transparent;
+    }
   `,
   { moduleId: 'lumo-select-value-button' }
 );

package/theme/material/vaadin-select-styles.js

@@ -3,10 +3,10 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
 import '@vaadin/vaadin-material-styles/font-icons.js';
-import { menuOverlay } from '@vaadin/vaadin-material-styles/mixins/menu-overlay.js';
 import { inputFieldShared } from '@vaadin/vaadin-material-styles/mixins/input-field-shared.js';
+import { menuOverlay } from '@vaadin/vaadin-material-styles/mixins/menu-overlay.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 const select = css`
   :host {
@@ -15,13 +15,13 @@ const select = css`
   }
 
   /* placeholder styles */
-  :host(:not([has-value])) [part='input-field'] ::slotted([slot='value']) {
+  :host [part='input-field'] ::slotted([slot='value'][placeholder]) {
     color: var(--material-disabled-text-color);
     transition: opacity 0.175s 0.1s;
     opacity: 1;
   }
 
-  :host([has-value]) [part='input-field'] ::slotted([slot='value']) {
+  :host [part='input-field'] ::slotted([slot='value']) {
     color: var(--material-body-text-color);
   }
 
@@ -53,6 +53,15 @@ registerStyles(
     :host::after {
       display: none;
     }
+
+    ::slotted(vaadin-item) {
+      font: inherit;
+      padding: 4px 0;
+    }
+
+    ::slotted(vaadin-item:hover) {
+      background-color: transparent;
+    }
   `,
   { moduleId: 'material-select-value-button' }
 );