@vaadin/rich-text-editor 24.1.6 → 24.1.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/rich-text-editor",
-  "version": "24.1.6",
+  "version": "24.1.8",
   "publishConfig": {
     "access": "public"
   },
@@ -40,18 +40,18 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/button": "~24.1.6",
-    "@vaadin/component-base": "~24.1.6",
-    "@vaadin/confirm-dialog": "~24.1.6",
-    "@vaadin/text-field": "~24.1.6",
-    "@vaadin/tooltip": "~24.1.6",
-    "@vaadin/vaadin-lumo-styles": "~24.1.6",
-    "@vaadin/vaadin-material-styles": "~24.1.6",
-    "@vaadin/vaadin-themable-mixin": "~24.1.6"
+    "@vaadin/button": "~24.1.8",
+    "@vaadin/component-base": "~24.1.8",
+    "@vaadin/confirm-dialog": "~24.1.8",
+    "@vaadin/text-field": "~24.1.8",
+    "@vaadin/tooltip": "~24.1.8",
+    "@vaadin/vaadin-lumo-styles": "~24.1.8",
+    "@vaadin/vaadin-material-styles": "~24.1.8",
+    "@vaadin/vaadin-themable-mixin": "~24.1.8"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/a11y-base": "~24.1.6",
+    "@vaadin/a11y-base": "~24.1.8",
     "@vaadin/testing-helpers": "^0.4.2",
     "gulp": "^4.0.2",
     "gulp-cli": "^2.3.0",
@@ -63,5 +63,5 @@
     "web-types.json",
     "web-types.lit.json"
   ],
-  "gitHead": "b43b09ece1efbaf1e6eee32166fcd9e8effa038e"
+  "gitHead": "7dd501f5c346495cb34bc34e06e186bbcde2aa49"
 }

package/src/vaadin-rich-text-editor.js

@@ -159,7 +159,7 @@ class RichTextEditor extends ElementMixin(ThemableMixin(PolymerElement)) {
 
       <div class="vaadin-rich-text-editor-container">
         <!-- Create toolbar container -->
-        <div part="toolbar">
+        <div part="toolbar" role="toolbar">
           <span part="toolbar-group toolbar-group-history">
             <!-- Undo and Redo -->
             <button id="btn-undo" type="button" part="toolbar-button toolbar-button-undo" on-click="_undo"></button>
@@ -533,6 +533,13 @@ class RichTextEditor extends ElementMixin(ThemableMixin(PolymerElement)) {
     }
   }
 
+  /** @protected */
+  disconnectedCallback() {
+    super.disconnectedCallback();
+    this._editor.emitter.removeAllListeners();
+    this._editor.emitter.listeners = {};
+  }
+
   /** @private */
   __setDirection(dir) {
     // Needed for proper `ql-align` class to be set and activate the toolbar align button
@@ -554,18 +561,14 @@ class RichTextEditor extends ElementMixin(ThemableMixin(PolymerElement)) {
   }
 
   /** @protected */
-  ready() {
-    super.ready();
+  connectedCallback() {
+    super.connectedCallback();
 
     const editor = this.shadowRoot.querySelector('[part="content"]');
-    const toolbarConfig = this._prepareToolbar();
-    this._toolbar = toolbarConfig.container;
-
-    this._addToolbarListeners();
 
     this._editor = new Quill(editor, {
       modules: {
-        toolbar: toolbarConfig,
+        toolbar: this._toolbarConfig,
       },
     });
 
@@ -577,10 +580,6 @@ class RichTextEditor extends ElementMixin(ThemableMixin(PolymerElement)) {
       this.__patchFirefoxFocus();
     }
 
-    this.$.linkDialog.$.dialog.$.overlay.addEventListener('vaadin-overlay-open', () => {
-      this.$.linkUrl.focus();
-    });
-
     const editorContent = editor.querySelector('.ql-editor');
 
     editorContent.setAttribute('role', 'textbox');
@@ -632,6 +631,20 @@ class RichTextEditor extends ElementMixin(ThemableMixin(PolymerElement)) {
     this._editor.on('selection-change', this.__announceFormatting.bind(this));
   }
 
+  /** @protected */
+  ready() {
+    super.ready();
+
+    this._toolbarConfig = this._prepareToolbar();
+    this._toolbar = this._toolbarConfig.container;
+
+    this._addToolbarListeners();
+
+    this.$.linkDialog.$.dialog.$.overlay.addEventListener('vaadin-overlay-open', () => {
+      this.$.linkUrl.focus();
+    });
+  }
+
   /** @private */
   _prepareToolbar() {
     const clean = Quill.imports['modules/toolbar'].DEFAULTS.handlers.clean;
@@ -935,6 +948,8 @@ class RichTextEditor extends ElementMixin(ThemableMixin(PolymerElement)) {
 
     // Remove Quill classes, e.g. ql-syntax, except for align
     content = content.replace(/\s*ql-(?!align)[\w-]*\s*/gu, '');
+    // Remove meta spans, e.g. cursor which are empty after Quill classes removed
+    content = content.replace(/<\/?span[^>]*>/gu, '');
 
     // Replace Quill align classes with inline styles
     [this.__dir === 'rtl' ? 'left' : 'right', 'center', 'justify'].forEach((align) => {

package/web-types.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/rich-text-editor",
-  "version": "24.1.6",
+  "version": "24.1.8",
   "description-markup": "markdown",
   "contributions": {
     "html": {

package/web-types.lit.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/rich-text-editor",
-  "version": "24.1.6",
+  "version": "24.1.8",
   "description-markup": "markdown",
   "framework": "lit",
   "framework-config": {