@vaadin/password-field 22.0.0-alpha9 → 22.0.0

package/README.md

@@ -1,8 +1,11 @@
 # @vaadin/password-field
 
-An extension of `vaadin-text-field` component for entering passwords.
+An extension of [`<vaadin-text-field>`](https://www.npmjs.com/package/@vaadin/text-field) component for entering passwords.
 
-[Live Demo ↗](https://vaadin.com/docs/latest/ds/components/password-field)
+[Documentation + Live Demo ↗](https://vaadin.com/docs/latest/ds/components/password-field)
+
+[![npm version](https://badgen.net/npm/v/@vaadin/password-field)](https://www.npmjs.com/package/@vaadin/password-field)
+[![Discord](https://img.shields.io/discord/732335336448852018?label=discord)](https://discord.gg/PHmkCKC)
 
 ```html
 <vaadin-password-field label="Password"></vaadin-password-field>
@@ -13,7 +16,7 @@ An extension of `vaadin-text-field` component for entering passwords.
 Install the component:
 
 ```sh
-npm i @vaadin/password-field --save
+npm i @vaadin/password-field
 ```
 
 Once installed, import the component in your application:
@@ -24,9 +27,8 @@ import '@vaadin/password-field';
 
 ## Themes
 
-Vaadin components come with two built-in [themes](https://vaadin.com/docs/latest/ds/customization/using-themes),
-Lumo and Material. The [main entrypoint](https://github.com/vaadin/web-components/blob/master/packages/password-field/vaadin-password-field.js)
-of the package uses Lumo theme.
+Vaadin components come with two built-in [themes](https://vaadin.com/docs/latest/ds/customization/using-themes), Lumo and Material.
+The [main entrypoint](https://github.com/vaadin/web-components/blob/master/packages/password-field/vaadin-password-field.js) of the package uses Lumo theme.
 
 To use the Material theme, import the component from the `theme/material` folder:
 
@@ -46,9 +48,13 @@ Finally, you can import the un-themed component from the `src` folder to get a m
 import '@vaadin/password-field/src/vaadin-password-field.js';
 ```
 
+## Contributing
+
+Read the [contributing guide](https://vaadin.com/docs/latest/guide/contributing/overview) to learn about our development process, how to propose bugfixes and improvements, and how to test your changes to Vaadin components.
+
 ## License
 
 Apache License 2.0
 
-Vaadin collects development time usage statistics to improve this product.
+Vaadin collects usage statistics at development time to improve this product.
 For details and to opt-out, see https://github.com/vaadin/vaadin-usage-statistics.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/password-field",
-  "version": "22.0.0-alpha9",
+  "version": "22.0.0",
   "publishConfig": {
     "access": "public"
   },
@@ -32,14 +32,14 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/text-field": "22.0.0-alpha9",
-    "@vaadin/vaadin-lumo-styles": "22.0.0-alpha9",
-    "@vaadin/vaadin-material-styles": "22.0.0-alpha9"
+    "@vaadin/text-field": "^22.0.0",
+    "@vaadin/vaadin-lumo-styles": "^22.0.0",
+    "@vaadin/vaadin-material-styles": "^22.0.0"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/testing-helpers": "^0.3.0",
+    "@vaadin/testing-helpers": "^0.3.2",
     "sinon": "^9.2.1"
   },
-  "gitHead": "6e8c899dc65918f97e3c0acb2076122c4b2ef274"
+  "gitHead": "b668e9b1a975227fbe34beb70d1cd5b03dce2348"
 }

package/src/vaadin-password-field.d.ts

@@ -3,6 +3,7 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
+import { SlotStylesMixin } from '@vaadin/field-base/src/slot-styles-mixin.js';
 import { TextField } from '@vaadin/text-field/src/vaadin-text-field.js';
 
 /**
@@ -32,19 +33,20 @@ export interface PasswordFieldEventMap extends HTMLElementEventMap, PasswordFiel
  *
  * ### Styling
  *
+ * `<vaadin-password-field>` provides the same set of shadow DOM parts and state attributes as `<vaadin-text-field>`.
  * See [`<vaadin-text-field>`](#/elements/vaadin-text-field) for the styling documentation.
  *
- * In addition to `<vaadin-text-field>` parts, here's the list of `<vaadin-password-field>` specific parts:
+ * In addition to `<vaadin-text-field>` parts, the following parts are available for theming:
  *
  * Part name       | Description
  * ----------------|----------------------------------------------------
  * `reveal-button` | The eye icon which toggles the password visibility
  *
- * In addition to `<vaadin-text-field>` state attributes, here's the list of `<vaadin-password-field>` specific attributes:
+ * In addition to `<vaadin-text-field>` state attributes, the following state attributes are available for theming:
  *
- * Attribute          | Description | Part name
- * -------------------|-------------|------------
- * `password-visible` | Set when the password is visible | :host
+ * Attribute          | Description
+ * -------------------|---------------------------------
+ * `password-visible` | Set when the password is visible
  *
  * See [Styling Components](https://vaadin.com/docs/latest/ds/customization/styling-components) documentation.
  *
@@ -53,7 +55,7 @@ export interface PasswordFieldEventMap extends HTMLElementEventMap, PasswordFiel
  * @fires {CustomEvent} invalid-changed - Fired when the `invalid` property changes.
  * @fires {CustomEvent} value-changed - Fired when the `value` property changes.
  */
-declare class PasswordField extends TextField {
+declare class PasswordField extends SlotStylesMixin(TextField) {
   /**
    * Set to true to hide the eye icon which toggles the password visibility.
    * @attr {boolean} reveal-button-hidden

package/src/vaadin-password-field.js

@@ -4,6 +4,7 @@
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
 import { html } from '@polymer/polymer/lib/utils/html-tag.js';
+import { SlotStylesMixin } from '@vaadin/field-base/src/slot-styles-mixin.js';
 import { TextField } from '@vaadin/text-field/src/vaadin-text-field.js';
 
 const ownTemplate = html`
@@ -23,19 +24,20 @@ let memoizedTemplate;
  *
  * ### Styling
  *
+ * `<vaadin-password-field>` provides the same set of shadow DOM parts and state attributes as `<vaadin-text-field>`.
  * See [`<vaadin-text-field>`](#/elements/vaadin-text-field) for the styling documentation.
  *
- * In addition to `<vaadin-text-field>` parts, here's the list of `<vaadin-password-field>` specific parts:
+ * In addition to `<vaadin-text-field>` parts, the following parts are available for theming:
  *
  * Part name       | Description
  * ----------------|----------------------------------------------------
  * `reveal-button` | The eye icon which toggles the password visibility
  *
- * In addition to `<vaadin-text-field>` state attributes, here's the list of `<vaadin-password-field>` specific attributes:
+ * In addition to `<vaadin-text-field>` state attributes, the following state attributes are available for theming:
  *
- * Attribute          | Description | Part name
- * -------------------|-------------|------------
- * `password-visible` | Set when the password is visible | :host
+ * Attribute          | Description
+ * -------------------|---------------------------------
+ * `password-visible` | Set when the password is visible
  *
  * See [Styling Components](https://vaadin.com/docs/latest/ds/customization/styling-components) documentation.
  *
@@ -45,8 +47,9 @@ let memoizedTemplate;
  * @fires {CustomEvent} value-changed - Fired when the `value` property changes.
  *
  * @extends TextField
+ * @mixes SlotStylesMixin
  */
-export class PasswordField extends TextField {
+export class PasswordField extends SlotStylesMixin(TextField) {
   static get is() {
     return 'vaadin-password-field';
   }
@@ -124,12 +127,24 @@ export class PasswordField extends TextField {
       reveal: () => {
         const btn = document.createElement('button');
         btn.setAttribute('type', 'button');
-        btn.setAttribute('tabindex', '0');
+        btn.disabled = this.disabled;
         return btn;
       }
     };
   }
 
+  /** @protected */
+  get slotStyles() {
+    const tag = this.localName;
+    return [
+      `
+        ${tag} [slot="input"]::-ms-reveal {
+          display: none;
+        }
+      `
+    ];
+  }
+
   /** @protected */
   get _revealNode() {
     return this._getDirectSlotChild('reveal');
@@ -203,7 +218,12 @@ export class PasswordField extends TextField {
     );
   }
 
-  /** @protected */
+  /**
+   * Override method inherited from `FocusMixin` to toggle password visibility.
+   * @param {boolean} focused
+   * @protected
+   * @override
+   */
   _setFocused(focused) {
     super._setFocused(focused);
 
@@ -212,7 +232,7 @@ export class PasswordField extends TextField {
     } else {
       const isButtonFocused = this.getRootNode().activeElement === this._revealNode;
       // Remove focus-ring from the field when the reveal button gets focused
-      this.toggleAttribute('focus-ring', !isButtonFocused);
+      this.toggleAttribute('focus-ring', this._keyboardActive && !isButtonFocused);
     }
   }
 
@@ -281,6 +301,20 @@ export class PasswordField extends TextField {
 
     this._updateToggleState(passwordVisible);
   }
+
+  /**
+   * Override method inherited from `DisabledMixin` to synchronize the reveal button
+   * disabled state with the password field disabled state.
+   * @param {boolean} disabled
+   * @protected
+   */
+  _disabledChanged(disabled) {
+    super._disabledChanged(disabled);
+
+    if (this._revealNode) {
+      this._revealNode.disabled = disabled;
+    }
+  }
 }
 
 customElements.define(PasswordField.is, PasswordField);

package/theme/lumo/vaadin-password-field-styles.js

@@ -3,11 +3,11 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
 import '@vaadin/vaadin-lumo-styles/font-icons.js';
 import '@vaadin/vaadin-lumo-styles/sizing.js';
 import '@vaadin/vaadin-lumo-styles/style.js';
 import { inputFieldShared } from '@vaadin/vaadin-lumo-styles/mixins/input-field-shared.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 const passwordField = css`
   [part='reveal-button']::before {

package/theme/material/vaadin-password-field-styles.js

@@ -3,10 +3,10 @@
  * Copyright (c) 2021 Vaadin Ltd.
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
-import { registerStyles, css } from '@vaadin/vaadin-themable-mixin/register-styles.js';
 import '@vaadin/vaadin-material-styles/color.js';
 import '@vaadin/vaadin-material-styles/font-icons.js';
 import { inputFieldShared } from '@vaadin/vaadin-material-styles/mixins/input-field-shared.js';
+import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 const passwordField = css`
   [part='reveal-button']::before {