@vaadin/number-field 22.0.0-rc1 → 23.0.0-alpha2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/number-field",
-  "version": "22.0.0-rc1",
+  "version": "23.0.0-alpha2",
   "publishConfig": {
     "access": "public"
   },
@@ -32,17 +32,17 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "22.0.0-rc1",
-    "@vaadin/field-base": "22.0.0-rc1",
-    "@vaadin/input-container": "22.0.0-rc1",
-    "@vaadin/vaadin-lumo-styles": "22.0.0-rc1",
-    "@vaadin/vaadin-material-styles": "22.0.0-rc1",
-    "@vaadin/vaadin-themable-mixin": "22.0.0-rc1"
+    "@vaadin/component-base": "23.0.0-alpha2",
+    "@vaadin/field-base": "23.0.0-alpha2",
+    "@vaadin/input-container": "23.0.0-alpha2",
+    "@vaadin/vaadin-lumo-styles": "23.0.0-alpha2",
+    "@vaadin/vaadin-material-styles": "23.0.0-alpha2",
+    "@vaadin/vaadin-themable-mixin": "23.0.0-alpha2"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
     "@vaadin/testing-helpers": "^0.3.2",
     "sinon": "^9.2.1"
   },
-  "gitHead": "7b6f44bcd2c0fd415028ace666feeb0fedb1d540"
+  "gitHead": "070f586dead02ca41b66717820c647f48bf1665f"
 }

package/src/vaadin-number-field.d.ts

@@ -8,6 +8,13 @@ import { InputFieldMixin } from '@vaadin/field-base/src/input-field-mixin.js';
 import { SlotStylesMixin } from '@vaadin/field-base/src/slot-styles-mixin.js';
 import { ThemableMixin } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
+/**
+ * Fired when the user commits a value change.
+ */
+export type NumberFieldChangeEvent = Event & {
+  target: NumberField;
+};
+
 /**
  * Fired when the `invalid` property changes.
  */
@@ -24,7 +31,9 @@ export interface NumberFieldCustomEventMap {
   'value-changed': NumberFieldValueChangedEvent;
 }
 
-export interface NumberFieldEventMap extends HTMLElementEventMap, NumberFieldCustomEventMap {}
+export interface NumberFieldEventMap extends HTMLElementEventMap, NumberFieldCustomEventMap {
+  change: NumberFieldChangeEvent;
+}
 
 /**
  * `<vaadin-number-field>` is an input field web component that only accepts numeric input.

package/src/vaadin-number-field.js

@@ -301,13 +301,11 @@ export class NumberField extends InputFieldMixin(SlotStylesMixin(ThemableMixin(E
         value = this.max;
         if (incr < 0) {
           incr = 0;
-        } else {
+        } else if (this._getIncrement(1, value - this.step) > this.max) {
+          value -= 2 * this.step;
           // FIXME(yuriy): find a proper solution to make correct step back
-          if (this._getIncrement(1, value - this.step) > this.max) {
-            value -= 2 * this.step;
-          } else {
-            value -= this.step;
-          }
+        } else {
+          value -= this.step;
         }
       }
     } else if (value < this.min) {
@@ -348,9 +346,8 @@ export class NumberField extends InputFieldMixin(SlotStylesMixin(ThemableMixin(E
       return (currentValue - margin + step) / multiplier;
     } else if (incr < 0) {
       return (currentValue - (margin || step)) / multiplier;
-    } else {
-      return currentValue / multiplier;
     }
+    return currentValue / multiplier;
   }
 
   /** @private */
@@ -363,7 +360,7 @@ export class NumberField extends InputFieldMixin(SlotStylesMixin(ThemableMixin(E
   /** @private */
   _getMultiplier(number) {
     if (!isNaN(number)) {
-      return Math.pow(10, this._getDecimalCount(number));
+      return 10 ** this._getDecimalCount(number);
     }
   }
 
@@ -373,9 +370,8 @@ export class NumberField extends InputFieldMixin(SlotStylesMixin(ThemableMixin(E
       return this.min == null || this._getIncrement(incr, value) >= this.min;
     } else if (incr > 0) {
       return this.max == null || this._getIncrement(incr, value) <= this.max;
-    } else {
-      return this._getIncrement(incr, value) <= this.max && this._getIncrement(incr, value) >= this.min;
     }
+    return this._getIncrement(incr, value) <= this.max && this._getIncrement(incr, value) >= this.min;
   }
 
   /** @private */
@@ -470,9 +466,8 @@ export class NumberField extends InputFieldMixin(SlotStylesMixin(ThemableMixin(E
       (this.required || this.min !== undefined || this.max !== undefined || this.__validateByStep)
     ) {
       return this.inputElement.checkValidity();
-    } else {
-      return !this.invalid;
     }
+    return !this.invalid;
   }
 }