@vaadin/multi-select-combo-box 24.3.1 → 24.4.0-alpha1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/multi-select-combo-box",
-  "version": "24.3.1",
+  "version": "24.4.0-alpha1",
   "publishConfig": {
     "access": "public"
   },
@@ -37,17 +37,17 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/a11y-base": "~24.3.1",
-    "@vaadin/combo-box": "~24.3.1",
-    "@vaadin/component-base": "~24.3.1",
-    "@vaadin/field-base": "~24.3.1",
-    "@vaadin/input-container": "~24.3.1",
-    "@vaadin/item": "~24.3.1",
-    "@vaadin/lit-renderer": "~24.3.1",
-    "@vaadin/overlay": "~24.3.1",
-    "@vaadin/vaadin-lumo-styles": "~24.3.1",
-    "@vaadin/vaadin-material-styles": "~24.3.1",
-    "@vaadin/vaadin-themable-mixin": "~24.3.1"
+    "@vaadin/a11y-base": "24.4.0-alpha1",
+    "@vaadin/combo-box": "24.4.0-alpha1",
+    "@vaadin/component-base": "24.4.0-alpha1",
+    "@vaadin/field-base": "24.4.0-alpha1",
+    "@vaadin/input-container": "24.4.0-alpha1",
+    "@vaadin/item": "24.4.0-alpha1",
+    "@vaadin/lit-renderer": "24.4.0-alpha1",
+    "@vaadin/overlay": "24.4.0-alpha1",
+    "@vaadin/vaadin-lumo-styles": "24.4.0-alpha1",
+    "@vaadin/vaadin-material-styles": "24.4.0-alpha1",
+    "@vaadin/vaadin-themable-mixin": "24.4.0-alpha1"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
@@ -59,5 +59,5 @@
     "web-types.json",
     "web-types.lit.json"
   ],
-  "gitHead": "b81b3535adec8e4371ceb5d1ba5b12fa2a2abf22"
+  "gitHead": "3e2ed41c99d618ff7def2734fd863c21c85775a3"
 }

package/src/vaadin-multi-select-combo-box-internal.js

@@ -120,6 +120,10 @@ class MultiSelectComboBoxInternal extends ComboBoxDataProviderMixin(ComboBoxMixi
     };
   }
 
+  static get observers() {
+    return ['_readonlyChanged(readonly)'];
+  }
+
   /**
    * Reference to the clear button element.
    * @protected
@@ -157,6 +161,11 @@ class MultiSelectComboBoxInternal extends ComboBoxDataProviderMixin(ComboBoxMixi
     this._toggleElement = this.querySelector('.toggle-button');
   }
 
+  /** @private */
+  _readonlyChanged() {
+    this._setDropdownItems(this.filteredItems);
+  }
+
   /**
    * Override combo-box method to group selected
    * items at the top of the overlay.
@@ -166,12 +175,12 @@ class MultiSelectComboBoxInternal extends ComboBoxDataProviderMixin(ComboBoxMixi
    */
   _setDropdownItems(items) {
     if (this.readonly) {
-      this._dropdownItems = this.selectedItems;
+      super._setDropdownItems(this.selectedItems);
       return;
     }
 
     if (this.filter || !this.selectedItemsOnTop) {
-      this._dropdownItems = items;
+      super._setDropdownItems(items);
       return;
     }
 
@@ -181,11 +190,11 @@ class MultiSelectComboBoxInternal extends ComboBoxDataProviderMixin(ComboBoxMixi
         (item) => this._comboBox._findIndex(item, this.topGroup, this.itemIdPath) === -1,
       );
 
-      this._dropdownItems = this.topGroup.concat(filteredItems);
+      super._setDropdownItems(this.topGroup.concat(filteredItems));
       return;
     }
 
-    this._dropdownItems = items;
+    super._setDropdownItems(items);
   }
 
   /** @private */

package/src/vaadin-multi-select-combo-box.js

@@ -163,7 +163,7 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
 
         <vaadin-multi-select-combo-box-internal
           id="comboBox"
-          items="[[__effectiveItems]]"
+          items="[[items]]"
           item-id-path="[[itemIdPath]]"
           item-label-path="[[itemLabelPath]]"
           item-value-path="[[itemValuePath]]"
@@ -177,7 +177,7 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
           last-filter="{{_lastFilter}}"
           loading="{{loading}}"
           size="{{size}}"
-          filtered-items="[[__effectiveFilteredItems]]"
+          filtered-items="[[filteredItems]]"
           selected-items="[[selectedItems]]"
           selected-items-on-top="[[selectedItemsOnTop]]"
           top-group="[[_topGroup]]"
@@ -486,18 +486,6 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
         type: String,
       },
 
-      /** @private */
-      __effectiveItems: {
-        type: Array,
-        computed: '__computeEffectiveItems(items, selectedItems, readonly)',
-      },
-
-      /** @private */
-      __effectiveFilteredItems: {
-        type: Array,
-        computed: '__computeEffectiveFilteredItems(items, filteredItems, selectedItems, readonly)',
-      },
-
       /** @private */
       _overflowItems: {
         type: Array,
@@ -1266,16 +1254,6 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
     // and keep the overlay opened when clicking a chip.
     event.preventDefault();
   }
-
-  /** @private */
-  __computeEffectiveItems(items, selectedItems, readonly) {
-    return items && readonly ? selectedItems : items;
-  }
-
-  /** @private */
-  __computeEffectiveFilteredItems(items, filteredItems, selectedItems, readonly) {
-    return !items && readonly ? selectedItems : filteredItems;
-  }
 }
 
 defineCustomElement(MultiSelectComboBox);

package/web-types.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/multi-select-combo-box",
-  "version": "24.3.1",
+  "version": "24.4.0-alpha1",
   "description-markup": "markdown",
   "contributions": {
     "html": {

package/web-types.lit.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/multi-select-combo-box",
-  "version": "24.3.1",
+  "version": "24.4.0-alpha1",
   "description-markup": "markdown",
   "framework": "lit",
   "framework-config": {