@vaadin/multi-select-combo-box 23.4.0-alpha2 → 23.4.0-alpha3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/multi-select-combo-box",
-  "version": "23.4.0-alpha2",
+  "version": "23.4.0-alpha3",
   "publishConfig": {
     "access": "public"
   },
@@ -37,14 +37,14 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/combo-box": "23.4.0-alpha2",
-    "@vaadin/component-base": "23.4.0-alpha2",
-    "@vaadin/field-base": "23.4.0-alpha2",
-    "@vaadin/input-container": "23.4.0-alpha2",
-    "@vaadin/lit-renderer": "23.4.0-alpha2",
-    "@vaadin/vaadin-lumo-styles": "23.4.0-alpha2",
-    "@vaadin/vaadin-material-styles": "23.4.0-alpha2",
-    "@vaadin/vaadin-themable-mixin": "23.4.0-alpha2"
+    "@vaadin/combo-box": "23.4.0-alpha3",
+    "@vaadin/component-base": "23.4.0-alpha3",
+    "@vaadin/field-base": "23.4.0-alpha3",
+    "@vaadin/input-container": "23.4.0-alpha3",
+    "@vaadin/lit-renderer": "23.4.0-alpha3",
+    "@vaadin/vaadin-lumo-styles": "23.4.0-alpha3",
+    "@vaadin/vaadin-material-styles": "23.4.0-alpha3",
+    "@vaadin/vaadin-themable-mixin": "23.4.0-alpha3"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
@@ -56,5 +56,5 @@
     "web-types.json",
     "web-types.lit.json"
   ],
-  "gitHead": "3fa9a5d13db6baf0307f863669ab2f3f5114c6a0"
+  "gitHead": "2336e451b1971dfb2dc4b601e11d05cafdb91516"
 }

package/src/vaadin-multi-select-combo-box-chip.js

@@ -71,7 +71,7 @@ class MultiSelectComboBoxChip extends ThemableMixin(PolymerElement) {
         }
       </style>
       <div part="label">[[label]]</div>
-      <div part="remove-button" role="button" on-click="_onRemoveClick"></div>
+      <div part="remove-button" on-click="_onRemoveClick"></div>
     `;
   }
 

package/src/vaadin-multi-select-combo-box-internal.js

@@ -58,6 +58,14 @@ class MultiSelectComboBoxInternal extends ComboBoxDataProviderMixin(ComboBoxMixi
         notify: true,
       },
 
+      /**
+       * When true, filter string isn't cleared after selecting an item.
+       */
+      keepFilter: {
+        type: Boolean,
+        value: false,
+      },
+
       /**
        * When set to `true`, "loading" attribute is set
        * on the host and the overlay element.
@@ -274,6 +282,30 @@ class MultiSelectComboBoxInternal extends ComboBoxDataProviderMixin(ComboBoxMixi
     super._onEscape(event);
   }
 
+  /**
+   * Override from combo-box to ignore requests to clear the filter if the
+   * keepFilter option is enabled. Exceptions are when the dropdown is closed,
+   * so the filter is still cleared on cancel and focus out.
+   * @protected
+   * @override
+   */
+  _clearFilter() {
+    if (!this.keepFilter || !this.opened) {
+      super._clearFilter();
+    }
+  }
+
+  /**
+   * Override method from combo-box to always clear the filter when reverting
+   * the input value, regardless of the keepFilter option.
+   * @override
+   * @protected
+   */
+  _revertInputValueToValue() {
+    super._revertInputValueToValue();
+    this.filter = '';
+  }
+
   /**
    * @protected
    * @override

package/src/vaadin-multi-select-combo-box.d.ts

@@ -268,6 +268,12 @@ declare class MultiSelectComboBox<TItem = ComboBoxDefaultItem> extends HTMLEleme
    */
   i18n: MultiSelectComboBoxI18n;
 
+  /**
+   * When true, filter string isn't cleared after selecting an item.
+   * @attr {boolean} keep-filter
+   */
+  keepFilter: boolean;
+
   /**
    * True when loading items from the data provider, false otherwise.
    */

package/src/vaadin-multi-select-combo-box.js

@@ -179,6 +179,7 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
           top-group="[[_topGroup]]"
           opened="{{opened}}"
           renderer="[[renderer]]"
+          keep-filter="[[keepFilter]]"
           theme$="[[_theme]]"
           on-combo-box-item-selected="_onComboBoxItemSelected"
           on-change="_onComboBoxChange"
@@ -346,6 +347,14 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
         },
       },
 
+      /**
+       * When true, filter string isn't cleared after selecting an item.
+       */
+      keepFilter: {
+        type: Boolean,
+        value: false,
+      },
+
       /**
        * True when loading items from the data provider, false otherwise.
        */
@@ -834,10 +843,27 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
     return selectedItems.indexOf(item);
   }
 
-  /** @private */
-  __clearFilter() {
-    this.filter = '';
-    this.$.comboBox.clear();
+  /**
+   * Clear the internal combo box value and filter. Filter will not be cleared
+   * when the `keepFilter` option is enabled. Using `force` can enforce clearing
+   * the filter.
+   * @param {boolean} force overrides the keepFilter option
+   * @private
+   */
+  __clearInternalValue(force = false) {
+    if (!this.keepFilter || force) {
+      // Clear both combo box value and filter.
+      this.filter = '';
+      this.$.comboBox.clear();
+    } else {
+      // Only clear combo box value. This effectively resets _lastCommittedValue
+      // which allows toggling the same item multiple times via keyboard.
+      this.$.comboBox.clear();
+      // Restore input to the filter value. Needed when items are
+      // navigated with keyboard, which overrides the input value
+      // with the item label.
+      this.inputElement.value = this.filter;
+    }
   }
 
   /** @private */
@@ -869,7 +895,7 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
       const lastFilter = this._lastFilter;
       // Do not unselect when manually typing and committing an already selected item.
       if (lastFilter && lastFilter.toLowerCase() === itemLabel.toLowerCase()) {
-        this.__clearFilter();
+        this.__clearInternalValue();
         return;
       }
 
@@ -882,7 +908,7 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
     this.__updateSelection(itemsCopy);
 
     // Suppress `value-changed` event.
-    this.__clearFilter();
+    this.__clearInternalValue();
 
     this.__announceItem(itemLabel, isSelected, itemsCopy.length);
   }
@@ -1226,7 +1252,7 @@ class MultiSelectComboBox extends ResizeMixin(InputControlMixin(ThemableMixin(El
     // Stop the original event
     event.stopPropagation();
 
-    this.__clearFilter();
+    this.__clearInternalValue(true);
 
     this.dispatchEvent(
       new CustomEvent('custom-value-set', {

package/web-types.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/multi-select-combo-box",
-  "version": "23.4.0-alpha2",
+  "version": "23.4.0-alpha3",
   "description-markup": "markdown",
   "contributions": {
     "html": {
@@ -241,6 +241,17 @@
                 ]
               }
             },
+            {
+              "name": "keep-filter",
+              "description": "When true, filter string isn't cleared after selecting an item.",
+              "value": {
+                "type": [
+                  "boolean",
+                  "null",
+                  "undefined"
+                ]
+              }
+            },
             {
               "name": "loading",
               "description": "True when loading items from the data provider, false otherwise.",
@@ -572,6 +583,17 @@
                   ]
                 }
               },
+              {
+                "name": "keepFilter",
+                "description": "When true, filter string isn't cleared after selecting an item.",
+                "value": {
+                  "type": [
+                    "boolean",
+                    "null",
+                    "undefined"
+                  ]
+                }
+              },
               {
                 "name": "loading",
                 "description": "True when loading items from the data provider, false otherwise.",

package/web-types.lit.json

@@ -1,7 +1,7 @@
 {
   "$schema": "https://json.schemastore.org/web-types",
   "name": "@vaadin/multi-select-combo-box",
-  "version": "23.4.0-alpha2",
+  "version": "23.4.0-alpha3",
   "description-markup": "markdown",
   "framework": "lit",
   "framework-config": {
@@ -89,6 +89,13 @@
                 "kind": "expression"
               }
             },
+            {
+              "name": "?keepFilter",
+              "description": "When true, filter string isn't cleared after selecting an item.",
+              "value": {
+                "kind": "expression"
+              }
+            },
             {
               "name": "?loading",
               "description": "True when loading items from the data provider, false otherwise.",