@vaadin/field-highlighter 25.3.0-alpha10 → 25.3.0-alpha11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/field-highlighter",
-  "version": "25.3.0-alpha10",
+  "version": "25.3.0-alpha11",
   "publishConfig": {
     "access": "public"
   },
@@ -32,33 +32,33 @@
     "field"
   ],
   "dependencies": {
-    "@vaadin/a11y-base": "25.3.0-alpha10",
-    "@vaadin/component-base": "25.3.0-alpha10",
-    "@vaadin/overlay": "25.3.0-alpha10",
-    "@vaadin/popover": "25.3.0-alpha10",
-    "@vaadin/tooltip": "25.3.0-alpha10",
-    "@vaadin/vaadin-themable-mixin": "25.3.0-alpha10",
+    "@vaadin/a11y-base": "25.3.0-alpha11",
+    "@vaadin/component-base": "25.3.0-alpha11",
+    "@vaadin/overlay": "25.3.0-alpha11",
+    "@vaadin/popover": "25.3.0-alpha11",
+    "@vaadin/tooltip": "25.3.0-alpha11",
+    "@vaadin/vaadin-themable-mixin": "25.3.0-alpha11",
     "lit": "^3.0.0"
   },
   "devDependencies": {
-    "@vaadin/aura": "25.3.0-alpha10",
-    "@vaadin/chai-plugins": "25.3.0-alpha10",
-    "@vaadin/checkbox": "25.3.0-alpha10",
-    "@vaadin/checkbox-group": "25.3.0-alpha10",
-    "@vaadin/custom-field": "25.3.0-alpha10",
-    "@vaadin/date-picker": "25.3.0-alpha10",
-    "@vaadin/date-time-picker": "25.3.0-alpha10",
-    "@vaadin/item": "25.3.0-alpha10",
-    "@vaadin/list-box": "25.3.0-alpha10",
-    "@vaadin/radio-group": "25.3.0-alpha10",
-    "@vaadin/select": "25.3.0-alpha10",
-    "@vaadin/test-runner-commands": "25.3.0-alpha10",
+    "@vaadin/aura": "25.3.0-alpha11",
+    "@vaadin/chai-plugins": "25.3.0-alpha11",
+    "@vaadin/checkbox": "25.3.0-alpha11",
+    "@vaadin/checkbox-group": "25.3.0-alpha11",
+    "@vaadin/custom-field": "25.3.0-alpha11",
+    "@vaadin/date-picker": "25.3.0-alpha11",
+    "@vaadin/date-time-picker": "25.3.0-alpha11",
+    "@vaadin/item": "25.3.0-alpha11",
+    "@vaadin/list-box": "25.3.0-alpha11",
+    "@vaadin/radio-group": "25.3.0-alpha11",
+    "@vaadin/select": "25.3.0-alpha11",
+    "@vaadin/test-runner-commands": "25.3.0-alpha11",
     "@vaadin/testing-helpers": "^2.0.0",
-    "@vaadin/text-area": "25.3.0-alpha10",
-    "@vaadin/text-field": "25.3.0-alpha10",
-    "@vaadin/time-picker": "25.3.0-alpha10",
-    "@vaadin/vaadin-lumo-styles": "25.3.0-alpha10",
+    "@vaadin/text-area": "25.3.0-alpha11",
+    "@vaadin/text-field": "25.3.0-alpha11",
+    "@vaadin/time-picker": "25.3.0-alpha11",
+    "@vaadin/vaadin-lumo-styles": "25.3.0-alpha11",
     "sinon": "^22.0.0"
   },
-  "gitHead": "f2833abdf9b613fa0d0ed216830e3f4de87b7dac"
+  "gitHead": "7e0c61a37e68d8971def9cdf28ad0548a0f530a9"
 }

package/src/vaadin-ai-field-marker.js

@@ -25,8 +25,6 @@ const DEFAULT_I18N = {
   badgeTooltip: 'Field value modified by AI.\nClick for details',
 };
 
-const POPOVER_TRIGGER = ['click'];
-
 // Half of the 1s working shimmer slide (`--vaadin-ai-field-marker-slide` in
 // the base styles), so that held-back values land — and the read-only lock
 // lifts — in the middle of a slide instead of at its edge.
@@ -96,6 +94,9 @@ class DelayedFieldValue {
   /** The queued value, while `#timer` is pending. */
   #queuedValue;
 
+  /** Whether the field's own `value` accessor is currently replaced. */
+  #installed = false;
+
   constructor(field, delay) {
     this.#field = field;
     this.#delay = delay;
@@ -146,12 +147,17 @@ class DelayedFieldValue {
         this.#timer = setTimeout(() => this.#flush(), this.#delay);
       },
     });
+    this.#installed = true;
   }
 
   /** Restores the field's own accessor, applying a queued value right away. */
   uninstall() {
-    if (Object.getOwnPropertyDescriptor(this.#field, 'value')) {
+    // Only remove an own property that this instance defined, so that a field
+    // keeping its value in an own property instead of an accessor — which
+    // `install()` leaves alone — does not lose it.
+    if (this.#installed) {
       delete this.#field.value;
+      this.#installed = false;
     }
     this.#flush();
   }
@@ -510,15 +516,7 @@ class AiFieldMarker extends SlotStylesMixin(I18nMixin(DirMixin(PolylitMixin(LitE
     return html`
       <button id="${this.#badgeId}" class="badge" type="button" tabindex="0" aria-label="${badgeLabel}"></button>
       <vaadin-tooltip for="${this.#badgeId}" text="${badgeTooltip}"></vaadin-tooltip>
-      <vaadin-popover
-        for="${this.#badgeId}"
-        role="dialog"
-        aria-label="${badgeLabel}"
-        .trigger="${POPOVER_TRIGGER}"
-        autofocus
-        theme="arrow"
-        position="end-top"
-      >
+      <vaadin-popover for="${this.#badgeId}" aria-label="${badgeLabel}" autofocus theme="arrow" position="end-top">
         <p class="message">${message}</p>
         <div class="actions">
           <button type="button" tabindex="0" @click="${this.#onRevert}">${revert}</button>
@@ -673,9 +671,6 @@ class AiFieldMarker extends SlotStylesMixin(I18nMixin(DirMixin(PolylitMixin(LitE
    */
   #stopWorking(immediate = false) {
     const field = this.#field;
-    if (!field) {
-      return;
-    }
 
     if (this.#restoreTimer != null) {
       // Already winding down. Finish it now when the marker is going away, so