@vaadin/field-highlighter 24.0.0-alpha8 → 24.0.0-beta1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/field-highlighter",
-  "version": "24.0.0-alpha8",
+  "version": "24.0.0-beta1",
   "publishConfig": {
     "access": "public"
   },
@@ -34,29 +34,29 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "24.0.0-alpha8",
-    "@vaadin/overlay": "24.0.0-alpha8",
-    "@vaadin/vaadin-lumo-styles": "24.0.0-alpha8",
-    "@vaadin/vaadin-material-styles": "24.0.0-alpha8",
-    "@vaadin/vaadin-themable-mixin": "24.0.0-alpha8",
+    "@vaadin/component-base": "24.0.0-beta1",
+    "@vaadin/overlay": "24.0.0-beta1",
+    "@vaadin/vaadin-lumo-styles": "24.0.0-beta1",
+    "@vaadin/vaadin-material-styles": "24.0.0-beta1",
+    "@vaadin/vaadin-themable-mixin": "24.0.0-beta1",
     "lit": "^2.0.0"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/checkbox": "24.0.0-alpha8",
-    "@vaadin/checkbox-group": "24.0.0-alpha8",
-    "@vaadin/combo-box": "24.0.0-alpha8",
-    "@vaadin/date-picker": "24.0.0-alpha8",
-    "@vaadin/date-time-picker": "24.0.0-alpha8",
-    "@vaadin/item": "24.0.0-alpha8",
-    "@vaadin/list-box": "24.0.0-alpha8",
-    "@vaadin/radio-group": "24.0.0-alpha8",
-    "@vaadin/select": "24.0.0-alpha8",
-    "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-area": "24.0.0-alpha8",
-    "@vaadin/text-field": "24.0.0-alpha8",
-    "@vaadin/time-picker": "24.0.0-alpha8",
+    "@vaadin/checkbox": "24.0.0-beta1",
+    "@vaadin/checkbox-group": "24.0.0-beta1",
+    "@vaadin/combo-box": "24.0.0-beta1",
+    "@vaadin/date-picker": "24.0.0-beta1",
+    "@vaadin/date-time-picker": "24.0.0-beta1",
+    "@vaadin/item": "24.0.0-beta1",
+    "@vaadin/list-box": "24.0.0-beta1",
+    "@vaadin/radio-group": "24.0.0-beta1",
+    "@vaadin/select": "24.0.0-beta1",
+    "@vaadin/testing-helpers": "^0.4.0",
+    "@vaadin/text-area": "24.0.0-beta1",
+    "@vaadin/text-field": "24.0.0-beta1",
+    "@vaadin/time-picker": "24.0.0-beta1",
     "sinon": "^13.0.2"
   },
-  "gitHead": "476752249bb12295c500980d98a3256ad3b22b73"
+  "gitHead": "c5b48921a62482746df8e46994b37e1490fec27e"
 }

package/src/fields/outline.js

@@ -10,8 +10,6 @@ const getOutlineTarget = (element, tagName) => {
     case 'vaadin-big-decimal-field':
     case 'vaadin-combo-box':
     case 'vaadin-date-picker':
-    case 'vaadin-date-time-picker-date-picker':
-    case 'vaadin-date-time-picker-time-picker':
     case 'vaadin-email-field':
     case 'vaadin-integer-field':
     case 'vaadin-number-field':

package/src/vaadin-field-highlighter.js

@@ -53,20 +53,6 @@ const initFieldObserver = (field) => {
  * See https://vaadin.com/collaboration for Collaboration Engine documentation.
  */
 export class FieldHighlighterController {
-  get user() {
-    return this._user;
-  }
-
-  set user(user) {
-    this._user = user;
-
-    if (user) {
-      const msg = `${user.name} started editing`;
-      const { label } = this.host;
-      announce(label ? `${msg} ${label}` : msg);
-    }
-  }
-
   constructor(host) {
     this.host = host;
 
@@ -94,6 +80,20 @@ export class FieldHighlighterController {
     this.users = [];
   }
 
+  get user() {
+    return this._user;
+  }
+
+  set user(user) {
+    this._user = user;
+
+    if (user) {
+      const msg = `${user.name} started editing`;
+      const { label } = this.host;
+      announce(label ? `${msg} ${label}` : msg);
+    }
+  }
+
   hostConnected() {
     this.redraw();
   }

package/src/vaadin-user-tags.js

@@ -128,6 +128,11 @@ export class UserTags extends PolymerElement {
     );
   }
 
+  /** @protected */
+  get wrapper() {
+    return this.$.overlay.querySelector('[part="tags"]');
+  }
+
   /** @protected */
   connectedCallback() {
     super.connectedCallback();
@@ -208,10 +213,6 @@ export class UserTags extends PolymerElement {
     }
   }
 
-  get wrapper() {
-    return this.$.overlay.querySelector('[part="tags"]');
-  }
-
   createUserTag(user) {
     const tag = document.createElement('vaadin-user-tag');
     tag.name = user.name;
@@ -235,9 +236,9 @@ export class UserTags extends PolymerElement {
     const usersToRemove = [];
 
     splices.forEach((splice) => {
-      for (let i = 0; i < splice.removed.length; i++) {
-        usersToRemove.push(splice.removed[i]);
-      }
+      splice.removed.forEach((user) => {
+        usersToRemove.push(user);
+      });
 
       for (let i = splice.addedCount - 1; i >= 0; i--) {
         usersToAdd.push(users[splice.index + i]);
@@ -290,15 +291,17 @@ export class UserTags extends PolymerElement {
 
     // Check if flash queue contains pending tags for removed users
     if (this.__flashQueue.length > 0) {
-      for (let i = 0; i < removedUsers.length; i++) {
+      removedUsers.forEach((user, i) => {
         if (changedTags.removed[i] === null) {
-          for (let j = 0; j < this.__flashQueue.length; j++) {
-            if (this.__flashQueue[j].some((tag) => tag.uid === removedUsers[i].id)) {
-              this.splice('__flashQueue', i, 1);
-            }
-          }
+          return;
         }
-      }
+
+        this.__flashQueue.forEach((tags) => {
+          if (tags.some((tag) => tag.uid === user.id)) {
+            this.splice('__flashQueue', i, 1);
+          }
+        });
+      });
     }
 
     if (this.opened && this.hasFocus) {