@vaadin/field-highlighter 23.1.0-alpha4 → 23.1.0-beta3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/field-highlighter",
-  "version": "23.1.0-alpha4",
+  "version": "23.1.0-beta3",
   "publishConfig": {
     "access": "public"
   },
@@ -34,27 +34,27 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "23.1.0-alpha4",
-    "@vaadin/vaadin-lumo-styles": "23.1.0-alpha4",
-    "@vaadin/vaadin-material-styles": "23.1.0-alpha4",
-    "@vaadin/vaadin-overlay": "23.1.0-alpha4",
-    "@vaadin/vaadin-themable-mixin": "23.1.0-alpha4",
+    "@vaadin/component-base": "23.1.0-beta3",
+    "@vaadin/vaadin-lumo-styles": "23.1.0-beta3",
+    "@vaadin/vaadin-material-styles": "23.1.0-beta3",
+    "@vaadin/vaadin-overlay": "23.1.0-beta3",
+    "@vaadin/vaadin-themable-mixin": "23.1.0-beta3",
     "lit": "^2.0.0"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/checkbox": "23.1.0-alpha4",
-    "@vaadin/combo-box": "23.1.0-alpha4",
-    "@vaadin/date-picker": "23.1.0-alpha4",
-    "@vaadin/date-time-picker": "23.1.0-alpha4",
-    "@vaadin/item": "23.1.0-alpha4",
-    "@vaadin/list-box": "23.1.0-alpha4",
-    "@vaadin/radio-group": "23.1.0-alpha4",
-    "@vaadin/select": "23.1.0-alpha4",
+    "@vaadin/checkbox": "23.1.0-beta3",
+    "@vaadin/combo-box": "23.1.0-beta3",
+    "@vaadin/date-picker": "23.1.0-beta3",
+    "@vaadin/date-time-picker": "23.1.0-beta3",
+    "@vaadin/item": "23.1.0-beta3",
+    "@vaadin/list-box": "23.1.0-beta3",
+    "@vaadin/radio-group": "23.1.0-beta3",
+    "@vaadin/select": "23.1.0-beta3",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-field": "23.1.0-alpha4",
-    "@vaadin/time-picker": "23.1.0-alpha4",
+    "@vaadin/text-field": "23.1.0-beta3",
+    "@vaadin/time-picker": "23.1.0-beta3",
     "sinon": "^13.0.2"
   },
-  "gitHead": "aacdb7fe09811894751f0378ff7fb66071892c71"
+  "gitHead": "c787ceb8a312f88631c6d429ff320d5f89b1b838"
 }

package/src/fields/vaadin-component-observer.js

@@ -32,7 +32,7 @@ export class ComponentObserver {
     this._tags = tags;
 
     component.addEventListener('mouseenter', (event) => {
-      // ignore mouseleave on overlay opening
+      // Ignore mouseleave on overlay opening
       if (event.relatedTarget === this._tags.$.overlay) {
         return;
       }
@@ -45,7 +45,7 @@ export class ComponentObserver {
     });
 
     component.addEventListener('mouseleave', (event) => {
-      // ignore mouseleave on overlay opening
+      // Ignore mouseleave on overlay opening
       if (event.relatedTarget === this._tags.$.overlay) {
         return;
       }
@@ -76,7 +76,7 @@ export class ComponentObserver {
     });
 
     this._tags.$.overlay.addEventListener('mouseleave', (event) => {
-      // ignore mouseleave when moving back to field
+      // Ignore mouseleave when moving back to field
       if (event.relatedTarget === component) {
         return;
       }

package/src/fields/vaadin-date-picker-observer.js

@@ -45,13 +45,13 @@ export class DatePickerObserver extends ComponentObserver {
 
   onFocusIn(event) {
     if (event.relatedTarget === this.overlay) {
-      // focus returns from the overlay, do nothing.
+      // Focus returns from the overlay, do nothing.
       return;
     }
 
     if (this.blurWhileOpened) {
       this.blurWhileOpened = false;
-      // focus returns from outside the browser tab, ignore.
+      // Focus returns from outside the browser tab, ignore.
       return;
     }
 
@@ -60,9 +60,9 @@ export class DatePickerObserver extends ComponentObserver {
 
   onFocusOut(event) {
     if (this.fullscreenFocus || event.relatedTarget === this.overlay) {
-      // do nothing, overlay is opening.
+      // Do nothing, overlay is opening.
     } else if (!this.datePicker.opened) {
-      // field blur when closed.
+      // Field blur when closed.
       this.hideOutline(this.datePicker);
     } else {
       // Focus moves away while still opened, e.g. outside the browser.
@@ -84,7 +84,7 @@ export class DatePickerObserver extends ComponentObserver {
       this.showOutline(this.datePicker);
     }
 
-    // closing after previously moving focus away.
+    // Closing after previously moving focus away.
     if (event.detail.value === false && this.blurWhileOpened) {
       this.blurWhileOpened = false;
       this.hideOutline(this.datePicker);

package/src/fields/vaadin-date-time-picker-observer.js

@@ -11,7 +11,7 @@ class DateObserver extends DatePickerObserver {
   constructor(datePicker, host) {
     super(datePicker);
 
-    // fire events on the host
+    // Fire events on the host
     this.component = host;
   }
 
@@ -24,7 +24,7 @@ class TimeObserver extends FieldObserver {
   constructor(timePicker, host) {
     super(timePicker);
 
-    // fire events on the host
+    // Fire events on the host
     this.component = host;
     this.timePicker = timePicker;
   }

package/src/fields/vaadin-select-observer.js

@@ -17,7 +17,7 @@ export class SelectObserver extends FieldObserver {
     super.addListeners(select);
 
     select.addEventListener('opened-changed', (event) => {
-      // when in phone mode, focus is lost when closing.
+      // When in phone mode, focus is lost when closing.
       if (select._phone && event.detail.value === false) {
         this.hideOutline(select);
       }
@@ -26,12 +26,12 @@ export class SelectObserver extends FieldObserver {
 
   onFocusIn(event) {
     if (this.overlay.contains(event.relatedTarget)) {
-      // focus returns on item select, do nothing.
+      // Focus returns on item select, do nothing.
       return;
     }
 
     if (!this.component._phone && this.overlay.hasAttribute('closing')) {
-      // focus returns on outside click, do nothing.
+      // Focus returns on outside click, do nothing.
       return;
     }
 
@@ -40,7 +40,7 @@ export class SelectObserver extends FieldObserver {
 
   onFocusOut(event) {
     if (this.overlay.contains(event.relatedTarget)) {
-      // do nothing, overlay is opening.
+      // Do nothing, overlay is opening.
       return;
     }
     super.onFocusOut(event);

package/src/vaadin-user-tags-overlay.js

@@ -4,17 +4,15 @@
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
 import { OverlayElement } from '@vaadin/vaadin-overlay/src/vaadin-overlay.js';
+import { PositionMixin } from '@vaadin/vaadin-overlay/src/vaadin-overlay-position-mixin.js';
 import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
 
 registerStyles(
   'vaadin-user-tags-overlay',
   css`
     :host {
-      align-items: stretch;
-      justify-content: flex-start;
       background: transparent;
       box-shadow: none;
-      bottom: auto;
     }
 
     [part='overlay'] {
@@ -42,14 +40,6 @@ registerStyles(
       padding: 0;
     }
 
-    :host([dir='rtl']) {
-      left: auto;
-    }
-
-    :host(:not([dir='rtl'])) {
-      right: auto;
-    }
-
     :host([opening]),
     :host([closing]) {
       animation: 0.14s user-tags-overlay-dummy-animation;
@@ -73,7 +63,7 @@ registerStyles(
  * @extends OverlayElement
  * @private
  */
-class UserTagsOverlay extends OverlayElement {
+class UserTagsOverlay extends PositionMixin(OverlayElement) {
   static get is() {
     return 'vaadin-user-tags-overlay';
   }

package/src/vaadin-user-tags.js

@@ -45,6 +45,7 @@ export class UserTags extends PolymerElement {
         id="overlay"
         modeless
         opened="[[opened]]"
+        no-vertical-overlap
         on-vaadin-overlay-open="_onOverlayOpen"
       ></vaadin-user-tags-overlay>
     `;
@@ -68,7 +69,6 @@ export class UserTags extends PolymerElement {
       opened: {
         type: Boolean,
         value: false,
-        observer: '_openedChanged',
       },
 
       /**
@@ -85,6 +85,7 @@ export class UserTags extends PolymerElement {
        */
       target: {
         type: Object,
+        observer: '__targetChanged',
       },
 
       /**
@@ -103,23 +104,9 @@ export class UserTags extends PolymerElement {
     };
   }
 
-  constructor() {
-    super();
-    this._boundSetPosition = this._debounceSetPosition.bind(this);
-  }
-
-  /** @protected */
-  connectedCallback() {
-    super.connectedCallback();
-    window.addEventListener('resize', this._boundSetPosition);
-    window.addEventListener('scroll', this._boundSetPosition);
-  }
-
   /** @protected */
   disconnectedCallback() {
     super.disconnectedCallback();
-    window.removeEventListener('resize', this._boundSetPosition);
-    window.removeEventListener('scroll', this._boundSetPosition);
     this.opened = false;
   }
 
@@ -138,15 +125,8 @@ export class UserTags extends PolymerElement {
   }
 
   /** @private */
-  _debounceSetPosition() {
-    this._debouncePosition = Debouncer.debounce(this._debouncePosition, timeOut.after(16), () => this._setPosition());
-  }
-
-  /** @private */
-  _openedChanged(opened) {
-    if (opened) {
-      this._setPosition();
-    }
+  __targetChanged(target) {
+    this.$.overlay.positionTarget = target;
   }
 
   /** @private */
@@ -156,34 +136,6 @@ export class UserTags extends PolymerElement {
     }
   }
 
-  /**
-   * Set position of the user tags overlay.
-   * TODO: use PositionMixin instead.
-   *
-   * @private
-   */
-  _setPosition() {
-    if (!this.opened) {
-      return;
-    }
-
-    const targetRect = this.target.getBoundingClientRect();
-
-    const overlayRect = this.$.overlay.getBoundingClientRect();
-
-    this._translateX =
-      this.getAttribute('dir') === 'rtl'
-        ? targetRect.right - overlayRect.right + (this._translateX || 0)
-        : targetRect.left - overlayRect.left + (this._translateX || 0);
-    this._translateY = targetRect.top - overlayRect.top + (this._translateY || 0) + targetRect.height;
-
-    const devicePixelRatio = window.devicePixelRatio || 1;
-    this._translateX = Math.round(this._translateX * devicePixelRatio) / devicePixelRatio;
-    this._translateY = Math.round(this._translateY * devicePixelRatio) / devicePixelRatio;
-
-    this.$.overlay.style.transform = `translate3d(${this._translateX}px, ${this._translateY}px, 0)`;
-  }
-
   get wrapper() {
     return this.$.overlay.content.querySelector('[part="tags"]');
   }
@@ -220,7 +172,7 @@ export class UserTags extends PolymerElement {
       }
     });
 
-    // filter out users that are only moved
+    // Filter out users that are only moved
     const addedUsers = usersToAdd.filter((u) => !usersToRemove.some((u2) => u.id === u2.id));
     const removedUsers = usersToRemove.filter((u) => !usersToAdd.some((u2) => u.id === u2.id));
 
@@ -264,7 +216,7 @@ export class UserTags extends PolymerElement {
 
     const changedTags = this.getChangedTags(addedUsers, removedUsers);
 
-    // check if flash queue contains pending tags for removed users
+    // Check if flash queue contains pending tags for removed users
     if (this._flashQueue.length > 0) {
       for (let i = 0; i < removedUsers.length; i++) {
         if (changedTags.removed[i] === null) {
@@ -283,7 +235,7 @@ export class UserTags extends PolymerElement {
       // Avoid adding to queue if window is not visible.
       const tags = changedTags.added;
       if (this.flashing) {
-        // schedule next flash later
+        // Schedule next flash later
         this.push('_flashQueue', tags);
       } else {
         this.flashTags(tags);
@@ -296,7 +248,7 @@ export class UserTags extends PolymerElement {
 
   /** @private */
   _onOverlayOpen() {
-    // animate all tags except removing ones
+    // Animate all tags except removing ones
     Array.from(this.wrapper.children).forEach((tag) => {
       if (!tag.classList.contains('removing')) {
         tag.classList.add('show');
@@ -308,11 +260,11 @@ export class UserTags extends PolymerElement {
     this.flashing = true;
     const wrapper = this.wrapper;
 
-    // hide existing tags
+    // Hide existing tags
     const hidden = Array.from(wrapper.children);
     hidden.forEach((tag) => (tag.style.display = 'none'));
 
-    // render new tags
+    // Render new tags
     added.forEach((tag) => {
       wrapper.insertBefore(tag, wrapper.firstChild);
     });
@@ -320,12 +272,12 @@ export class UserTags extends PolymerElement {
     this.flashPromise = new Promise((resolve) => {
       listenOnce(this.$.overlay, 'vaadin-overlay-open').then(() => {
         this._debounceFlashStart = Debouncer.debounce(this._debounceFlashStart, timeOut.after(DURATION + DELAY), () => {
-          // animate disappearing
+          // Animate disappearing
           if (!this.hasFocus) {
             added.forEach((tag) => tag.classList.remove('show'));
           }
           this._debounceFlashEnd = Debouncer.debounce(this._debounceFlashEnd, timeOut.after(DURATION), () => {
-            // show all tags
+            // Show all tags
             const finishFlash = () => {
               hidden.forEach((tag) => (tag.style.display = 'block'));
               this.flashing = false;
@@ -335,7 +287,7 @@ export class UserTags extends PolymerElement {
             if (this.hasFocus) {
               finishFlash();
             } else {
-              // wait for overlay closing animation to complete
+              // Wait for overlay closing animation to complete
               listenOnce(this.$.overlay, 'animationend').then(() => {
                 finishFlash();
               });