@vaadin/dialog 25.0.0-beta1 → 25.0.0-beta2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "@vaadin/dialog",
3
- "version": "25.0.0-beta1",
3
+ "version": "25.0.0-beta2",
4
4
  "publishConfig": {
5
5
  "access": "public"
6
6
  },
@@ -36,23 +36,23 @@
36
36
  ],
37
37
  "dependencies": {
38
38
  "@open-wc/dedupe-mixin": "^1.3.0",
39
- "@vaadin/component-base": "25.0.0-beta1",
40
- "@vaadin/lit-renderer": "25.0.0-beta1",
41
- "@vaadin/overlay": "25.0.0-beta1",
42
- "@vaadin/vaadin-themable-mixin": "25.0.0-beta1",
39
+ "@vaadin/component-base": "25.0.0-beta2",
40
+ "@vaadin/lit-renderer": "25.0.0-beta2",
41
+ "@vaadin/overlay": "25.0.0-beta2",
42
+ "@vaadin/vaadin-themable-mixin": "25.0.0-beta2",
43
43
  "lit": "^3.0.0"
44
44
  },
45
45
  "devDependencies": {
46
- "@vaadin/a11y-base": "25.0.0-beta1",
47
- "@vaadin/chai-plugins": "25.0.0-beta1",
48
- "@vaadin/test-runner-commands": "25.0.0-beta1",
46
+ "@vaadin/a11y-base": "25.0.0-beta2",
47
+ "@vaadin/chai-plugins": "25.0.0-beta2",
48
+ "@vaadin/test-runner-commands": "25.0.0-beta2",
49
49
  "@vaadin/testing-helpers": "^2.0.0",
50
- "@vaadin/vaadin-lumo-styles": "25.0.0-beta1",
50
+ "@vaadin/vaadin-lumo-styles": "25.0.0-beta2",
51
51
  "sinon": "^21.0.0"
52
52
  },
53
53
  "web-types": [
54
54
  "web-types.json",
55
55
  "web-types.lit.json"
56
56
  ],
57
- "gitHead": "1d20cf54e582d1f2e209126d4586f8b4c01c50e0"
57
+ "gitHead": "e078f8371ae266f05c7ca1ec25686cc489c83f24"
58
58
  }
@@ -53,6 +53,22 @@ export const DialogOverlayMixin = (superClass) =>
53
53
  return this.owner;
54
54
  }
55
55
 
56
+ /**
57
+ * Override method from OverlayMixin to use slotted div as a renderer root.
58
+ * @protected
59
+ * @override
60
+ */
61
+ get _rendererRoot() {
62
+ if (!this.__savedRoot) {
63
+ const root = document.createElement('vaadin-dialog-content');
64
+ root.style.display = 'contents';
65
+ this.owner.appendChild(root);
66
+ this.__savedRoot = root;
67
+ }
68
+
69
+ return this.__savedRoot;
70
+ }
71
+
56
72
  /** @protected */
57
73
  ready() {
58
74
  super.ready();
@@ -78,7 +94,7 @@ export const DialogOverlayMixin = (superClass) =>
78
94
 
79
95
  /** @private */
80
96
  __createContainer(slot) {
81
- const container = document.createElement('div');
97
+ const container = document.createElement('vaadin-dialog-content');
82
98
  container.setAttribute('slot', slot);
83
99
  return container;
84
100
  }
@@ -98,8 +114,9 @@ export const DialogOverlayMixin = (superClass) =>
98
114
  // Reset existing container in case if a new renderer is set.
99
115
  this.__clearContainer(container);
100
116
  } else {
101
- // Create the container, but wait to append it until requestContentUpdate is called.
117
+ // Create the container and append it to the dialog element.
102
118
  container = this.__createContainer(slot);
119
+ this.owner.appendChild(container);
103
120
  }
104
121
  return container;
105
122
  }
@@ -181,28 +198,12 @@ export const DialogOverlayMixin = (superClass) =>
181
198
  requestContentUpdate() {
182
199
  super.requestContentUpdate();
183
200
 
184
- if (this.headerContainer) {
185
- // If a new renderer has been set, make sure to reattach the container
186
- if (!this.headerContainer.parentElement) {
187
- this.owner.appendChild(this.headerContainer);
188
- }
189
-
190
- if (this.headerRenderer) {
191
- // Only call header renderer after the container has been initialized
192
- this.headerRenderer.call(this.owner, this.headerContainer, this.owner);
193
- }
201
+ if (this.headerContainer && this.headerRenderer) {
202
+ this.headerRenderer.call(this.owner, this.headerContainer, this.owner);
194
203
  }
195
204
 
196
- if (this.footerContainer) {
197
- // If a new renderer has been set, make sure to reattach the container
198
- if (!this.footerContainer.parentElement) {
199
- this.owner.appendChild(this.footerContainer);
200
- }
201
-
202
- if (this.footerRenderer) {
203
- // Only call header renderer after the container has been initialized
204
- this.footerRenderer.call(this.owner, this.footerContainer, this.owner);
205
- }
205
+ if (this.footerContainer && this.footerRenderer) {
206
+ this.footerRenderer.call(this.owner, this.footerContainer, this.owner);
206
207
  }
207
208
 
208
209
  this._headerTitleRenderer();
package/web-types.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "$schema": "https://json.schemastore.org/web-types",
3
3
  "name": "@vaadin/dialog",
4
- "version": "25.0.0-beta1",
4
+ "version": "25.0.0-beta2",
5
5
  "description-markup": "markdown",
6
6
  "contributions": {
7
7
  "html": {
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "$schema": "https://json.schemastore.org/web-types",
3
3
  "name": "@vaadin/dialog",
4
- "version": "25.0.0-beta1",
4
+ "version": "25.0.0-beta2",
5
5
  "description-markup": "markdown",
6
6
  "framework": "lit",
7
7
  "framework-config": {