@vaadin/dialog 23.1.0-alpha3 → 23.1.0-alpha4

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/dialog",
-  "version": "23.1.0-alpha3",
+  "version": "23.1.0-alpha4",
   "publishConfig": {
     "access": "public"
   },
@@ -35,18 +35,18 @@
   "dependencies": {
     "@open-wc/dedupe-mixin": "^1.3.0",
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "23.1.0-alpha3",
-    "@vaadin/vaadin-lumo-styles": "23.1.0-alpha3",
-    "@vaadin/vaadin-material-styles": "23.1.0-alpha3",
-    "@vaadin/vaadin-overlay": "23.1.0-alpha3",
-    "@vaadin/vaadin-themable-mixin": "23.1.0-alpha3"
+    "@vaadin/component-base": "23.1.0-alpha4",
+    "@vaadin/vaadin-lumo-styles": "23.1.0-alpha4",
+    "@vaadin/vaadin-material-styles": "23.1.0-alpha4",
+    "@vaadin/vaadin-overlay": "23.1.0-alpha4",
+    "@vaadin/vaadin-themable-mixin": "23.1.0-alpha4"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
-    "@vaadin/polymer-legacy-adapter": "23.1.0-alpha3",
+    "@vaadin/polymer-legacy-adapter": "23.1.0-alpha4",
     "@vaadin/testing-helpers": "^0.3.2",
-    "@vaadin/text-area": "23.1.0-alpha3",
+    "@vaadin/text-area": "23.1.0-alpha4",
     "sinon": "^13.0.2"
   },
-  "gitHead": "8c9e64e8dfa158dd52a9bf6da351ff038c88ca85"
+  "gitHead": "aacdb7fe09811894751f0378ff7fb66071892c71"
 }

package/src/vaadin-dialog-draggable-mixin.d.ts

@@ -6,7 +6,7 @@
 import { Constructor } from '@open-wc/dedupe-mixin';
 
 export declare function DialogDraggableMixin<T extends Constructor<HTMLElement>>(
-  base: T
+  base: T,
 ): T & Constructor<DialogDraggableMixinClass>;
 
 export declare class DialogDraggableMixinClass {

package/src/vaadin-dialog-draggable-mixin.js

@@ -28,19 +28,19 @@ export const DialogDraggableMixin = (superClass) =>
         draggable: {
           type: Boolean,
           value: false,
-          reflectToAttribute: true
+          reflectToAttribute: true,
         },
 
         /** @private */
         _touchDevice: {
           type: Boolean,
-          value: isTouch
+          value: isTouch,
         },
 
         /* TODO: Expose as a public property (check naming) */
         __dragHandleClassName: {
-          type: String
-        }
+          type: String,
+        },
       };
     }
 
@@ -82,7 +82,9 @@ export const DialogDraggableMixin = (superClass) =>
         });
 
         if ((isResizerContainer && !isResizerContainerScrollbar) || isContentPart || isDraggable) {
-          !isDraggable && e.preventDefault();
+          if (!isDraggable) {
+            e.preventDefault();
+          }
           this._originalBounds = this.$.overlay.getBounds();
           const event = getMouseOrFirstTouchEvent(e);
           this._originalMouseCoords = { top: event.pageY, left: event.pageX };

package/src/vaadin-dialog-resizable-mixin.d.ts

@@ -6,7 +6,7 @@
 import { Constructor } from '@open-wc/dedupe-mixin';
 
 export declare function DialogResizableMixin<T extends Constructor<HTMLElement>>(
-  base: T
+  base: T,
 ): T & Constructor<DialogResizableMixinClass>;
 
 export declare class DialogResizableMixinClass {

package/src/vaadin-dialog-resizable-mixin.js

@@ -105,7 +105,7 @@ registerStyles(
       cursor: nwse-resize;
     }
   `,
-  { moduleId: 'vaadin-dialog-resizable-overlay-styles' }
+  { moduleId: 'vaadin-dialog-resizable-overlay-styles' },
 );
 
 /**
@@ -122,8 +122,8 @@ export const DialogResizableMixin = (superClass) =>
         resizable: {
           type: Boolean,
           value: false,
-          reflectToAttribute: true
-        }
+          reflectToAttribute: true,
+        },
       };
     }
 
@@ -252,7 +252,7 @@ export const DialogResizableMixin = (superClass) =>
       const content = this.$.overlay.$.content;
       content.setAttribute(
         'style',
-        'position: absolute; top: 0; right: 0; bottom: 0; left: 0; box-sizing: content-box; height: auto;'
+        'position: absolute; top: 0; right: 0; bottom: 0; left: 0; box-sizing: content-box; height: auto;',
       );
       const { width: contentWidth, height: contentHeight } = getComputedStyle(content);
       content.removeAttribute('style');

package/src/vaadin-dialog.d.ts

@@ -208,13 +208,13 @@ declare class Dialog extends ThemePropertyMixin(ElementMixin(DialogDraggableMixi
   addEventListener<K extends keyof DialogEventMap>(
     type: K,
     listener: (this: Dialog, ev: DialogEventMap[K]) => void,
-    options?: boolean | AddEventListenerOptions
+    options?: boolean | AddEventListenerOptions,
   ): void;
 
   removeEventListener<K extends keyof DialogEventMap>(
     type: K,
     listener: (this: Dialog, ev: DialogEventMap[K]) => void,
-    options?: boolean | EventListenerOptions
+    options?: boolean | EventListenerOptions,
   ): void;
 }
 

package/src/vaadin-dialog.js

@@ -15,10 +15,9 @@ import { DialogResizableMixin } from './vaadin-dialog-resizable-mixin.js';
 registerStyles(
   'vaadin-dialog-overlay',
   css`
-    /* prefixing with the element tags to avoid styling confirm-dialog header part */
-    header[part='header'],
+    [part='header'],
     [part='header-content'],
-    footer[part='footer'] {
+    [part='footer'] {
       display: flex;
       align-items: center;
       flex-wrap: wrap;
@@ -27,10 +26,9 @@ registerStyles(
       z-index: 1;
     }
 
-    :host(:is([has-title], [has-header])) ::slotted([slot='header']),
     ::slotted([slot='header-content']),
     ::slotted([slot='title']),
-    :host([has-footer]) ::slotted([slot='footer']) {
+    ::slotted([slot='footer']) {
       display: contents;
       pointer-events: auto;
     }
@@ -39,19 +37,16 @@ registerStyles(
       flex: 1;
     }
 
-    /* prefixing with the element tag to avoid styling confirm-dialog footer part */
     :host([has-title]) [part='header-content'],
-    footer[part='footer'] {
+    [part='footer'] {
       justify-content: flex-end;
     }
 
-    :host(:not([has-title]):not([has-header])) header[part='header'],
-    :host(:not([has-title])) [part='title'] {
-      display: none;
-    }
-
-    :host(:not([has-footer])) footer[part='footer'] {
-      display: none;
+    :host(:not([has-title]):not([has-header])) [part='header'],
+    :host(:not([has-header])) [part='header-content'],
+    :host(:not([has-title])) [part='title'],
+    :host(:not([has-footer])) [part='footer'] {
+      display: none !important;
     }
 
     :host(:is([has-title], [has-header], [has-footer])) [part='content'] {
@@ -83,7 +78,7 @@ registerStyles(
       max-width: none;
     }
   `,
-  { moduleId: 'vaadin-dialog-overlay-styles' }
+  { moduleId: 'vaadin-dialog-overlay-styles' },
 );
 
 let memoizedTemplate;
@@ -144,7 +139,7 @@ export class DialogOverlay extends OverlayElement {
   static get observers() {
     return [
       '_headerFooterRendererChange(headerRenderer, footerRenderer, opened)',
-      '_headerTitleChanged(headerTitle, opened)'
+      '_headerTitleChanged(headerTitle, opened)',
     ];
   }
 
@@ -158,7 +153,7 @@ export class DialogOverlay extends OverlayElement {
 
       headerRenderer: Function,
 
-      footerRenderer: Function
+      footerRenderer: Function,
     };
   }
 
@@ -502,7 +497,7 @@ class Dialog extends ThemePropertyMixin(ElementMixin(DialogDraggableMixin(Dialog
       opened: {
         type: Boolean,
         value: false,
-        notify: true
+        notify: true,
       },
 
       /**
@@ -512,7 +507,7 @@ class Dialog extends ThemePropertyMixin(ElementMixin(DialogDraggableMixin(Dialog
        */
       noCloseOnOutsideClick: {
         type: Boolean,
-        value: false
+        value: false,
       },
 
       /**
@@ -522,7 +517,7 @@ class Dialog extends ThemePropertyMixin(ElementMixin(DialogDraggableMixin(Dialog
        */
       noCloseOnEsc: {
         type: Boolean,
-        value: false
+        value: false,
       },
 
       /**
@@ -532,7 +527,7 @@ class Dialog extends ThemePropertyMixin(ElementMixin(DialogDraggableMixin(Dialog
        */
       ariaLabel: {
         type: String,
-        value: ''
+        value: '',
       },
 
       /**
@@ -591,8 +586,8 @@ class Dialog extends ThemePropertyMixin(ElementMixin(DialogDraggableMixin(Dialog
        */
       modeless: {
         type: Boolean,
-        value: false
-      }
+        value: false,
+      },
     };
   }
 
@@ -600,7 +595,7 @@ class Dialog extends ThemePropertyMixin(ElementMixin(DialogDraggableMixin(Dialog
     return [
       '_openedChanged(opened)',
       '_ariaLabelChanged(ariaLabel)',
-      '_rendererChanged(renderer, headerRenderer, footerRenderer)'
+      '_rendererChanged(renderer, headerRenderer, footerRenderer)',
     ];
   }
 

package/theme/lumo/vaadin-dialog-styles.js

@@ -31,20 +31,20 @@ const dialogOverlay = css`
     padding-top: 0;
   }
 
-  :host(:is([has-header], [has-title])) [part='header'],
-  :host([has-header]) [part='header-content'],
-  :host([has-footer]) [part='footer'] {
+  [part='header'],
+  [part='header-content'],
+  [part='footer'] {
     gap: var(--lumo-space-xs) var(--lumo-space-s);
     line-height: var(--lumo-line-height-s);
   }
 
-  :host(:is([has-header], [has-title])) [part='header'] {
+  [part='header'] {
     padding: var(--lumo-space-m);
     background-color: var(--lumo-base-color);
     border-radius: var(--lumo-border-radius-l) var(--lumo-border-radius-l) 0 0; /* Needed for Safari */
   }
 
-  :host([has-footer]) [part='footer'] {
+  [part='footer'] {
     padding: var(--lumo-space-s) var(--lumo-space-m);
     background-color: var(--lumo-contrast-5pct);
     border-radius: 0 0 var(--lumo-border-radius-l) var(--lumo-border-radius-l); /* Needed for Safari */
@@ -63,7 +63,7 @@ const dialogOverlay = css`
   }
 
   @media (min-height: 320px) {
-    :host(:is([has-header], [has-title])[overflow~='top']) [part='header'] {
+    :host([overflow~='top']) [part='header'] {
       box-shadow: 0 1px 0 0 var(--lumo-contrast-10pct);
     }
   }

package/theme/material/vaadin-dialog-styles.js

@@ -16,7 +16,7 @@ const dialogOverlay = css`
     padding: 24px;
   }
 
-  :host(:is([has-header], [has-title])) [part='header'] {
+  [part='header'] {
     padding: 16px;
   }
 
@@ -24,9 +24,9 @@ const dialogOverlay = css`
     padding-top: 0;
   }
 
-  :host(:is([has-header], [has-title])) [part='header'],
-  :host([has-header]) [part='header-content'],
-  :host([has-footer]) [part='footer'] {
+  [part='header'],
+  [part='header-content'],
+  [part='footer'] {
     gap: 8px;
     line-height: 1.2;
   }
@@ -37,16 +37,16 @@ const dialogOverlay = css`
     margin-inline-start: 8px;
   }
 
-  :host([has-footer]) [part='footer'] {
+  [part='footer'] {
     padding: 8px;
   }
 
   @media (min-height: 320px) {
-    :host(:is([has-header], [has-title])[overflow~='top']) [part='header'] {
+    :host([overflow~='top']) [part='header'] {
       box-shadow: 0 1px 0 0 var(--material-divider-color);
     }
 
-    :host([has-footer][overflow~='bottom']) [part='footer'] {
+    :host([overflow~='bottom']) [part='footer'] {
       box-shadow: 0 -1px 0 0 var(--material-divider-color);
     }
   }
@@ -58,5 +58,5 @@ const dialogOverlay = css`
 `;
 
 registerStyles('vaadin-dialog-overlay', [overlay, dialogOverlay], {
-  moduleId: 'material-dialog'
+  moduleId: 'material-dialog',
 });