@vaadin/component-base 23.3.0-alpha1 → 23.3.0-alpha2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/component-base",
-  "version": "23.3.0-alpha1",
+  "version": "23.3.0-alpha2",
   "publishConfig": {
     "access": "public"
   },
@@ -42,5 +42,5 @@
     "@vaadin/testing-helpers": "^0.3.2",
     "sinon": "^13.0.2"
   },
-  "gitHead": "beabc527d4b1274eb798ff701d406fed45cfe638"
+  "gitHead": "ae61027c62ffa7f7d70cfc50e43f333addfc74b6"
 }

package/src/dom-utils.d.ts

@@ -23,3 +23,8 @@ export function addValueToAttribute(element: HTMLElement, attr: string, value: s
  * If the value is the last one, the whole attribute is removed.
  */
 export function removeValueFromAttribute(element: HTMLElement, attr: string, value: string): void;
+
+/**
+ * Returns true if the given node is an empty text node, false otherwise.
+ */
+export function isEmptyTextNode(node: Node): boolean;

package/src/dom-utils.js

@@ -90,3 +90,13 @@ export function removeValueFromAttribute(element, attr, value) {
   }
   element.setAttribute(attr, serializeAttributeValue(values));
 }
+
+/**
+ * Returns true if the given node is an empty text node, false otherwise.
+ *
+ * @param {Node} node
+ * @return {boolean}
+ */
+export function isEmptyTextNode(node) {
+  return node.nodeType === Node.TEXT_NODE && node.textContent.trim() === '';
+}

package/src/element-mixin.js

@@ -39,7 +39,7 @@ const registered = new Set();
 export const ElementMixin = (superClass) =>
   class VaadinElementMixin extends DirMixin(superClass) {
     static get version() {
-      return '23.3.0-alpha1';
+      return '23.3.0-alpha2';
     }
 
     /** @protected */

package/src/tooltip-controller.d.ts

@@ -24,7 +24,7 @@ type TooltipPosition =
  */
 export class TooltipController extends SlotController {
   /**
-   * Object with properties passed to `textGenerator`
+   * Object with properties passed to `generator`
    * function to be used for generating tooltip text.
    */
   context: Record<string, unknown>;
@@ -52,7 +52,7 @@ export class TooltipController extends SlotController {
   target: HTMLElement;
 
   /**
-   * Set a context object to be used by text generator.
+   * Set a context object to be used by generator.
    */
   setContext(context: Record<string, unknown>): void;
 

package/src/tooltip-controller.js

@@ -39,7 +39,7 @@ export class TooltipController extends SlotController {
     }
 
     if (this.position !== undefined) {
-      tooltipNode.position = this.position;
+      this.__updatePosition(tooltipNode, this.position);
     }
 
     if (this.shouldShow !== undefined) {
@@ -48,7 +48,7 @@ export class TooltipController extends SlotController {
   }
 
   /**
-   * Set a context object to be used by text generator.
+   * Set a context object to be used by generator.
    * @param {object} context
    */
   setContext(context) {
@@ -93,10 +93,7 @@ export class TooltipController extends SlotController {
   setPosition(position) {
     this.position = position;
 
-    const tooltipNode = this.node;
-    if (tooltipNode) {
-      tooltipNode.position = position;
-    }
+    this.__updatePosition(this.node, position);
   }
 
   /**
@@ -125,4 +122,11 @@ export class TooltipController extends SlotController {
       tooltipNode.target = target;
     }
   }
+
+  /** @private */
+  __updatePosition(node, position) {
+    if (node && !node.hasAttribute('position')) {
+      node.position = position;
+    }
+  }
 }