@vaadin/charts 23.0.5 → 23.0.8

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/charts",
-  "version": "23.0.5",
+  "version": "23.0.8",
   "publishConfig": {
     "access": "public"
   },
@@ -34,9 +34,9 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "^23.0.5",
+    "@vaadin/component-base": "^23.0.8",
     "@vaadin/vaadin-license-checker": "^2.1.0",
-    "@vaadin/vaadin-themable-mixin": "^23.0.5",
+    "@vaadin/vaadin-themable-mixin": "^23.0.8",
     "highcharts": "9.2.2"
   },
   "devDependencies": {
@@ -44,5 +44,5 @@
     "@vaadin/testing-helpers": "^0.3.2",
     "sinon": "^9.2.4"
   },
-  "gitHead": "4cd2b11eb053d36fba9f0a8128da4e63984753e2"
+  "gitHead": "43fe9d95c8cd745adc7bef214c0097c47f4f83ed"
 }

package/src/vaadin-chart.js

@@ -62,6 +62,10 @@ export function deepMerge(target, source) {
   /* eslint-enable no-invalid-this */
 });
 
+// Init Highcharts global language defaults
+// No data message should be empty by default
+Highcharts.setOptions({ lang: { noData: '' } });
+
 /**
  * `<vaadin-chart>` is a Web Component for creating high quality charts.
  *
@@ -428,7 +432,6 @@ class Chart extends ResizeMixin(ElementMixin(ThemableMixin(PolymerElement))) {
        */
       emptyText: {
         type: String,
-        value: ' ',
         reflectToAttribute: true
       },
 
@@ -1032,13 +1035,7 @@ class Chart extends ResizeMixin(ElementMixin(ThemableMixin(PolymerElement))) {
     // Best effort to make chart display custom empty-text messages when series are removed.
     // This is needed because Highcharts currently doesn't react. A condition not catered for is
     // when all points are removed from all series without removing any series.
-    const isEmpty =
-      this.configuration.series.length === 0 ||
-      this.configuration.series.map((e) => e.data.length === 0).reduce((e1, e2) => e1 && e2, true);
-    if (isEmpty) {
-      this.configuration.hideNoData();
-      this.configuration.showNoData(this.emptyText);
-    }
+    this.__updateNoDataElement(this.configuration);
   }
 
   /** @private */
@@ -1664,8 +1661,21 @@ class Chart extends ResizeMixin(ElementMixin(ThemableMixin(PolymerElement))) {
         noData: emptyText
       }
     });
-    config.hideNoData();
-    config.showNoData(emptyText);
+    this.__updateNoDataElement(config);
+  }
+
+  /**
+   * Force the no data text element to become visible if the chart has no data.
+   * This is necessary in cases where Highcharts does not update the element
+   * automatically, for example when setting the language config
+   * @private
+   */
+  __updateNoDataElement(config) {
+    const isEmpty = config.series.every((e) => e.data.length === 0);
+    if (isEmpty) {
+      config.hideNoData();
+      config.showNoData(this.emptyText);
+    }
   }
 
   /** @private */