@vaadin/avatar-group 23.0.10 → 23.0.11

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/avatar-group",
-  "version": "23.0.10",
+  "version": "23.0.11",
   "publishConfig": {
     "access": "public"
   },
@@ -35,19 +35,19 @@
   ],
   "dependencies": {
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/avatar": "^23.0.10",
-    "@vaadin/component-base": "^23.0.10",
-    "@vaadin/item": "^23.0.10",
-    "@vaadin/list-box": "^23.0.10",
-    "@vaadin/vaadin-lumo-styles": "^23.0.10",
-    "@vaadin/vaadin-material-styles": "^23.0.10",
-    "@vaadin/vaadin-overlay": "^23.0.10",
-    "@vaadin/vaadin-themable-mixin": "^23.0.10"
+    "@vaadin/avatar": "^23.0.11",
+    "@vaadin/component-base": "^23.0.11",
+    "@vaadin/item": "^23.0.11",
+    "@vaadin/list-box": "^23.0.11",
+    "@vaadin/vaadin-lumo-styles": "^23.0.11",
+    "@vaadin/vaadin-material-styles": "^23.0.11",
+    "@vaadin/vaadin-overlay": "^23.0.11",
+    "@vaadin/vaadin-themable-mixin": "^23.0.11"
   },
   "devDependencies": {
     "@esm-bundle/chai": "^4.3.4",
     "@vaadin/testing-helpers": "^0.3.2",
     "sinon": "^9.2.1"
   },
-  "gitHead": "e8402a55ce0e823ae6da5c97486998cfd931b1d3"
+  "gitHead": "10838304fe6f5c98b838ec3a90bdcf49cbf4650b"
 }

package/src/vaadin-avatar-group-overlay.js

@@ -4,22 +4,7 @@
  * This program is available under Apache License Version 2.0, available at https://vaadin.com/license/
  */
 import { OverlayElement } from '@vaadin/vaadin-overlay/src/vaadin-overlay.js';
-import { css, registerStyles } from '@vaadin/vaadin-themable-mixin/vaadin-themable-mixin.js';
-
-registerStyles(
-  'vaadin-avatar-group-overlay',
-  css`
-    :host {
-      align-items: flex-start;
-      justify-content: flex-start;
-    }
-
-    :host([bottom-aligned]) {
-      justify-content: flex-end;
-    }
-  `,
-  { moduleId: 'vaadin-avatar-group-overlay-styles' },
-);
+import { PositionMixin } from '@vaadin/vaadin-overlay/src/vaadin-overlay-position-mixin.js';
 
 /**
  * An element used internally by `<vaadin-avatar-group>`. Not intended to be used separately.
@@ -27,7 +12,7 @@ registerStyles(
  * @extends OverlayElement
  * @private
  */
-class AvatarGroupOverlay extends OverlayElement {
+class AvatarGroupOverlay extends PositionMixin(OverlayElement) {
   static get is() {
     return 'vaadin-avatar-group-overlay';
   }

package/src/vaadin-avatar-group.js

@@ -133,7 +133,12 @@ class AvatarGroup extends ResizeMixin(ElementMixin(ThemableMixin(PolymerElement)
           aria-haspopup="listbox"
         ></vaadin-avatar>
       </div>
-      <vaadin-avatar-group-overlay id="overlay" opened="{{_opened}}" on-vaadin-overlay-close="_onVaadinOverlayClose">
+      <vaadin-avatar-group-overlay
+        id="overlay"
+        opened="{{_opened}}"
+        no-vertical-overlap
+        on-vaadin-overlay-close="_onVaadinOverlayClose"
+      >
         <template>
           <vaadin-avatar-group-list-box on-keydown="_onListKeyDown">
             <template is="dom-repeat" items="[[__computeExtraItems(items.*, __itemsInView, maxItemsVisible)]]">
@@ -279,28 +284,14 @@ class AvatarGroup extends ResizeMixin(ElementMixin(ThemableMixin(PolymerElement)
   ready() {
     super.ready();
 
-    this.__boundSetPosition = this.__setPosition.bind(this);
-
     this._overlayElement = this.shadowRoot.querySelector('vaadin-avatar-group-overlay');
+    this._overlayElement.positionTarget = this.$.overflow;
 
     afterNextRender(this, () => {
       this.__setItemsInView();
     });
   }
 
-  /**
-   * @param {string} name
-   * @param {?string} oldValue
-   * @param {?string} newValue
-   * @protected
-   */
-  attributeChangedCallback(name, oldValue, newValue) {
-    super.attributeChangedCallback(name, oldValue, newValue);
-    if (name === 'dir') {
-      this.__setPosition();
-    }
-  }
-
   /**
    * @return {!Array<!HTMLElement>}
    * @protected
@@ -347,7 +338,6 @@ class AvatarGroup extends ResizeMixin(ElementMixin(ThemableMixin(PolymerElement)
    */
   _onResize() {
     this.__setItemsInView();
-    this.__setPosition();
   }
 
   /** @private */
@@ -490,14 +480,11 @@ class AvatarGroup extends ResizeMixin(ElementMixin(ThemableMixin(PolymerElement)
       avatars.forEach((avatar) => avatar.removeAttribute('title'));
 
       this._menuElement.focus();
-      this.__setPosition();
-      window.addEventListener('scroll', this.__boundSetPosition, true);
     } else if (wasOpened) {
       this.$.overflow.focus();
       if (this._openedWithFocusRing) {
         this.$.overflow.setAttribute('focus-ring', '');
       }
-      window.removeEventListener('scroll', this.__boundSetPosition, true);
     }
     this.$.overflow.setAttribute('aria-expanded', opened === true);
   }
@@ -551,34 +538,6 @@ class AvatarGroup extends ResizeMixin(ElementMixin(ThemableMixin(PolymerElement)
 
     return Math.floor((this.$.container.offsetWidth - avatarWidth) / (avatarWidth + offset));
   }
-
-  /** @private */
-  __setPosition() {
-    if (!this._opened) {
-      return;
-    }
-    const btnRect = this.$.overflow.getBoundingClientRect();
-    const viewportHeight = Math.min(window.innerHeight, document.documentElement.clientHeight);
-    const bottomAlign = btnRect.top > (viewportHeight - btnRect.height) / 2;
-
-    const isRtl = this.getAttribute('dir') === 'rtl';
-
-    if (isRtl) {
-      this._overlayElement.style.right = document.documentElement.clientWidth - btnRect.right + 'px';
-    } else {
-      this._overlayElement.style.left = btnRect.left + 'px';
-    }
-
-    if (bottomAlign) {
-      this._overlayElement.setAttribute('bottom-aligned', '');
-      this._overlayElement.style.removeProperty('top');
-      this._overlayElement.style.bottom = viewportHeight - btnRect.top + 'px';
-    } else {
-      this._overlayElement.removeAttribute('bottom-aligned');
-      this._overlayElement.style.removeProperty('bottom');
-      this._overlayElement.style.top = btnRect.bottom + 'px';
-    }
-  }
 }
 
 customElements.define(AvatarGroup.is, AvatarGroup);

package/theme/lumo/vaadin-avatar-group.js

@@ -1,5 +1,6 @@
 import '@vaadin/avatar/theme/lumo/vaadin-avatar.js';
 import '@vaadin/item/theme/lumo/vaadin-item.js';
 import '@vaadin/list-box/theme/lumo/vaadin-list-box.js';
+import '@vaadin/vaadin-overlay/theme/lumo/vaadin-overlay.js';
 import './vaadin-avatar-group-styles.js';
 import '../../src/vaadin-avatar-group.js';

package/theme/material/vaadin-avatar-group.js

@@ -1,5 +1,6 @@
 import '@vaadin/avatar/theme/material/vaadin-avatar.js';
 import '@vaadin/item/theme/material/vaadin-item.js';
 import '@vaadin/list-box/theme/material/vaadin-list-box.js';
+import '@vaadin/vaadin-overlay/theme/material/vaadin-overlay.js';
 import './vaadin-avatar-group-styles.js';
 import '../../src/vaadin-avatar-group.js';