@vaadin/a11y-base 24.1.0-alpha8 → 24.1.0-beta1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vaadin/a11y-base",
-  "version": "24.1.0-alpha8",
+  "version": "24.1.0-beta1",
   "publishConfig": {
     "access": "public"
   },
@@ -32,7 +32,7 @@
   "dependencies": {
     "@open-wc/dedupe-mixin": "^1.3.0",
     "@polymer/polymer": "^3.0.0",
-    "@vaadin/component-base": "24.1.0-alpha8",
+    "@vaadin/component-base": "24.1.0-beta1",
     "lit": "^2.0.0"
   },
   "devDependencies": {
@@ -40,5 +40,5 @@
     "@vaadin/testing-helpers": "^0.4.0",
     "sinon": "^13.0.2"
   },
-  "gitHead": "1996d6f496a68cefc4c370c45a5d1995c3276c0b"
+  "gitHead": "f0ddb6576073a6af05ab29867bc5ec82e334f9d7"
 }

package/src/aria-id-reference.js

@@ -114,8 +114,8 @@ export function setAriaIDReference(target, attr, config = { newId: null, oldId:
   if (!fromUser && !!storedValues) {
     // If there's any stored values, it means the attribute is being handled by the user
     // Replace the "oldId" with "newId" on the stored values set and leave
-    storedValues.delete(oldId);
-    storedValues.add(newId);
+    oldId && storedValues.delete(oldId);
+    newId && storedValues.add(newId);
     return;
   }
 

package/src/field-aria-controller.js

@@ -19,16 +19,6 @@ export class FieldAriaController {
     this.__required = false;
   }
 
-  /**
-   * `true` if the target element is the host component itself, `false` otherwise.
-   *
-   * @return {boolean}
-   * @private
-   */
-  get __isGroupField() {
-    return this.__target === this.host;
-  }
-
   /**
    * Sets a target element to which ARIA attributes are added.
    *
@@ -37,7 +27,11 @@ export class FieldAriaController {
   setTarget(target) {
     this.__target = target;
     this.__setAriaRequiredAttribute(this.__required);
-    this.__setLabelIdToAriaAttribute(this.__labelId);
+    // We need to make sure that value in __labelId is stored
+    this.__setLabelIdToAriaAttribute(this.__labelId, this.__labelId);
+    if (this.__labelIdFromUser != null) {
+      this.__setLabelIdToAriaAttribute(this.__labelIdFromUser, this.__labelIdFromUser, true);
+    }
     this.__setErrorIdToAriaAttribute(this.__errorId);
     this.__setHelperIdToAriaAttribute(this.__helperId);
     this.setAriaLabel(this.__label);
@@ -146,10 +140,7 @@ export class FieldAriaController {
    * @private
    */
   __setErrorIdToAriaAttribute(errorId, oldErrorId) {
-    // For groups, add all IDs to aria-labelledby rather than aria-describedby -
-    // that should guarantee that it's announced when the group is entered.
-    const ariaAttribute = this.__isGroupField ? 'aria-labelledby' : 'aria-describedby';
-    setAriaIDReference(this.__target, ariaAttribute, { newId: errorId, oldId: oldErrorId, fromUser: false });
+    setAriaIDReference(this.__target, 'aria-describedby', { newId: errorId, oldId: oldErrorId, fromUser: false });
   }
 
   /**
@@ -158,10 +149,7 @@ export class FieldAriaController {
    * @private
    */
   __setHelperIdToAriaAttribute(helperId, oldHelperId) {
-    // For groups, add all IDs to aria-labelledby rather than aria-describedby -
-    // that should guarantee that it's announced when the group is entered.
-    const ariaAttribute = this.__isGroupField ? 'aria-labelledby' : 'aria-describedby';
-    setAriaIDReference(this.__target, ariaAttribute, { newId: helperId, oldId: oldHelperId, fromUser: false });
+    setAriaIDReference(this.__target, 'aria-describedby', { newId: helperId, oldId: oldHelperId, fromUser: false });
   }
 
   /**

package/src/focus-utils.js

@@ -148,7 +148,9 @@ export function isElementHidden(element) {
   // `offsetParent` is `null` when the element itself
   // or one of its ancestors is hidden with `display: none`.
   // https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/offsetParent
-  if (element.offsetParent === null) {
+  // However `offsetParent` is also null when the element is using fixed
+  // positioning, so additionally check if the element takes up layout space.
+  if (element.offsetParent === null && element.clientWidth === 0 && element.clientHeight === 0) {
     return true;
   }