@uxland/primary-shell 7.29.3 → 7.29.5

package/dist/primary/shell/src/api/pdf-viewer-manager/pdf-viewer-manager.d.ts

@@ -15,10 +15,8 @@ export declare class PdfViewerManager {
     constructor(broker: PrimariaBroker, notificationService: PrimariaNotificationService);
     private pdfs;
     private activePdf;
-    private hasBeenActivated;
     add(pdfName: string, data: PdfData): void;
     delete(pdfId: string): void;
     getPdfs(): IPdfDocument[];
-    private registerNavButton;
 }
 export declare const createPdfViewerManager: (broker: PrimariaBroker, notificationService: PrimariaNotificationService) => PdfViewerManager;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@uxland/primary-shell",
-  "version": "7.29.3",
+  "version": "7.29.5",
   "description": "Primaria Shell",
   "author": "UXLand <dev@uxland.es>",
   "homepage": "https://github.com/uxland/harmonix/tree/app#readme",

package/src/UI/internal-views/handle-views.ts

@@ -1,5 +1,5 @@
 import { shellApi } from "../../api/api";
-import { registerPDFVisorMainView } from "../../api/pdf-viewer-manager/handle-views";
+import { registerPDFVisorMainView, registerPdfViewerNavItem } from "../../api/pdf-viewer-manager/handle-views";
 import { registerAdministrativeNavMenuViews } from "./administrative-nav-menu";
 import { registerDoctorNavMenuViews } from "./doctor-nav-menu";
 import { registerDoctorQuickActionViews } from "./doctor-quick-action-menu";
@@ -8,8 +8,13 @@ const registerMainViews = () => {
   registerPDFVisorMainView();
 };
 
+const registerPdfViewerNavButton = () => {
+  registerPdfViewerNavItem();
+};
+
 export const useInternalViews = () => {
   registerMainViews();
+  registerPdfViewerNavButton();
   const isUserRoleAdministrative = shellApi.userManager.isUserRoleAdministrative();
   if (isUserRoleAdministrative) registerAdministrativeNavMenuViews();
   else {

package/src/api/pdf-viewer-manager/handle-views.ts

@@ -3,12 +3,11 @@ import { translate } from "../../locales";
 import { PrimariaNavItem } from "../../UI/shared-components/primaria-nav-item/primaria-nav-item";
 import { shellApi } from "../api";
 import { PdfVisor } from "./pdf-visor/pdf-visor";
-import { showNavItemTooltip } from "../../UI/components/navigation-tooltip/tooltip-manager";
-import { primariaShellId } from "../../constants";
 
 export const registerPdfViewerNavItem = () => {
   shellApi.regionManager.registerView(shellApi.regionManager.regions.shell.navigationMenu, {
     id: pdfViewerId,
+    sortHint: "0110",
     factory: () => {
       const menuItem = new PrimariaNavItem({
         icon: "picture_as_pdf",
@@ -20,12 +19,6 @@ export const registerPdfViewerNavItem = () => {
       return Promise.resolve(menuItem);
     },
   });
-
-  // Show tooltip when PDF viewer is registered
-  setTimeout(() => {
-    const navItemKey = `${primariaShellId}::${pdfViewerId}`;
-    showNavItemTooltip(navItemKey, translate("pdfManager.tooltipMessage"));
-  }, 100);
 };
 
 export const registerPDFVisorMainView = () => {

package/src/api/pdf-viewer-manager/pdf-viewer-manager.test.ts

@@ -36,9 +36,9 @@ describe("PdfViewerManager", () => {
       success: vi.fn(),
     };
 
-    manager = createPdfViewerManager(broker, notificationService);
-
     vi.clearAllMocks();
+
+    manager = createPdfViewerManager(broker, notificationService);
   });
 
   it("should show error if neither url nor b64 is provided", () => {
@@ -120,16 +120,19 @@ describe("PdfViewerManager", () => {
     vi.useRealTimers();
   });
 
-  it("should call registerNavButton only once", () => {
+  it("should not call registerNavButton when adding PDFs", () => {
+    // registerPdfViewerNavItem is now called from UI/internal-views, not from the manager
     manager.add("Doc1", { url: "u" });
     manager.add("Doc2", { url: "u2" });
 
-    expect(registerPdfViewerNavItem).toHaveBeenCalledTimes(1);
+    expect(registerPdfViewerNavItem).not.toHaveBeenCalled();
   });
 
   it("should delete a pdf and publish deletion event", () => {
     manager.add("Doc1", { url: "u" });
-    const id = manager.getPdfs()[0].id;
+    const pdfs = manager.getPdfs();
+    expect(pdfs.length).toBeGreaterThan(0);
+    const id = pdfs[0]!.id;
 
     manager.delete(id);
 
@@ -139,7 +142,9 @@ describe("PdfViewerManager", () => {
 
   it("should clear activePdf if deleted", () => {
     manager.add("Doc1", { url: "u" });
-    const id = manager.getPdfs()[0].id;
+    const pdfs = manager.getPdfs();
+    expect(pdfs.length).toBeGreaterThan(0);
+    const id = pdfs[0]!.id;
 
     // simula que esté activo
     (manager as any).activePdf = { id } as any;

package/src/api/pdf-viewer-manager/pdf-viewer-manager.ts

@@ -1,6 +1,5 @@
 import { generateId } from "@primaria/plugins-core";
 import { customElement } from "lit/decorators.js";
-import { registerPdfViewerNavItem } from "./handle-views";
 import { translate } from "../../locales";
 import { PrimariaBroker } from "../broker/primaria-broker";
 import { PrimariaNotificationService } from "../notification-service/notification-service";
@@ -37,7 +36,6 @@ export class PdfViewerManager {
 
   private pdfs: IPdfDocument[] = [];
   private activePdf: IPdfDocument | null = null;
-  private hasBeenActivated = false;
 
   add(pdfName: string, data: PdfData) {
     const id = generateId();
@@ -51,10 +49,6 @@ export class PdfViewerManager {
       this.notificationService.error(translate("pdfManager.duplicatedSource"));
       return;
     }
-    if (!this.hasBeenActivated) {
-      this.registerNavButton();
-      this.hasBeenActivated = true;
-    }
     if (this.pdfs.some((p) => p.pdfName === pdf.pdfName)) {
       this.notificationService.warning(translate("pdfManager.alreadyUploaded"));
     } else {
@@ -82,10 +76,6 @@ export class PdfViewerManager {
   getPdfs(): IPdfDocument[] {
     return this.pdfs;
   }
-
-  private registerNavButton() {
-    registerPdfViewerNavItem();
-  }
 }
 
 export const createPdfViewerManager = (broker: PrimariaBroker, notificationService: PrimariaNotificationService) =>