@uxland/primary-shell 6.0.3 → 6.0.5

package/dist/internal-plugins/activity-history/activity-history-item/filter/up-filters/handle-add-up-options-from-item.d.ts

@@ -1,4 +1,13 @@
 import { Store } from '@reduxjs/toolkit';
 import { IActivityHistoryItem } from '../../domain/model';
 
+export declare const getUpFilter: (items: IActivityHistoryItem[]) => {
+    id: string;
+    title: string;
+    values: {
+        label: any;
+        value: any;
+    }[];
+    enabledValues: never[];
+} | undefined;
 export declare const handleAddUpFilter: (items: IActivityHistoryItem[], store: Store) => void;

package/dist/internal-plugins/activity-history/activity-history-item/filter/up-filters/handle-add-up-options-from-item.test.d.ts

@@ -0,0 +1 @@
+export {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@uxland/primary-shell",
-  "version": "6.0.3",
+  "version": "6.0.5",
   "description": "Primaria Shell",
   "author": "UXLand <dev@uxland.es>",
   "homepage": "https://github.com/uxland/harmonix/tree/app#readme",

package/src/features/clinical-monitoring/component/styles.css

@@ -14,6 +14,7 @@
   #widgets-sidebar-region {
     width: 25%;
     border-left: 1px solid rgb(189, 189, 189);
+    overflow: auto;
   }
   .content {
     flex: 1;
@@ -23,14 +24,13 @@
       display: grid;
       grid-template-columns: repeat(3, 1fr);
       gap: 24px;
-      padding: 24px 40px;
+      padding: 24px 24px 0 24px;
     }
     #content-widgets-region {
       flex: 1;
       min-height: 1px;
       height: 100%;
-      padding-inline: 40px;
-      padding-bottom: 24px;
+      padding: 24px;
     }
   }
 }
@@ -47,6 +47,7 @@
       border-left: none;
       padding-inline: 40px;
       padding-bottom: 24px;
+      overflow: auto;
     }
     .content {
       #header-widgets-region {

package/src/internal-plugins/activity-history/activity-history-item/filter/up-filters/handle-add-up-options-from-item.test.ts

@@ -0,0 +1,237 @@
+import { describe, it, expect, vi, beforeEach } from 'vitest';
+import { getUpFilter } from "./handle-add-up-options-from-item";
+
+// Mock de las dependencias
+const mockMapArrayToLabelValue = vi.fn((arr, descField, idField) => 
+  arr.map(item => ({ 
+    label: item[descField] || item[idField], // Usa el ID como fallback si description está vacía
+    value: item[idField] 
+  }))
+);
+
+vi.mock('./path/to/your/utils', () => ({
+  mapArrayToLabelValue: mockMapArrayToLabelValue,
+}));
+
+const upFilterId = 'history-up'; // Define el valor que uses en tu código
+
+describe('getUpFilter', () => {
+  beforeEach(() => {
+    vi.clearAllMocks();
+  });
+  it('debe retornar filtro cuando hay UPs válidos con ID', () => {
+    const items = [
+      {
+        id: '1',
+        up: [
+          { id: 'up1', description: 'UP 1' },
+          { id: 'up2', description: 'UP 2' },
+        ],
+      },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toEqual({
+      id: upFilterId,
+      title: 'UP',
+      values: [
+        { label: 'UP 1', value: 'up1' },
+        { label: 'UP 2', value: 'up2' },
+      ],
+      enabledValues: [],
+    });
+  });
+
+  it('debe permitir UPs con description vacía pero ID válido', () => {
+    const items = [
+      {
+        id: '1',
+        up: [
+          { id: 'up1', description: '' },
+          { id: 'up2', description: null },
+          { id: 'up3', description: undefined },
+          { id: 'up4', description: 'UP 4' },
+        ],
+      },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toEqual({
+      id: upFilterId,
+      title: 'UP',
+      values: [
+        { label: 'up1', value: 'up1' },
+        { label: 'up2', value: 'up2' },
+        { label: 'up3', value: 'up3' },
+        { label: 'UP 4', value: 'up4' },
+      ],
+      enabledValues: [],
+    });
+  });
+
+  it('no debe incluir UPs con ID vacío, null, undefined o solo espacios', () => {
+    const items = [
+      {
+        id: '1',
+        up: [
+          { id: '', description: 'UP con ID vacío' },
+          { id: null, description: 'UP con ID null' },
+          { id: undefined, description: 'UP con ID undefined' },
+          { id: '   ', description: 'UP con ID solo espacios' },
+          { id: '\t\n  ', description: 'UP con ID espacios y tabs' },
+          { id: 'up1', description: 'UP válido' },
+        ],
+      },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toEqual({
+      id: upFilterId,
+      title: 'UP',
+      values: [{ label: 'UP válido', value: 'up1' }],
+      enabledValues: [],
+    });
+  });
+
+  it('debe filtrar UPs duplicados por ID', () => {
+    const items = [
+      {
+        id: '1',
+        up: [
+          { id: 'up1', description: 'UP 1 - Primera aparición' },
+          { id: 'up2', description: 'UP 2' },
+        ],
+      },
+      {
+        id: '2',
+        up: [
+          { id: 'up1', description: 'UP 1 - Duplicado' },
+          { id: 'up3', description: 'UP 3' },
+        ],
+      },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toEqual({
+      id: upFilterId,
+      title: 'UP',
+      values: [
+        { label: 'UP 1 - Primera aparición', value: 'up1' },
+        { label: 'UP 2', value: 'up2' },
+        { label: 'UP 3', value: 'up3' },
+      ],
+      enabledValues: [],
+    });
+  });
+
+  it('debe manejar items sin propiedad up', () => {
+    const items = [
+      { id: '1' },
+      { id: '2', up: null },
+      { id: '3', up: undefined },
+      { id: '4', up: [{ id: 'up1', description: 'UP 1' }] },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toEqual({
+      id: upFilterId,
+      title: 'UP',
+      values: [{ label: 'UP 1', value: 'up1' }],
+      enabledValues: [],
+    });
+  });
+
+  it('debe manejar array up vacío', () => {
+    const items = [
+      { id: '1', up: [] },
+      { id: '2', up: [{ id: 'up1', description: 'UP 1' }] },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toEqual({
+      id: upFilterId,
+      title: 'UP',
+      values: [{ label: 'UP 1', value: 'up1' }],
+      enabledValues: [],
+    });
+  });
+
+  it('debe retornar undefined cuando no hay UPs válidos', () => {
+    const items = [
+      {
+        id: '1',
+        up: [
+          { id: '', description: 'UP con ID vacío' },
+          { id: null, description: 'UP con ID null' },
+        ],
+      },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toBeUndefined();
+  });
+
+  it('debe retornar undefined cuando items está vacío', () => {
+    const items = [];
+
+    const result = getUpFilter(items);
+
+    expect(result).toBeUndefined();
+  });
+
+  it('debe manejar objetos up que son null o undefined en el array', () => {
+    const items = [
+      {
+        id: '1',
+        up: [
+          null,
+          undefined,
+          { id: 'up1', description: 'UP válido' },
+          null,
+        ],
+      },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toEqual({
+      id: upFilterId,
+      title: 'UP',
+      values: [{ label: 'UP válido', value: 'up1' }],
+      enabledValues: [],
+    });
+  });
+
+  it('debe rechazar IDs que son solo espacios en blanco', () => {
+    const items = [
+      {
+        id: '1',
+        up: [
+          { id: '   ', description: 'UP con ID solo espacios' },
+          { id: '\t\n  \r', description: 'UP con tabs y saltos' },
+          { id: 'up1', description: 'UP válido' },
+          { id: ' up2 ', description: 'UP válido con espacios al inicio/final' },
+        ],
+      },
+    ];
+
+    const result = getUpFilter(items);
+
+    expect(result).toEqual({
+      id: upFilterId,
+      title: 'UP',
+      values: [
+        { label: 'UP válido', value: 'up1' },
+        { label: 'UP válido con espacios al inicio/final', value: ' up2 ' },
+      ],
+      enabledValues: [],
+    });
+  });
+});

package/src/internal-plugins/activity-history/activity-history-item/filter/up-filters/handle-add-up-options-from-item.ts

@@ -4,8 +4,11 @@ import { IActivityHistoryItem } from "../../domain/model";
 import { upFilterId } from "../model";
 import { addUpFilters } from "./add/actions";
 
-export const handleAddUpFilter = (items: IActivityHistoryItem[], store: Store) => {
-  const allUps = items.flatMap((item) => item.up ?? []).filter((up, index, self) => index === self.findIndex((u) => u.id === up.id));
+export const getUpFilter = (items: IActivityHistoryItem[]) => {
+  const allUps = items
+    .flatMap((item) => item.up ?? [])
+    .filter((up) => up?.id?.trim()) // Filtrar UPs que tienen ID válido (no vacío ni solo espacios)
+    .filter((up, index, self) => index === self.findIndex((u) => u.id === up.id)); // Filtrar duplicados
 
   if (allUps.length > 0) {
     const newUpFilter = {
@@ -15,6 +18,12 @@ export const handleAddUpFilter = (items: IActivityHistoryItem[], store: Store) =
       enabledValues: [],
     };
 
-    store.dispatch(addUpFilters(newUpFilter));
+    return newUpFilter;
   }
 };
+
+export const handleAddUpFilter = (items: IActivityHistoryItem[], store: Store) => {
+  const newUpFilter = getUpFilter(items);
+  if (newUpFilter)
+    store.dispatch(addUpFilters(newUpFilter));
+};