@uwdata/mosaic-sql 0.16.1 → 0.16.2

package/dist/types/visit/rewrite.d.ts

@@ -1,6 +1,6 @@
 /**
  * Rewrite a SQL expression, based on a map of nodes to replace.
- * This method updates the expression in place.
+ * This method copies nodes as needed; it does not modify the input node.
  * @param {ExprNode} node The root AST node of the expression.
  * @param {Map<ExprNode, ExprNode>} map The rewrite map.
  *  When encountered, key nodes are replaced by value nodes.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@uwdata/mosaic-sql",
-  "version": "0.16.1",
+  "version": "0.16.2",
   "description": "SQL query construction and analysis.",
   "keywords": [
     "sql",
@@ -27,5 +27,5 @@
     "tsc": "tsc -p jsconfig.json",
     "prepublishOnly": "npm run test && npm run lint && npm run build"
   },
-  "gitHead": "e12af9927b0a35a0e3194850ef569d0d24a022ce"
+  "gitHead": "26d2719f4bcab471d2831145e1f03f39f3509869"
 }

package/src/visit/rewrite.js

@@ -4,7 +4,7 @@ import { recurse } from './recurse.js';
 
 /**
  * Rewrite a SQL expression, based on a map of nodes to replace.
- * This method updates the expression in place.
+ * This method copies nodes as needed; it does not modify the input node.
  * @param {ExprNode} node The root AST node of the expression.
  * @param {Map<ExprNode, ExprNode>} map The rewrite map.
  *  When encountered, key nodes are replaced by value nodes.
@@ -16,18 +16,30 @@ export function rewrite(node, map) {
   } else if (isNode(node)) {
     const props = recurse[node.type];
     const n = props?.length ?? 0;
-    for (let i = 0; i < n; ++i) {
-      const prop = props[i];
-      const child = node[prop];
-      if (Array.isArray(child)) {
-        const m = child.length;
-        for (let j = 0; j < m; ++j) {
-          child[j] = rewrite(child[j], map);
+    if (n > 0) {
+      node = cloneNode(node);
+      for (let i = 0; i < n; ++i) {
+        const prop = props[i];
+        const child = node[prop];
+        if (Array.isArray(child)) {
+          const m = child.length;
+          for (let j = 0; j < m; ++j) {
+            child[j] = rewrite(child[j], map);
+          }
+        } else if (child) {
+          node[prop] = rewrite(child, map);
         }
-      } else if (child) {
-        node[prop] = rewrite(child, map);
       }
     }
   }
   return node;
 }
+
+// TODO: consider typed node.clone() methods
+function cloneNode(node) {
+  const clone = new node.constructor();
+  for (const key in node) {
+    clone[key] = node[key];
+  }
+  return clone;
+}