@usequeek/theme-check 0.5.0 → 0.5.1

package/dist/context.d.ts

@@ -9,7 +9,7 @@ export declare function localEnv(dir: string, cwd?: string): CheckEnv;
  * the theme's own project — the kit the developer installed, not ours.
  */
 export declare function loadContext(themeDir: string, env?: Partial<CheckEnv>): Promise<ThemeContext>;
-/** Every .ts/.tsx under a theme, for the whole-tree scans. */
+/** Every JS/TS source file under a theme, for the whole-tree scans. */
 export declare function themeSourceFiles(dir: string): string[];
 /**
  * Load a module of the kit the theme's project installed. The kit ships

package/dist/context.js

@@ -80,13 +80,13 @@ export async function loadContext(themeDir, env = {}) {
         read,
     };
 }
-/** Every .ts/.tsx under a theme, for the whole-tree scans. */
+/** Every JS/TS source file under a theme, for the whole-tree scans. */
 export function themeSourceFiles(dir) {
     return readdirSync(dir, { withFileTypes: true }).flatMap((entry) => {
         const full = join(dir, entry.name);
         if (entry.isDirectory())
             return entry.name === 'node_modules' ? [] : themeSourceFiles(full);
-        return /\.tsx?$/.test(entry.name) ? [full] : [];
+        return /\.[mc]?[jt]sx?$/.test(entry.name) ? [full] : [];
     });
 }
 /**

package/dist/index.d.ts

@@ -13,5 +13,5 @@ export { TEMPLATE_COPY_PLACES, copyViolations, isTestimonialSection, storeNameFo
 export { PRIMARY_DEMO_ID, DEMO_ID_FORMAT, demoFilesOf } from './utils/theme-demos.js';
 export { designsOf, groupTemplates, mainTemplateKey, composeLabel, type DesignDeclaration, type ThemeDesignsConfig, type ThemeDesign, type ThemeTemplate, } from './utils/theme-designs.js';
 export { TEMPLATE_DESCRIPTION_MAX, screenshotFile, sectionStyle, sectionCopy, declaredFieldsByVariant } from './utils/theme-templates.js';
-export { STATIC_RULES, moduleContractRule, structureRule, demoStoreRule, demoStoresRule, demoArtRule, codeQualityRule, sdkBoundaryRule, selectionMetadataRule, demoCompletenessRule, subscribeScopeRule, demoBlockTypesRule, compositionVariantsRule, identityRule, productMetafieldsRule, poweredByRule, fontsSelfHostedRule, templateDescriptionRule, templateScreenshotRule, templateChromeRule, templateStyleRule, templateBusinessRule, templateVersionsRule, templateDesignsRule, TEMPLATE_DESIGNS_MAX, templatePagesRule, templateCopyRule, vendorFactsRule, placeholderContentRule, frameworkImport, STARTER_PLACEHOLDER_IMAGES, } from './rules/static.js';
+export { STATIC_RULES, moduleContractRule, structureRule, demoStoreRule, demoStoresRule, demoArtRule, codeQualityRule, sdkBoundaryRule, selectionMetadataRule, demoCompletenessRule, subscribeScopeRule, demoBlockTypesRule, compositionVariantsRule, identityRule, productMetafieldsRule, poweredByRule, fontsSelfHostedRule, templateDescriptionRule, templateScreenshotRule, templateChromeRule, templateStyleRule, templateBusinessRule, templateVersionsRule, templateDesignsRule, TEMPLATE_DESIGNS_MAX, templatePagesRule, templateCopyRule, vendorFactsRule, placeholderContentRule, frameworkImport, moduleSpecifiers, STARTER_PLACEHOLDER_IMAGES, } from './rules/static.js';
 export { ANALYSIS_RULES, variantParityRule, fieldParityRule, designTokensRule } from './rules/analysis.js';

package/dist/index.js

@@ -17,5 +17,5 @@ export { TEMPLATE_DESCRIPTION_MAX, screenshotFile, sectionStyle, sectionCopy, de
 // Per-kind rule arrays and the individual rule constants, for rule-level unit
 // tests that want to run one rule against a hand-built ThemeContext instead
 // of a whole theme directory through checkTheme().
-export { STATIC_RULES, moduleContractRule, structureRule, demoStoreRule, demoStoresRule, demoArtRule, codeQualityRule, sdkBoundaryRule, selectionMetadataRule, demoCompletenessRule, subscribeScopeRule, demoBlockTypesRule, compositionVariantsRule, identityRule, productMetafieldsRule, poweredByRule, fontsSelfHostedRule, templateDescriptionRule, templateScreenshotRule, templateChromeRule, templateStyleRule, templateBusinessRule, templateVersionsRule, templateDesignsRule, TEMPLATE_DESIGNS_MAX, templatePagesRule, templateCopyRule, vendorFactsRule, placeholderContentRule, frameworkImport, STARTER_PLACEHOLDER_IMAGES, } from './rules/static.js';
+export { STATIC_RULES, moduleContractRule, structureRule, demoStoreRule, demoStoresRule, demoArtRule, codeQualityRule, sdkBoundaryRule, selectionMetadataRule, demoCompletenessRule, subscribeScopeRule, demoBlockTypesRule, compositionVariantsRule, identityRule, productMetafieldsRule, poweredByRule, fontsSelfHostedRule, templateDescriptionRule, templateScreenshotRule, templateChromeRule, templateStyleRule, templateBusinessRule, templateVersionsRule, templateDesignsRule, TEMPLATE_DESIGNS_MAX, templatePagesRule, templateCopyRule, vendorFactsRule, placeholderContentRule, frameworkImport, moduleSpecifiers, STARTER_PLACEHOLDER_IMAGES, } from './rules/static.js';
 export { ANALYSIS_RULES, variantParityRule, fieldParityRule, designTokensRule } from './rules/analysis.js';

package/dist/rules/static.d.ts

@@ -16,6 +16,13 @@ export declare const codeQualityRule: Rule;
  * import Next, a theme may not.
  */
 export declare function frameworkImport(source: string): string | null;
+/**
+ * Every static module specifier in a source file: `import … from`,
+ * `export … from`, side-effect `import '…'`, dynamic `import('…')` and
+ * `require('…')`. Parsed like frameworkImport — regexes, not a bundler — so
+ * a theme whose module graph will not load still gets checked.
+ */
+export declare function moduleSpecifiers(source: string): string[];
 export declare const sdkBoundaryRule: Rule;
 /**
  * The ThemeModule shape (Layout, Header, Footer, blocks, getBlock, pages…) is

package/dist/rules/static.js

@@ -1,4 +1,4 @@
-import { join, relative } from 'node:path';
+import { dirname, join, relative, resolve, sep } from 'node:path';
 import { readdirSync, existsSync, readFileSync } from 'node:fs';
 import { foreignImageRefs } from '../utils/theme-demo-images.js';
 import { DEMO_ID_FORMAT, PRIMARY_DEMO_ID } from '../utils/theme-demos.js';
@@ -308,9 +308,29 @@ export function frameworkImport(source) {
     const match = source.match(/(?:\bfrom\s*|\bimport\s*\(?\s*|\brequire\s*\(\s*)['"](next(?:\/[\w./-]+)?)['"]/);
     return match ? match[1] : null;
 }
+/**
+ * Every static module specifier in a source file: `import … from`,
+ * `export … from`, side-effect `import '…'`, dynamic `import('…')` and
+ * `require('…')`. Parsed like frameworkImport — regexes, not a bundler — so
+ * a theme whose module graph will not load still gets checked.
+ */
+export function moduleSpecifiers(source) {
+    const found = [];
+    const patterns = [
+        /(?:import|export)[^'"]*?from\s*['"]([^'"]+)['"]/g,
+        /\bimport\s*['"]([^'"]+)['"]/g,
+        /\bimport\s*\(\s*['"]([^'"]+)['"]\s*\)/g,
+        /\brequire\s*\(\s*['"]([^'"]+)['"]\s*\)/g,
+    ];
+    for (const pattern of patterns) {
+        for (const match of source.matchAll(pattern))
+            found.push(match[1]);
+    }
+    return found;
+}
 export const sdkBoundaryRule = {
     id: 'theme/core-boundary',
-    summary: 'No SDK or framework imports, no direct API calls, no store mutations',
+    summary: 'No SDK or framework imports, no app-code imports or escapes, no direct API calls, no store mutations',
     kind: 'static',
     run(context) {
         const findings = [];
@@ -334,6 +354,33 @@ export const sdkBoundaryRule = {
                     docs: `${context.env.docs}#what-themes-must-not-do`,
                 }));
             }
+            // A theme is a self-contained folder: it imports packages and its own
+            // files, never the app around it. `@/` only resolves inside the
+            // storefront repo, and a relative import past the theme root only
+            // resolves there too — both break in a developer's `npm create`
+            // project and in `theme:pull`.
+            const root = resolve(context.dir);
+            for (const spec of moduleSpecifiers(source)) {
+                if (spec.startsWith('@/')) {
+                    findings.push(finding(context, 'theme/core-boundary', 'reject', {
+                        where,
+                        found: `imports app code ('${spec}')`,
+                        fix: "Move the code into the theme's own folder, or import it from '@usequeek/theme-kit'.",
+                        docs: `${context.env.docs}#what-themes-must-not-do`,
+                    }));
+                }
+                else if (spec.startsWith('.')) {
+                    const resolved = resolve(dirname(path), spec);
+                    if (resolved !== root && !resolved.startsWith(root + sep)) {
+                        findings.push(finding(context, 'theme/core-boundary', 'reject', {
+                            where,
+                            found: `relative import '${spec}' escapes the theme (resolves to ${relative(root, resolved)})`,
+                            fix: "Move the code into the theme's own folder, or import it from '@usequeek/theme-kit'.",
+                            docs: `${context.env.docs}#what-themes-must-not-do`,
+                        }));
+                    }
+                }
+            }
             if (/\b(?:fetch|axios)\s*\(\s*['"`]https?:/.test(source)) {
                 findings.push(finding(context, 'theme/core-boundary', 'reject', {
                     where,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@usequeek/theme-check",
-  "version": "0.5.0",
+  "version": "0.5.1",
   "description": "The rules a Queek storefront theme is checked against, as a library.",
   "license": "MIT",
   "type": "module",