@usequeek/theme-check 0.3.2 → 0.3.5

package/dist/index.d.ts

@@ -11,3 +11,5 @@ export { BUSINESS_KEYS, SERVICE_SLUGS, CATALOGUE, SUBCATEGORIES, isBusinessKey,
 export { TEMPLATE_COPY_PLACES, copyViolations, isTestimonialSection, storeNameForms } from './utils/template-copy.js';
 export { PRIMARY_DEMO_ID, DEMO_ID_FORMAT, demoFilesOf } from './utils/theme-demos.js';
 export { TEMPLATE_DESCRIPTION_MAX, screenshotFile, sectionStyle, sectionCopy, declaredFieldsByVariant } from './utils/theme-templates.js';
+export { STATIC_RULES, moduleContractRule, structureRule, demoStoreRule, demoStoresRule, demoArtRule, codeQualityRule, sdkBoundaryRule, selectionMetadataRule, demoCompletenessRule, subscribeScopeRule, demoBlockTypesRule, identityRule, productMetafieldsRule, poweredByRule, fontsSelfHostedRule, templateDescriptionRule, templateScreenshotRule, templateChromeRule, templateStyleRule, templateBusinessRule, templateVersionsRule, templatePagesRule, templateCopyRule, vendorFactsRule, placeholderContentRule, frameworkImport, STARTER_PLACEHOLDER_IMAGES, } from './rules/static.js';
+export { ANALYSIS_RULES, variantParityRule, fieldParityRule, designTokensRule } from './rules/analysis.js';

package/dist/index.js

@@ -10,3 +10,8 @@ export { BUSINESS_KEYS, SERVICE_SLUGS, CATALOGUE, SUBCATEGORIES, isBusinessKey,
 export { TEMPLATE_COPY_PLACES, copyViolations, isTestimonialSection, storeNameForms } from './utils/template-copy.js';
 export { PRIMARY_DEMO_ID, DEMO_ID_FORMAT, demoFilesOf } from './utils/theme-demos.js';
 export { TEMPLATE_DESCRIPTION_MAX, screenshotFile, sectionStyle, sectionCopy, declaredFieldsByVariant } from './utils/theme-templates.js';
+// Per-kind rule arrays and the individual rule constants, for rule-level unit
+// tests that want to run one rule against a hand-built ThemeContext instead
+// of a whole theme directory through checkTheme().
+export { STATIC_RULES, moduleContractRule, structureRule, demoStoreRule, demoStoresRule, demoArtRule, codeQualityRule, sdkBoundaryRule, selectionMetadataRule, demoCompletenessRule, subscribeScopeRule, demoBlockTypesRule, identityRule, productMetafieldsRule, poweredByRule, fontsSelfHostedRule, templateDescriptionRule, templateScreenshotRule, templateChromeRule, templateStyleRule, templateBusinessRule, templateVersionsRule, templatePagesRule, templateCopyRule, vendorFactsRule, placeholderContentRule, frameworkImport, STARTER_PLACEHOLDER_IMAGES, } from './rules/static.js';
+export { ANALYSIS_RULES, variantParityRule, fieldParityRule, designTokensRule } from './rules/analysis.js';

package/dist/rules/static.js

@@ -7,6 +7,10 @@ import { copyViolations, isTestimonialSection } from '../utils/template-copy.js'
 import { BUSINESS_KEYS, SERVICE_SLUGS, isBusinessKey } from '../utils/business-vocabulary.js';
 import { themeSourceFiles } from '../context.js';
 import { finding } from '../types.js';
+/** A theme file as a finding names it: relative to the theme, with `/` on every OS (Windows gave `styles\type.css`). */
+function themePath(context, path) {
+    return relative(context.dir, path).replace(/\\/g, '/');
+}
 const REQUIRED_FILES = [
     'index.ts', 'manifest.ts', 'theme.config.ts',
     'layout.tsx', 'header.tsx', 'footer.tsx',
@@ -250,7 +254,7 @@ export const codeQualityRule = {
             // mention in a docblock, and three themes do.
             if (path.endsWith('.tsx') && /<img[\s>]/.test(stripComments(source))) {
                 findings.push(finding(context, 'theme/code-quality', 'reject', {
-                    where: relative(context.dir, path),
+                    where: themePath(context, path),
                     found: 'renders a raw <img>',
                     fix: "Use <Image /> from @usequeek/theme-kit/components/image. It carries the broken-image fallback, the Smart Placeholder for empty slots, and the srcset the backend ships as image_variants — a raw <img> silently gives up all three.",
                     docs: `${context.env.docs}#what-themes-must-not-do`,
@@ -259,7 +263,7 @@ export const codeQualityRule = {
             const match = source.match(/from '(?:@\/)?themes\/(?!.*\/)?([\w-]+)/);
             if (match && match[1] !== context.slug) {
                 findings.push(finding(context, 'theme/code-quality', 'reject', {
-                    where: relative(context.dir, path),
+                    where: themePath(context, path),
                     found: `imports from the "${match[1]}" theme`,
                     fix: 'A theme is self-contained. Copy what you need into your own folder, or ask for it to be promoted into @usequeek/theme-kit if every theme needs it.',
                     docs: `${context.env.docs}#what-themes-must-not-do`,
@@ -286,7 +290,7 @@ export const sdkBoundaryRule = {
         const findings = [];
         for (const path of themeSourceFiles(context.dir)) {
             const source = readFileSync(path, 'utf8');
-            const where = relative(context.dir, path);
+            const where = themePath(context, path);
             if (/from '@queekai\/client-sdk'|from '@\/lib\/core\/sdk\//.test(source)) {
                 findings.push(finding(context, 'theme/core-boundary', 'reject', {
                     where,
@@ -1138,7 +1142,7 @@ export const vendorFactsRule = {
         for (const path of themeSourceFiles(context.dir)) {
             for (const { fact, words } of vendorFactFallbacks(readFileSync(path, 'utf8'))) {
                 findings.push(finding(context, 'theme/vendor-facts', 'reject', {
-                    where: relative(context.dir, path),
+                    where: themePath(context, path),
                     found: `vendor.${fact} falls back to "${words}"`,
                     fix: `A store with no ${fact} would show these words as its own. Render nothing when it is empty (\`vendor.${fact} ?? ''\`, or leave the element out).`,
                     docs: `${context.env.docs}#component-rules`,
@@ -1159,7 +1163,7 @@ function themeCssFiles(dir) {
 }
 export const fontsSelfHostedRule = {
     id: 'theme/fonts-self-hosted',
-    summary: 'Theme fonts ship as files in the theme: next/font/google is rejected (it fails builds), a Google Fonts @import is flagged',
+    summary: 'Theme fonts ship as files in the theme: next/font/google (fails builds) and a Google Fonts @import (dropped or render-blocking) are rejected',
     kind: 'static',
     run(context) {
         const findings = [];
@@ -1168,7 +1172,7 @@ export const fontsSelfHostedRule = {
             const source = stripComments(readFileSync(path, 'utf8'));
             if (/from\s+['"]next\/font\/google['"]/.test(source)) {
                 findings.push(finding(context, 'theme/fonts-self-hosted', 'reject', {
-                    where: relative(context.dir, path),
+                    where: themePath(context, path),
                     found: 'imports next/font/google',
                     fix,
                     docs: `${context.env.docs}#fonts`,
@@ -1178,10 +1182,10 @@ export const fontsSelfHostedRule = {
         for (const path of themeCssFiles(context.dir)) {
             const css = readFileSync(path, 'utf8').replace(/\/\*[\s\S]*?\*\//g, '');
             if (/@import\s+(?:url\()?['"]?https?:\/\/fonts\.googleapis\.com/.test(css)) {
-                findings.push(finding(context, 'theme/fonts-self-hosted', 'warn', {
-                    where: relative(context.dir, path),
+                findings.push(finding(context, 'theme/fonts-self-hosted', 'reject', {
+                    where: themePath(context, path),
                     found: 'loads a font with @import from fonts.googleapis.com',
-                    fix: `Either the bundler drops it (it only survives as the very first rule of the compiled stylesheet), so the font never loads, or it survives and every page load waits on an extra render-blocking request to Google before the text can paint. ${fix}`,
+                    fix: `Either the bundler drops it (it only survives as the very first rule of the compiled stylesheet), so the font never loads — atelier, deluxr and lumiere shipped that way until 24/9/26 — or it survives and every page load waits on an extra render-blocking request to Google before the text can paint. ${fix}`,
                     docs: `${context.env.docs}#fonts`,
                 }));
             }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@usequeek/theme-check",
-  "version": "0.3.2",
+  "version": "0.3.5",
   "description": "The rules a Queek storefront theme is checked against, as a library.",
   "license": "MIT",
   "type": "module",