@usearazzo/runner 1.0.1-alpha.14 → 1.0.1-alpha.16

package/CHANGELOG.md

@@ -3,6 +3,18 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [1.0.1-alpha.16](https://github.com/usearazzo/arazzo-toolkit/compare/v1.0.1-alpha.15...v1.0.1-alpha.16) (2026-10-28)
+
+### Bug Fixes
+
+- **runner:** merge workflow default actions into steps by name ([#288](https://github.com/usearazzo/arazzo-toolkit/issues/288)) ([8ee0ba3](https://github.com/usearazzo/arazzo-toolkit/commit/8ee0ba387c475fef329c7d094e10ed3b2b0753c1)), closes [#117](https://github.com/usearazzo/arazzo-toolkit/issues/117)
+
+## [1.0.1-alpha.15](https://github.com/usearazzo/arazzo-toolkit/compare/v1.0.1-alpha.14...v1.0.1-alpha.15) (2026-10-28)
+
+### Bug Fixes
+
+- **runner:** reject an unreadable successCriteria before any request ([#284](https://github.com/usearazzo/arazzo-toolkit/issues/284)) ([11662f5](https://github.com/usearazzo/arazzo-toolkit/commit/11662f5e603909e356e95f0daa85a7e245667920)), closes [#127](https://github.com/usearazzo/arazzo-toolkit/issues/127)
+
 ## [1.0.1-alpha.14](https://github.com/usearazzo/arazzo-toolkit/compare/v1.0.1-alpha.13...v1.0.1-alpha.14) (2026-10-27)
 
 ### Bug Fixes

package/dist/arazzo-runner.browser.js

@@ -12097,8 +12097,10 @@ __webpack_require__.r(__webpack_exports__);
 /* harmony import */ var _action_ActionResolver_ts__WEBPACK_IMPORTED_MODULE_8__ = __webpack_require__(51097);
 /* harmony import */ var _OpenAPIOperationLocatorNormalizer_ts__WEBPACK_IMPORTED_MODULE_9__ = __webpack_require__(7308);
 /* harmony import */ var _errors_ExecutionError_ts__WEBPACK_IMPORTED_MODULE_10__ = __webpack_require__(17658);
-/* harmony import */ var _errors_RuntimeExpressionError_ts__WEBPACK_IMPORTED_MODULE_11__ = __webpack_require__(48770);
-/* harmony import */ var _abort_ts__WEBPACK_IMPORTED_MODULE_12__ = __webpack_require__(99628);
+/* harmony import */ var _errors_ResolverError_ts__WEBPACK_IMPORTED_MODULE_11__ = __webpack_require__(8696);
+/* harmony import */ var _errors_RuntimeExpressionError_ts__WEBPACK_IMPORTED_MODULE_12__ = __webpack_require__(48770);
+/* harmony import */ var _abort_ts__WEBPACK_IMPORTED_MODULE_13__ = __webpack_require__(99628);
+
 
 
 
@@ -12231,6 +12233,7 @@ class StepExecutor {
         reason: 'workflow-step'
       });
     }
+    this.assertSuccessCriteria(step);
 
     // locate which operation the step invokes — reduced to a (document, JSON
     // Pointer) locator that the operation executor extracts, normalizes,
@@ -12252,8 +12255,8 @@ class StepExecutor {
     // still reach this line — and this is the last moment before the step has a
     // live side effect. The signal stays in the bag, so a request already in
     // flight is aborted by the transport as before.
-    const signal = (0,_abort_ts__WEBPACK_IMPORTED_MODULE_12__.readAbortSignal)(executeOptions);
-    (0,_abort_ts__WEBPACK_IMPORTED_MODULE_12__.throwIfAborted)(signal, {
+    const signal = (0,_abort_ts__WEBPACK_IMPORTED_MODULE_13__.readAbortSignal)(executeOptions);
+    (0,_abort_ts__WEBPACK_IMPORTED_MODULE_13__.throwIfAborted)(signal, {
       stepId
     });
 
@@ -12274,7 +12277,7 @@ class StepExecutor {
       // cancelled, it did not: reporting it as the abort keeps one error shape
       // whether the run was withdrawn between two steps or mid-flight, and keeps
       // the whole feature from reading differently per transport.
-      ;(0,_abort_ts__WEBPACK_IMPORTED_MODULE_12__.throwIfAborted)(signal, {
+      ;(0,_abort_ts__WEBPACK_IMPORTED_MODULE_13__.throwIfAborted)(signal, {
         stepId
       });
       throw error;
@@ -12326,9 +12329,48 @@ class StepExecutor {
     });
   }
 
+  /**
+   * Throws {@link ResolverError} unless the step's `successCriteria` is absent
+   * or a list of Criterion Objects: `malformed-criteria` for one that is
+   * present but not a list, `malformed-criterion` for an entry that is not a
+   * Criterion Object. Skipping an unreadable entry would turn the author's
+   * assertion into a vacuous pass, so it is an authoring error, as an action's
+   * unreadable `criteria` is in {@link ActionResolver}.
+   *
+   * Called before the step's request is sent, so no live side effect precedes
+   * the error. Public because the workflow executor checks every step of a
+   * workflow with it before any of them runs, a step targeting a `workflowId`
+   * included. It passes `workflowId`, which the error then carries: step ids
+   * are only unique within a workflow.
+   */
+  assertSuccessCriteria(step, workflowId) {
+    const criteria = step.successCriteria;
+    if (criteria === undefined) return;
+    const scope = {
+      ...(workflowId === undefined ? {} : {
+        workflowId
+      }),
+      stepId: (0,_speclynx_apidom_core__WEBPACK_IMPORTED_MODULE_0__["default"])(step.stepId),
+      target: 'successCriteria'
+    };
+    if (!(0,_speclynx_apidom_datamodel__WEBPACK_IMPORTED_MODULE_1__.isArrayElement)(criteria)) {
+      throw new _errors_ResolverError_ts__WEBPACK_IMPORTED_MODULE_11__["default"]("A step's `successCriteria` is present but is not a list", {
+        ...scope,
+        reason: 'malformed-criteria'
+      });
+    }
+    if (![...criteria].every(_speclynx_apidom_ns_arazzo_1__WEBPACK_IMPORTED_MODULE_2__.isCriterionElement)) {
+      throw new _errors_ResolverError_ts__WEBPACK_IMPORTED_MODULE_11__["default"]("A step's `successCriteria` contains an entry that is not a Criterion Object", {
+        ...scope,
+        reason: 'malformed-criterion'
+      });
+    }
+  }
+
   /**
    * Evaluates the step's `successCriteria`; all criteria must pass. A step with
-   * no criteria succeeds on a received response.
+   * no criteria succeeds on a received response. An unreadable
+   * `successCriteria` throws, see {@link StepExecutor.assertSuccessCriteria}.
    *
    * Public for the same reason as {@link StepExecutor.selectActions}: a step
    * targeting a `workflowId` is run by the workflow executor and never reaches
@@ -12336,15 +12378,12 @@ class StepExecutor {
    * assertion about the step and must be evaluated somewhere.
    */
   evaluateCriteria(step, context) {
+    this.assertSuccessCriteria(step);
     const criteria = step.successCriteria;
-    // no (or non-array) successCriteria: the step succeeds on a received response.
-    if (!(0,_speclynx_apidom_datamodel__WEBPACK_IMPORTED_MODULE_1__.isArrayElement)(criteria)) return true;
-    for (const criterion of criteria) {
-      if (!(0,_speclynx_apidom_ns_arazzo_1__WEBPACK_IMPORTED_MODULE_2__.isCriterionElement)(criterion)) continue;
-      const met = this.#criterionEvaluator.evaluate(criterion, expression => this.#evaluate(context, expression));
-      if (!met) return false;
-    }
-    return true;
+    if (criteria === undefined) return true;
+
+    // assertSuccessCriteria above guarantees every entry is a Criterion Object
+    return [...criteria].every(criterion => this.#criterionEvaluator.evaluate(criterion, expression => this.#evaluate(context, expression)));
   }
 
   /**
@@ -12377,7 +12416,7 @@ class StepExecutor {
         // components. A condition on an HTTP exchange cannot apply to a step
         // that calls a workflow, so the action does not match; the run does not
         // abort over a default written for the operation steps.
-        if (error instanceof _errors_RuntimeExpressionError_ts__WEBPACK_IMPORTED_MODULE_11__["default"] && error.reason === 'unavailable-expression') {
+        if (error instanceof _errors_RuntimeExpressionError_ts__WEBPACK_IMPORTED_MODULE_12__["default"] && error.reason === 'unavailable-expression') {
           return false;
         }
         throw error;
@@ -13279,6 +13318,10 @@ class WorkflowExecutor {
     // at `#result` where it used to be resolved, means the throw lands before
     // the first request rather than after the last.
     this.#validateWorkflowOutputsShape(workflow, workflowId);
+    // and to every step's `successCriteria`, a step calling a workflow
+    // included: an unreadable assertion found at step three must not cost the
+    // run the requests of steps one and two.
+    for (const step of steps) this.#stepExecutor.assertSuccessCriteria(step, workflowId);
     const dependencies = await this.#runDependencies(workflow, invocation, scope);
     if (dependencies.some(dependency => this.#settledFailed(dependency))) {
       // a declared prerequisite did not complete, so this workflow cannot be
@@ -14916,23 +14959,32 @@ class ArazzoWorkflowNormalizer {
   }
 
   /**
-   * Inherits the workflow's `successActions` / `failureActions` into each step
-   * that declares no `onSuccess` / `onFailure` of its own.
+   * Merges the workflow's `successActions` / `failureActions` into each step's
+   * `onSuccess` / `onFailure`.
    *
-   * Per Arazzo 1.0.1 both lists are "applicable for all steps described under
-   * this workflow", and a step's own list **overrides** the corresponding
-   * workflow one — wholesale, with no per-action merge, which is where this
-   * differs from the parameters above. Success and failure fall back
-   * independently: a step may override only its `onFailure` and still inherit
-   * the workflow's `successActions`.
+   * Per Arazzo both lists are "applicable for all steps described under this
+   * workflow" and "can be overridden at the step level but cannot be removed
+   * there". The required action `name` is what makes both halves hold: a
+   * step's action replaces the workflow action of the same `name`, and every
+   * workflow action the step does not name still applies. The effective list is
+   * the step's own actions in order, then the workflow actions it did not
+   * override, in theirs — order matters, as selection is first-match-wins on
+   * `criteria`. So a step with no list, or with `[]`, gets every workflow
+   * action. The step's own list is kept exactly as written, even a duplicate
+   * `name` in it, which the validator reports: inheritance only adds to it.
+   * Within the workflow's list the first action with a given `name` wins.
+   * Success and failure merge independently.
    *
-   * Presence is tested with `hasKey`, not truthiness: a step declaring an empty
-   * list (`onSuccess: []`) has *overridden* the default with an empty set of
-   * actions, not asked for one — it is skipped, as is a step whose `onSuccess`
-   * is present but not a list, for the same reason the parameters pass leaves a
-   * malformed list alone. Testing the key is also what makes the pass
-   * idempotent: after the first run the step has it, so a workflow reached again
-   * through the registry cache is skipped.
+   * An entry without a readable `name` (an unresolved Reusable Object, a
+   * scalar someone put in the list) neither overrides nor is overridden: it
+   * keeps its place, and is added only if that same element is not already in
+   * the list. A step whose `onSuccess` is present but not a list is left
+   * alone, for the same reason the parameters pass leaves a malformed list
+   * alone — overwriting it would erase what makes the document invalid.
+   *
+   * The pass is idempotent, so a workflow reached again through the registry
+   * cache is merged into once: on a second pass every inherited action is
+   * already in the step's list, under its own `name` or as the same element.
    *
    * Unlike parameters there is no step-kind filter — an action names a
    * transition within the workflow, which is as meaningful for a step targeting
@@ -14959,13 +15011,34 @@ class ArazzoWorkflowNormalizer {
     if (!inheritSuccess && !inheritFailure) return;
     for (const step of workflow.steps) {
       if (!(0,_speclynx_apidom_ns_arazzo_1__WEBPACK_IMPORTED_MODULE_1__.isStepElement)(step)) continue;
-      if (inheritSuccess && !step.hasKey('onSuccess')) {
-        step.onSuccess = new _speclynx_apidom_ns_arazzo_1__WEBPACK_IMPORTED_MODULE_3__["default"]([...successActions]);
+      if (inheritSuccess && (!step.hasKey('onSuccess') || (0,_speclynx_apidom_datamodel__WEBPACK_IMPORTED_MODULE_6__.isArrayElement)(step.onSuccess))) {
+        step.onSuccess = new _speclynx_apidom_ns_arazzo_1__WEBPACK_IMPORTED_MODULE_3__["default"](ArazzoWorkflowNormalizer.#mergeActions([...(step.onSuccess ?? [])], [...successActions]));
+      }
+      if (inheritFailure && (!step.hasKey('onFailure') || (0,_speclynx_apidom_datamodel__WEBPACK_IMPORTED_MODULE_6__.isArrayElement)(step.onFailure))) {
+        step.onFailure = new _speclynx_apidom_ns_arazzo_1__WEBPACK_IMPORTED_MODULE_2__["default"](ArazzoWorkflowNormalizer.#mergeActions([...(step.onFailure ?? [])], [...failureActions]));
       }
-      if (inheritFailure && !step.hasKey('onFailure')) {
-        step.onFailure = new _speclynx_apidom_ns_arazzo_1__WEBPACK_IMPORTED_MODULE_2__["default"]([...failureActions]);
+    }
+  }
+
+  /**
+   * The step's actions as written, followed by each workflow action whose
+   * `name` neither the step nor an earlier workflow action carries; a nameless
+   * workflow entry is added unless that same element is already present.
+   */
+  static #mergeActions(own, inherited) {
+    const nameOf = action => (0,_speclynx_apidom_datamodel__WEBPACK_IMPORTED_MODULE_6__.isObjectElement)(action) ? (0,_speclynx_apidom_core__WEBPACK_IMPORTED_MODULE_5__["default"])(action.get('name')) : undefined;
+    const names = new Set(own.map(nameOf));
+    const merged = [...own];
+    for (const action of inherited) {
+      const name = nameOf(action);
+      if (typeof name !== 'string') {
+        if (!merged.includes(action)) merged.push(action);
+      } else if (!names.has(name)) {
+        names.add(name);
+        merged.push(action);
       }
     }
+    return merged;
   }
 }
 /* harmony default export */ const __WEBPACK_DEFAULT_EXPORT__ = (ArazzoWorkflowNormalizer);