@uscreen.de/dev-service 0.12.2 → 0.12.3

package/README.md

@@ -1,7 +1,9 @@
 # dev-service
 
-[![Test CI](https://github.com/uscreen/dev-service/actions/workflows/node.js.yml/badge.svg)](https://github.com/uscreen/dev-service/actions/workflows/node.js.yml)
+[![Test CI](https://github.com/uscreen/dev-service/actions/workflows/main.yml/badge.svg)](https://github.com/uscreen/dev-service/actions/workflows/node.js.yml)
+[![Test Coverage](https://coveralls.io/repos/github/uscreen/dev-service/badge.svg?branch=master)](https://coveralls.io/github/uscreen/dev-service?branch=master)
 [![Known Vulnerabilities](https://snyk.io/test/github/uscreen/dev-service/badge.svg?targetFile=package.json)](https://snyk.io/test/github/uscreen/dev-service?targetFile=package.json)
+[![NPM Version](https://badge.fury.io/js/@uscreen.de%2Fdev-service.svg)](https://badge.fury.io/js/@uscreen.de%2Fdev-service)
 
 > Manage docker services for local development
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@uscreen.de/dev-service",
-  "version": "0.12.2",
+  "version": "0.12.3",
   "description": "cli to manage services in dev repos",
   "main": "index.js",
   "type": "module",
@@ -18,7 +18,7 @@
   "homepage": "https://github.com/uscreen/dev-service",
   "repository": {
     "type": "git",
-    "url": "https://github.com:uscreen/dev-service.git"
+    "url": "git+https://github.com/uscreen/dev-service.git"
   },
   "author": "Martin Herting <herting@uscreen.de>",
   "license": "MIT",
@@ -26,9 +26,9 @@
     "node": "^14.13 || >=15"
   },
   "scripts": {
-    "test": "c8 --all tap --no-coverage test/**/*.test.js",
-    "test:cov": "c8 --all --reporter html tap --no-coverage test/**/*.test.js && open coverage/index.html",
-    "test:ci": "c8 --all --reporter text-summary tap --no-coverage test/**/*.test.js",
+    "test": "c8 tap",
+    "test:cov": "c8 --reporter=html --reporter=text tap",
+    "test:ci": "c8 --reporter=lcovonly tap",
     "prepare": "husky install"
   },
   "gitHooks": {
@@ -47,7 +47,7 @@
   },
   "dependencies": {
     "c8": "^7.12.0",
-    "commander": "^9.4.1",
+    "commander": "^10.0.0",
     "fs-extra": "^11.1.0",
     "nanoid": "^4.0.0",
     "parse-json": "^6.0.2",

package/src/check.js

@@ -224,8 +224,6 @@ const getProcess = async (pid) =>
             cmd: args.join(' ')
           }))
 
-        if (!processes[0]) return resolve(null)
-
         resolve(processes[0])
       }
     )

package/src/utils.js

@@ -58,9 +58,10 @@ export const getComposeFiles = () =>
 const getComposePath = (containerId) =>
   new Promise((resolve, reject) => {
     exec(`docker inspect ${containerId}`, function (err, stdout, stderr) {
-      if (err || stderr.toString().trim()) {
-        return reject(err)
-      }
+      if (err) reject(err)
+
+      const errMessage = stderr.toString().trim()
+      if (errMessage) reject(new Error(errMessage))
 
       const [data] = JSON.parse(stdout)
 
@@ -70,7 +71,7 @@ const getComposePath = (containerId) =>
         data.Config.Labels &&
         data.Config.Labels['com.docker.compose.project.working_dir']
 
-      resolve(result || null)
+      resolve(result)
     })
   })
 
@@ -92,9 +93,7 @@ export const getComposePaths = () =>
 
           resolve(paths)
         })
-        .catch((err) => {
-          reject(err)
-        })
+        .catch(reject)
     })
   })