@urateam/core 0.1.42 → 0.1.43

package/dist/__tests__/bitbucket.test.js

@@ -0,0 +1,237 @@
+/**
+ * Unit tests for the Bitbucket repo provider.
+ *
+ * All tests run without a live Bitbucket instance — HTTP calls are intercepted
+ * by replacing `globalThis.fetch` with a Vitest spy before each test.
+ *
+ * Bitbucket API tier notes
+ * -----------------------
+ * - All APIs exercised here are part of the Bitbucket REST API v2.
+ * - PR creation, comments, and merging are available on all Bitbucket Cloud plans.
+ * - Bitbucket Data Center (self-hosted) uses the same API endpoints via a
+ *   configurable `apiBaseUrl` in `BitbucketConfig`.
+ */
+import { describe, it, expect, vi, afterEach } from "vitest";
+import { buildBitbucketAuthenticatedUrl, createBitbucketPR, addBitbucketPRComment, mergeBitbucketPR, parseBitbucketUrl, } from "../repo/bitbucket.js";
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+function makeResponse(body, status = 200, opts = {}) {
+    const ok = opts.ok ?? (status >= 200 && status < 300);
+    const text = typeof body === "string" ? body : JSON.stringify(body);
+    return {
+        ok,
+        status,
+        json: async () => (typeof body === "string" ? JSON.parse(body) : body),
+        text: async () => text,
+    };
+}
+const oauthConfig = { accessToken: "bbtoken-abc123" };
+const appPwdConfig = {
+    appUsername: "myuser",
+    appPassword: "myapppassword",
+};
+// ---------------------------------------------------------------------------
+// parseBitbucketUrl
+// ---------------------------------------------------------------------------
+describe("parseBitbucketUrl", () => {
+    it("parses an HTTPS URL", () => {
+        expect(parseBitbucketUrl("https://bitbucket.org/myworkspace/myrepo")).toEqual({
+            workspace: "myworkspace",
+            repoSlug: "myrepo",
+        });
+    });
+    it("parses an HTTPS URL with .git suffix", () => {
+        expect(parseBitbucketUrl("https://bitbucket.org/myworkspace/myrepo.git")).toEqual({
+            workspace: "myworkspace",
+            repoSlug: "myrepo",
+        });
+    });
+    it("parses an SSH URL", () => {
+        expect(parseBitbucketUrl("git@bitbucket.org:myworkspace/myrepo.git")).toEqual({
+            workspace: "myworkspace",
+            repoSlug: "myrepo",
+        });
+    });
+    it("throws for an unrecognised URL format", () => {
+        expect(() => parseBitbucketUrl("not-a-valid-url")).toThrow("Unable to parse Bitbucket repo URL");
+    });
+    it("parses slugs containing dots (HTTPS, no .git)", () => {
+        // Regression: the original regex used [^/.]+ which truncated `my.repo` to `my`.
+        expect(parseBitbucketUrl("https://bitbucket.org/ws/my.repo")).toEqual({
+            workspace: "ws",
+            repoSlug: "my.repo",
+        });
+    });
+    it("parses slugs containing dots (HTTPS with .git suffix)", () => {
+        expect(parseBitbucketUrl("https://bitbucket.org/ws/my.repo.git")).toEqual({
+            workspace: "ws",
+            repoSlug: "my.repo",
+        });
+    });
+    it("parses slugs containing dots (SSH with .git suffix)", () => {
+        expect(parseBitbucketUrl("git@bitbucket.org:ws/my.repo.git")).toEqual({
+            workspace: "ws",
+            repoSlug: "my.repo",
+        });
+    });
+});
+// ---------------------------------------------------------------------------
+// buildBitbucketAuthenticatedUrl
+// ---------------------------------------------------------------------------
+describe("buildBitbucketAuthenticatedUrl", () => {
+    it("injects OAuth token as x-token-auth user", () => {
+        const result = buildBitbucketAuthenticatedUrl("https://bitbucket.org/myworkspace/myrepo.git", oauthConfig);
+        expect(result).toBe("https://x-token-auth:bbtoken-abc123@bitbucket.org/myworkspace/myrepo.git");
+    });
+    it("injects App Password credentials as username:password", () => {
+        const result = buildBitbucketAuthenticatedUrl("https://bitbucket.org/myworkspace/myrepo.git", appPwdConfig);
+        expect(result).toBe("https://myuser:myapppassword@bitbucket.org/myworkspace/myrepo.git");
+    });
+    it("does not overwrite credentials already present in the URL", () => {
+        const url = "https://existing:creds@bitbucket.org/workspace/repo.git";
+        expect(buildBitbucketAuthenticatedUrl(url, oauthConfig)).toBe(url);
+    });
+    it("throws when neither accessToken nor appPassword is provided", () => {
+        expect(() => buildBitbucketAuthenticatedUrl("https://bitbucket.org/ws/repo.git", {})).toThrow("BitbucketConfig requires either accessToken or appUsername+appPassword");
+    });
+});
+// ---------------------------------------------------------------------------
+// createBitbucketPR
+// ---------------------------------------------------------------------------
+describe("createBitbucketPR", () => {
+    const options = {
+        workspace: "myworkspace",
+        repoSlug: "myrepo",
+        sourceBranch: "agent/LIN-42-my-feature",
+        targetBranch: "main",
+        title: "My feature",
+        description: "Adds a cool feature",
+    };
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+    it("creates a PR and returns the web URL", async () => {
+        vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ links: { html: { href: "https://bitbucket.org/myworkspace/myrepo/pull-requests/42" } } }, 201));
+        const url = await createBitbucketPR(oauthConfig, options);
+        expect(url).toBe("https://bitbucket.org/myworkspace/myrepo/pull-requests/42");
+    });
+    it("sends the correct API endpoint", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ links: { html: { href: "https://bitbucket.org/myworkspace/myrepo/pull-requests/1" } } }));
+        await createBitbucketPR(oauthConfig, options);
+        const [url] = fetchSpy.mock.calls[0];
+        expect(url).toBe("https://api.bitbucket.org/2.0/repositories/myworkspace/myrepo/pullrequests");
+    });
+    it("uses Bearer auth for OAuth tokens", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ links: { html: { href: "https://bitbucket.org/myworkspace/myrepo/pull-requests/1" } } }));
+        await createBitbucketPR(oauthConfig, options);
+        const [, init] = fetchSpy.mock.calls[0];
+        expect(init.headers["Authorization"]).toBe("Bearer bbtoken-abc123");
+    });
+    it("uses Basic auth for App Passwords", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ links: { html: { href: "https://bitbucket.org/myworkspace/myrepo/pull-requests/1" } } }));
+        await createBitbucketPR(appPwdConfig, options);
+        const [, init] = fetchSpy.mock.calls[0];
+        const authHeader = init.headers["Authorization"];
+        expect(authHeader).toMatch(/^Basic /);
+        const decoded = Buffer.from(authHeader.slice(6), "base64").toString();
+        expect(decoded).toBe("myuser:myapppassword");
+    });
+    it("sends correct request body fields", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ links: { html: { href: "https://bitbucket.org/myworkspace/myrepo/pull-requests/1" } } }));
+        await createBitbucketPR(oauthConfig, options);
+        const [, init] = fetchSpy.mock.calls[0];
+        const body = JSON.parse(init.body);
+        expect(body).toMatchObject({
+            title: "My feature",
+            description: "Adds a cool feature",
+            source: { branch: { name: "agent/LIN-42-my-feature" } },
+            destination: { branch: { name: "main" } },
+            close_source_branch: true,
+        });
+    });
+    it("sets draft: true when draft option is provided", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ links: { html: { href: "https://bitbucket.org/myworkspace/myrepo/pull-requests/1" } } }));
+        await createBitbucketPR(oauthConfig, { ...options, draft: true });
+        const [, init] = fetchSpy.mock.calls[0];
+        const body = JSON.parse(init.body);
+        expect(body.draft).toBe(true);
+    });
+    it("throws on a non-ok API response", async () => {
+        vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse("Unauthorized", 401, { ok: false }));
+        await expect(createBitbucketPR(oauthConfig, options)).rejects.toThrow("Bitbucket API error 401 creating PR");
+    });
+    it("uses a custom apiBaseUrl when provided", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ links: { html: { href: "https://bitbucket.example.com/repos/myworkspace/myrepo/pull-requests/1" } } }));
+        const selfHostedConfig = {
+            accessToken: "mytoken",
+            apiBaseUrl: "https://bitbucket.example.com/rest/api/2.0",
+        };
+        await createBitbucketPR(selfHostedConfig, options);
+        const [url] = fetchSpy.mock.calls[0];
+        expect(url).toMatch(/^https:\/\/bitbucket\.example\.com/);
+    });
+});
+// ---------------------------------------------------------------------------
+// addBitbucketPRComment
+// ---------------------------------------------------------------------------
+describe("addBitbucketPRComment", () => {
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+    it("posts a comment to the correct endpoint", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ id: 1 }, 201));
+        await addBitbucketPRComment(oauthConfig, "myworkspace", "myrepo", 42, "Hello from the agent");
+        const [url, init] = fetchSpy.mock.calls[0];
+        expect(url).toBe("https://api.bitbucket.org/2.0/repositories/myworkspace/myrepo/pullrequests/42/comments");
+        expect(init.method).toBe("POST");
+        const body = JSON.parse(init.body);
+        expect(body.content.raw).toBe("Hello from the agent");
+    });
+    it("resolves without error on a 201 response", async () => {
+        vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ id: 2 }, 201));
+        await expect(addBitbucketPRComment(oauthConfig, "ws", "repo", 1, "test")).resolves.toBeUndefined();
+    });
+    it("throws a descriptive error on non-ok response", async () => {
+        vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse("Not Found", 404, { ok: false }));
+        await expect(addBitbucketPRComment(oauthConfig, "ws", "repo", 99, "comment")).rejects.toThrow("Bitbucket API error 404 adding PR comment");
+    });
+});
+// ---------------------------------------------------------------------------
+// mergeBitbucketPR
+// ---------------------------------------------------------------------------
+describe("mergeBitbucketPR", () => {
+    afterEach(() => {
+        vi.restoreAllMocks();
+    });
+    it("returns true on a successful merge", async () => {
+        vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ state: "MERGED" }, 200));
+        const result = await mergeBitbucketPR(oauthConfig, "ws", "repo", 42);
+        expect(result).toBe(true);
+    });
+    it("returns false on a non-ok response", async () => {
+        vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse("Conflict", 409, { ok: false }));
+        const result = await mergeBitbucketPR(oauthConfig, "ws", "repo", 42);
+        expect(result).toBe(false);
+    });
+    it("returns false when fetch throws", async () => {
+        vi.spyOn(globalThis, "fetch").mockRejectedValueOnce(new Error("network error"));
+        const result = await mergeBitbucketPR(oauthConfig, "ws", "repo", 42);
+        expect(result).toBe(false);
+    });
+    it("sends the merge_strategy in the request body", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ state: "MERGED" }, 200));
+        await mergeBitbucketPR(oauthConfig, "ws", "repo", 42, "squash");
+        const [, init] = fetchSpy.mock.calls[0];
+        expect(init.method).toBe("POST");
+        const body = JSON.parse(init.body);
+        expect(body.merge_strategy).toBe("squash");
+    });
+    it("posts to the correct merge endpoint", async () => {
+        const fetchSpy = vi.spyOn(globalThis, "fetch").mockResolvedValueOnce(makeResponse({ state: "MERGED" }, 200));
+        await mergeBitbucketPR(oauthConfig, "myworkspace", "myrepo", 7);
+        const [url] = fetchSpy.mock.calls[0];
+        expect(url).toBe("https://api.bitbucket.org/2.0/repositories/myworkspace/myrepo/pullrequests/7/merge");
+    });
+});
+//# sourceMappingURL=bitbucket.test.js.map

package/dist/__tests__/bitbucket.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"bitbucket.test.js","sourceRoot":"","sources":["../../src/__tests__/bitbucket.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;GAYG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,SAAS,EAAE,MAAM,QAAQ,CAAC;AAC7D,OAAO,EACL,8BAA8B,EAC9B,iBAAiB,EACjB,qBAAqB,EACrB,gBAAgB,EAChB,iBAAiB,GAGlB,MAAM,sBAAsB,CAAC;AAE9B,8EAA8E;AAC9E,UAAU;AACV,8EAA8E;AAE9E,SAAS,YAAY,CACnB,IAAa,EACb,MAAM,GAAG,GAAG,EACZ,OAAyB,EAAE;IAE3B,MAAM,EAAE,GAAG,IAAI,CAAC,EAAE,IAAI,CAAC,MAAM,IAAI,GAAG,IAAI,MAAM,GAAG,GAAG,CAAC,CAAC;IACtD,MAAM,IAAI,GAAG,OAAO,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC;IACpE,OAAO;QACL,EAAE;QACF,MAAM;QACN,IAAI,EAAE,KAAK,IAAI,EAAE,CAAC,CAAC,OAAO,IAAI,KAAK,QAAQ,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QACtE,IAAI,EAAE,KAAK,IAAI,EAAE,CAAC,IAAI;KACA,CAAC;AAC3B,CAAC;AAED,MAAM,WAAW,GAAoB,EAAE,WAAW,EAAE,gBAAgB,EAAE,CAAC;AACvE,MAAM,YAAY,GAAoB;IACpC,WAAW,EAAE,QAAQ;IACrB,WAAW,EAAE,eAAe;CAC7B,CAAC;AAEF,8EAA8E;AAC9E,oBAAoB;AACpB,8EAA8E;AAE9E,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;IACjC,EAAE,CAAC,qBAAqB,EAAE,GAAG,EAAE;QAC7B,MAAM,CAAC,iBAAiB,CAAC,0CAA0C,CAAC,CAAC,CAAC,OAAO,CAAC;YAC5E,SAAS,EAAE,aAAa;YACxB,QAAQ,EAAE,QAAQ;SACnB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sCAAsC,EAAE,GAAG,EAAE;QAC9C,MAAM,CAAC,iBAAiB,CAAC,8CAA8C,CAAC,CAAC,CAAC,OAAO,CAAC;YAChF,SAAS,EAAE,aAAa;YACxB,QAAQ,EAAE,QAAQ;SACnB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mBAAmB,EAAE,GAAG,EAAE;QAC3B,MAAM,CAAC,iBAAiB,CAAC,0CAA0C,CAAC,CAAC,CAAC,OAAO,CAAC;YAC5E,SAAS,EAAE,aAAa;YACxB,QAAQ,EAAE,QAAQ;SACnB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uCAAuC,EAAE,GAAG,EAAE;QAC/C,MAAM,CAAC,GAAG,EAAE,CAAC,iBAAiB,CAAC,iBAAiB,CAAC,CAAC,CAAC,OAAO,CAAC,oCAAoC,CAAC,CAAC;IACnG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,GAAG,EAAE;QACvD,gFAAgF;QAChF,MAAM,CAAC,iBAAiB,CAAC,kCAAkC,CAAC,CAAC,CAAC,OAAO,CAAC;YACpE,SAAS,EAAE,IAAI;YACf,QAAQ,EAAE,SAAS;SACpB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,CAAC,iBAAiB,CAAC,sCAAsC,CAAC,CAAC,CAAC,OAAO,CAAC;YACxE,SAAS,EAAE,IAAI;YACf,QAAQ,EAAE,SAAS;SACpB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qDAAqD,EAAE,GAAG,EAAE;QAC7D,MAAM,CAAC,iBAAiB,CAAC,kCAAkC,CAAC,CAAC,CAAC,OAAO,CAAC;YACpE,SAAS,EAAE,IAAI;YACf,QAAQ,EAAE,SAAS;SACpB,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,8EAA8E;AAC9E,iCAAiC;AACjC,8EAA8E;AAE9E,QAAQ,CAAC,gCAAgC,EAAE,GAAG,EAAE;IAC9C,EAAE,CAAC,0CAA0C,EAAE,GAAG,EAAE;QAClD,MAAM,MAAM,GAAG,8BAA8B,CAC3C,8CAA8C,EAC9C,WAAW,CACZ,CAAC;QACF,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CACjB,0EAA0E,CAC3E,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,uDAAuD,EAAE,GAAG,EAAE;QAC/D,MAAM,MAAM,GAAG,8BAA8B,CAC3C,8CAA8C,EAC9C,YAAY,CACb,CAAC;QACF,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CACjB,mEAAmE,CACpE,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,2DAA2D,EAAE,GAAG,EAAE;QACnE,MAAM,GAAG,GAAG,yDAAyD,CAAC;QACtE,MAAM,CAAC,8BAA8B,CAAC,GAAG,EAAE,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;IACrE,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,6DAA6D,EAAE,GAAG,EAAE;QACrE,MAAM,CAAC,GAAG,EAAE,CACV,8BAA8B,CAAC,mCAAmC,EAAE,EAAE,CAAC,CACxE,CAAC,OAAO,CAAC,wEAAwE,CAAC,CAAC;IACtF,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,8EAA8E;AAC9E,oBAAoB;AACpB,8EAA8E;AAE9E,QAAQ,CAAC,mBAAmB,EAAE,GAAG,EAAE;IACjC,MAAM,OAAO,GAA6B;QACxC,SAAS,EAAE,aAAa;QACxB,QAAQ,EAAE,QAAQ;QAClB,YAAY,EAAE,yBAAyB;QACvC,YAAY,EAAE,MAAM;QACpB,KAAK,EAAE,YAAY;QACnB,WAAW,EAAE,qBAAqB;KACnC,CAAC;IAEF,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,sCAAsC,EAAE,KAAK,IAAI,EAAE;QACpD,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CACjD,YAAY,CAAC,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,2DAA2D,EAAE,EAAE,EAAE,EAAE,GAAG,CAAC,CAC9G,CAAC;QAEF,MAAM,GAAG,GAAG,MAAM,iBAAiB,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC;QAC1D,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,2DAA2D,CAAC,CAAC;IAChF,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gCAAgC,EAAE,KAAK,IAAI,EAAE;QAC9C,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,0DAA0D,EAAE,EAAE,EAAE,CAAC,CACxG,CAAC;QAEF,MAAM,iBAAiB,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC;QAE9C,MAAM,CAAC,GAAG,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QAC9D,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,4EAA4E,CAAC,CAAC;IACjG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mCAAmC,EAAE,KAAK,IAAI,EAAE;QACjD,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,0DAA0D,EAAE,EAAE,EAAE,CAAC,CACxG,CAAC;QAEF,MAAM,iBAAiB,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC;QAE9C,MAAM,CAAC,EAAE,IAAI,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QACjE,MAAM,CAAE,IAAI,CAAC,OAAkC,CAAC,eAAe,CAAC,CAAC,CAAC,IAAI,CAAC,uBAAuB,CAAC,CAAC;IAClG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mCAAmC,EAAE,KAAK,IAAI,EAAE;QACjD,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,0DAA0D,EAAE,EAAE,EAAE,CAAC,CACxG,CAAC;QAEF,MAAM,iBAAiB,CAAC,YAAY,EAAE,OAAO,CAAC,CAAC;QAE/C,MAAM,CAAC,EAAE,IAAI,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QACjE,MAAM,UAAU,GAAI,IAAI,CAAC,OAAkC,CAAC,eAAe,CAAC,CAAC;QAC7E,MAAM,CAAC,UAAU,CAAC,CAAC,OAAO,CAAC,SAAS,CAAC,CAAC;QACtC,MAAM,OAAO,GAAG,MAAM,CAAC,IAAI,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,EAAE,QAAQ,CAAC,CAAC,QAAQ,EAAE,CAAC;QACtE,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,sBAAsB,CAAC,CAAC;IAC/C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,mCAAmC,EAAE,KAAK,IAAI,EAAE;QACjD,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,0DAA0D,EAAE,EAAE,EAAE,CAAC,CACxG,CAAC;QAEF,MAAM,iBAAiB,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC;QAE9C,MAAM,CAAC,EAAE,IAAI,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QACjE,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,IAAc,CAAC,CAAC;QAC7C,MAAM,CAAC,IAAI,CAAC,CAAC,aAAa,CAAC;YACzB,KAAK,EAAE,YAAY;YACnB,WAAW,EAAE,qBAAqB;YAClC,MAAM,EAAE,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,yBAAyB,EAAE,EAAE;YACvD,WAAW,EAAE,EAAE,MAAM,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE;YACzC,mBAAmB,EAAE,IAAI;SAC1B,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,gDAAgD,EAAE,KAAK,IAAI,EAAE;QAC9D,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,0DAA0D,EAAE,EAAE,EAAE,CAAC,CACxG,CAAC;QAEF,MAAM,iBAAiB,CAAC,WAAW,EAAE,EAAE,GAAG,OAAO,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC;QAElE,MAAM,CAAC,EAAE,IAAI,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QACjE,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,IAAc,CAAC,CAAC;QAC7C,MAAM,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAChC,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iCAAiC,EAAE,KAAK,IAAI,EAAE;QAC/C,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CACjD,YAAY,CAAC,cAAc,EAAE,GAAG,EAAE,EAAE,EAAE,EAAE,KAAK,EAAE,CAAC,CACjD,CAAC;QAEF,MAAM,MAAM,CAAC,iBAAiB,CAAC,WAAW,EAAE,OAAO,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,CACnE,qCAAqC,CACtC,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,wCAAwC,EAAE,KAAK,IAAI,EAAE;QACtD,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,KAAK,EAAE,EAAE,IAAI,EAAE,EAAE,IAAI,EAAE,wEAAwE,EAAE,EAAE,EAAE,CAAC,CACtH,CAAC;QAEF,MAAM,gBAAgB,GAAoB;YACxC,WAAW,EAAE,SAAS;YACtB,UAAU,EAAE,4CAA4C;SACzD,CAAC;QACF,MAAM,iBAAiB,CAAC,gBAAgB,EAAE,OAAO,CAAC,CAAC;QAEnD,MAAM,CAAC,GAAG,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAa,CAAC;QACjD,MAAM,CAAC,GAAG,CAAC,CAAC,OAAO,CAAC,oCAAoC,CAAC,CAAC;IAC5D,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,8EAA8E;AAC9E,wBAAwB;AACxB,8EAA8E;AAE9E,QAAQ,CAAC,uBAAuB,EAAE,GAAG,EAAE;IACrC,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,yCAAyC,EAAE,KAAK,IAAI,EAAE;QACvD,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,EAAE,GAAG,CAAC,CAC7B,CAAC;QAEF,MAAM,qBAAqB,CAAC,WAAW,EAAE,aAAa,EAAE,QAAQ,EAAE,EAAE,EAAE,sBAAsB,CAAC,CAAC;QAE9F,MAAM,CAAC,GAAG,EAAE,IAAI,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QACpE,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,wFAAwF,CAAC,CAAC;QAC3G,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACjC,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,IAAc,CAAC,CAAC;QAC7C,MAAM,CAAC,IAAI,CAAC,OAAO,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,sBAAsB,CAAC,CAAC;IACxD,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,0CAA0C,EAAE,KAAK,IAAI,EAAE;QACxD,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAAC,YAAY,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,EAAE,GAAG,CAAC,CAAC,CAAC;QAClF,MAAM,MAAM,CAAC,qBAAqB,CAAC,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,CAAC,EAAE,MAAM,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,EAAE,CAAC;IACrG,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,+CAA+C,EAAE,KAAK,IAAI,EAAE;QAC7D,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CACjD,YAAY,CAAC,WAAW,EAAE,GAAG,EAAE,EAAE,EAAE,EAAE,KAAK,EAAE,CAAC,CAC9C,CAAC;QAEF,MAAM,MAAM,CACV,qBAAqB,CAAC,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,SAAS,CAAC,CAChE,CAAC,OAAO,CAAC,OAAO,CAAC,2CAA2C,CAAC,CAAC;IACjE,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC;AAEH,8EAA8E;AAC9E,mBAAmB;AACnB,8EAA8E;AAE9E,QAAQ,CAAC,kBAAkB,EAAE,GAAG,EAAE;IAChC,SAAS,CAAC,GAAG,EAAE;QACb,EAAE,CAAC,eAAe,EAAE,CAAC;IACvB,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oCAAoC,EAAE,KAAK,IAAI,EAAE;QAClD,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAAC,YAAY,CAAC,EAAE,KAAK,EAAE,QAAQ,EAAE,EAAE,GAAG,CAAC,CAAC,CAAC;QAC5F,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,CAAC,CAAC;QACrE,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IAC5B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,oCAAoC,EAAE,KAAK,IAAI,EAAE;QAClD,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CACjD,YAAY,CAAC,UAAU,EAAE,GAAG,EAAE,EAAE,EAAE,EAAE,KAAK,EAAE,CAAC,CAC7C,CAAC;QACF,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,CAAC,CAAC;QACrE,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC7B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,iCAAiC,EAAE,KAAK,IAAI,EAAE;QAC/C,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAAC,IAAI,KAAK,CAAC,eAAe,CAAC,CAAC,CAAC;QAChF,MAAM,MAAM,GAAG,MAAM,gBAAgB,CAAC,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,CAAC,CAAC;QACrE,MAAM,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;IAC7B,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,8CAA8C,EAAE,KAAK,IAAI,EAAE;QAC5D,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,KAAK,EAAE,QAAQ,EAAE,EAAE,GAAG,CAAC,CACvC,CAAC;QAEF,MAAM,gBAAgB,CAAC,WAAW,EAAE,IAAI,EAAE,MAAM,EAAE,EAAE,EAAE,QAAQ,CAAC,CAAC;QAEhE,MAAM,CAAC,EAAE,IAAI,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAA0B,CAAC;QACjE,MAAM,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,CAAC;QACjC,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,IAAc,CAAC,CAAC;QAC7C,MAAM,CAAC,IAAI,CAAC,cAAc,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;IAC7C,CAAC,CAAC,CAAC;IAEH,EAAE,CAAC,qCAAqC,EAAE,KAAK,IAAI,EAAE;QACnD,MAAM,QAAQ,GAAG,EAAE,CAAC,KAAK,CAAC,UAAU,EAAE,OAAO,CAAC,CAAC,qBAAqB,CAClE,YAAY,CAAC,EAAE,KAAK,EAAE,QAAQ,EAAE,EAAE,GAAG,CAAC,CACvC,CAAC;QAEF,MAAM,gBAAgB,CAAC,WAAW,EAAE,aAAa,EAAE,QAAQ,EAAE,CAAC,CAAC,CAAC;QAEhE,MAAM,CAAC,GAAG,CAAC,GAAG,QAAQ,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAa,CAAC;QACjD,MAAM,CAAC,GAAG,CAAC,CAAC,IAAI,CAAC,oFAAoF,CAAC,CAAC;IACzG,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/gitlab-webhook.test.d.ts

@@ -0,0 +1,13 @@
+/**
+ * Unit tests for the GitLab webhook handler.
+ *
+ * Covers:
+ *  - Token verification (verifyGitLabToken)
+ *  - Valid X-Gitlab-Token → feedback-run trigger
+ *  - Invalid / missing token → 401 response
+ *  - MR merged event → DB update
+ *  - Dedup, bot-exclusion, allowed-reviewer filter, trigger-keyword
+ *  - Integration path: handler → runner.startFeedback()
+ */
+export {};
+//# sourceMappingURL=gitlab-webhook.test.d.ts.map

package/dist/__tests__/gitlab-webhook.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"gitlab-webhook.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/gitlab-webhook.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG"}

package/dist/__tests__/gitlab-webhook.test.js

@@ -0,0 +1,388 @@
+/**
+ * Unit tests for the GitLab webhook handler.
+ *
+ * Covers:
+ *  - Token verification (verifyGitLabToken)
+ *  - Valid X-Gitlab-Token → feedback-run trigger
+ *  - Invalid / missing token → 401 response
+ *  - MR merged event → DB update
+ *  - Dedup, bot-exclusion, allowed-reviewer filter, trigger-keyword
+ *  - Integration path: handler → runner.startFeedback()
+ */
+import { describe, it, expect, vi } from "vitest";
+import { createGitLabWebhookHandler, verifyGitLabToken } from "../webhook/gitlab-handler.js";
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+const TOKEN = "gl-webhook-secret-token";
+const pipelineConfig = {
+    name: "auto-implement",
+    stages: ["triage", "implement", "test", "review"],
+    retry: { maxAttempts: 1, strategy: "fix-and-retry" },
+    review: { requiredApprovals: 1 },
+    prStrategy: "draft",
+};
+const repoConfig = {
+    url: "https://gitlab.com/org/repo",
+    defaultBranch: "main",
+    testCommand: "npm test",
+    buildCommand: "npm run build",
+    provider: "gitlab",
+    githubFeedback: {
+        botLogins: ["bot[bot]"],
+        autoTrigger: true,
+    },
+};
+const mockRun = {
+    id: "run-abc123",
+    issueId: "LIN-42",
+    issueTitle: "Add user search",
+    pipelineKey: "auto-implement",
+    repoUrl: "https://gitlab.com/org/repo",
+    branch: "agent/LIN-42-add-user-search",
+    status: "completed",
+    prUrl: "https://gitlab.com/org/repo/-/merge_requests/7",
+    runType: "standard",
+    parentRunId: null,
+    feedbackContext: null,
+};
+function makeMockDb(run = mockRun) {
+    return {
+        select: vi.fn().mockReturnValue({
+            from: vi.fn().mockReturnValue({
+                where: vi.fn().mockReturnValue({
+                    limit: vi.fn().mockResolvedValue(run ? [run] : []),
+                }),
+            }),
+        }),
+        update: vi.fn().mockReturnValue({
+            set: vi.fn().mockReturnValue({
+                where: vi.fn().mockResolvedValue(undefined),
+            }),
+        }),
+    };
+}
+function makeMockRunner() {
+    return {
+        startFeedback: vi.fn().mockResolvedValue(undefined),
+        isActiveFeedback: vi.fn().mockReturnValue(false),
+    };
+}
+function buildConfig(overrides = {}) {
+    return {
+        webhookToken: TOKEN,
+        runner: makeMockRunner(),
+        pipelineConfigs: { "auto-implement": pipelineConfig },
+        repoConfigs: { "org/repo": repoConfig },
+        db: makeMockDb(),
+        ...overrides,
+    };
+}
+function makeNotePayload(overrides = {}) {
+    return {
+        object_kind: "note",
+        user: { username: "reviewer-alice" },
+        object_attributes: {
+            id: 12345,
+            note: "Please rename this variable for clarity.",
+            noteable_type: "MergeRequest",
+            url: "https://gitlab.com/org/repo/-/merge_requests/7#note_12345",
+            ...overrides.object_attributes,
+        },
+        merge_request: {
+            iid: 7,
+            url: "https://gitlab.com/org/repo/-/merge_requests/7",
+            source_branch: "agent/LIN-42-add-user-search",
+            draft: false,
+            work_in_progress: false,
+            ...overrides.merge_request,
+        },
+        ...overrides,
+    };
+}
+async function postWebhook(config, payload, headers = {}) {
+    const app = createGitLabWebhookHandler(config);
+    const body = JSON.stringify(payload);
+    const req = new Request("http://localhost/webhooks/gitlab", {
+        method: "POST",
+        headers: {
+            "Content-Type": "application/json",
+            "X-Gitlab-Token": TOKEN,
+            ...headers,
+        },
+        body,
+    });
+    return app.fetch(req);
+}
+// ---------------------------------------------------------------------------
+// verifyGitLabToken
+// ---------------------------------------------------------------------------
+describe("verifyGitLabToken", () => {
+    it("returns true for matching tokens", () => {
+        expect(verifyGitLabToken("my-secret", "my-secret")).toBe(true);
+    });
+    it("returns false for mismatched tokens", () => {
+        expect(verifyGitLabToken("wrong-token", "my-secret")).toBe(false);
+    });
+    it("returns false for empty received token", () => {
+        expect(verifyGitLabToken("", "my-secret")).toBe(false);
+    });
+    it("returns false for empty expected token", () => {
+        expect(verifyGitLabToken("some-token", "")).toBe(false);
+    });
+    it("is case-sensitive", () => {
+        expect(verifyGitLabToken("My-Secret", "my-secret")).toBe(false);
+    });
+});
+// ---------------------------------------------------------------------------
+// Token validation
+// ---------------------------------------------------------------------------
+describe("createGitLabWebhookHandler — token validation", () => {
+    it("accepts a valid X-Gitlab-Token and triggers feedback", async () => {
+        const config = buildConfig();
+        const res = await postWebhook(config, makeNotePayload());
+        expect(res.status).toBe(200);
+        const body = await res.json();
+        expect(body.action).toBe("feedback-triggered");
+    });
+    it("rejects an invalid X-Gitlab-Token with 401", async () => {
+        const config = buildConfig();
+        const res = await postWebhook(config, makeNotePayload(), {
+            "X-Gitlab-Token": "wrong-token",
+        });
+        expect(res.status).toBe(401);
+    });
+    it("rejects a missing X-Gitlab-Token with 401", async () => {
+        const config = buildConfig();
+        const body = JSON.stringify(makeNotePayload());
+        const req = new Request("http://localhost/webhooks/gitlab", {
+            method: "POST",
+            headers: { "Content-Type": "application/json" },
+            body,
+        });
+        const res = await createGitLabWebhookHandler(config).fetch(req);
+        expect(res.status).toBe(401);
+    });
+    it("skips token check when webhookToken is not configured", async () => {
+        const config = buildConfig({ webhookToken: undefined });
+        const body = JSON.stringify(makeNotePayload());
+        const req = new Request("http://localhost/webhooks/gitlab", {
+            method: "POST",
+            headers: { "Content-Type": "application/json" },
+            body,
+        });
+        const res = await createGitLabWebhookHandler(config).fetch(req);
+        expect(res.status).toBe(200);
+    });
+});
+// ---------------------------------------------------------------------------
+// Note (comment) events → review-feedback runs
+// ---------------------------------------------------------------------------
+describe("createGitLabWebhookHandler — note events", () => {
+    it("triggers runner.startFeedback() for a qualifying MR note", async () => {
+        const runner = makeMockRunner();
+        const config = buildConfig({ runner: runner });
+        const res = await postWebhook(config, makeNotePayload());
+        expect(res.status).toBe(200);
+        const body = await res.json();
+        expect(body.action).toBe("feedback-triggered");
+        expect(runner.startFeedback).toHaveBeenCalledOnce();
+        const callArgs = runner.startFeedback.mock.calls[0][0];
+        expect(callArgs.prUrl).toBe("https://gitlab.com/org/repo/-/merge_requests/7");
+        expect(callArgs.feedbackComments).toHaveLength(1);
+        expect(callArgs.feedbackComments[0].body).toBe("Please rename this variable for clarity.");
+        expect(callArgs.feedbackComments[0].author).toBe("reviewer-alice");
+    });
+    it("skips non-MergeRequest notes", async () => {
+        const runner = makeMockRunner();
+        const config = buildConfig({ runner: runner });
+        const payload = makeNotePayload({
+            object_attributes: {
+                id: 99,
+                note: "comment on an issue",
+                noteable_type: "Issue",
+                url: "https://gitlab.com/org/repo/-/issues/1#note_99",
+            },
+        });
+        const res = await postWebhook(config, payload);
+        expect(res.status).toBe(200);
+        const body = await res.json();
+        expect(body.skipped).toBeDefined();
+        expect(runner.startFeedback).not.toHaveBeenCalled();
+    });
+    it("skips draft MRs", async () => {
+        const runner = makeMockRunner();
+        const config = buildConfig({ runner: runner });
+        const res = await postWebhook(config, makeNotePayload({ merge_request: { iid: 7, url: "https://gitlab.com/org/repo/-/merge_requests/7", source_branch: "agent/LIN-42-add-user-search", draft: true, work_in_progress: false } }));
+        expect(res.status).toBe(200);
+        const body = await res.json();
+        expect(body.skipped).toMatch(/draft/i);
+        expect(runner.startFeedback).not.toHaveBeenCalled();
+    });
+    it("skips comments from bot logins", async () => {
+        const runner = makeMockRunner();
+        const config = buildConfig({ runner: runner });
+        const res = await postWebhook(config, makeNotePayload({ user: { username: "bot[bot]" } }));
+        const body = await res.json();
+        expect(body.skipped).toBe("comment from bot login");
+        expect(runner.startFeedback).not.toHaveBeenCalled();
+    });
+    it("skips when commenter not in allowedReviewers (when list is non-empty)", async () => {
+        const runner = makeMockRunner();
+        const config = buildConfig({
+            runner: runner,
+            repoConfigs: {
+                "org/repo": {
+                    ...repoConfig,
+                    githubFeedback: {
+                        allowedReviewers: ["alice"],
+                        botLogins: [],
+                        autoTrigger: true,
+                    },
+                },
+            },
+        });
+        const res = await postWebhook(config, makeNotePayload({ user: { username: "unknown-person" } }));
+        const body = await res.json();
+        expect(body.skipped).toBe("commenter not in allowedReviewers");
+        expect(runner.startFeedback).not.toHaveBeenCalled();
+    });
+    it("skips when trigger keyword is required but missing", async () => {
+        const runner = makeMockRunner();
+        const config = buildConfig({
+            runner: runner,
+            repoConfigs: {
+                "org/repo": {
+                    ...repoConfig,
+                    githubFeedback: {
+                        triggerKeyword: "@agent",
+                        autoTrigger: false,
+                    },
+                },
+            },
+        });
+        const res = await postWebhook(config, makeNotePayload());
+        const body = await res.json();
+        expect(body.skipped).toBe("trigger keyword not found");
+        expect(runner.startFeedback).not.toHaveBeenCalled();
+    });
+    it("triggers when trigger keyword is present", async () => {
+        const runner = makeMockRunner();
+        const config = buildConfig({
+            runner: runner,
+            repoConfigs: {
+                "org/repo": {
+                    ...repoConfig,
+                    githubFeedback: {
+                        triggerKeyword: "@agent",
+                    },
+                },
+            },
+        });
+        const res = await postWebhook(config, makeNotePayload({
+            object_attributes: {
+                id: 12345,
+                note: "please @agent fix this",
+                noteable_type: "MergeRequest",
+                url: "https://gitlab.com/org/repo/-/merge_requests/7#note_12345",
+            },
+        }));
+        expect((await res.json()).action).toBe("feedback-triggered");
+        expect(runner.startFeedback).toHaveBeenCalledOnce();
+    });
+    it("skips empty comments", async () => {
+        const runner = makeMockRunner();
+        const config = buildConfig({ runner: runner });
+        const res = await postWebhook(config, makeNotePayload({
+            object_attributes: {
+                id: 12345,
+                note: "   ",
+                noteable_type: "MergeRequest",
+                url: "https://gitlab.com/org/repo/-/merge_requests/7#note_12345",
+            },
+        }));
+        const body = await res.json();
+        expect(body.skipped).toBe("empty comment body");
+        expect(runner.startFeedback).not.toHaveBeenCalled();
+    });
+    it("returns not-found for unrecognised MR (not an agent-created MR)", async () => {
+        const db = makeMockDb(null); // No pipeline run found
+        const config = buildConfig({ db: db });
+        const res = await postWebhook(config, makeNotePayload());
+        const body = await res.json();
+        expect(body.skipped).toBe("not an agent-created MR");
+    });
+    it("skips when a feedback run is already active for this MR", async () => {
+        const runner = makeMockRunner();
+        runner.isActiveFeedback.mockReturnValue(true);
+        const config = buildConfig({ runner: runner });
+        const res = await postWebhook(config, makeNotePayload());
+        const body = await res.json();
+        expect(body.skipped).toBe("feedback run already in progress");
+        expect(runner.startFeedback).not.toHaveBeenCalled();
+    });
+});
+// ---------------------------------------------------------------------------
+// MR merged events
+// ---------------------------------------------------------------------------
+describe("createGitLabWebhookHandler — MR merged events", () => {
+    it("marks pipeline run merged when MR is merged", async () => {
+        const db = makeMockDb();
+        const config = buildConfig({ db: db });
+        const payload = {
+            object_kind: "merge_request",
+            object_attributes: {
+                action: "merge",
+                url: "https://gitlab.com/org/repo/-/merge_requests/7",
+                source_branch: "agent/LIN-42-add-user-search",
+                state: "merged",
+            },
+        };
+        const res = await postWebhook(config, payload);
+        expect(res.status).toBe(200);
+        const body = await res.json();
+        expect(body.action).toBe("mr-merged");
+        expect(db.update).toHaveBeenCalled();
+    });
+    it("calls notifier.onPRMerged when notifier is provided", async () => {
+        const db = makeMockDb();
+        const notifier = { onPRMerged: vi.fn().mockResolvedValue(undefined) };
+        const config = buildConfig({ db: db, notifier: notifier });
+        const payload = {
+            object_kind: "merge_request",
+            object_attributes: {
+                action: "merge",
+                url: "https://gitlab.com/org/repo/-/merge_requests/7",
+                source_branch: "agent/LIN-42-add-user-search",
+                state: "merged",
+            },
+        };
+        await postWebhook(config, payload);
+        expect(notifier.onPRMerged).toHaveBeenCalledOnce();
+    });
+});
+// ---------------------------------------------------------------------------
+// Unhandled event types
+// ---------------------------------------------------------------------------
+describe("createGitLabWebhookHandler — unhandled events", () => {
+    it("returns skipped for push events", async () => {
+        const config = buildConfig();
+        const res = await postWebhook(config, { object_kind: "push" });
+        const body = await res.json();
+        expect(body.skipped).toBeDefined();
+    });
+    it("returns 400 for invalid JSON", async () => {
+        const config = buildConfig();
+        const req = new Request("http://localhost/webhooks/gitlab", {
+            method: "POST",
+            headers: {
+                "Content-Type": "application/json",
+                "X-Gitlab-Token": TOKEN,
+            },
+            body: "not json",
+        });
+        const res = await createGitLabWebhookHandler(config).fetch(req);
+        expect(res.status).toBe(400);
+    });
+});
+//# sourceMappingURL=gitlab-webhook.test.js.map