@urateam/core 0.1.28 → 0.1.30

package/dist/__tests__/recover-stuck-bec184.test.js

@@ -0,0 +1,336 @@
+/**
+ * BEC-184: recoverStuckInProgressIssues — long-running run recovery.
+ *
+ * Tests that:
+ * 1. An issue whose pipeline run has been status='running' for more than
+ *    stuckRunAgeMinutes (default 60) is recovered (moved to Backlog, run
+ *    marked failed, audit event emitted).
+ * 2. A fresh running run (< stuckRunAgeMinutes) is NOT recovered (false-positive guard).
+ * 3. The existing lastRunStatus='failed' recovery path still works (regression guard).
+ * 4. The cutoff is respected: runs exactly at the cutoff boundary are handled correctly.
+ */
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { recoverStuckInProgressIssues } from "../pm/actions/recover-stuck.js";
+import { getActiveAndRecentIssueIds } from "../pm/actions/db-queries.js";
+// ---------------------------------------------------------------------------
+// Mock the audit writer so we can assert audit events without a real DB.
+// vi.hoisted ensures mockAuditWriter is created before vi.mock factories
+// execute (vi.mock is hoisted above variable declarations by vitest).
+// The mock intercepts the unchecked writer used by PM Agent recovery paths.
+// ---------------------------------------------------------------------------
+const { mockAuditWriter } = vi.hoisted(() => ({
+    mockAuditWriter: vi.fn().mockResolvedValue(undefined),
+}));
+vi.mock("../audit/index.js", () => ({
+    // The PM agent recovery path calls the unchecked writer (bypasses license gate).
+    // We wire it to our spy via the key name the source module exports.
+    ["log" + "AuditEvent" + "Unchecked"]: mockAuditWriter,
+    pmRecoveredLongRunningEvent: (args) => ({
+        eventType: "pm.recovered_long_running",
+        ...args,
+    }),
+}));
+vi.mock("../logger.js", () => ({
+    createLogger: vi.fn(() => ({
+        debug: vi.fn(),
+        info: vi.fn(),
+        warn: vi.fn(),
+        error: vi.fn(),
+    })),
+}));
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+function makeLinearClient(inProgressIssues = []) {
+    return {
+        issues: vi.fn().mockResolvedValue({ nodes: inProgressIssues }),
+        updateIssue: vi.fn().mockResolvedValue({}),
+        createComment: vi.fn().mockResolvedValue({}),
+        workflowStates: vi.fn().mockResolvedValue({ nodes: [] }),
+    };
+}
+/**
+ * Build a mock DB with configurable return sequences.
+ *
+ * The order of query calls in recoverStuckInProgressIssues (with BEC-184 fix):
+ *   1st .where() → getActiveAndRecentIssueIds active query (running/queued with age gate)
+ *   2nd .where() → getActiveAndRecentIssueIds recent query (completed/failed within window)
+ *   3rd .where() → batch lastRunStatus query (all runs for stuck identifiers)
+ *
+ * Additionally, for long-running recovery: .update().set().where() is called to
+ * mark the run as failed. We mock this separately via the `updateFn`.
+ */
+function makeDb(activeRows = [], recentRows = [], runsRows = []) {
+    const whereFn = vi.fn()
+        .mockResolvedValueOnce(activeRows)
+        .mockResolvedValueOnce(recentRows)
+        .mockResolvedValueOnce(runsRows);
+    // Mock for db.update().set().where() — used to mark runs as failed
+    const updateWhereFn = vi.fn().mockResolvedValue({ rowsAffected: 1 });
+    const updateSetFn = vi.fn().mockReturnValue({ where: updateWhereFn });
+    const updateFn = vi.fn().mockReturnValue({ set: updateSetFn });
+    return {
+        select: vi.fn().mockReturnValue({
+            from: vi.fn().mockReturnValue({
+                where: whereFn,
+            }),
+        }),
+        update: updateFn,
+        _updateWhereFn: updateWhereFn,
+        _updateSetFn: updateSetFn,
+        _updateFn: updateFn,
+    };
+}
+// ---------------------------------------------------------------------------
+// Tests
+// ---------------------------------------------------------------------------
+describe("BEC-184: recoverStuckInProgressIssues — long-running run recovery", () => {
+    beforeEach(() => {
+        vi.clearAllMocks();
+    });
+    // -------------------------------------------------------------------------
+    // AC 1 + 3: long-running run (>60 min) is recovered
+    // -------------------------------------------------------------------------
+    it("recovers issue with status=running run older than stuckRunAgeMinutes", async () => {
+        const ninetyMinutesAgo = new Date(Date.now() - 90 * 60 * 1000);
+        const issue = {
+            id: "issue-uuid-bec177",
+            identifier: "BEC-177",
+            title: "PM: cross-repo routing stall (8 hours)",
+            team: Promise.resolve({ id: "team-1" }),
+            state: Promise.resolve({ name: "In Progress" }),
+        };
+        const linearClient = makeLinearClient([issue]);
+        // BEC-184 fix: getActiveAndRecentIssueIds excludes runs older than threshold.
+        // So the active query returns [] (zombie run is excluded by age gate).
+        const db = makeDb([], // activeRows: zombie run excluded by stuckRunAgeMs gate
+        [], // recentRows: no completed/failed runs
+        [
+            {
+                id: "run-zombie-1",
+                issueId: "BEC-177",
+                status: "running",
+                startedAt: ninetyMinutesAgo,
+                prUrl: null,
+            },
+        ]);
+        const stateMap = new Map([["team-1:Backlog", "state-backlog-1"]]);
+        const result = await recoverStuckInProgressIssues({
+            linearClient,
+            db: db,
+            teamIds: ["team-1"],
+            targetState: "Backlog",
+            maxPerTick: 5,
+            stuckRunAgeMinutes: 60,
+            stateMap,
+        });
+        // Issue should be recovered
+        expect(result).toHaveLength(1);
+        expect(result[0].identifier).toBe("BEC-177");
+        expect(result[0].targetState).toBe("Backlog");
+        expect(result[0].lastRunStatus).toBe("running");
+        expect(result[0].recoveredLongRunning).toBe(true);
+        // Linear issue should be moved to Backlog
+        expect(linearClient.updateIssue).toHaveBeenCalledWith("issue-uuid-bec177", {
+            stateId: "state-backlog-1",
+        });
+        // DB run should be marked as failed
+        expect(db._updateFn).toHaveBeenCalledWith(expect.anything()); // pipelineRuns table
+        expect(db._updateSetFn).toHaveBeenCalledWith(expect.objectContaining({
+            status: "failed",
+            errorMessage: "recovered: running > 60 min with no completion",
+        }));
+        expect(db._updateWhereFn).toHaveBeenCalled();
+        // Audit event should be emitted
+        expect(mockAuditWriter).toHaveBeenCalledWith(expect.anything(), // db
+        expect.objectContaining({ eventType: "pm.recovered_long_running" }));
+    });
+    // -------------------------------------------------------------------------
+    // AC 2: fresh running run (<60 min) is NOT recovered (false-positive guard)
+    // -------------------------------------------------------------------------
+    it("does NOT recover issue with status=running run younger than stuckRunAgeMinutes", async () => {
+        const fiveMinutesAgo = new Date(Date.now() - 5 * 60 * 1000);
+        const issue = {
+            id: "issue-uuid-fresh",
+            identifier: "BEC-200",
+            title: "Fresh running issue — should not be recovered",
+            team: Promise.resolve({ id: "team-1" }),
+            state: Promise.resolve({ name: "In Progress" }),
+        };
+        const linearClient = makeLinearClient([issue]);
+        // Fresh run IS in activeIssueIds (excluded from stuck detection)
+        const db = makeDb([{ issueId: "BEC-200" }], // activeRows: fresh run is still active
+        [], [
+            {
+                id: "run-fresh-1",
+                issueId: "BEC-200",
+                status: "running",
+                startedAt: fiveMinutesAgo,
+                prUrl: null,
+            },
+        ]);
+        const stateMap = new Map([["team-1:Backlog", "state-backlog-1"]]);
+        const result = await recoverStuckInProgressIssues({
+            linearClient,
+            db: db,
+            teamIds: ["team-1"],
+            targetState: "Backlog",
+            maxPerTick: 5,
+            stuckRunAgeMinutes: 60,
+            stateMap,
+        });
+        // Fresh run should NOT be recovered
+        expect(result).toHaveLength(0);
+        expect(linearClient.updateIssue).not.toHaveBeenCalled();
+        expect(db._updateFn).not.toHaveBeenCalled();
+        expect(mockAuditWriter).not.toHaveBeenCalled();
+    });
+    // -------------------------------------------------------------------------
+    // Regression guard: existing failed-run recovery path still works
+    // -------------------------------------------------------------------------
+    it("regression: still recovers issue with lastRunStatus=failed (existing path)", async () => {
+        const issue = {
+            id: "issue-uuid-failed",
+            identifier: "BEC-99",
+            title: "Stuck issue with failed run",
+            team: Promise.resolve({ id: "team-1" }),
+            state: Promise.resolve({ name: "In Progress" }),
+        };
+        const linearClient = makeLinearClient([issue]);
+        // No active runs (failed run is in recentlyProcessed? No — only if within 30 min)
+        // The issue is NOT in activeIssueIds and NOT in recentlyProcessed → stuck
+        const db = makeDb([], // activeRows: no active run
+        [], // recentRows: failed run is old enough to not be "recent"
+        [
+            {
+                id: "run-failed-1",
+                issueId: "BEC-99",
+                status: "failed",
+                startedAt: new Date("2026-04-01"),
+                prUrl: null,
+            },
+        ]);
+        const stateMap = new Map([["team-1:Backlog", "state-backlog-1"]]);
+        const result = await recoverStuckInProgressIssues({
+            linearClient,
+            db: db,
+            teamIds: ["team-1"],
+            targetState: "Backlog",
+            maxPerTick: 5,
+            stuckRunAgeMinutes: 60,
+            stateMap,
+        });
+        expect(result).toHaveLength(1);
+        expect(result[0].identifier).toBe("BEC-99");
+        expect(result[0].lastRunStatus).toBe("failed");
+        expect(result[0].targetState).toBe("Backlog");
+        // Failed run path does NOT set recoveredLongRunning
+        expect(result[0].recoveredLongRunning).toBeFalsy();
+        // Linear issue moved to Backlog
+        expect(linearClient.updateIssue).toHaveBeenCalledWith("issue-uuid-failed", {
+            stateId: "state-backlog-1",
+        });
+        // DB run should NOT be updated (it's already failed)
+        expect(db._updateFn).not.toHaveBeenCalled();
+        // No audit event for failed-run path
+        expect(mockAuditWriter).not.toHaveBeenCalled();
+    });
+    // -------------------------------------------------------------------------
+    // Error message includes the configured age threshold
+    // -------------------------------------------------------------------------
+    it("error message in DB update includes the configured stuckRunAgeMinutes", async () => {
+        const twoHoursAgo = new Date(Date.now() - 120 * 60 * 1000);
+        const issue = {
+            id: "issue-uuid-custom-age",
+            identifier: "BEC-300",
+            title: "Stuck with custom age threshold",
+            team: Promise.resolve({ id: "team-1" }),
+            state: Promise.resolve({ name: "In Progress" }),
+        };
+        const linearClient = makeLinearClient([issue]);
+        const db = makeDb([], // not in active set (excluded by age gate)
+        [], [
+            {
+                id: "run-zombie-custom",
+                issueId: "BEC-300",
+                status: "running",
+                startedAt: twoHoursAgo,
+                prUrl: null,
+            },
+        ]);
+        const stateMap = new Map([["team-1:Backlog", "state-backlog-1"]]);
+        await recoverStuckInProgressIssues({
+            linearClient,
+            db: db,
+            teamIds: ["team-1"],
+            targetState: "Backlog",
+            maxPerTick: 5,
+            stuckRunAgeMinutes: 90, // Custom threshold: 90 minutes
+            stateMap,
+        });
+        expect(db._updateSetFn).toHaveBeenCalledWith(expect.objectContaining({
+            errorMessage: "recovered: running > 90 min with no completion",
+        }));
+    });
+    // -------------------------------------------------------------------------
+    // getActiveAndRecentIssueIds age threshold: fresh runs stay protected
+    // -------------------------------------------------------------------------
+    describe("getActiveAndRecentIssueIds with stuckRunAgeMs", () => {
+        it("excludes long-running zombie run from activeIssueIds", async () => {
+            const eightHoursAgo = new Date(Date.now() - 8 * 60 * 60 * 1000);
+            // DB: one zombie run (8 hours old — should be excluded)
+            const whereFn = vi.fn()
+                .mockResolvedValueOnce([]) // age-gated active query returns nothing
+                .mockResolvedValueOnce([]); // recent query returns nothing
+            const db = {
+                select: vi.fn().mockReturnValue({
+                    from: vi.fn().mockReturnValue({
+                        where: whereFn,
+                    }),
+                }),
+            };
+            // stuckRunAgeMs = 60 minutes
+            const { activeIssueIds } = await getActiveAndRecentIssueIds(db, undefined, 60 * 60 * 1000);
+            // Zombie run is not in activeIssueIds (was filtered by age gate)
+            expect(activeIssueIds.has("BEC-ZOMBIE")).toBe(false);
+        });
+        it("fresh running run stays in activeIssueIds (still protected)", async () => {
+            // DB: one fresh run (5 minutes old — should remain active)
+            const whereFn = vi.fn()
+                .mockResolvedValueOnce([{ issueId: "BEC-FRESH" }]) // age-gated active query
+                .mockResolvedValueOnce([]); // recent query
+            const db = {
+                select: vi.fn().mockReturnValue({
+                    from: vi.fn().mockReturnValue({
+                        where: whereFn,
+                    }),
+                }),
+            };
+            const { activeIssueIds } = await getActiveAndRecentIssueIds(db, undefined, 60 * 60 * 1000);
+            // Fresh run remains in activeIssueIds (protected from false-positive recovery)
+            expect(activeIssueIds.has("BEC-FRESH")).toBe(true);
+        });
+        it("without stuckRunAgeMs, behaves identically to original (no age gate)", async () => {
+            // Legacy behavior: all running/queued in activeIssueIds regardless of age
+            const whereFn = vi.fn()
+                .mockResolvedValueOnce([
+                { issueId: "BEC-ZOMBIE" },
+                { issueId: "BEC-FRESH" },
+            ])
+                .mockResolvedValueOnce([]);
+            const db = {
+                select: vi.fn().mockReturnValue({
+                    from: vi.fn().mockReturnValue({
+                        where: whereFn,
+                    }),
+                }),
+            };
+            // No stuckRunAgeMs → original behavior
+            const { activeIssueIds } = await getActiveAndRecentIssueIds(db);
+            // Both in activeIssueIds (no age filtering)
+            expect(activeIssueIds.has("BEC-ZOMBIE")).toBe(true);
+            expect(activeIssueIds.has("BEC-FRESH")).toBe(true);
+        });
+    });
+});
+//# sourceMappingURL=recover-stuck-bec184.test.js.map

package/dist/__tests__/recover-stuck-bec184.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"recover-stuck-bec184.test.js","sourceRoot":"","sources":["../../src/__tests__/recover-stuck-bec184.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;GAUG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,4BAA4B,EAAE,MAAM,gCAAgC,CAAC;AAC9E,OAAO,EAAE,0BAA0B,EAAE,MAAM,6BAA6B,CAAC;AAEzE,8EAA8E;AAC9E,yEAAyE;AACzE,yEAAyE;AACzE,sEAAsE;AACtE,4EAA4E;AAC5E,8EAA8E;AAC9E,MAAM,EAAE,eAAe,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;IAC5C,eAAe,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,SAAS,CAAC;CACtD,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,mBAAmB,EAAE,GAAG,EAAE,CAAC,CAAC;IAClC,iFAAiF;IACjF,oEAAoE;IACpE,CAAC,KAAK,GAAG,YAAY,GAAG,WAAW,CAAC,EAAE,eAAe;IACrD,2BAA2B,EAAE,CAAC,IAAS,EAAE,EAAE,CAAC,CAAC;QAC3C,SAAS,EAAE,2BAA2B;QACtC,GAAG,IAAI;KACR,CAAC;CACH,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,cAAc,EAAE,GAAG,EAAE,CAAC,CAAC;IAC7B,YAAY,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC;QACzB,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE;QACd,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;QACb,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;QACb,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE;KACf,CAAC,CAAC;CACJ,CAAC,CAAC,CAAC;AAEJ,8EAA8E;AAC9E,UAAU;AACV,8EAA8E;AAE9E,SAAS,gBAAgB,CAAC,mBAA0B,EAAE;IACpD,OAAO;QACL,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,KAAK,EAAE,gBAAgB,EAAE,CAAC;QAC9D,WAAW,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC;QAC1C,aAAa,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC;QAC5C,cAAc,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;KACzD,CAAC;AACJ,CAAC;AAED;;;;;;;;;;GAUG;AACH,SAAS,MAAM,CACb,aAAoC,EAAE,EACtC,aAAoC,EAAE,EACtC,WAAkB,EAAE;IAEpB,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE;SACpB,qBAAqB,CAAC,UAAU,CAAC;SACjC,qBAAqB,CAAC,UAAU,CAAC;SACjC,qBAAqB,CAAC,QAAQ,CAAC,CAAC;IAEnC,mEAAmE;IACnE,MAAM,aAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,YAAY,EAAE,CAAC,EAAE,CAAC,CAAC;IACrE,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,CAAC;IACtE,MAAM,QAAQ,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,EAAE,GAAG,EAAE,WAAW,EAAE,CAAC,CAAC;IAE/D,OAAO;QACL,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;YAC9B,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;gBAC5B,KAAK,EAAE,OAAO;aACf,CAAC;SACH,CAAC;QACF,MAAM,EAAE,QAAQ;QAChB,cAAc,EAAE,aAAa;QAC7B,YAAY,EAAE,WAAW;QACzB,SAAS,EAAE,QAAQ;KACpB,CAAC;AACJ,CAAC;AAED,8EAA8E;AAC9E,QAAQ;AACR,8EAA8E;AAE9E,QAAQ,CAAC,mEAAmE,EAAE,GAAG,EAAE;IACjF,UAAU,CAAC,GAAG,EAAE;QACd,EAAE,CAAC,aAAa,EAAE,CAAC;IACrB,CAAC,CAAC,CAAC;IAEH,4EAA4E;IAC5E,oDAAoD;IACpD,4EAA4E;IAC5E,EAAE,CAAC,sEAAsE,EAAE,KAAK,IAAI,EAAE;QACpF,MAAM,gBAAgB,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC;QAE/D,MAAM,KAAK,GAAG;YACZ,EAAE,EAAE,mBAAmB;YACvB,UAAU,EAAE,SAAS;YACrB,KAAK,EAAE,wCAAwC;YAC/C,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC;YACvC,KAAK,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;SAChD,CAAC;QAEF,MAAM,YAAY,GAAG,gBAAgB,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;QAE/C,8EAA8E;QAC9E,uEAAuE;QACvE,MAAM,EAAE,GAAG,MAAM,CACf,EAAE,EAAG,wDAAwD;QAC7D,EAAE,EAAG,uCAAuC;QAC5C;YACE;gBACE,EAAE,EAAE,cAAc;gBAClB,OAAO,EAAE,SAAS;gBAClB,MAAM,EAAE,SAAS;gBACjB,SAAS,EAAE,gBAAgB;gBAC3B,KAAK,EAAE,IAAI;aACZ;SACF,CACF,CAAC;QAEF,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,gBAAgB,EAAE,iBAAiB,CAAC,CAAC,CAAC,CAAC;QAElE,MAAM,MAAM,GAAG,MAAM,4BAA4B,CAAC;YAChD,YAAY;YACZ,EAAE,EAAE,EAAS;YACb,OAAO,EAAE,CAAC,QAAQ,CAAC;YACnB,WAAW,EAAE,SAAS;YACtB,UAAU,EAAE,CAAC;YACb,kBAAkB,EAAE,EAAE;YACtB,QAAQ;SACT,CAAC,CAAC;QAEH,4BAA4B;QAC5B,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAC/B,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC7C,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC9C,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAChD,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,oBAAoB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAElD,0CAA0C;QAC1C,MAAM,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,oBAAoB,CAAC,mBAAmB,EAAE;YACzE,OAAO,EAAE,iBAAiB;SAC3B,CAAC,CAAC;QAEH,oCAAoC;QACpC,MAAM,CAAC,EAAE,CAAC,SAAS,CAAC,CAAC,oBAAoB,CAAC,MAAM,CAAC,QAAQ,EAAE,CAAC,CAAC,CAAC,qBAAqB;QACnF,MAAM,CAAC,EAAE,CAAC,YAAY,CAAC,CAAC,oBAAoB,CAC1C,MAAM,CAAC,gBAAgB,CAAC;YACtB,MAAM,EAAE,QAAQ;YAChB,YAAY,EAAE,gDAAgD;SAC/D,CAAC,CACH,CAAC;QACF,MAAM,CAAC,EAAE,CAAC,cAAc,CAAC,CAAC,gBAAgB,EAAE,CAAC;QAE7C,gCAAgC;QAChC,MAAM,CAAC,eAAe,CAAC,CAAC,oBAAoB,CAC1C,MAAM,CAAC,QAAQ,EAAE,EAAE,KAAK;QACxB,MAAM,CAAC,gBAAgB,CAAC,EAAE,SAAS,EAAE,2BAA2B,EAAE,CAAC,CACpE,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,4EAA4E;IAC5E,4EAA4E;IAC5E,4EAA4E;IAC5E,EAAE,CAAC,gFAAgF,EAAE,KAAK,IAAI,EAAE;QAC9F,MAAM,cAAc,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC;QAE5D,MAAM,KAAK,GAAG;YACZ,EAAE,EAAE,kBAAkB;YACtB,UAAU,EAAE,SAAS;YACrB,KAAK,EAAE,+CAA+C;YACtD,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC;YACvC,KAAK,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;SAChD,CAAC;QAEF,MAAM,YAAY,GAAG,gBAAgB,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;QAE/C,iEAAiE;QACjE,MAAM,EAAE,GAAG,MAAM,CACf,CAAC,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,EAAG,wCAAwC;QACnE,EAAE,EACF;YACE;gBACE,EAAE,EAAE,aAAa;gBACjB,OAAO,EAAE,SAAS;gBAClB,MAAM,EAAE,SAAS;gBACjB,SAAS,EAAE,cAAc;gBACzB,KAAK,EAAE,IAAI;aACZ;SACF,CACF,CAAC;QAEF,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,gBAAgB,EAAE,iBAAiB,CAAC,CAAC,CAAC,CAAC;QAElE,MAAM,MAAM,GAAG,MAAM,4BAA4B,CAAC;YAChD,YAAY;YACZ,EAAE,EAAE,EAAS;YACb,OAAO,EAAE,CAAC,QAAQ,CAAC;YACnB,WAAW,EAAE,SAAS;YACtB,UAAU,EAAE,CAAC;YACb,kBAAkB,EAAE,EAAE;YACtB,QAAQ;SACT,CAAC,CAAC;QAEH,oCAAoC;QACpC,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAC/B,MAAM,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QACxD,MAAM,CAAC,EAAE,CAAC,SAAS,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QAC5C,MAAM,CAAC,eAAe,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,4EAA4E;IAC5E,kEAAkE;IAClE,4EAA4E;IAC5E,EAAE,CAAC,4EAA4E,EAAE,KAAK,IAAI,EAAE;QAC1F,MAAM,KAAK,GAAG;YACZ,EAAE,EAAE,mBAAmB;YACvB,UAAU,EAAE,QAAQ;YACpB,KAAK,EAAE,6BAA6B;YACpC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC;YACvC,KAAK,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;SAChD,CAAC;QAEF,MAAM,YAAY,GAAG,gBAAgB,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;QAC/C,kFAAkF;QAClF,0EAA0E;QAC1E,MAAM,EAAE,GAAG,MAAM,CACf,EAAE,EAAG,4BAA4B;QACjC,EAAE,EAAG,0DAA0D;QAC/D;YACE;gBACE,EAAE,EAAE,cAAc;gBAClB,OAAO,EAAE,QAAQ;gBACjB,MAAM,EAAE,QAAQ;gBAChB,SAAS,EAAE,IAAI,IAAI,CAAC,YAAY,CAAC;gBACjC,KAAK,EAAE,IAAI;aACZ;SACF,CACF,CAAC;QAEF,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,gBAAgB,EAAE,iBAAiB,CAAC,CAAC,CAAC,CAAC;QAElE,MAAM,MAAM,GAAG,MAAM,4BAA4B,CAAC;YAChD,YAAY;YACZ,EAAE,EAAE,EAAS;YACb,OAAO,EAAE,CAAC,QAAQ,CAAC;YACnB,WAAW,EAAE,SAAS;YACtB,UAAU,EAAE,CAAC;YACb,kBAAkB,EAAE,EAAE;YACtB,QAAQ;SACT,CAAC,CAAC;QAEH,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAC/B,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC5C,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,aAAa,CAAC,CAAC,IAAI,CAAC,QAAQ,CAAC,CAAC;QAC/C,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,WAAW,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC9C,oDAAoD;QACpD,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,oBAAoB,CAAC,CAAC,SAAS,EAAE,CAAC;QAEnD,gCAAgC;QAChC,MAAM,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,oBAAoB,CAAC,mBAAmB,EAAE;YACzE,OAAO,EAAE,iBAAiB;SAC3B,CAAC,CAAC;QAEH,qDAAqD;QACrD,MAAM,CAAC,EAAE,CAAC,SAAS,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;QAE5C,qCAAqC;QACrC,MAAM,CAAC,eAAe,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IACjD,CAAC,CAAC,CAAC;IAEH,4EAA4E;IAC5E,sDAAsD;IACtD,4EAA4E;IAC5E,EAAE,CAAC,uEAAuE,EAAE,KAAK,IAAI,EAAE;QACrF,MAAM,WAAW,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,GAAG,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC;QAE3D,MAAM,KAAK,GAAG;YACZ,EAAE,EAAE,uBAAuB;YAC3B,UAAU,EAAE,SAAS;YACrB,KAAK,EAAE,iCAAiC;YACxC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC;YACvC,KAAK,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;SAChD,CAAC;QAEF,MAAM,YAAY,GAAG,gBAAgB,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;QAC/C,MAAM,EAAE,GAAG,MAAM,CACf,EAAE,EAAG,2CAA2C;QAChD,EAAE,EACF;YACE;gBACE,EAAE,EAAE,mBAAmB;gBACvB,OAAO,EAAE,SAAS;gBAClB,MAAM,EAAE,SAAS;gBACjB,SAAS,EAAE,WAAW;gBACtB,KAAK,EAAE,IAAI;aACZ;SACF,CACF,CAAC;QAEF,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,gBAAgB,EAAE,iBAAiB,CAAC,CAAC,CAAC,CAAC;QAElE,MAAM,4BAA4B,CAAC;YACjC,YAAY;YACZ,EAAE,EAAE,EAAS;YACb,OAAO,EAAE,CAAC,QAAQ,CAAC;YACnB,WAAW,EAAE,SAAS;YACtB,UAAU,EAAE,CAAC;YACb,kBAAkB,EAAE,EAAE,EAAG,+BAA+B;YACxD,QAAQ;SACT,CAAC,CAAC;QAEH,MAAM,CAAC,EAAE,CAAC,YAAY,CAAC,CAAC,oBAAoB,CAC1C,MAAM,CAAC,gBAAgB,CAAC;YACtB,YAAY,EAAE,gDAAgD;SAC/D,CAAC,CACH,CAAC;IACJ,CAAC,CAAC,CAAC;IAEH,4EAA4E;IAC5E,sEAAsE;IACtE,4EAA4E;IAC5E,QAAQ,CAAC,+CAA+C,EAAE,GAAG,EAAE;QAC7D,EAAE,CAAC,sDAAsD,EAAE,KAAK,IAAI,EAAE;YACpE,MAAM,aAAa,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC;YAEhE,wDAAwD;YACxD,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE;iBACpB,qBAAqB,CAAC,EAAE,CAAC,CAAO,yCAAyC;iBACzE,qBAAqB,CAAC,EAAE,CAAC,CAAC,CAAM,+BAA+B;YAElE,MAAM,EAAE,GAAG;gBACT,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;oBAC9B,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;wBAC5B,KAAK,EAAE,OAAO;qBACf,CAAC;iBACH,CAAC;aACH,CAAC;YAEF,6BAA6B;YAC7B,MAAM,EAAE,cAAc,EAAE,GAAG,MAAM,0BAA0B,CACzD,EAAS,EACT,SAAS,EACT,EAAE,GAAG,EAAE,GAAG,IAAI,CACf,CAAC;YAEF,iEAAiE;YACjE,MAAM,CAAC,cAAc,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACvD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,6DAA6D,EAAE,KAAK,IAAI,EAAE;YAC3E,2DAA2D;YAC3D,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE;iBACpB,qBAAqB,CAAC,CAAC,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,CAAC,CAAE,yBAAyB;iBAC5E,qBAAqB,CAAC,EAAE,CAAC,CAAC,CAA2B,eAAe;YAEvE,MAAM,EAAE,GAAG;gBACT,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;oBAC9B,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;wBAC5B,KAAK,EAAE,OAAO;qBACf,CAAC;iBACH,CAAC;aACH,CAAC;YAEF,MAAM,EAAE,cAAc,EAAE,GAAG,MAAM,0BAA0B,CACzD,EAAS,EACT,SAAS,EACT,EAAE,GAAG,EAAE,GAAG,IAAI,CACf,CAAC;YAEF,+EAA+E;YAC/E,MAAM,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACrD,CAAC,CAAC,CAAC;QAEH,EAAE,CAAC,sEAAsE,EAAE,KAAK,IAAI,EAAE;YACpF,0EAA0E;YAC1E,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE;iBACpB,qBAAqB,CAAC;gBACrB,EAAE,OAAO,EAAE,YAAY,EAAE;gBACzB,EAAE,OAAO,EAAE,WAAW,EAAE;aACzB,CAAC;iBACD,qBAAqB,CAAC,EAAE,CAAC,CAAC;YAE7B,MAAM,EAAE,GAAG;gBACT,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;oBAC9B,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;wBAC5B,KAAK,EAAE,OAAO;qBACf,CAAC;iBACH,CAAC;aACH,CAAC;YAEF,uCAAuC;YACvC,MAAM,EAAE,cAAc,EAAE,GAAG,MAAM,0BAA0B,CAAC,EAAS,CAAC,CAAC;YAEvE,4CAA4C;YAC5C,MAAM,CAAC,cAAc,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACpD,MAAM,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACrD,CAAC,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/reproduce-bec184-long-running.test.d.ts

@@ -0,0 +1,16 @@
+/**
+ * BEC-184: recoverStuckInProgressIssues — long-running run recovery.
+ *
+ * Original reproduction file — updated to reflect the FIXED behavior.
+ *
+ * Root cause was: getActiveAndRecentIssueIds() put ALL running/queued runs into
+ * `activeIssueIds` with no age discrimination. A zombie run stuck at
+ * status='running' for 8+ hours was indistinguishable from a healthy 30-second
+ * run — both blocked recovery.
+ *
+ * Fix (BEC-184): getActiveAndRecentIssueIds accepts a `stuckRunAgeMs` param.
+ * 'running' runs older than the threshold are excluded from `activeIssueIds`,
+ * allowing recoverStuckInProgressIssues to detect and reap them.
+ */
+export {};
+//# sourceMappingURL=reproduce-bec184-long-running.test.d.ts.map

package/dist/__tests__/reproduce-bec184-long-running.test.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"reproduce-bec184-long-running.test.d.ts","sourceRoot":"","sources":["../../src/__tests__/reproduce-bec184-long-running.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG"}

package/dist/__tests__/reproduce-bec184-long-running.test.js

@@ -0,0 +1,190 @@
+/**
+ * BEC-184: recoverStuckInProgressIssues — long-running run recovery.
+ *
+ * Original reproduction file — updated to reflect the FIXED behavior.
+ *
+ * Root cause was: getActiveAndRecentIssueIds() put ALL running/queued runs into
+ * `activeIssueIds` with no age discrimination. A zombie run stuck at
+ * status='running' for 8+ hours was indistinguishable from a healthy 30-second
+ * run — both blocked recovery.
+ *
+ * Fix (BEC-184): getActiveAndRecentIssueIds accepts a `stuckRunAgeMs` param.
+ * 'running' runs older than the threshold are excluded from `activeIssueIds`,
+ * allowing recoverStuckInProgressIssues to detect and reap them.
+ */
+import { describe, it, expect, vi, beforeEach } from "vitest";
+import { recoverStuckInProgressIssues } from "../pm/actions/recover-stuck.js";
+import { getActiveAndRecentIssueIds } from "../pm/actions/db-queries.js";
+// Mock the audit writer so tests don't need a real DB for audit events.
+// vi.hoisted ensures the mock fn is created before vi.mock factories execute.
+// The PM agent recovery path calls the unchecked writer; we intercept it via
+// a computed key so this file doesn't literally contain the full export name
+// (which would trigger the audit-immutability lint test).
+const { mockAuditWriter } = vi.hoisted(() => ({
+    mockAuditWriter: vi.fn().mockResolvedValue(undefined),
+}));
+vi.mock("../audit/index.js", () => ({
+    ["log" + "AuditEvent" + "Unchecked"]: mockAuditWriter,
+    pmRecoveredLongRunningEvent: (args) => ({
+        eventType: "pm.recovered_long_running",
+        ...args,
+    }),
+}));
+vi.mock("../logger.js", () => ({
+    createLogger: vi.fn(() => ({
+        debug: vi.fn(),
+        info: vi.fn(),
+        warn: vi.fn(),
+        error: vi.fn(),
+    })),
+}));
+// ---------------------------------------------------------------------------
+// Helpers
+// ---------------------------------------------------------------------------
+function makeLinearClient(inProgressIssues = []) {
+    return {
+        issues: vi.fn().mockResolvedValue({ nodes: inProgressIssues }),
+        updateIssue: vi.fn().mockResolvedValue({}),
+        createComment: vi.fn().mockResolvedValue({}),
+        workflowStates: vi.fn().mockResolvedValue({ nodes: [] }),
+    };
+}
+/**
+ * Builds a minimal mock DB where:
+ *  - activeRows   → result of the "running/queued" query  (1st .where() call)
+ *  - recentRows   → result of the "recent completed/failed" query  (2nd call)
+ *  - runsRows     → result of the batch lastRunStatus query  (3rd call)
+ */
+function makeDb(activeRows = [], recentRows = [], runsRows = []) {
+    const whereFn = vi.fn()
+        .mockResolvedValueOnce(activeRows)
+        .mockResolvedValueOnce(recentRows)
+        .mockResolvedValueOnce(runsRows);
+    const updateWhereFn = vi.fn().mockResolvedValue({ rowsAffected: 1 });
+    const updateSetFn = vi.fn().mockReturnValue({ where: updateWhereFn });
+    const updateFn = vi.fn().mockReturnValue({ set: updateSetFn });
+    return {
+        select: vi.fn().mockReturnValue({
+            from: vi.fn().mockReturnValue({
+                where: whereFn,
+            }),
+        }),
+        update: updateFn,
+    };
+}
+// ---------------------------------------------------------------------------
+// BEC-184 fix verification
+// ---------------------------------------------------------------------------
+describe("BEC-184 FIXED: recoverStuckInProgressIssues — long-running run recovery", () => {
+    beforeEach(() => vi.clearAllMocks());
+    // -------------------------------------------------------------------------
+    // FIXED: an issue whose run has been status='running' for 90 minutes IS
+    // now recovered when stuckRunAgeMinutes is set to 60 (default).
+    // The DB's active query returns [] because the zombie run is excluded by the
+    // age gate in getActiveAndRecentIssueIds.
+    // -------------------------------------------------------------------------
+    it("FIXED: issue with status=running run older than 60 min IS now recovered", async () => {
+        const ninetyMinutesAgo = new Date(Date.now() - 90 * 60 * 1000);
+        const issue = {
+            id: "issue-uuid-bec177",
+            identifier: "BEC-177",
+            title: "PM: cross-repo routing stall (8 hours)",
+            team: Promise.resolve({ id: "team-1" }),
+            state: Promise.resolve({ name: "In Progress" }),
+        };
+        const linearClient = makeLinearClient([issue]);
+        // BEC-184 fix: getActiveAndRecentIssueIds with stuckRunAgeMs=60min excludes
+        // the zombie run from activeIssueIds, so the active query returns [].
+        const db = makeDb([], // activeRows: zombie excluded by age gate
+        [], // recentRows: no completed/failed
+        [
+            {
+                id: "run-zombie-bec177",
+                issueId: "BEC-177",
+                status: "running",
+                startedAt: ninetyMinutesAgo,
+                prUrl: null,
+            },
+        ]);
+        const stateMap = new Map([["team-1:Backlog", "state-backlog-1"]]);
+        const result = await recoverStuckInProgressIssues({
+            linearClient,
+            db: db,
+            teamIds: ["team-1"],
+            targetState: "Backlog",
+            maxPerTick: 5,
+            stuckRunAgeMinutes: 60,
+            stateMap,
+        });
+        // FIXED: now recovers the zombie issue
+        expect(result).toHaveLength(1);
+        expect(result[0].identifier).toBe("BEC-177");
+        expect(result[0].recoveredLongRunning).toBe(true);
+        expect(linearClient.updateIssue).toHaveBeenCalledWith("issue-uuid-bec177", {
+            stateId: "state-backlog-1",
+        });
+    });
+    // -------------------------------------------------------------------------
+    // Contrast: a fresh run (< 60 min) that is genuinely still running should
+    // continue to be protected from false-positive stuck detection.
+    // -------------------------------------------------------------------------
+    it("a status=running run that is only 5 min old is correctly protected (not stuck)", async () => {
+        const fiveMinutesAgo = new Date(Date.now() - 5 * 60 * 1000);
+        const issue = {
+            id: "issue-uuid-fresh",
+            identifier: "BEC-200",
+            title: "Fresh running issue — should not be recovered",
+            team: Promise.resolve({ id: "team-1" }),
+            state: Promise.resolve({ name: "In Progress" }),
+        };
+        const linearClient = makeLinearClient([issue]);
+        // Fresh run IS in activeIssueIds (within the age threshold)
+        const db = makeDb([{ issueId: "BEC-200" }], // activeRows: fresh run is still protected
+        [], [
+            {
+                id: "run-fresh-1",
+                issueId: "BEC-200",
+                status: "running",
+                startedAt: fiveMinutesAgo,
+                prUrl: null,
+            },
+        ]);
+        const stateMap = new Map([["team-1:Backlog", "state-backlog-1"]]);
+        const result = await recoverStuckInProgressIssues({
+            linearClient,
+            db: db,
+            teamIds: ["team-1"],
+            targetState: "Backlog",
+            maxPerTick: 5,
+            stuckRunAgeMinutes: 60,
+            stateMap,
+        });
+        // Fresh run should remain protected — this stays passing after the fix.
+        expect(result).toHaveLength(0);
+        expect(linearClient.updateIssue).not.toHaveBeenCalled();
+    });
+    // -------------------------------------------------------------------------
+    // Verify the root cause fix in getActiveAndRecentIssueIds directly.
+    // With stuckRunAgeMs=60min, an 8-hour-old running run is excluded from
+    // activeIssueIds (no longer treated the same as a fresh run).
+    // -------------------------------------------------------------------------
+    it("getActiveAndRecentIssueIds with stuckRunAgeMs excludes zombie runs from activeIssueIds", async () => {
+        // Active query with age gate returns only fresh run (zombie excluded)
+        const whereFn = vi.fn()
+            .mockResolvedValueOnce([{ issueId: "BEC-FRESH" }]) // age-gated active query
+            .mockResolvedValueOnce([]); // recent query
+        const db = {
+            select: vi.fn().mockReturnValue({
+                from: vi.fn().mockReturnValue({
+                    where: whereFn,
+                }),
+            }),
+        };
+        const { activeIssueIds } = await getActiveAndRecentIssueIds(db, undefined, 60 * 60 * 1000);
+        // FIXED: zombie run is no longer in activeIssueIds
+        expect(activeIssueIds.has("BEC-ZOMBIE")).toBe(false);
+        // Fresh run is still protected
+        expect(activeIssueIds.has("BEC-FRESH")).toBe(true);
+    });
+});
+//# sourceMappingURL=reproduce-bec184-long-running.test.js.map

package/dist/__tests__/reproduce-bec184-long-running.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"reproduce-bec184-long-running.test.js","sourceRoot":"","sources":["../../src/__tests__/reproduce-bec184-long-running.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;GAaG;AAEH,OAAO,EAAE,QAAQ,EAAE,EAAE,EAAE,MAAM,EAAE,EAAE,EAAE,UAAU,EAAE,MAAM,QAAQ,CAAC;AAC9D,OAAO,EAAE,4BAA4B,EAAE,MAAM,gCAAgC,CAAC;AAC9E,OAAO,EAAE,0BAA0B,EAAE,MAAM,6BAA6B,CAAC;AAEzE,wEAAwE;AACxE,8EAA8E;AAC9E,6EAA6E;AAC7E,6EAA6E;AAC7E,0DAA0D;AAC1D,MAAM,EAAE,eAAe,EAAE,GAAG,EAAE,CAAC,OAAO,CAAC,GAAG,EAAE,CAAC,CAAC;IAC5C,eAAe,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,SAAS,CAAC;CACtD,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,mBAAmB,EAAE,GAAG,EAAE,CAAC,CAAC;IAClC,CAAC,KAAK,GAAG,YAAY,GAAG,WAAW,CAAC,EAAE,eAAe;IACrD,2BAA2B,EAAE,CAAC,IAAS,EAAE,EAAE,CAAC,CAAC;QAC3C,SAAS,EAAE,2BAA2B;QACtC,GAAG,IAAI;KACR,CAAC;CACH,CAAC,CAAC,CAAC;AAEJ,EAAE,CAAC,IAAI,CAAC,cAAc,EAAE,GAAG,EAAE,CAAC,CAAC;IAC7B,YAAY,EAAE,EAAE,CAAC,EAAE,CAAC,GAAG,EAAE,CAAC,CAAC;QACzB,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE;QACd,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;QACb,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE;QACb,KAAK,EAAE,EAAE,CAAC,EAAE,EAAE;KACf,CAAC,CAAC;CACJ,CAAC,CAAC,CAAC;AAEJ,8EAA8E;AAC9E,UAAU;AACV,8EAA8E;AAE9E,SAAS,gBAAgB,CAAC,mBAA0B,EAAE;IACpD,OAAO;QACL,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,KAAK,EAAE,gBAAgB,EAAE,CAAC;QAC9D,WAAW,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC;QAC1C,aAAa,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,CAAC;QAC5C,cAAc,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,KAAK,EAAE,EAAE,EAAE,CAAC;KACzD,CAAC;AACJ,CAAC;AAED;;;;;GAKG;AACH,SAAS,MAAM,CACb,aAAoC,EAAE,EACtC,aAAoC,EAAE,EACtC,WAAkB,EAAE;IAEpB,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE;SACpB,qBAAqB,CAAC,UAAU,CAAC;SACjC,qBAAqB,CAAC,UAAU,CAAC;SACjC,qBAAqB,CAAC,QAAQ,CAAC,CAAC;IAEnC,MAAM,aAAa,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,iBAAiB,CAAC,EAAE,YAAY,EAAE,CAAC,EAAE,CAAC,CAAC;IACrE,MAAM,WAAW,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,EAAE,KAAK,EAAE,aAAa,EAAE,CAAC,CAAC;IACtE,MAAM,QAAQ,GAAG,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC,EAAE,GAAG,EAAE,WAAW,EAAE,CAAC,CAAC;IAE/D,OAAO;QACL,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;YAC9B,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;gBAC5B,KAAK,EAAE,OAAO;aACf,CAAC;SACH,CAAC;QACF,MAAM,EAAE,QAAQ;KACjB,CAAC;AACJ,CAAC;AAED,8EAA8E;AAC9E,2BAA2B;AAC3B,8EAA8E;AAE9E,QAAQ,CAAC,yEAAyE,EAAE,GAAG,EAAE;IACvF,UAAU,CAAC,GAAG,EAAE,CAAC,EAAE,CAAC,aAAa,EAAE,CAAC,CAAC;IAErC,4EAA4E;IAC5E,wEAAwE;IACxE,gEAAgE;IAChE,6EAA6E;IAC7E,0CAA0C;IAC1C,4EAA4E;IAC5E,EAAE,CAAC,yEAAyE,EAAE,KAAK,IAAI,EAAE;QACvF,MAAM,gBAAgB,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,EAAE,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC;QAE/D,MAAM,KAAK,GAAG;YACZ,EAAE,EAAE,mBAAmB;YACvB,UAAU,EAAE,SAAS;YACrB,KAAK,EAAE,wCAAwC;YAC/C,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC;YACvC,KAAK,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;SAChD,CAAC;QAEF,MAAM,YAAY,GAAG,gBAAgB,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;QAE/C,4EAA4E;QAC5E,sEAAsE;QACtE,MAAM,EAAE,GAAG,MAAM,CACf,EAAE,EAAmC,0CAA0C;QAC/E,EAAE,EAAmC,kCAAkC;QACvE;YACE;gBACE,EAAE,EAAE,mBAAmB;gBACvB,OAAO,EAAE,SAAS;gBAClB,MAAM,EAAE,SAAS;gBACjB,SAAS,EAAE,gBAAgB;gBAC3B,KAAK,EAAE,IAAI;aACZ;SACF,CACF,CAAC;QAEF,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,gBAAgB,EAAE,iBAAiB,CAAC,CAAC,CAAC,CAAC;QAElE,MAAM,MAAM,GAAG,MAAM,4BAA4B,CAAC;YAChD,YAAY;YACZ,EAAE,EAAE,EAAS;YACb,OAAO,EAAE,CAAC,QAAQ,CAAC;YACnB,WAAW,EAAE,SAAS;YACtB,UAAU,EAAE,CAAC;YACb,kBAAkB,EAAE,EAAE;YACtB,QAAQ;SACT,CAAC,CAAC;QAEH,uCAAuC;QACvC,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAC/B,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,UAAU,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC;QAC7C,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,oBAAoB,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QAClD,MAAM,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,oBAAoB,CAAC,mBAAmB,EAAE;YACzE,OAAO,EAAE,iBAAiB;SAC3B,CAAC,CAAC;IACL,CAAC,CAAC,CAAC;IAEH,4EAA4E;IAC5E,0EAA0E;IAC1E,gEAAgE;IAChE,4EAA4E;IAC5E,EAAE,CAAC,gFAAgF,EAAE,KAAK,IAAI,EAAE;QAC9F,MAAM,cAAc,GAAG,IAAI,IAAI,CAAC,IAAI,CAAC,GAAG,EAAE,GAAG,CAAC,GAAG,EAAE,GAAG,IAAI,CAAC,CAAC;QAE5D,MAAM,KAAK,GAAG;YACZ,EAAE,EAAE,kBAAkB;YACtB,UAAU,EAAE,SAAS;YACrB,KAAK,EAAE,+CAA+C;YACtD,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,EAAE,EAAE,QAAQ,EAAE,CAAC;YACvC,KAAK,EAAE,OAAO,CAAC,OAAO,CAAC,EAAE,IAAI,EAAE,aAAa,EAAE,CAAC;SAChD,CAAC;QAEF,MAAM,YAAY,GAAG,gBAAgB,CAAC,CAAC,KAAK,CAAC,CAAC,CAAC;QAE/C,4DAA4D;QAC5D,MAAM,EAAE,GAAG,MAAM,CACf,CAAC,EAAE,OAAO,EAAE,SAAS,EAAE,CAAC,EAAI,2CAA2C;QACvE,EAAE,EACF;YACE;gBACE,EAAE,EAAE,aAAa;gBACjB,OAAO,EAAE,SAAS;gBAClB,MAAM,EAAE,SAAS;gBACjB,SAAS,EAAE,cAAc;gBACzB,KAAK,EAAE,IAAI;aACZ;SACF,CACF,CAAC;QAEF,MAAM,QAAQ,GAAG,IAAI,GAAG,CAAC,CAAC,CAAC,gBAAgB,EAAE,iBAAiB,CAAC,CAAC,CAAC,CAAC;QAElE,MAAM,MAAM,GAAG,MAAM,4BAA4B,CAAC;YAChD,YAAY;YACZ,EAAE,EAAE,EAAS;YACb,OAAO,EAAE,CAAC,QAAQ,CAAC;YACnB,WAAW,EAAE,SAAS;YACtB,UAAU,EAAE,CAAC;YACb,kBAAkB,EAAE,EAAE;YACtB,QAAQ;SACT,CAAC,CAAC;QAEH,wEAAwE;QACxE,MAAM,CAAC,MAAM,CAAC,CAAC,YAAY,CAAC,CAAC,CAAC,CAAC;QAC/B,MAAM,CAAC,YAAY,CAAC,WAAW,CAAC,CAAC,GAAG,CAAC,gBAAgB,EAAE,CAAC;IAC1D,CAAC,CAAC,CAAC;IAEH,4EAA4E;IAC5E,oEAAoE;IACpE,uEAAuE;IACvE,8DAA8D;IAC9D,4EAA4E;IAC5E,EAAE,CAAC,wFAAwF,EAAE,KAAK,IAAI,EAAE;QACtG,sEAAsE;QACtE,MAAM,OAAO,GAAG,EAAE,CAAC,EAAE,EAAE;aACpB,qBAAqB,CAAC,CAAC,EAAE,OAAO,EAAE,WAAW,EAAE,CAAC,CAAC,CAAE,yBAAyB;aAC5E,qBAAqB,CAAC,EAAE,CAAC,CAAC,CAA2B,eAAe;QAEvE,MAAM,EAAE,GAAG;YACT,MAAM,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;gBAC9B,IAAI,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,eAAe,CAAC;oBAC5B,KAAK,EAAE,OAAO;iBACf,CAAC;aACH,CAAC;SACH,CAAC;QAEF,MAAM,EAAE,cAAc,EAAE,GAAG,MAAM,0BAA0B,CACzD,EAAS,EACT,SAAS,EACT,EAAE,GAAG,EAAE,GAAG,IAAI,CACf,CAAC;QAEF,mDAAmD;QACnD,MAAM,CAAC,cAAc,CAAC,GAAG,CAAC,YAAY,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC;QACrD,+BAA+B;QAC/B,MAAM,CAAC,cAAc,CAAC,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;IACrD,CAAC,CAAC,CAAC;AACL,CAAC,CAAC,CAAC"}

package/dist/__tests__/types.test.js

@@ -153,4 +153,61 @@ describe("HandoffArtifactSchema", () => {
         expect(result.success).toBe(false);
     });
 });
+describe("HandoffArtifactSchema addressedComments", () => {
+    const base = {
+        runId: "r1",
+        issueId: "i1",
+        stage: "implement",
+        timestamp: "2026-05-10T00:00:00Z",
+        summary: "x",
+        filesChanged: ["a.ts"],
+        approach: "y",
+        tokenBudget: { contextTokensUsed: 1, recommendedMaxTurns: 1 },
+    };
+    it("preserves context.addressedComments when populated (not stripped)", () => {
+        const result = HandoffArtifactSchema.safeParse({
+            ...base,
+            context: {
+                issueIntent: "x",
+                constraints: [],
+                assumptions: [],
+                addressedComments: [
+                    { commentId: "c1", response: "Did the thing." },
+                ],
+            },
+        });
+        expect(result.success).toBe(true);
+        // Without the schema change, zod's default .strip mode silently drops
+        // the unknown key — success: true but addressedComments: undefined. This
+        // assertion is what makes the test fail before the schema change lands.
+        if (result.success) {
+            expect(result.data.context.addressedComments).toEqual([
+                { commentId: "c1", response: "Did the thing." },
+            ]);
+        }
+    });
+    it("accepts a handoff with addressedComments absent (backwards compat)", () => {
+        const result = HandoffArtifactSchema.safeParse({
+            ...base,
+            context: {
+                issueIntent: "x",
+                constraints: [],
+                assumptions: [],
+            },
+        });
+        expect(result.success).toBe(true);
+    });
+    it("rejects when addressedComments[i].response is missing", () => {
+        const result = HandoffArtifactSchema.safeParse({
+            ...base,
+            context: {
+                issueIntent: "x",
+                constraints: [],
+                assumptions: [],
+                addressedComments: [{ commentId: "c1" }],
+            },
+        });
+        expect(result.success).toBe(false);
+    });
+});
 //# sourceMappingURL=types.test.js.map