@uoyo/mvtt 2.0.0-beta.1 → 2.0.0-beta.2

package/sources/skills/mvt-design/manifest.yaml

@@ -1,96 +1,96 @@
-name: mvt-design
-output: .claude/skills/mvt-design/SKILL.md
-
-frontmatter:
-  name: mvt-design
-  description: "Create architecture design based on analyzed requirements. This skill should be used when user wants to design system architecture, define module structure, or create technical blueprints for implementation."
-
-sections:
-  - type: inline
-    content: |
-      # MVT Design
-
-      ## Purpose
-
-      Design system architecture based on analyzed requirements. Create technical blueprints that guide implementation, respecting existing project structure and constraints.
-
-  - type: shared
-    source: sections/role-header.md
-    params:
-      role: Architect
-      role_desc: "a System Architecture Expert"
-      decision_rules:
-        - rule: "Multiple valid approaches exist -> Present top 2-3 options with pros/cons table, recommend one"
-        - rule: "Trade-off affects performance vs maintainability -> Document as ADR, state the trade-off"
-        - rule: "User asks for technology choice -> Evaluate against: requirements fit, team familiarity, maintenance cost"
-        - rule: "Design needs breaking change -> Highlight impact scope, list affected files, propose migration"
-        - rule: "Requirements are ambiguous -> Stop and ask clarification before designing"
-        - rule: "Layer constraint violation in design -> Flag and suggest alternative that respects existing boundaries"
-      boundaries:
-        - scope: "write implementation code"
-          skill: "/mvt-implement"
-        - scope: "re-analyze requirements"
-          skill: "/mvt-analyze"
-        - scope: "review code"
-          skill: "/mvt-review"
-
-  - type: inline
-    content: |
-      ## Variants
-
-      | Variant | Description |
-      |---------|-------------|
-      | `/mvt-design` | Full architecture design |
-      | `/mvt-design --plan` | High-level implementation plan only |
-
-  - type: shared
-    source: sections/activation-load-context.md
-    params:
-      extended_context:
-        - ".ai-agents/workspace/artifacts/{active_change.id}/analysis.md -- Analysis from previous phase"
-
-  - type: shared
-    source: sections/activation-load-config.md
-
-  - type: shared
-    source: sections/output-language-constraint.md
-
-  - type: shared
-    source: sections/activation-preflight.md
-    params:
-      checks:
-        - order: "1"
-          field: "session.initialized_at"
-          level: "BLOCK"
-          message: "Session not initialized. Run `/mvt-init` first."
-        - order: "2"
-          field: "projects[] in project-context.yaml"
-          level: "BLOCK"
-          message: "Project not initialized. Run `/mvt-init` first."
-        - order: "3"
-          field: "project-context.md"
-          level: "WARN"
-          message: "No project-context.md found. Run `/mvt-analyze-code` for better design context. (allow user to proceed)"
-        - order: "4"
-          field: "requirements in project-context.md"
-          level: "WARN"
-          message: "No requirements found. Run `/mvt-analyze` first. (allow user to proceed)"
-
-  - type: file
-    source: ./business.md
-
-  - type: inline
-    content: |
-      ## Artifact Structure
-      Read the document structure template from: `.ai-agents/skills/_templates/design-output.md`
-      If a custom version exists at `.ai-agents/skills/_templates/custom/design-output.md`, use the custom version instead.
-      The template defines section headings only. Generate content for each section based on design results.
-      Write the artifact to: `.ai-agents/workspace/artifacts/{change-id}/design.md`
-
-  - type: shared
-    source: sections/session-update.md
-
-  - type: shared
-    source: sections/footer-next-steps.md
-    params:
-      current_skill: mvt-design
+name: mvt-design
+output: .claude/skills/mvt-design/SKILL.md
+
+frontmatter:
+  name: mvt-design
+  description: "Create architecture design based on analyzed requirements. This skill should be used when user wants to design system architecture, define module structure, or create technical blueprints for implementation."
+
+sections:
+  - type: inline
+    content: |
+      # MVT Design
+
+      ## Purpose
+
+      Design system architecture based on analyzed requirements. Create technical blueprints that guide implementation, respecting existing project structure and constraints.
+
+  - type: shared
+    source: sections/role-header.md
+    params:
+      role: Architect
+      role_desc: "a System Architecture Expert"
+      decision_rules:
+        - rule: "Multiple valid approaches exist -> Present top 2-3 options with pros/cons table, recommend one"
+        - rule: "Trade-off affects performance vs maintainability -> Document as ADR, state the trade-off"
+        - rule: "User asks for technology choice -> Evaluate against: requirements fit, team familiarity, maintenance cost"
+        - rule: "Design needs breaking change -> Highlight impact scope, list affected files, propose migration"
+        - rule: "Requirements are ambiguous -> Stop and ask clarification before designing"
+        - rule: "Layer constraint violation in design -> Flag and suggest alternative that respects existing boundaries"
+      boundaries:
+        - scope: "write implementation code"
+          skill: "/mvt-implement"
+        - scope: "re-analyze requirements"
+          skill: "/mvt-analyze"
+        - scope: "review code"
+          skill: "/mvt-review"
+
+  - type: inline
+    content: |
+      ## Variants
+
+      | Variant | Description |
+      |---------|-------------|
+      | `/mvt-design` | Full architecture design |
+      | `/mvt-design --plan` | High-level implementation plan only |
+
+  - type: shared
+    source: sections/activation-load-context.md
+    params:
+      extended_context:
+        - ".ai-agents/workspace/artifacts/{active_change.id}/analysis.md -- Analysis from previous phase"
+
+  - type: shared
+    source: sections/activation-load-config.md
+
+  - type: shared
+    source: sections/output-language-constraint.md
+
+  - type: shared
+    source: sections/activation-preflight.md
+    params:
+      checks:
+        - order: "1"
+          field: "session.initialized_at"
+          level: "BLOCK"
+          message: "Session not initialized. Run `/mvt-init` first."
+        - order: "2"
+          field: "projects[] in project-context.yaml"
+          level: "BLOCK"
+          message: "Project not initialized. Run `/mvt-init` first."
+        - order: "3"
+          field: "project-context.md"
+          level: "WARN"
+          message: "No project-context.md found. Run `/mvt-analyze-code` for better design context. (allow user to proceed)"
+        - order: "4"
+          field: "requirements in project-context.md"
+          level: "WARN"
+          message: "No requirements found. Run `/mvt-analyze` first. (allow user to proceed)"
+
+  - type: file
+    source: ./business.md
+
+  - type: inline
+    content: |
+      ## Artifact Structure
+      Read the document structure template from: `.ai-agents/skills/_templates/design-output.md`
+      If a custom version exists at `.ai-agents/skills/_templates/custom/design-output.md`, use the custom version instead.
+      The template defines section headings only. Generate content for each section based on design results.
+      Write the artifact to: `.ai-agents/workspace/artifacts/{change-id}/design.md`
+
+  - type: shared
+    source: sections/session-update.md
+
+  - type: shared
+    source: sections/footer-next-steps.md
+    params:
+      current_skill: mvt-design

package/sources/skills/mvt-fix/business.md

@@ -1,13 +1,35 @@
 ## Execution Flow
 
-### Step 1: Load Inputs
-- **Required**:
-  - User-provided bug description (free text, possibly with stack trace, error message, or reproduction steps).
+### Step 1: Resolve Input Source
+- Determine the diagnosis source by checking in priority order:
+
+  | Priority | Source | Condition | What to Load |
+  |----------|--------|-----------|--------------|
+  | 1 | Review artifact | `review.md` exists in active change artifacts | Critical + Warning findings as fix targets |
+  | 2 | Bug detection result | `/mvt-bug-detect` was executed in the current conversation | Root cause, affected files, severity, reproduction status from conversation history |
+  | 3 | Direct user input | User provided bug description in conversation | Bug description text |
+
+- **1a. Review artifact (mvt-review output)**
+  - Read `.ai-agents/workspace/artifacts/{active_change.id}/review.md`
+  - Extract Critical + Warning findings as fix targets. For each finding: file, line range, observation, recommendation serve as pre-verified diagnosis.
+  - If multiple Critical findings exist, ask user which to address first.
+  - Skip Steps 2-4, proceed directly to Step 5.
+
+- **1b. Bug detection result (mvt-bug-detect output)**
+  - Extract analysis results from the most recent `/mvt-bug-detect` execution in conversation history: Status, Root Cause, Severity, Affected files, Similar issues.
+  - If Status is `NotABug` or `Inconclusive` — STOP, report finding, do not proceed to fix.
+  - Skip Steps 2-4, proceed directly to Step 5 with extracted context.
+
+- **1c. Direct user input (no upstream artifact)**
+  - Read bug description from user message.
+  - Execute Steps 2-4 for self-contained diagnosis.
+
+- **Fallback**: If no source yields content, ask user to describe the bug or run `/mvt-bug-detect` first.
 - **Recommended (read if available, do not block on absence)**:
   - Recent git state: `git diff HEAD`, `git log -n 10 --oneline` -- to surface recent changes that may correlate with the regression.
-- **Fallback**: if none of the above exists, proceed using the bug description alone and note "context-light fix" in the final fix notes.
 
-### Step 2: Reproduce & Localize
+### Step 2: Reproduce & Localize (only for source 1c)
+**Skip this step if Step 1 resolved to source 1a (review artifact) or 1b (bug detection).**
 - **What**: confirm the bug is reproducible (or, if not reproducible, mark it explicitly as "report-only") and identify the smallest set of files that contain the suspected fault.
 - **How**:
   1. Extract concrete signals from the bug description: error message text, stack trace frames, file paths, function/class names, input data.
@@ -22,7 +44,8 @@
   | Not reproducible, signals are concrete (stack trace + paths) | Continue with static analysis only, mark "unverified repro" in fix notes |
   | Not reproducible, signals are vague | STOP -- ask user for: minimal repro, exact error, environment, last-known-good version |
 
-### Step 3: Generate Hypotheses
+### Step 3: Generate Hypotheses (only for source 1c)
+**Skip this step if Step 1 resolved to source 1a or 1b.**
 - **What**: produce 1-5 candidate root causes, each with a falsifiable check.
 - **How**: derive hypotheses from the dominant input signal using the table below. Combine sources when multiple are available.
 
@@ -35,7 +58,8 @@
 
 - Each hypothesis must be written as: `<claim> -- evidence: <pointer> -- check: <how to verify>`.
 
-### Step 4: Verify Root Cause
+### Step 4: Verify Root Cause (only for source 1c)
+**Skip this step if Step 1 resolved to source 1a or 1b.**
 - **What**: reduce the hypothesis set to one confirmed root cause.
 - **How**:
   1. For each hypothesis, run its check (read code, add tracing, run a focused script). Cheapest check first.
@@ -52,6 +76,9 @@
 ### Step 5: Plan the Fix
 - **What**: decide the change scope and minimum-risk patch shape.
 - **How**: classify the fix using the table below. Choose the strategy that matches the smallest viable scope -- escalate only if the smaller scope cannot fully address the root cause.
+- For source 1a (review.md): each Critical/Warning finding maps to a fix; classify individually.
+- For source 1b (bug detection result): use the root cause and affected files from the diagnosis to determine fix class directly.
+- For source 1c: classify based on self-contained diagnosis from Steps 2-4.
 
   | Fix class | Indicator | Strategy |
   |-----------|-----------|----------|
@@ -73,6 +100,7 @@
 - **Confirmation prompt format**: present `Root cause: ...`, `Proposed change: <files + summary>`, `Risk: <regression scope>`, then ask `Apply? (y / n / show-diff)`.
 
 ### Step 7: Apply the Fix
+- For source 1a (review.md): apply fixes per finding; re-run the review's relevant checks (not reproduction) to confirm each fix addresses its finding.
 - Make the targeted code change.
 - If no test covered the regression and the fix class is multi-module or above, add a minimal regression test alongside the fix.
 - Re-run the original repro (if any) to confirm resolution.
@@ -82,8 +110,9 @@
 - **Path**: `.ai-agents/workspace/artifacts/{change-id}/fix-notes.md` if an `active_change` exists; otherwise inline in the conversation only (no artifact -- shortcut operation).
 - **Structure** (each section is a single paragraph or list):
   - `Symptom` -- what the user saw / reported.
+  - `Input Source` -- "Review artifact" | "Bug detection result" | "Direct user input".
   - `Reproduction` -- verified | unverified | not-applicable, with steps if verified.
-  - `Hypotheses considered` -- bulleted, one line each, marking the confirmed one.
+  - `Hypotheses considered` -- bulleted, one line each, marking the confirmed one. (Skip if source 1a or 1b provided a pre-verified root cause.)
   - `Root cause` -- one paragraph.
   - `Patch summary` -- files touched + one-line per file.
   - `Regression risk` -- scope of behavior potentially affected, plus what tests guard it.

package/sources/skills/mvt-fix/manifest.yaml

@@ -1,72 +1,85 @@
-name: mvt-fix
-output: .claude/skills/mvt-fix/SKILL.md
-
-frontmatter:
-  name: mvt-fix
-  description: "Diagnose and fix bugs or issues in the codebase. This skill should be used when user reports a bug, encounters an error, or wants to diagnose and resolve an issue."
-
-sections:
-  - type: inline
-    content: |
-      # MVT Fix
-
-      ## Purpose
-
-      Diagnose bugs and issues, perform root cause analysis, and apply targeted fixes. This is a shortcut operation that can run at any time without requiring full workflow state.
-
-  - type: shared
-    source: sections/role-header.md
-    params:
-      role: Developer
-      role_desc: "an Implementation Specialist"
-      decision_rules:
-        - rule: "Bug description provided -> Analyze the issue, propose fix, apply after user confirms"
-        - rule: "Error message provided -> Trace to root cause, fix the source not the symptom"
-        - rule: "Multiple possible causes -> List hypotheses with evidence, verify each"
-        - rule: "Fix requires architecture change -> Stop and suggest `/mvt-design`"
-        - rule: "Fix affects other modules -> Document impact scope before applying"
-      boundaries:
-        - scope: "re-analyze requirements"
-          skill: "/mvt-analyze"
-        - scope: "evaluate architecture"
-          skill: "/mvt-design"
-        - scope: "review own fix"
-          skill: "/mvt-review"
-
-  - type: shared
-    source: sections/activation-load-context.md
-    params:
-      extended_context:
-        - "Related source files only (load based on bug description)"
-
-  - type: shared
-    source: sections/activation-load-config.md
-
-  - type: shared
-    source: sections/output-language-constraint.md
-
-  - type: shared
-    source: sections/activation-preflight.md
-    params:
-      checks:
-        - order: "1"
-          field: "session.initialized_at"
-          level: "WARN"
-          message: 'Session not initialized. Run `/mvt-init` first.'
-
-  - type: inline
-    content: |
-      ### Shortcut Operation Rules
-      - Can execute at any time without checking workflow prerequisites
-      - Do NOT update `progress` (this is a shortcut operation, not a workflow phase)
-
-  - type: file
-    source: ./business.md
-
-  - type: shared
-    source: sections/session-update.md
-
-  - type: shared
-    source: sections/footer-next-steps.md
-    params:
-      current_skill: mvt-fix
+name: mvt-fix
+output: .claude/skills/mvt-fix/SKILL.md
+
+frontmatter:
+  name: mvt-fix
+  description: "Diagnose and fix bugs or issues in the codebase. This skill should be used when user reports a bug, encounters an error, or wants to diagnose and resolve an issue."
+
+sections:
+  - type: inline
+    content: |
+      # MVT Fix
+
+      ## Purpose
+
+      Diagnose bugs and issues, perform root cause analysis, and apply targeted fixes. This is a shortcut operation that can run at any time without requiring full workflow state.
+
+  - type: shared
+    source: sections/role-header.md
+    params:
+      role: Developer
+      role_desc: "an Implementation Specialist"
+      decision_rules:
+        - rule: "Bug description provided -> Analyze the issue, propose fix, apply after user confirms"
+        - rule: "Error message provided -> Trace to root cause, fix the source not the symptom"
+        - rule: "Multiple possible causes -> List hypotheses with evidence, verify each"
+        - rule: "Fix requires architecture change -> Stop and suggest `/mvt-design`"
+        - rule: "Fix affects other modules -> Document impact scope before applying"
+      boundaries:
+        - scope: "re-analyze requirements"
+          skill: "/mvt-analyze"
+        - scope: "evaluate architecture"
+          skill: "/mvt-design"
+        - scope: "review own fix"
+          skill: "/mvt-review"
+        - scope: "diagnose bugs without fixing"
+          skill: "/mvt-bug-detect"
+
+  - type: shared
+    source: sections/activation-load-context.md
+    params:
+      extended_context:
+        - "Related source files only (load based on bug description)"
+
+  - type: shared
+    source: sections/activation-load-config.md
+
+  - type: shared
+    source: sections/output-language-constraint.md
+
+  - type: shared
+    source: sections/activation-preflight.md
+    params:
+      checks:
+        - order: "1"
+          field: "session.initialized_at"
+          level: "WARN"
+          message: 'Session not initialized. Run `/mvt-init` first.'
+
+  - type: inline
+    content: |
+      ### Shortcut Operation Rules
+      - Can execute at any time without checking workflow prerequisites
+      - Do NOT update `progress` (this is a shortcut operation, not a workflow phase)
+
+  - type: file
+    source: ./business.md
+
+  - type: shared
+    source: sections/session-update.md
+
+  - type: shared
+    source: sections/footer-next-steps.md
+    params:
+      current_skill: mvt-fix
+      conditional_suggestions:
+        conditions:
+          - condition: "fix applied, root cause had wide impact"
+            primary: "mvt-review"
+            primary_desc: "Review the fix for side effects"
+          - condition: "fix applied, needs test coverage"
+            primary: "mvt-test"
+            primary_desc: "Add regression tests"
+          - condition: "bug too complex for targeted fix"
+            primary: "mvt-design"
+            primary_desc: "Design architectural solution"

package/sources/skills/mvt-help/manifest.yaml

@@ -1,67 +1,67 @@
-name: mvt-help
-output: .claude/skills/mvt-help/SKILL.md
-
-frontmatter:
-  name: mvt-help
-  description: "Show available skills, current project status, and workflow guidance. This skill should be used when user is new to MVTT, wants to discover available commands, or needs guidance on what to do next."
-
-sections:
-  - type: inline
-    content: |
-      # MVT Help
-
-      ## Purpose
-
-      Navigate the MVTT framework by showing available skills, current project status, and contextual guidance on what to do next. Entry point for new users and quick reference for experienced ones.
-
-      ## Role
-
-      You are the **Conductor** -- a Workflow Coordinator.
-
-  - type: shared
-    source: sections/activation-load-context.md
-
-  - type: shared
-    source: sections/activation-load-config.md
-
-  - type: shared
-    source: sections/output-language-constraint.md
-
-  - type: inline
-    content: |
-      ### Step 3: Pre-flight Checks
-      - No blocking checks required.
-
-  - type: file
-    source: ./business.md
-
-  - type: inline
-    content: |
-      ## Output Format
-
-      Output is generated inline (no external template). Structure:
-
-      ```markdown
-      ## MVT Help
-
-      ### Current Status
-      - **Project**: {name} ({initialized/not initialized})
-      - **Last Skill**: {last command from skill_history}
-      - **Recommended Next**: `/mvt-{next}` -- {description}
-
-      ### Workflow
-      {Mermaid flowchart with current position highlighted}
-
-      ### Available Skills
-      {Skills tables grouped by category, as defined in Step 3}
-      ```
-
-  - type: shared
-    source: sections/session-update.md
-    params:
-      read_only: true
-
-  - type: shared
-    source: sections/footer-next-steps.md
-    params:
-      current_skill: mvt-help
+name: mvt-help
+output: .claude/skills/mvt-help/SKILL.md
+
+frontmatter:
+  name: mvt-help
+  description: "Show available skills, current project status, and workflow guidance. This skill should be used when user is new to MVTT, wants to discover available commands, or needs guidance on what to do next."
+
+sections:
+  - type: inline
+    content: |
+      # MVT Help
+
+      ## Purpose
+
+      Navigate the MVTT framework by showing available skills, current project status, and contextual guidance on what to do next. Entry point for new users and quick reference for experienced ones.
+
+      ## Role
+
+      You are the **Conductor** -- a Workflow Coordinator.
+
+  - type: shared
+    source: sections/activation-load-context.md
+
+  - type: shared
+    source: sections/activation-load-config.md
+
+  - type: shared
+    source: sections/output-language-constraint.md
+
+  - type: inline
+    content: |
+      ### Step 3: Pre-flight Checks
+      - No blocking checks required.
+
+  - type: file
+    source: ./business.md
+
+  - type: inline
+    content: |
+      ## Output Format
+
+      Output is generated inline (no external template). Structure:
+
+      ```markdown
+      ## MVT Help
+
+      ### Current Status
+      - **Project**: {name} ({initialized/not initialized})
+      - **Last Skill**: {last command from skill_history}
+      - **Recommended Next**: `/mvt-{next}` -- {description}
+
+      ### Workflow
+      {Mermaid flowchart with current position highlighted}
+
+      ### Available Skills
+      {Skills tables grouped by category, as defined in Step 3}
+      ```
+
+  - type: shared
+    source: sections/session-update.md
+    params:
+      read_only: true
+
+  - type: shared
+    source: sections/footer-next-steps.md
+    params:
+      current_skill: mvt-help