@univerjs/slides-ui 0.2.8 → 0.2.9

package/lib/es/index.js

@@ -145,13 +145,6 @@ var __defProp$9 = Object.defineProperty, __getOwnPropDesc$9 = Object.getOwnPrope
   return kind && result && __defProp$9(target, key, result), result;
 }, "__decorateClass$9"), __decorateParam$9 = /* @__PURE__ */ __name((index, decorator) => (target, key) => decorator(target, key, index), "__decorateParam$9"), _a;
 let SlideRenderController = (_a = class extends RxDisposable {
-  /**
-   * As a dep of UNIVER_SLIDE, init by RenderManagerService@createRender --> injector.get(dep)
-   * @param _renderContext
-   * @param _injector
-   * @param _univerInstanceService
-   * @param _renderManagerService
-   */
   constructor(_renderContext, _injector, _univerInstanceService, _renderManagerService) {
     super();
     __publicField(this, "_objectProvider", null);
@@ -160,9 +153,6 @@ let SlideRenderController = (_a = class extends RxDisposable {
     }, 300));
     this._renderContext = _renderContext, this._injector = _injector, this._univerInstanceService = _univerInstanceService, this._renderManagerService = _renderManagerService, this._objectProvider = this._injector.createInstance(ObjectProvider), this._addNewRender();
   }
-  /**
-   * _initialize --> _create --> _addNewRender
-   */
   _addNewRender() {
     const { unitId, engine, scene } = this._renderContext, slideDataModel = this._getCurrUnitModel();
     if (!slideDataModel) return;
@@ -213,7 +203,6 @@ let SlideRenderController = (_a = class extends RxDisposable {
     return this._renderManagerService.getCurrentTypeOfRenderer(UniverInstanceType.UNIVER_SLIDE);
   }
   /**
-   * init --> _addNewRender
    * @param mainScene
    */
   _createSlide(mainScene) {
@@ -259,8 +248,7 @@ let SlideRenderController = (_a = class extends RxDisposable {
     slide.renderToThumb(thumbContext, pageId, pageWidth / width, pageHeight / height);
   }
   /**
-   * _createScene by pages, createScene --> set sceneMap
-   * invoked stack: initialize --> _create --> _addNewRender --> _createSlidePages
+   * CreateScene by pages, and activate first one.
    * @param slideDataModel
    * @param slide
    */
@@ -314,12 +302,9 @@ let SlideRenderController = (_a = class extends RxDisposable {
       }
   }
   /**
-   * _initialize --> _create --> _addNewRender --> _createSlidePages --> page forEach --> createPageScene
-   * _sceneMap.set(pageId, pageScene);
-   *
+   * Create scene by page and set to _sceneMap.
    * @param pageId
    * @param page
-   * @returns pageScene: Scene
    */
   createPageScene(pageId, page) {
     const render2 = this._renderContext;
@@ -350,10 +335,9 @@ let SlideRenderController = (_a = class extends RxDisposable {
     }), slide.addPageScene(pageScene), pageScene;
   }
   /**
-   * get pageScene from Slide
-   * pageScene was added to the mainComponent(Slide) in createPageScene --> slide.addPageScene
+   * Get pageScene from Slide.
    * @param pageId
-   * @returns {Scene, Engine, UnitModel}
+   * @returns {Scene, Engine, UnitModel} scene & engine & unit from renderContext
    */
   getPageRenderUnit(pageId) {
     const pageScene = this._renderContext.mainComponent.getSubScenes().get(pageId), { engine, unit } = this._renderContext;
@@ -1666,7 +1650,6 @@ let SlideEditorBridgeService = (_a6 = class extends Disposable {
   }
   /**
    * 1st part of startEditing.
-   * editorBridgeRenderController@startEditing ---> editorBridgeRenderController@_updateEditor
    * @editorInfo editorInfo
    */
   setEditorRect(editorInfo) {
@@ -1980,16 +1963,7 @@ let SlideEditingRenderController = (_a8 = class extends Disposable {
     }));
   }
   /**
-   * set size and pos of editing area
-   * invoked by _handleEditorVisible
-   *
-   * size & pos derives from slide-editor-bridge.service.ts@getEditRectState.position
-   *
-   * set pos of editing area
-   * EditorContainer.tsx cellEditorManagerService.setFocus(true) -->
-   * _focus$.next --> editingRenderController -->
-   * _textSelectionRenderManager.sync() --> _updateInputPosition --> activate(left, top)
-   *
+   * Set size and pos of editing area.
    * @param positionFromEditRectState
    * @param canvasOffset
    * @param documentSkeleton
@@ -2107,14 +2081,13 @@ let SlideEditingRenderController = (_a8 = class extends Disposable {
     })));
   }
   /**
-   * show input area, resize input area and then place input to right place.
-   * invoked when this._editorBridgeService.visible$ param.visible = true
-   *
-   * handleVisible is the 2nd part of editing.
-   * startEditing --> _updateEditor
-   * startEditing --> changeVisible --> slide-editor-bridge.render-controller.ts@changeVisible --> _editorBridgeService.changeVisible
+   * Show input area, resize input area and then place input to right place.
+   * @TODO why do resize in show input area?
    * @param param
    */
+  // handleVisible is the 2nd part of editing.
+  // first part: startEditing --> _updateEditor
+  // 2nd part: startEditing --> changeVisible --> slide-editor-bridge.render-controller.ts@changeVisible --> _editorBridgeService.changeVisible
   _handleEditorVisible(param) {
     var _a11, _b;
     const { eventType } = param;

package/lib/types/controllers/slide-editing.render-controller.d.ts

@@ -40,16 +40,7 @@ export declare class SlideEditingRenderController extends Disposable implements
      */
     private _subscribeToCurrentCell;
     /**
-     * set size and pos of editing area
-     * invoked by _handleEditorVisible
-     *
-     * size & pos derives from slide-editor-bridge.service.ts@getEditRectState.position
-     *
-     * set pos of editing area
-     * EditorContainer.tsx cellEditorManagerService.setFocus(true) -->
-     * _focus$.next --> editingRenderController -->
-     * _textSelectionRenderManager.sync() --> _updateInputPosition --> activate(left, top)
-     *
+     * Set size and pos of editing area.
      * @param positionFromEditRectState
      * @param canvasOffset
      * @param documentSkeleton
@@ -72,12 +63,8 @@ export declare class SlideEditingRenderController extends Disposable implements
      */
     private _addBackground;
     /**
-     * show input area, resize input area and then place input to right place.
-     * invoked when this._editorBridgeService.visible$ param.visible = true
-     *
-     * handleVisible is the 2nd part of editing.
-     * startEditing --> _updateEditor
-     * startEditing --> changeVisible --> slide-editor-bridge.render-controller.ts@changeVisible --> _editorBridgeService.changeVisible
+     * Show input area, resize input area and then place input to right place.
+     * @TODO why do resize in show input area?
      * @param param
      */
     private _handleEditorVisible;

package/lib/types/controllers/slide.render-controller.d.ts

@@ -7,23 +7,12 @@ export declare class SlideRenderController extends RxDisposable implements IRend
     private readonly _univerInstanceService;
     private readonly _renderManagerService;
     private _objectProvider;
-    /**
-     * As a dep of UNIVER_SLIDE, init by RenderManagerService@createRender --> injector.get(dep)
-     * @param _renderContext
-     * @param _injector
-     * @param _univerInstanceService
-     * @param _renderManagerService
-     */
     constructor(_renderContext: IRenderContext<UnitModel>, _injector: Injector, _univerInstanceService: IUniverInstanceService, _renderManagerService: IRenderManagerService);
-    /**
-     * _initialize --> _create --> _addNewRender
-     */
     private _addNewRender;
     private _scrollToCenter;
     private _currentRender;
     private _refreshThumb;
     /**
-     * init --> _addNewRender
      * @param mainScene
      */
     private _createSlide;
@@ -31,8 +20,7 @@ export declare class SlideRenderController extends RxDisposable implements IRend
     private _getCenterPositionViewPort;
     private _thumbSceneRender;
     /**
-     * _createScene by pages, createScene --> set sceneMap
-     * invoked stack: initialize --> _create --> _addNewRender --> _createSlidePages
+     * CreateScene by pages, and activate first one.
      * @param slideDataModel
      * @param slide
      */
@@ -45,19 +33,15 @@ export declare class SlideRenderController extends RxDisposable implements IRend
     activePage(_pageId?: string): void;
     createThumbs(): void;
     /**
-     * _initialize --> _create --> _addNewRender --> _createSlidePages --> page forEach --> createPageScene
-     * _sceneMap.set(pageId, pageScene);
-     *
+     * Create scene by page and set to _sceneMap.
      * @param pageId
      * @param page
-     * @returns pageScene: Scene
      */
-    createPageScene(pageId: string, page: ISlidePage): Scene | undefined;
+    createPageScene(pageId: string, page: ISlidePage): Nullable<Scene>;
     /**
-     * get pageScene from Slide
-     * pageScene was added to the mainComponent(Slide) in createPageScene --> slide.addPageScene
+     * Get pageScene from Slide.
      * @param pageId
-     * @returns {Scene, Engine, UnitModel}
+     * @returns {Scene, Engine, UnitModel} scene & engine & unit from renderContext
      */
     getPageRenderUnit(pageId: PageID): {
         scene: Scene;

package/lib/types/services/slide-editor-bridge.service.d.ts

@@ -77,7 +77,6 @@ export declare class SlideEditorBridgeService extends Disposable implements ISli
     getEditorRect(): ISetEditorInfo;
     /**
      * 1st part of startEditing.
-     * editorBridgeRenderController@startEditing ---> editorBridgeRenderController@_updateEditor
      * @editorInfo editorInfo
      */
     setEditorRect(editorInfo: ISetEditorInfo): void;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@univerjs/slides-ui",
-  "version": "0.2.8",
+  "version": "0.2.9",
   "private": false,
   "description": "Univer normal ui-plugin-slides",
   "author": "DreamNum <developer@univer.ai>",
@@ -53,16 +53,16 @@
     "clsx": ">=2.0.0",
     "react": "^16.9.0 || ^17.0.0 || ^18.0.0",
     "rxjs": ">=7.0.0",
-    "@univerjs/core": "0.2.8",
-    "@univerjs/design": "0.2.8",
-    "@univerjs/docs": "0.2.8",
-    "@univerjs/drawing": "0.2.8",
-    "@univerjs/slides": "0.2.8",
-    "@univerjs/engine-render": "0.2.8",
-    "@univerjs/ui": "0.2.8"
+    "@univerjs/core": "0.2.9",
+    "@univerjs/design": "0.2.9",
+    "@univerjs/docs": "0.2.9",
+    "@univerjs/drawing": "0.2.9",
+    "@univerjs/engine-render": "0.2.9",
+    "@univerjs/slides": "0.2.9",
+    "@univerjs/ui": "0.2.9"
   },
   "dependencies": {
-    "@univerjs/icons": "^0.1.73"
+    "@univerjs/icons": "^0.1.77"
   },
   "devDependencies": {
     "@types/react": "^18.3.3",
@@ -73,14 +73,14 @@
     "typescript": "^5.5.4",
     "vite": "^5.4.0",
     "vitest": "^2.0.5",
-    "@univerjs/core": "0.2.8",
-    "@univerjs/drawing": "0.2.8",
-    "@univerjs/design": "0.2.8",
-    "@univerjs/docs": "0.2.8",
-    "@univerjs/engine-render": "0.2.8",
-    "@univerjs/slides": "0.2.8",
-    "@univerjs/shared": "0.2.8",
-    "@univerjs/ui": "0.2.8"
+    "@univerjs/core": "0.2.9",
+    "@univerjs/design": "0.2.9",
+    "@univerjs/docs": "0.2.9",
+    "@univerjs/drawing": "0.2.9",
+    "@univerjs/engine-render": "0.2.9",
+    "@univerjs/ui": "0.2.9",
+    "@univerjs/slides": "0.2.9",
+    "@univerjs/shared": "0.2.9"
   },
   "univerSpace": {
     ".": {