@univerjs/engine-formula 1.0.2 → 1.0.3

package/lib/index.js

@@ -9740,6 +9740,89 @@ function baseValueObjectToArrayValueObject(valueObject) {
 	if (valueObject.isArray()) return valueObject;
 	return ArrayValueObject.createByArray([[valueObject.getValue()]]);
 }
+function getEqualityValueKeys(value) {
+	const keys = [];
+	if (value.isString()) keys.push(normalizeTextForComparison(String(value.getValue())));
+	else if (!value.isNumber()) return keys;
+	const number = value.isNumber() ? value : createCriteriaValueObject(String(value.getValue()), value.getDateSystem());
+	if (number.isNumber() && Number.isFinite(Number(number.getValue()))) keys.push(stripErrorMargin(Number(number.getValue())));
+	return keys;
+}
+function buildEqualityIndex(range) {
+	const index = /* @__PURE__ */ new Map();
+	range.iterator((value, row, column) => {
+		if (!value) return;
+		const position = [row, column];
+		for (const key of getEqualityValueKeys(value)) {
+			let matches = index.get(key);
+			if (!matches) {
+				matches = [];
+				index.set(key, matches);
+			}
+			matches.push(position);
+		}
+	});
+	return index;
+}
+function getIndexedPositions(index, keys, range) {
+	const buckets = keys.map((key) => index.get(key) ?? []);
+	if (buckets.reduce((count, bucket) => count + bucket.length, 0) >= range.getRowCount() * range.getColumnCount() / 2) return;
+	if (buckets.length === 1) return buckets[0];
+	return Array.from(new Set(buckets.flat())).sort((a, b) => a[0] - b[0] || a[1] - b[1]);
+}
+function pickRangePositions(range, positions) {
+	return ArrayValueObject.create({
+		calculateValueList: positions.map(([row, column]) => [range.get(row, column)]),
+		rowCount: positions.length,
+		columnCount: 1,
+		unitId: "",
+		sheetId: "",
+		row: -1,
+		column: -1
+	});
+}
+function getExactCriteriaKeys(criteria) {
+	if (!criteria || !criteria.isString() && !criteria.isNumber()) return;
+	const [operator, value] = criteria.isString() ? findCompareToken(String(criteria.getValue()), criteria.getDateSystem()) : ["=", criteria];
+	if (operator !== "=" || value.isDateFormat()) return;
+	if (value.isString() && (value.getValue() === "" || isWildcard(String(value.getValue())))) return;
+	const keys = getEqualityValueKeys(value);
+	return keys.length > 0 ? keys : void 0;
+}
+function getCriteriaCacheKey(criteria) {
+	if (criteria.length === 0 || criteria.some((value) => getExactCriteriaKeys(value) === void 0)) return;
+	const values = criteria.map((value) => value.getValue());
+	return values.length === 1 ? values[0] : JSON.stringify(values);
+}
+function getCriteriaPositions(pairs, indexes, row, column) {
+	for (const { range, criteriaArray } of pairs) {
+		const keys = getExactCriteriaKeys(criteriaArray.get(row, column));
+		if (!keys) continue;
+		let index = indexes.get(range);
+		if (!index) {
+			index = buildEqualityIndex(range);
+			indexes.set(range, index);
+		}
+		const positions = getIndexedPositions(index, keys, range);
+		if (positions !== void 0) return positions;
+	}
+}
+function getConditionalAggregateResult(formulaName, comparison, targetRange) {
+	if (formulaName === "COUNTIFS") {
+		let count = 0;
+		comparison.iterator((value) => {
+			if ((value === null || value === void 0 ? void 0 : value.isBoolean()) && value.getValue() === true) count++;
+		});
+		return NumberValueObject.create(count);
+	}
+	const picked = targetRange === null || targetRange === void 0 ? void 0 : targetRange.pick(comparison);
+	switch (formulaName) {
+		case "SUMIFS": return picked.sum();
+		case "AVERAGEIFS": return picked.sum().divided(picked.count());
+		case "MAXIFS": return picked.getColumnCount() === 0 ? NumberValueObject.create(0) : picked.max();
+		case "MINIFS": return picked.getColumnCount() === 0 ? NumberValueObject.create(0) : picked.min();
+	}
+}
 /**
 * Get the paired range and criteria result for COUNTIFS, SUMIFS, etc.
 */
@@ -9758,50 +9841,48 @@ function getPairedRangeAndCriteriaResult(variants, params) {
 	}
 	if (rangeAndCriteriaArrays.length === 0) return [];
 	const results = [];
-	/**
-	* Iterate through all criteria values for each dimension, calculate the comparison result with the corresponding range, and then calculate the Boolean intersection of all comparison results as the final result for that dimension criteria value.
-	* Then calculate this dimension criteria value's result.
-	* This avoiding store the all dimension comparison result in memory and then calculating all dimension criteria value's result, which may cause memory overflow when the range is large and there are multiple dimension criteria.
-	* For example, `=COUNTIFS(Q$3:Q$10002,C$3:C$5002,R$3:R$10002,L6)`.
-	*/
+	const arrayPairs = rangeAndCriteriaArrays.filter((_, index) => {
+		const criteria = variants[index * 2 + 1];
+		return criteria.isArray() && criteria.getRowCount() * criteria.getColumnCount() > 1;
+	});
+	const useEqualityIndex = isNumberSensitive && maxRowLength * maxColumnLength > 1 && arrayPairs.length > 0;
+	const repeatedResults = /* @__PURE__ */ new Map();
+	const equalityIndexes = /* @__PURE__ */ new Map();
 	rangeAndCriteriaArrays[0].criteriaArray.iterator((_, rowIndex, columnIndex) => {
 		let finalCompareResult;
-		for (let i = 0; i < rangeAndCriteriaArrays.length; i++) {
-			const { range, criteriaArray } = rangeAndCriteriaArrays[i];
+		let positions;
+		const cacheKey = useEqualityIndex ? getCriteriaCacheKey(arrayPairs.map(({ criteriaArray }) => criteriaArray.get(rowIndex, columnIndex))) : void 0;
+		const cached = cacheKey === void 0 ? void 0 : repeatedResults.get(cacheKey);
+		if (cached) {
+			results[rowIndex] ??= [];
+			results[rowIndex][columnIndex] = cached;
+			return;
+		}
+		if (useEqualityIndex) {
+			positions = getCriteriaPositions(arrayPairs, equalityIndexes, rowIndex, columnIndex);
+			if ((positions === null || positions === void 0 ? void 0 : positions.length) === 0) {
+				results[rowIndex] ??= [];
+				results[rowIndex][columnIndex] = formulaName === "AVERAGEIFS" ? ErrorValueObject.create("#DIV/0!") : NumberValueObject.create(0);
+				return;
+			}
+		}
+		rangeAndCriteriaArrays.forEach(({ range: sourceRange, criteriaArray }) => {
+			const range = positions === void 0 ? sourceRange : pickRangePositions(sourceRange, positions);
 			const criteriaValueObject = criteriaArray.get(rowIndex, columnIndex);
-			if (!criteriaValueObject) continue;
+			if (!criteriaValueObject) return;
 			let compareResult = valueObjectCompare(range, criteriaValueObject);
 			if (isNumberSensitive) compareResult = filterSameValueObjectResult(compareResult, range, criteriaValueObject);
 			if (finalCompareResult === void 0) {
 				finalCompareResult = compareResult;
-				continue;
+				return;
 			}
 			finalCompareResult = booleanObjectIntersection(finalCompareResult, compareResult);
-		}
-		let result;
-		if (formulaName === "COUNTIFS") {
-			let count = 0;
-			finalCompareResult.iterator((value) => {
-				if ((value === null || value === void 0 ? void 0 : value.isBoolean()) && value.getValue() === true) count++;
-			});
-			result = NumberValueObject.create(count);
-		} else if (formulaName === "SUMIFS") result = targetRange.pick(finalCompareResult).sum();
-		else if (formulaName === "AVERAGEIFS") {
-			const picked = targetRange.pick(finalCompareResult);
-			const sum = picked.sum();
-			const count = picked.count();
-			result = sum.divided(count);
-		} else if (formulaName === "MAXIFS") {
-			const picked = targetRange.pick(finalCompareResult);
-			if (picked.getColumnCount() === 0) result = NumberValueObject.create(0);
-			else result = picked.max();
-		} else if (formulaName === "MINIFS") {
-			const picked = targetRange.pick(finalCompareResult);
-			if (picked.getColumnCount() === 0) result = NumberValueObject.create(0);
-			else result = picked.min();
-		}
+		});
+		const aggregateRange = positions === void 0 || !targetRange ? targetRange : pickRangePositions(targetRange, positions);
+		const result = getConditionalAggregateResult(formulaName, finalCompareResult, aggregateRange);
 		if (!results[rowIndex]) results[rowIndex] = [];
 		results[rowIndex][columnIndex] = result;
+		if (cacheKey !== void 0 && result) repeatedResults.set(cacheKey, result);
 	});
 	return results;
 }
@@ -36215,6 +36296,19 @@ var Sumif = class extends BaseFunction {
 		let _criteria = criteria;
 		if (criteria.isReferenceObject()) _criteria = criteria.toArrayValueObject();
 		if (_criteria.isArray()) {
+			const criteriaArray = _criteria;
+			const rangeArray = range.toArrayValueObject();
+			const targetArray = sumRange ? sumRange.toArrayValueObject() : rangeArray;
+			if (criteriaArray.getRowCount() * criteriaArray.getColumnCount() > 1 && rangeArray.getRowCount() === targetArray.getRowCount() && rangeArray.getColumnCount() === targetArray.getColumnCount()) {
+				const values = getPairedRangeAndCriteriaResult([rangeArray, criteriaArray], {
+					formulaName: "SUMIFS",
+					maxRowLength: criteriaArray.getRowCount(),
+					maxColumnLength: criteriaArray.getColumnCount(),
+					isNumberSensitive: true,
+					targetRange: targetArray
+				});
+				return criteriaArray.mapValue((_, row, column) => values[row][column]);
+			}
 			const resultArray = _criteria.mapValue((criteriaObject) => this._handleSingleObject(range, criteriaObject, sumRange));
 			if (resultArray.getRowCount() === 1 && resultArray.getColumnCount() === 1) return resultArray.get(0, 0);
 			return resultArray;
@@ -37200,6 +37294,19 @@ var Averageif = class extends BaseFunction {
 		let _criteria = criteria;
 		if (criteria.isReferenceObject()) _criteria = criteria.toArrayValueObject();
 		if (_criteria.isArray()) {
+			const criteriaArray = _criteria;
+			const rangeArray = range.toArrayValueObject();
+			const targetArray = averageRange ? averageRange.toArrayValueObject() : rangeArray;
+			if (criteriaArray.getRowCount() * criteriaArray.getColumnCount() > 1 && rangeArray.getRowCount() === targetArray.getRowCount() && rangeArray.getColumnCount() === targetArray.getColumnCount()) {
+				const values = getPairedRangeAndCriteriaResult([rangeArray, criteriaArray], {
+					formulaName: "AVERAGEIFS",
+					maxRowLength: criteriaArray.getRowCount(),
+					maxColumnLength: criteriaArray.getColumnCount(),
+					isNumberSensitive: true,
+					targetRange: targetArray
+				});
+				return criteriaArray.mapValue((_, row, column) => values[row][column]);
+			}
 			const resultArray = _criteria.mapValue((criteriaObject) => this._handleSingleObject(range, criteriaObject, averageRange));
 			if (resultArray.getRowCount() === 1 && resultArray.getColumnCount() === 1) return resultArray.get(0, 0);
 			return resultArray;
@@ -37618,6 +37725,18 @@ var Countif = class extends BaseFunction {
 			}
 		}
 		if (_criteria.isArray()) {
+			const criteriaArray = _criteria;
+			const rangeArray = range.toArrayValueObject();
+			if (criteriaArray.getRowCount() * criteriaArray.getColumnCount() > 1) {
+				const normalized = criteria.isReferenceObject() ? criteriaArray.mapValue((value) => value.isNull() ? NumberValueObject.create(0) : value) : criteriaArray;
+				const values = getPairedRangeAndCriteriaResult([rangeArray, normalized], {
+					formulaName: "COUNTIFS",
+					maxRowLength: criteriaArray.getRowCount(),
+					maxColumnLength: criteriaArray.getColumnCount(),
+					isNumberSensitive: true
+				});
+				return criteriaArray.mapValue((_, row, column) => values[row][column]);
+			}
 			const resultArray = _criteria.mapValue((criteriaObject) => this._handleSingleObject(range, criteria.isReferenceObject() && criteriaObject.isNull() ? NumberValueObject.create(0) : criteriaObject));
 			if (resultArray.getRowCount() === 1 && resultArray.getColumnCount() === 1) return resultArray.get(0, 0);
 			return resultArray;
@@ -43600,7 +43719,7 @@ function getObjectValue(result, isUseStrip = false) {
 //#endregion
 //#region package.json
 var name = "@univerjs/engine-formula";
-var version = "1.0.2";
+var version = "1.0.3";
 
 //#endregion
 //#region src/services/global-computing-status.service.ts