@unito/integration-sdk 1.4.2 → 1.4.4

package/dist/src/index.cjs

@@ -1366,7 +1366,7 @@ class Provider {
                         case 'TimeoutError':
                             throw this.handleError(408, 'Request timeout', options);
                     }
-                    throw this.handleError(500, `Unexpected error while calling the provider: name: "${error.name}" \n message: "${error.message}" \n stack: ${error.stack}`, options);
+                    throw this.handleError(500, `Unexpected error while calling the provider. ErrorName: "${error.name}" \n message: "${error.message}" \n stack: ${error.stack} \n cause: ${error.cause} \n causeStack: ${error.cause?.stack}`, options);
                 }
                 throw this.handleError(500, 'Unexpected error while calling the provider - this is not normal, investigate', options);
             }
@@ -1374,6 +1374,10 @@ class Provider {
                 const textResult = await response.text();
                 throw this.handleError(response.status, textResult, options);
             }
+            else if (response.status === 204 || response.body === null) {
+                // No content: return without inspecting the body
+                return { status: response.status, headers: response.headers, body: undefined };
+            }
             const responseContentType = response.headers.get('content-type');
             let body;
             if (options.rawBody || headers.Accept === 'application/octet-stream') {
@@ -1387,7 +1391,7 @@ class Provider {
                 if (responseContentType && !responseContentType.includes('application/json')) {
                     const textResult = await response.text();
                     throw this.handleError(500, `Unsupported content-type, expected 'application/json' but got '${responseContentType}'.
-             Original response (${response.status}): ${textResult}`, options);
+             Original response (${response.status}): "${textResult}"`, options);
                 }
                 try {
                     body = response.body ? await response.json() : undefined;

package/dist/src/resources/provider.js

@@ -267,7 +267,7 @@ export class Provider {
                         case 'TimeoutError':
                             throw this.handleError(408, 'Request timeout', options);
                     }
-                    throw this.handleError(500, `Unexpected error while calling the provider: name: "${error.name}" \n message: "${error.message}" \n stack: ${error.stack}`, options);
+                    throw this.handleError(500, `Unexpected error while calling the provider. ErrorName: "${error.name}" \n message: "${error.message}" \n stack: ${error.stack} \n cause: ${error.cause} \n causeStack: ${error.cause?.stack}`, options);
                 }
                 throw this.handleError(500, 'Unexpected error while calling the provider - this is not normal, investigate', options);
             }
@@ -275,6 +275,10 @@ export class Provider {
                 const textResult = await response.text();
                 throw this.handleError(response.status, textResult, options);
             }
+            else if (response.status === 204 || response.body === null) {
+                // No content: return without inspecting the body
+                return { status: response.status, headers: response.headers, body: undefined };
+            }
             const responseContentType = response.headers.get('content-type');
             let body;
             if (options.rawBody || headers.Accept === 'application/octet-stream') {
@@ -288,7 +292,7 @@ export class Provider {
                 if (responseContentType && !responseContentType.includes('application/json')) {
                     const textResult = await response.text();
                     throw this.handleError(500, `Unsupported content-type, expected 'application/json' but got '${responseContentType}'.
-             Original response (${response.status}): ${textResult}`, options);
+             Original response (${response.status}): "${textResult}"`, options);
                 }
                 try {
                     body = response.body ? await response.json() : undefined;

package/dist/test/resources/provider.test.js

@@ -452,6 +452,22 @@ describe('Provider', () => {
         assert.ok(providerResponse);
         assert.ok(providerResponse.body instanceof ReadableStream);
     });
+    it('returns successfully on unexpected content-type response with no body', async (context) => {
+        const response = new Response(null, {
+            status: 201,
+            headers: { 'Content-Type': 'html/text' },
+        });
+        context.mock.method(global, 'fetch', () => Promise.resolve(response));
+        const providerResponse = await provider.post('/endpoint/123', {}, {
+            credentials: { apiKey: 'apikey#1111' },
+            logger: logger,
+            signal: new AbortController().signal,
+        });
+        assert.ok(providerResponse);
+        assert.strictEqual(providerResponse.status, response.status);
+        assert.strictEqual(providerResponse.headers, response.headers);
+        assert.strictEqual(providerResponse.body, undefined);
+    });
     it('throws on invalid json response', async (context) => {
         const response = new Response('{invalidJSON}', {
             status: 200,
@@ -553,7 +569,7 @@ describe('Provider', () => {
     });
     it('throws on unknown errors', async (context) => {
         context.mock.method(global, 'fetch', () => {
-            throw new Error('foo');
+            throw new TypeError('foo', { cause: new Error('bar') });
         });
         let error;
         try {
@@ -567,10 +583,12 @@ describe('Provider', () => {
             error = e;
         }
         assert.ok(error instanceof HttpErrors.HttpError);
-        assert.ok(error.message.startsWith('Unexpected error while calling the provider:'));
-        assert.ok(error.message.includes('name: "Error"'));
+        assert.ok(error.message.startsWith('Unexpected error while calling the provider.'));
+        assert.ok(error.message.includes('ErrorName: "TypeError"'));
         assert.ok(error.message.includes('message: "foo"'));
         assert.ok(error.message.includes('stack:'));
+        assert.ok(error.message.includes('cause:'));
+        assert.ok(error.message.includes('causeStack:'));
     });
     it('throws on status 429', async (context) => {
         const response = new Response('response body', {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@unito/integration-sdk",
-  "version": "1.4.2",
+  "version": "1.4.4",
   "description": "Integration SDK",
   "type": "module",
   "types": "dist/src/index.d.ts",

package/src/resources/provider.ts

@@ -372,9 +372,10 @@ export class Provider {
             case 'TimeoutError':
               throw this.handleError(408, 'Request timeout', options);
           }
+
           throw this.handleError(
             500,
-            `Unexpected error while calling the provider: name: "${error.name}" \n message: "${error.message}" \n stack: ${error.stack}`,
+            `Unexpected error while calling the provider. ErrorName: "${error.name}" \n message: "${error.message}" \n stack: ${error.stack} \n cause: ${error.cause} \n causeStack: ${(error.cause as Error)?.stack}`,
             options,
           );
         }
@@ -389,6 +390,9 @@ export class Provider {
       if (response.status >= 400) {
         const textResult = await response.text();
         throw this.handleError(response.status, textResult, options);
+      } else if (response.status === 204 || response.body === null) {
+        // No content: return without inspecting the body
+        return { status: response.status, headers: response.headers, body: undefined as unknown as T };
       }
 
       const responseContentType = response.headers.get('content-type');
@@ -406,7 +410,7 @@ export class Provider {
           throw this.handleError(
             500,
             `Unsupported content-type, expected 'application/json' but got '${responseContentType}'.
-             Original response (${response.status}): ${textResult}`,
+             Original response (${response.status}): "${textResult}"`,
             options,
           );
         }

package/test/resources/provider.test.ts

@@ -539,6 +539,30 @@ describe('Provider', () => {
     assert.ok(providerResponse.body instanceof ReadableStream);
   });
 
+  it('returns successfully on unexpected content-type response with no body', async context => {
+    const response = new Response(null, {
+      status: 201,
+      headers: { 'Content-Type': 'html/text' },
+    });
+
+    context.mock.method(global, 'fetch', () => Promise.resolve(response));
+
+    const providerResponse = await provider.post(
+      '/endpoint/123',
+      {},
+      {
+        credentials: { apiKey: 'apikey#1111' },
+        logger: logger,
+        signal: new AbortController().signal,
+      },
+    );
+
+    assert.ok(providerResponse);
+    assert.strictEqual(providerResponse.status, response.status);
+    assert.strictEqual(providerResponse.headers, response.headers);
+    assert.strictEqual(providerResponse.body, undefined);
+  });
+
   it('throws on invalid json response', async context => {
     const response = new Response('{invalidJSON}', {
       status: 200,
@@ -658,7 +682,7 @@ describe('Provider', () => {
 
   it('throws on unknown errors', async context => {
     context.mock.method(global, 'fetch', () => {
-      throw new Error('foo');
+      throw new TypeError('foo', { cause: new Error('bar') });
     });
 
     let error;
@@ -674,10 +698,12 @@ describe('Provider', () => {
     }
 
     assert.ok(error instanceof HttpErrors.HttpError);
-    assert.ok(error.message.startsWith('Unexpected error while calling the provider:'));
-    assert.ok(error.message.includes('name: "Error"'));
+    assert.ok(error.message.startsWith('Unexpected error while calling the provider.'));
+    assert.ok(error.message.includes('ErrorName: "TypeError"'));
     assert.ok(error.message.includes('message: "foo"'));
     assert.ok(error.message.includes('stack:'));
+    assert.ok(error.message.includes('cause:'));
+    assert.ok(error.message.includes('causeStack:'));
   });
 
   it('throws on status 429', async context => {