@united-workforce/cli 0.4.0 → 0.5.0

package/src/validate-semantic.ts

@@ -55,19 +55,12 @@ function generateMockData(schema: SchemaObj): Record<string, string> {
   for (const key of Object.keys(props)) {
     mock[key] = `mock_${key}`;
   }
+  // _body is engine-injected (markdown body after frontmatter), not in the schema.
+  // Always provide it so templates referencing {{ _body }} pass strict validation.
+  mock._body = "mock__body";
   return mock;
 }
 
-/**
- * Pre-process a template to replace `$`-prefixed variables (like `$status`)
- * which are invalid in LiquidJS syntax but always valid at runtime.
- * Replaces `{{ $varName }}` with a literal placeholder so the strict render
- * does not reject them.
- */
-function sanitizeReservedVars(template: string): string {
-  return template.replace(/\{\{\s*\$\w+\s*\}\}/g, "RESERVED");
-}
-
 /** Extract variable name from a LiquidJS UndefinedVariableError message. */
 function extractVarName(err: unknown): string {
   const msg = String(err);
@@ -92,7 +85,7 @@ function validateMultiExitTemplates(
     if (!variant) continue;
     const mockData = generateMockData(variant);
     try {
-      strictEngine.parseAndRenderSync(sanitizeReservedVars(target.prompt), mockData);
+      strictEngine.parseAndRenderSync(target.prompt, mockData);
     } catch (err) {
       const varName = extractVarName(err);
       errors.push(
@@ -114,7 +107,7 @@ function validateFlatTemplates(
 
   for (const [status, target] of Object.entries(graphEntry)) {
     try {
-      strictEngine.parseAndRenderSync(sanitizeReservedVars(target.prompt), mockData);
+      strictEngine.parseAndRenderSync(target.prompt, mockData);
     } catch (err) {
       const varName = extractVarName(err);
       errors.push(
@@ -284,6 +277,32 @@ function checkStatusEdges(
   }
 }
 
+/** Reserved property names that must not appear in frontmatter schemas. */
+const RESERVED_PROPERTIES = new Set(["_body"]);
+
+/** Check that frontmatter schemas do not define reserved property names. */
+function checkReservedProperties(roleName: string, fm: unknown, errors: string[]): void {
+  const schemasToCheck: SchemaObj[] = [];
+
+  if (isOneOfSchema(fm)) {
+    schemasToCheck.push(...(fm.oneOf as SchemaObj[]));
+  } else if (typeof fm === "object" && fm !== null) {
+    schemasToCheck.push(fm as SchemaObj);
+  }
+
+  for (const schema of schemasToCheck) {
+    const props = schema.properties as Record<string, unknown> | undefined;
+    if (!props) continue;
+    for (const key of Object.keys(props)) {
+      if (RESERVED_PROPERTIES.has(key)) {
+        errors.push(
+          `role "${roleName}" frontmatter must not define reserved property "${key}" — it is injected by the engine`,
+        );
+      }
+    }
+  }
+}
+
 /** Check status-edge consistency and template vars for each role. */
 function checkRoleConsistency(payload: WorkflowPayload, errors: string[]): void {
   for (const [roleName, role] of Object.entries(payload.roles)) {
@@ -294,6 +313,8 @@ function checkRoleConsistency(payload: WorkflowPayload, errors: string[]): void
     const fm = role.frontmatter as unknown;
     const graphKeys = new Set(Object.keys(graphEntry));
 
+    checkReservedProperties(roleName, fm, errors);
+
     if (isOneOfSchema(fm)) {
       const variants = fm.oneOf as SchemaObj[];
       const statuses = getOneOfStatuses(variants);