@united-workforce/cli 0.3.0 → 0.5.0

package/src/__tests__/setup-complexity.test.ts

@@ -1,17 +1,12 @@
 import { mkdirSync, writeFileSync } from "node:fs";
 import { tmpdir } from "node:os";
 import { join } from "node:path";
-import { afterEach, describe, expect, test, vi } from "vitest";
+import { describe, expect, test } from "vitest";
 import {
   _discoverAgents,
   _isBackspace,
   _isTerminator,
   _parseWhichOutput,
-  _printModelMenu,
-  _printProviderMenu,
-  _printValidationResult,
-  _resolveModelChoice,
-  _resolveProviderChoice,
   _searchPathDirs,
 } from "../commands/setup.js";
 
@@ -172,203 +167,6 @@ describe("_isBackspace", () => {
   });
 });
 
-// ──────────────────────────────────────────────────────────────────────────────
-// 3a. _printProviderMenu
-// ──────────────────────────────────────────────────────────────────────────────
-
-describe("_printProviderMenu", () => {
-  afterEach(() => {
-    vi.restoreAllMocks();
-  });
-
-  const providers = [
-    { name: "openai", label: "OpenAI", baseUrl: "https://api.openai.com/v1" },
-    { name: "xai", label: "xAI", baseUrl: "https://api.x.ai/v1" },
-  ] as const;
-
-  test("prints correct number of lines (one per provider + custom)", () => {
-    const lines: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      lines.push(msg);
-    });
-    _printProviderMenu(providers);
-    // 2 providers + 1 custom = 3 lines
-    expect(lines.length).toBe(3);
-  });
-
-  test("custom option number = providers.length + 1", () => {
-    const lines: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      lines.push(msg);
-    });
-    _printProviderMenu(providers);
-    const lastLine = lines[lines.length - 1] ?? "";
-    expect(lastLine).toMatch(/3\)/);
-  });
-
-  test("each provider line contains its label and baseUrl", () => {
-    const lines: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      lines.push(msg);
-    });
-    _printProviderMenu(providers);
-    expect(lines[0]).toContain("OpenAI");
-    expect(lines[0]).toContain("https://api.openai.com/v1");
-    expect(lines[1]).toContain("xAI");
-    expect(lines[1]).toContain("https://api.x.ai/v1");
-  });
-});
-
-// ──────────────────────────────────────────────────────────────────────────────
-// 3b. _resolveProviderChoice
-// ──────────────────────────────────────────────────────────────────────────────
-
-describe("_resolveProviderChoice", () => {
-  const providers = [
-    { name: "openai", label: "OpenAI", baseUrl: "https://api.openai.com/v1" },
-    { name: "xai", label: "xAI", baseUrl: "https://api.x.ai/v1" },
-    { name: "deepseek", label: "DeepSeek", baseUrl: "https://api.deepseek.com/v1" },
-  ] as const;
-
-  test("valid index 1 returns first provider", () => {
-    const result = _resolveProviderChoice("1", providers);
-    expect(result).toEqual({ providerName: "openai", baseUrl: "https://api.openai.com/v1" });
-  });
-
-  test("valid index N (last preset) returns last provider", () => {
-    const result = _resolveProviderChoice("3", providers);
-    expect(result).toEqual({ providerName: "deepseek", baseUrl: "https://api.deepseek.com/v1" });
-  });
-
-  test("index providers.length+1 (custom) returns null", () => {
-    const result = _resolveProviderChoice("4", providers);
-    expect(result).toBeNull();
-  });
-
-  test("non-numeric string returns null", () => {
-    expect(_resolveProviderChoice("abc", providers)).toBeNull();
-  });
-
-  test("0 returns null (out of range)", () => {
-    expect(_resolveProviderChoice("0", providers)).toBeNull();
-  });
-
-  test("N+2 returns null (out of range)", () => {
-    expect(_resolveProviderChoice("5", providers)).toBeNull();
-  });
-
-  test("negative number returns null", () => {
-    expect(_resolveProviderChoice("-1", providers)).toBeNull();
-  });
-});
-
-// ──────────────────────────────────────────────────────────────────────────────
-// 3c. _resolveModelChoice
-// ──────────────────────────────────────────────────────────────────────────────
-
-describe("_resolveModelChoice", () => {
-  test("numeric input within range returns model at that index", () => {
-    expect(_resolveModelChoice("2", ["a", "b", "c"])).toBe("b");
-  });
-
-  test("numeric input out of range returns input as-is", () => {
-    expect(_resolveModelChoice("5", ["a"])).toBe("5");
-  });
-
-  test("non-numeric input returns input as-is", () => {
-    expect(_resolveModelChoice("gpt-4o", ["a", "b"])).toBe("gpt-4o");
-  });
-
-  test("numeric input 1 returns first model", () => {
-    expect(_resolveModelChoice("1", ["alpha", "beta"])).toBe("alpha");
-  });
-
-  test("empty models list with numeric input returns input as-is", () => {
-    expect(_resolveModelChoice("1", [])).toBe("1");
-  });
-});
-
-// ──────────────────────────────────────────────────────────────────────────────
-// 3d. _printModelMenu
-// ──────────────────────────────────────────────────────────────────────────────
-
-describe("_printModelMenu", () => {
-  afterEach(() => {
-    vi.restoreAllMocks();
-  });
-
-  test("prints all models — each model name appears in output", () => {
-    const output: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      output.push(msg);
-    });
-    const models = ["model-a", "model-b", "model-c"];
-    _printModelMenu(models, 100);
-    const combined = output.join("\n");
-    for (const m of models) {
-      expect(combined).toContain(m);
-    }
-  });
-
-  test("single column when termCols is very small", () => {
-    const output: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      output.push(msg);
-    });
-    _printModelMenu(["a", "b", "c"], 1);
-    // Each model on its own row → 3 lines
-    expect(output.length).toBe(3);
-  });
-
-  test("wide terminal fits multiple columns", () => {
-    const output: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      output.push(msg);
-    });
-    const models = Array.from({ length: 6 }, (_, i) => `m${i}`);
-    _printModelMenu(models, 200);
-    // With wide terminal and short names, should fit in fewer than 6 rows
-    expect(output.length).toBeLessThan(6);
-  });
-});
-
-// ──────────────────────────────────────────────────────────────────────────────
-// 3e. _printValidationResult
-// ──────────────────────────────────────────────────────────────────────────────
-
-describe("_printValidationResult", () => {
-  afterEach(() => {
-    vi.restoreAllMocks();
-  });
-
-  test("ok=true prints success message containing '✓'", () => {
-    const lines: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      lines.push(msg);
-    });
-    _printValidationResult({ ok: true, error: null });
-    expect(lines.join("\n")).toContain("✓");
-  });
-
-  test("ok=false prints warning message containing '⚠'", () => {
-    const lines: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      lines.push(msg);
-    });
-    _printValidationResult({ ok: false, error: "HTTP 401" });
-    expect(lines.join("\n")).toContain("⚠");
-  });
-
-  test("ok=false includes the error string in output", () => {
-    const lines: string[] = [];
-    vi.spyOn(console, "log").mockImplementation((msg: string) => {
-      lines.push(msg);
-    });
-    _printValidationResult({ ok: false, error: "HTTP 401" });
-    expect(lines.join("\n")).toContain("HTTP 401");
-  });
-});
-
 // ──────────────────────────────────────────────────────────────────────────────
 // 4. Regression
 // ──────────────────────────────────────────────────────────────────────────────

package/src/__tests__/setup-no-llm.test.ts

@@ -0,0 +1,68 @@
+import { mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { afterEach, describe, expect, test } from "vitest";
+import { parse } from "yaml";
+import { cmdSetup } from "../commands/setup.js";
+
+describe("cmdSetup — non-interactive, no LLM args (issue #143)", () => {
+  let tempDir: string;
+  afterEach(() => {
+    if (tempDir) rmSync(tempDir, { recursive: true, force: true });
+  });
+
+  test("writes config.yaml with only agents + defaultAgent", async () => {
+    tempDir = mkdtempSync(join(tmpdir(), "uwf-setup-"));
+    await cmdSetup({ agent: "hermes", storageRoot: tempDir });
+    const cfg = parse(readFileSync(join(tempDir, "config.yaml"), "utf8")) as Record<
+      string,
+      unknown
+    >;
+    expect(cfg.defaultAgent).toBe("hermes");
+    expect(cfg.agents).toBeDefined();
+    expect(cfg.providers).toBeUndefined();
+    expect(cfg.models).toBeUndefined();
+    expect(cfg.defaultModel).toBeUndefined();
+    expect(cfg.modelOverrides).toBeUndefined();
+  });
+
+  test("preserves existing agentOverrides on rewrite", async () => {
+    tempDir = mkdtempSync(join(tmpdir(), "uwf-setup-"));
+    writeFileSync(
+      join(tempDir, "config.yaml"),
+      "agents:\n  hermes: { command: uwf-hermes, args: [] }\ndefaultAgent: hermes\nagentOverrides:\n  solve-issue:\n    coder: claude-code\n",
+      "utf8",
+    );
+    await cmdSetup({ agent: "hermes", storageRoot: tempDir });
+    const cfg = parse(readFileSync(join(tempDir, "config.yaml"), "utf8")) as Record<
+      string,
+      unknown
+    >;
+    expect(cfg.agentOverrides).toEqual({ "solve-issue": { coder: "claude-code" } });
+  });
+
+  test("creates a default agent entry when missing", async () => {
+    tempDir = mkdtempSync(join(tmpdir(), "uwf-setup-"));
+    await cmdSetup({ agent: "claude-code", storageRoot: tempDir });
+    const cfg = parse(readFileSync(join(tempDir, "config.yaml"), "utf8")) as Record<
+      string,
+      unknown
+    >;
+    expect(cfg.defaultAgent).toBe("claude-code");
+    const agents = cfg.agents as Record<string, unknown>;
+    expect(agents["claude-code"]).toEqual({ command: "uwf-claude-code", args: [] });
+  });
+});
+
+describe("cmdSetup public surface — provider/model helpers removed (issue #143)", () => {
+  test("module does not export validateModel / provider menus / model menus", async () => {
+    const mod = (await import("../commands/setup.js")) as Record<string, unknown>;
+    expect(mod.validateModel).toBeUndefined();
+    expect(mod.resolvePresetBaseUrl).toBeUndefined();
+    expect(mod._printProviderMenu).toBeUndefined();
+    expect(mod._resolveProviderChoice).toBeUndefined();
+    expect(mod._printModelMenu).toBeUndefined();
+    expect(mod._resolveModelChoice).toBeUndefined();
+    expect(mod._printValidationResult).toBeUndefined();
+  });
+});

package/src/__tests__/solve-issue-tea-worktree.test.ts

@@ -13,7 +13,9 @@ import { parse } from "yaml";
  * which fixes the "path segment [0] is empty" error in worktree directories.
  */
 
-describe("solve-issue workflow: Gitea API PR creation", () => {
+// Skip: pure workflow YAML prose content assertions — procedure text changes
+// break these without indicating real bugs. See #299 discussion.
+describe.skip("solve-issue workflow: Gitea API PR creation", () => {
   // Navigate up from packages/cli/src/__tests__ to repo root
   const workflowPath = join(
     dirname(fileURLToPath(import.meta.url)),
@@ -21,11 +23,11 @@ describe("solve-issue workflow: Gitea API PR creation", () => {
     "..",
     "..",
     "..",
-    ".workflows",
+    "examples",
     "solve-issue.yaml",
   );
 
-  test("committer procedure should use curl API instead of tea pr create", async () => {
+  test("committer procedure should create PR via tea pr create", async () => {
     const yamlContent = await readFile(workflowPath, "utf-8");
     const workflow = parse(yamlContent) as WorkflowPayload;
 
@@ -33,25 +35,22 @@ describe("solve-issue workflow: Gitea API PR creation", () => {
     const committerProcedure = workflow.roles.committer?.procedure;
     expect(committerProcedure).toBeDefined();
 
-    // Verify the procedure uses curl API, not tea pr create
-    expect(committerProcedure).toContain("curl");
-    expect(committerProcedure).toContain("api/v1/repos");
-    expect(committerProcedure).toContain("/pulls");
-
-    // Verify it explicitly warns against tea pr create
-    expect(committerProcedure).toMatch(/do NOT use.*tea pr create/i);
+    // Verify the procedure uses tea pr create for PR creation
+    expect(committerProcedure).toContain("tea pr create");
+    expect(committerProcedure).toContain("git push");
+    expect(committerProcedure).toContain("Fixes #N");
   });
 
-  test("committer procedure should reference repoRemote from task prompt", async () => {
+  test("committer procedure should extract owner/repo from git remote", async () => {
     const yamlContent = await readFile(workflowPath, "utf-8");
     const workflow = parse(yamlContent) as WorkflowPayload;
 
     const committerProcedure = workflow.roles.committer?.procedure;
     expect(committerProcedure).toBeDefined();
 
-    // Verify the procedure mentions repoRemote is provided in task prompt
-    expect(committerProcedure).toMatch(/repo remote.*provided.*task prompt/i);
-    expect(committerProcedure).toMatch(/owner\/repo/i);
+    // Verify the procedure extracts owner/repo from remote
+    expect(committerProcedure).toContain("git remote get-url origin");
+    expect(committerProcedure).toContain("hook_failed");
   });
 
   test("committer procedure should include error handling for curl failures", async () => {
@@ -100,45 +99,42 @@ describe("solve-issue workflow: Gitea API PR creation", () => {
     expect(committedVariant.required).toContain("$status");
   });
 
-  test("developer procedure should include mandatory verification step", async () => {
+  test("developer procedure should include worktree setup", async () => {
     const yamlContent = await readFile(workflowPath, "utf-8");
     const workflow = parse(yamlContent) as WorkflowPayload;
 
     const developerProcedure = workflow.roles.developer?.procedure;
     expect(developerProcedure).toBeDefined();
 
-    // Verify the procedure includes mandatory verification step
-    expect(developerProcedure).toContain("MANDATORY VERIFICATION");
-    expect(developerProcedure).toContain("git branch --show-current");
-    expect(developerProcedure).toContain("git status");
-    expect(developerProcedure).toMatch(/ls -la|verify.*exist/i);
+    // Verify the procedure includes worktree setup
+    expect(developerProcedure).toContain("IMPORTANT");
+    expect(developerProcedure).toContain("git worktree add");
+    expect(developerProcedure).toContain("pnpm install");
   });
 
-  test("reviewer procedure should enforce worktree path verification", async () => {
+  test("reviewer procedure should verify branch and run checks", async () => {
     const yamlContent = await readFile(workflowPath, "utf-8");
     const workflow = parse(yamlContent) as WorkflowPayload;
 
     const reviewerProcedure = workflow.roles.reviewer?.procedure;
     expect(reviewerProcedure).toBeDefined();
 
-    // Verify the procedure includes critical enforcement
-    expect(reviewerProcedure).toContain("CRITICAL");
-    expect(reviewerProcedure).toMatch(/cd.*pwd/);
-    expect(reviewerProcedure).toContain(
-      "Do NOT report results without running the actual commands",
-    );
+    // Verify the procedure includes branch verification and build checks
+    expect(reviewerProcedure).toContain("git branch --show-current");
+    expect(reviewerProcedure).toContain("pnpm run build");
+    expect(reviewerProcedure).toContain("pnpm run check");
   });
 
-  test("developer procedure should include test debugging escalation", async () => {
+  test("developer procedure should include changeset and failure handling", async () => {
     const yamlContent = await readFile(workflowPath, "utf-8");
     const workflow = parse(yamlContent) as WorkflowPayload;
 
     const developerProcedure = workflow.roles.developer?.procedure;
     expect(developerProcedure).toBeDefined();
 
-    // Verify the procedure includes test failure guidance
-    expect(developerProcedure).toMatch(/tests fail.*first run/i);
-    expect(developerProcedure).toMatch(/3 test cycles|after 3 attempts/i);
+    // Verify the procedure includes changeset requirement and failure path
+    expect(developerProcedure).toContain(".changeset/");
     expect(developerProcedure).toContain("$status=failed");
+    expect(developerProcedure).toContain("pnpm test");
   });
 });