@unisphere/nx 4.12.5 → 4.13.0

package/dist/migrations/4-12-6/comment-out-security-audit.d.ts

@@ -0,0 +1,22 @@
+/**
+ * Migration: Comment out the "Security Audit" step in cicd.yml
+ *
+ * The `Security Audit` step (`npx unisphere tools audit`) is temporarily
+ * disabled across projects. This migration comments out the step's lines in
+ * .github/workflows/cicd.yml by prefixing each with `#`:
+ *
+ *   #      - name: Security Audit
+ *   #        run: npx unisphere tools audit
+ *   #        env:
+ *   #          KALTURA_JFROG_TOKEN: ${{ steps.setup-jfrog.outputs.oidc-token }}
+ *
+ * The step's block is matched by its `- name: Security Audit` anchor and the
+ * following contiguous body lines (stopping at the first blank line or the next
+ * `- name:` step), so it is resilient to indentation differences between repos.
+ *
+ * Idempotent: if the step is already commented out (or absent), re-running
+ * makes no further changes.
+ */
+import { Tree } from '@nx/devkit';
+export default function update(tree: Tree): Promise<void>;
+//# sourceMappingURL=comment-out-security-audit.d.ts.map

package/dist/migrations/4-12-6/comment-out-security-audit.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"comment-out-security-audit.d.ts","sourceRoot":"","sources":["../../../src/migrations/4-12-6/comment-out-security-audit.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;;;;;GAkBG;AAEH,OAAO,EAAE,IAAI,EAAU,MAAM,YAAY,CAAC;AAK1C,wBAA8B,MAAM,CAAC,IAAI,EAAE,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,CAkD9D"}

package/dist/migrations/4-12-6/comment-out-security-audit.js

@@ -0,0 +1,64 @@
+"use strict";
+/**
+ * Migration: Comment out the "Security Audit" step in cicd.yml
+ *
+ * The `Security Audit` step (`npx unisphere tools audit`) is temporarily
+ * disabled across projects. This migration comments out the step's lines in
+ * .github/workflows/cicd.yml by prefixing each with `#`:
+ *
+ *   #      - name: Security Audit
+ *   #        run: npx unisphere tools audit
+ *   #        env:
+ *   #          KALTURA_JFROG_TOKEN: ${{ steps.setup-jfrog.outputs.oidc-token }}
+ *
+ * The step's block is matched by its `- name: Security Audit` anchor and the
+ * following contiguous body lines (stopping at the first blank line or the next
+ * `- name:` step), so it is resilient to indentation differences between repos.
+ *
+ * Idempotent: if the step is already commented out (or absent), re-running
+ * makes no further changes.
+ */
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = update;
+const devkit_1 = require("@nx/devkit");
+const CICD_PATH = '.github/workflows/cicd.yml';
+const STEP_ANCHOR = '- name: Security Audit';
+async function update(tree) {
+    devkit_1.logger.info(`🔄 Commenting out the Security Audit step in ${CICD_PATH}...`);
+    if (!tree.exists(CICD_PATH)) {
+        devkit_1.logger.info(`ℹ️ No ${CICD_PATH} found, skipping migration`);
+        return;
+    }
+    const content = tree.read(CICD_PATH, 'utf-8') ?? '';
+    const lines = content.split('\n');
+    // Match the anchor whether or not it is already commented out, so re-running
+    // recognises the existing state instead of treating it as "not found".
+    const stripComment = (line) => line.replace(/^\s*#/, '').trim();
+    const anchorIndex = lines.findIndex((line) => stripComment(line) === STEP_ANCHOR);
+    if (anchorIndex === -1) {
+        devkit_1.logger.info(`ℹ️ Security Audit step not found in ${CICD_PATH}, skipping migration`);
+        return;
+    }
+    // Already commented? (anchor line begins with #) — don't add a second #.
+    if (lines[anchorIndex].trimStart().startsWith('#')) {
+        devkit_1.logger.info('✅ Security Audit step already commented out, skipping');
+        return;
+    }
+    // Comment the step's contiguous block: the anchor line plus the following
+    // body lines, stopping at the first blank line or the next `- name:` step.
+    let commented = 0;
+    for (let i = anchorIndex; i < lines.length; i++) {
+        const line = lines[i];
+        if (i > anchorIndex &&
+            (line.trim() === '' || stripComment(line).startsWith('- name:'))) {
+            break;
+        }
+        // Per-line guard: never prefix a line that is already commented.
+        if (!line.trimStart().startsWith('#')) {
+            lines[i] = `#${line}`;
+            commented++;
+        }
+    }
+    tree.write(CICD_PATH, lines.join('\n'));
+    devkit_1.logger.info(`✅ Commented out ${commented} lines of the Security Audit step`);
+}

package/dist/migrations/4-13-0/patches/@changesets+cli+2.29.7.patch

@@ -0,0 +1,94 @@
+diff --git a/node_modules/@changesets/cli/dist/changesets-cli.cjs.js b/node_modules/@changesets/cli/dist/changesets-cli.cjs.js
+index 53fc925..ca3c8ad 100644
+--- a/node_modules/@changesets/cli/dist/changesets-cli.cjs.js
++++ b/node_modules/@changesets/cli/dist/changesets-cli.cjs.js
+@@ -272,9 +272,19 @@ async function getPackagesToRelease(changedPackages, allPackages) {
+     });
+   }
+   if (allPackages.length > 1) {
++    // Exclude local packages and local applications entirely — they live under
++    // packages/local or applications/local (or use the @local/ scope), are
++    // bundled into the runtimes at build time, and must never be shown for
++    // selection or get their own version bump.
++    const pkgDirByName = new Map(allPackages.map(p => [p.packageJson.name, (p.dir || '').replace(/\\/g, '/')]));
++    const isLocalPackage = pkgName => {
++      const dir = pkgDirByName.get(pkgName) || '';
++      return pkgName.startsWith('@local/') || dir.includes('/packages/local/') || dir.includes('/applications/local/');
++    };
++    changedPackages = changedPackages.filter(name => !isLocalPackage(name));
+     const unchangedPackagesNames = allPackages.map(({
+       packageJson
+-    }) => packageJson.name).filter(name => !changedPackages.includes(name));
++    }) => packageJson.name).filter(name => !changedPackages.includes(name) && !isLocalPackage(name));
+     const defaultChoiceList = [{
+       name: "changed packages",
+       choices: changedPackages
+@@ -310,9 +320,10 @@ async function createChangeset(changedPackages, allPackages) {
+     const packagesToRelease = await getPackagesToRelease(changedPackages, allPackages);
+     let pkgJsonsByName = getPkgJsonsByName(allPackages);
+     let pkgsLeftToGetBumpTypeFor = new Set(packagesToRelease);
+-    let pkgsThatShouldBeMajorBumped = (await askCheckboxPlus(bold(`Which packages should have a ${red("major")} bump?`), [{
++    let nonRuntimePackages = packagesToRelease.filter(pkgName => !pkgName.includes('unisphere-runtime-'));
++    let pkgsThatShouldBeMajorBumped = nonRuntimePackages.length > 0 ? (await askCheckboxPlus(bold(`Which packages should have a ${red("major")} bump?`), [{
+       name: "all packages",
+-      choices: packagesToRelease.map(pkgName => {
++      choices: nonRuntimePackages.map(pkgName => {
+         return {
+           name: pkgName,
+           message: formatPkgNameAndVersion(pkgName, pkgJsonsByName.get(pkgName).version)
+@@ -325,7 +336,7 @@ async function createChangeset(changedPackages, allPackages) {
+         return x.filter(x => x !== "all packages").map(x => cyan(x)).join(", ");
+       }
+       return x;
+-    })).filter(x => x !== "all packages");
++    })).filter(x => x !== "all packages") : [];
+     for (const pkgName of pkgsThatShouldBeMajorBumped) {
+       // for packages that are under v1, we want to make sure major releases are intended,
+       // as some repo-wide sweeping changes have mistakenly release first majors
+diff --git a/node_modules/@changesets/cli/dist/changesets-cli.esm.js b/node_modules/@changesets/cli/dist/changesets-cli.esm.js
+index 6c363c0..f18a637 100644
+--- a/node_modules/@changesets/cli/dist/changesets-cli.esm.js
++++ b/node_modules/@changesets/cli/dist/changesets-cli.esm.js
+@@ -234,9 +234,19 @@ async function getPackagesToRelease(changedPackages, allPackages) {
+     });
+   }
+   if (allPackages.length > 1) {
++    // Exclude local packages and local applications entirely — they live under
++    // packages/local or applications/local (or use the @local/ scope), are
++    // bundled into the runtimes at build time, and must never be shown for
++    // selection or get their own version bump.
++    const pkgDirByName = new Map(allPackages.map(p => [p.packageJson.name, (p.dir || '').replace(/\\/g, '/')]));
++    const isLocalPackage = pkgName => {
++      const dir = pkgDirByName.get(pkgName) || '';
++      return pkgName.startsWith('@local/') || dir.includes('/packages/local/') || dir.includes('/applications/local/');
++    };
++    changedPackages = changedPackages.filter(name => !isLocalPackage(name));
+     const unchangedPackagesNames = allPackages.map(({
+       packageJson
+-    }) => packageJson.name).filter(name => !changedPackages.includes(name));
++    }) => packageJson.name).filter(name => !changedPackages.includes(name) && !isLocalPackage(name));
+     const defaultChoiceList = [{
+       name: "changed packages",
+       choices: changedPackages
+@@ -272,9 +282,10 @@ async function createChangeset(changedPackages, allPackages) {
+     const packagesToRelease = await getPackagesToRelease(changedPackages, allPackages);
+     let pkgJsonsByName = getPkgJsonsByName(allPackages);
+     let pkgsLeftToGetBumpTypeFor = new Set(packagesToRelease);
+-    let pkgsThatShouldBeMajorBumped = (await askCheckboxPlus(bold(`Which packages should have a ${red("major")} bump?`), [{
++    let nonRuntimePackages = packagesToRelease.filter(pkgName => !pkgName.includes('unisphere-runtime-'));
++    let pkgsThatShouldBeMajorBumped = nonRuntimePackages.length > 0 ? (await askCheckboxPlus(bold(`Which packages should have a ${red("major")} bump?`), [{
+       name: "all packages",
+-      choices: packagesToRelease.map(pkgName => {
++      choices: nonRuntimePackages.map(pkgName => {
+         return {
+           name: pkgName,
+           message: formatPkgNameAndVersion(pkgName, pkgJsonsByName.get(pkgName).version)
+@@ -287,7 +298,7 @@ async function createChangeset(changedPackages, allPackages) {
+         return x.filter(x => x !== "all packages").map(x => cyan(x)).join(", ");
+       }
+       return x;
+-    })).filter(x => x !== "all packages");
++    })).filter(x => x !== "all packages") : [];
+     for (const pkgName of pkgsThatShouldBeMajorBumped) {
+       // for packages that are under v1, we want to make sure major releases are intended,
+       // as some repo-wide sweeping changes have mistakenly release first majors

package/dist/migrations/4-13-0/update-changeset-patch.d.ts

@@ -0,0 +1,18 @@
+import { Tree } from '@nx/devkit';
+/**
+ * Migration: Update @changesets/cli patch to also exclude local packages and
+ * local applications from the changeset flow.
+ *
+ * The previous patch (shipped in 3.0.0) only filtered `unisphere-runtime-*`
+ * packages out of the MAJOR bump prompt. This updated patch additionally
+ * excludes local packages and local applications (anything under
+ * `packages/local` / `applications/local`, or using the `@local/` scope) from
+ * `getPackagesToRelease` — so they never appear in the "Which packages would
+ * you like to include?" prompt and never get their own version bump. Runtimes
+ * keep their existing behavior (dropped from the major prompt only).
+ *
+ * Replaces any existing @changesets/cli patch in the consuming project's
+ * `patches/` directory with the updated one bundled alongside this migration.
+ */
+export default function update(tree: Tree): Promise<void>;
+//# sourceMappingURL=update-changeset-patch.d.ts.map

package/dist/migrations/4-13-0/update-changeset-patch.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"update-changeset-patch.d.ts","sourceRoot":"","sources":["../../../src/migrations/4-13-0/update-changeset-patch.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAyB,MAAM,YAAY,CAAC;AAGzD;;;;;;;;;;;;;;GAcG;AACH,wBAA8B,MAAM,CAAC,IAAI,EAAE,IAAI,GAAG,OAAO,CAAC,IAAI,CAAC,CA8B9D"}

package/dist/migrations/4-13-0/update-changeset-patch.js

@@ -0,0 +1,46 @@
+"use strict";
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = update;
+const devkit_1 = require("@nx/devkit");
+const path_1 = require("path");
+/**
+ * Migration: Update @changesets/cli patch to also exclude local packages and
+ * local applications from the changeset flow.
+ *
+ * The previous patch (shipped in 3.0.0) only filtered `unisphere-runtime-*`
+ * packages out of the MAJOR bump prompt. This updated patch additionally
+ * excludes local packages and local applications (anything under
+ * `packages/local` / `applications/local`, or using the `@local/` scope) from
+ * `getPackagesToRelease` — so they never appear in the "Which packages would
+ * you like to include?" prompt and never get their own version bump. Runtimes
+ * keep their existing behavior (dropped from the major prompt only).
+ *
+ * Replaces any existing @changesets/cli patch in the consuming project's
+ * `patches/` directory with the updated one bundled alongside this migration.
+ */
+async function update(tree) {
+    devkit_1.logger.info('🔄 Updating @changesets/cli patch');
+    try {
+        const patchesPath = 'patches';
+        const patchesTemplatePath = (0, path_1.join)(__dirname, 'patches');
+        const patchFileName = '@changesets+cli+2.29.7.patch';
+        // Delete existing changeset patch if it exists
+        if (tree.exists(patchesPath)) {
+            const existingFiles = tree.children(patchesPath);
+            for (const file of existingFiles) {
+                if (file.includes('@changesets+cli')) {
+                    devkit_1.logger.info(`🗑️ Removing existing patch: ${file}`);
+                    tree.delete((0, path_1.join)(patchesPath, file));
+                }
+            }
+        }
+        // Copy the updated patch file
+        (0, devkit_1.generateFiles)(tree, patchesTemplatePath, `./${patchesPath}`, {});
+        devkit_1.logger.info(`✅ Updated patch: ${patchFileName}`);
+        devkit_1.logger.info('ℹ️  This patch hides local packages and local applications from the changeset prompt, and keeps unisphere-runtime-* packages out of the major bump selection');
+    }
+    catch (error) {
+        devkit_1.logger.error(`❌ Failed to update patch: ${error?.message || 'Unknown error'}`);
+        throw error;
+    }
+}

package/migrations.json

@@ -514,6 +514,22 @@
       "cli": {
         "postUpdateMessage": "✅ ESLint: @nx/enforce-module-boundaries disabled for rollup.config.{js,mjs}"
       }
+    },
+    "4.12.6-comment-out-security-audit": {
+      "version": "4.12.6",
+      "description": "Comments out the Security Audit step (npx unisphere tools audit) in .github/workflows/cicd.yml",
+      "factory": "./dist/migrations/4-12-6/comment-out-security-audit.js",
+      "cli": {
+        "postUpdateMessage": "✅ Security Audit step commented out in .github/workflows/cicd.yml"
+      }
+    },
+    "4.13.0-update-changeset-patch": {
+      "version": "4.13.0",
+      "description": "Updates @changesets/cli patch to also hide local packages and local applications from the changeset prompt (runtimes stay out of the major bump selection)",
+      "factory": "./dist/migrations/4-13-0/update-changeset-patch.js",
+      "cli": {
+        "postUpdateMessage": "✅ @changesets/cli patch updated"
+      }
     }
   },
   "packageJsonUpdates": {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@unisphere/nx",
-  "version": "4.12.5",
+  "version": "4.13.0",
   "private": false,
   "main": "./dist/index.js",
   "module": "./dist/index.js",