@uniflowed/test 0.0.0-alpha.31 → 0.0.0-alpha.33

package/browser-worker.js

@@ -71,15 +71,15 @@ type Request = {|
  *
  * Generous against a cold Chromium with a cold profile, which is about seven
  * seconds on a laptop and much worse in a busy container, and deliberately
- * *shorter than `uf_test`'s browser file budget* (`BROWSER_FILE_TIMEOUT`, sixty
- * seconds).
+ * *shorter than `uf_test`'s browser file budget* (`BROWSER_FILE_TIMEOUT`, two
+ * minutes).
  * That order is the whole point: `uf` is already holding a stopwatch on the
  * first file while this is happening, and whichever of the two fires first is
  * what the report says. A browser that will not start should be reported as a
  * browser that will not start, with its own output attached — not as a file
  * that timed out, which is a sentence about tests that were never reached.
  */
-const START_TIMEOUT_MS = 45_000;
+const START_TIMEOUT_MS = 110_000;
 
 /**
  * The switches a headless run needs, and what each is for.
@@ -117,8 +117,25 @@ function browserArguments(profile: string, url: string): Array<string> {
     // A scratch profile per run: no extensions, no saved state, no policy from
     // the developer's own browser leaking into what the suite measures.
     `--user-data-dir=${profile}`,
+    // The scratch profile stores no credentials, so keep Chrome off desktop
+    // keyring backends that can hang behind a broken CI DBus session before
+    // the first page request.
+    "--password-store=basic",
     "--no-first-run",
     "--no-default-browser-check",
+    // Keep startup deterministic in CI. These cut services Chrome may start
+    // before the first page request: extensions, sync, updater probes, and
+    // background network clients such as GCM. None of them changes layout or
+    // module execution, which is what browser mode measures.
+    "--disable-background-networking",
+    "--disable-client-side-phishing-detection",
+    "--disable-component-update",
+    "--disable-default-apps",
+    "--disable-domain-reliability",
+    "--disable-extensions",
+    "--disable-sync",
+    "--disable-features=AutofillServerCommunication,BackgroundFetch,BackgroundSync,CertificateTransparencyComponentUpdater,DialMediaRouteProvider,MediaRouter,NotificationTriggers,OptimizationHints,PushMessaging,Translate",
+    "--metrics-recording-only",
     // Nothing here paints, and a GPU process is one more thing to fail in a
     // container.
     "--disable-gpu",
@@ -210,6 +227,11 @@ async function main(): Promise<void> {
   const child = spawn(browser, browserArguments(profile, server.url), {
     stdio: ["ignore", "pipe", "pipe", "pipe", "pipe"],
   });
+  // The DevTools pipe is a lifeline, not a protocol this driver speaks. Chrome
+  // can still write target bookkeeping to fd 4 before the page asks for work;
+  // drain it so a full pipe cannot block startup before the first HTTP request.
+  const devtoolsOutput = child.stdio[4];
+  devtoolsOutput?.on("data", () => {});
   // Kept, not printed. A Chromium writes a dozen lines about GPU probing and
   // Vulkan on a healthy start, and forwarding those to a passing run's report
   // would be noise; they are the whole of the evidence when it does not start,

package/internal/registry.js

@@ -36,6 +36,7 @@ export type Case = {|
   readonly name: string,
   readonly body: Body | null,
   readonly modifier: Modifier,
+  readonly skipReason: string | null,
   readonly timeoutMs: number | null,
   readonly line: number,
   readonly column: number,
@@ -123,6 +124,7 @@ function addCase(
   body: Body | null,
   modifier: Modifier,
   timeoutMs: number | null,
+  skipReason: string | null = null,
 ): void {
   const position = callSite();
   current.children.push({
@@ -130,6 +132,7 @@ function addCase(
     name,
     body,
     modifier,
+    skipReason,
     timeoutMs,
     line: position.line,
     column: position.column,
@@ -179,6 +182,9 @@ function caseApi(): $FlowFixMe {
   api.skip = (name: string, body?: Body) => {
     addCase(name, body ?? null, "skip", null);
   };
+  api.skipBecause = (name: string, reason: string, body?: Body) => {
+    addCase(name, body ?? null, "skip", null, reason);
+  };
   api.todo = (name: string, body?: Body) => {
     addCase(name, body ?? null, "todo", null);
   };

package/internal/run.js

@@ -27,7 +27,11 @@ export type Outcome =
       /** Where the failing assertion was written, when the stack says. */
       readonly site: {| readonly line: number, readonly column: number |} | null,
     |}
-  | {| readonly status: "skipped", readonly reason: "explicit" | "not-only" | "filtered" |}
+  | {|
+      readonly status: "skipped",
+      readonly reason: "explicit" | "not-only" | "filtered",
+      readonly message?: string | null,
+    |}
   | {| readonly status: "todo" |};
 
 /** One finished case, as the runner reports it. */
@@ -188,12 +192,17 @@ async function runCase(
     });
   };
 
-  if (test.modifier === "todo" || test.body == null) {
+  if (test.modifier === "todo") {
     report({ status: "todo" });
     return true;
   }
   if (context.skipped || test.modifier === "skip") {
-    report({ status: "skipped", reason: "explicit" });
+    report({ status: "skipped", reason: "explicit", message: test.skipReason });
+    return true;
+  }
+  const body = test.body;
+  if (body == null) {
+    report({ status: "todo" });
     return true;
   }
   if (!context.onlyPath) {
@@ -222,7 +231,7 @@ async function runCase(
       for (const hook of context.beforeEach) {
         await withTimeout(hook, timeoutMs);
       }
-      await withTimeout(test.body, timeoutMs);
+      await withTimeout(body, timeoutMs);
     } catch (thrown) {
       outcome = failure(thrown, options.file ?? null);
     }
@@ -315,7 +324,7 @@ async function runSuite(
             line: child.line,
             column: child.column,
             durationMicros: 0,
-            outcome: failure(thrown),
+            outcome: failure(thrown, options.file ?? null),
           });
           passed = false;
           continue;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@uniflowed/test",
-  "version": "0.0.0-alpha.31",
+  "version": "0.0.0-alpha.33",
   "description": "The test API and worker for `uf test`: describe/it, a full matcher set, and the process uf fans test files out to.",
   "type": "module",
   "license": "MIT",
@@ -26,7 +26,7 @@
     "!*.test.js"
   ],
   "dependencies": {
-    "@uniflowed/host": "0.0.0-alpha.31"
+    "@uniflowed/host": "0.0.0-alpha.33"
   },
   "peerDependencies": {
     "axe-core": ">=4"