@unified-product-graph/core 0.16.2 → 0.17.1

package/dist/index.js

@@ -3174,9 +3174,13 @@ var UPG_CROSS_EDGE_TYPES = [
   "screen_targets_competitor",
   "feature_surfaces_product",
   "feature_uses_design_component",
-  "product_implements_design_system"
+  "product_implements_design_system",
+  // Org-link (0.17.0): dual-registered ownership edges (see UPGCrossEdgeType above).
+  "node_owned_by_team",
+  "node_owned_by_department"
 ];
 var REGISTRY_PRODUCT_ID = "registry";
+var UPG_PORTFOLIO_KINDS = ["owned", "watched", "strategic", "internal", "gtm"];
 
 // src/registry/entity-type-resolution.ts
 var TYPES = getTypes();
@@ -23369,7 +23373,8 @@ var TEAM_ORG_GUIDE = {
   anti_patterns: [
     { description: "Teams without OKRs: every team needs clear goals" },
     { description: "Dependencies without both teams linked: a dependency must connect blocker and blocked" },
-    { description: "Retrospectives without action items: reflection without action is just venting" }
+    { description: "Retrospectives without action items: reflection without action is just venting" },
+    { description: "Double-modelling the org as product_area and team_org: a product_area is the classification axis ON products (which area a product belongs to, the axis used to group products); a team_org department/team is the people structure (the org chart, who reports to whom). Use product_area to classify products and department/team for the org chart, and relate them through the team that owns an area rather than restating one as the other." }
   ]
 };
 var PROGRAM_MGMT_GUIDE = {
@@ -23478,7 +23483,8 @@ var PORTFOLIO_GUIDE = {
   ],
   anti_patterns: [
     { description: "Products without a product area: every product should be classified" },
-    { description: "Portfolios without strategic alignment: portfolio decisions should reflect strategy" }
+    { description: "Portfolios without strategic alignment: portfolio decisions should reflect strategy" },
+    { description: "Confusing product_area with the org chart: product_area is the classification axis on products (how products are grouped), not the people structure. Model who reports to whom with team_org department/team; relate the two through the team that owns an area." }
   ]
 };
 var WORKSPACE_GUIDE = {
@@ -26295,6 +26301,54 @@ var UPG_ANTI_PATTERNS = [
     severity: "medium",
     source: { kind: "practitioner", attribution: "Marty Cagan, Inspired (product discovery)" }
   },
+  // ── Operating-function layer (0.17.0): member_kind: operating_function ─────
+  // Carry concern 'operating' (UPG_ANTI_PATTERN_CONCERNS) and are evaluated ONLY
+  // for operating_function graphs — a function a team operates (revenue / success
+  // / finance / people / marketing), not a product it ships. The product-spine
+  // patterns above are not evaluated for that kind (category errors); these assert
+  // the function spine instead.
+  {
+    id: "operating-function-without-north-star",
+    since: "0.17.0",
+    name: "Operating function without a north-star metric",
+    description: "An operating function graph has real content but no north-star metric to operate toward. A function (sales, finance, people, marketing) is run against one headline number it moves and that rolls up to the company tree. With no north-star metric the function has direction but nothing to steer by.",
+    structured_condition: {
+      operator: "and",
+      checks: [
+        { check: { type: "total_entity_count", comparison: "gt", threshold: 3 } },
+        { check: { type: "entity_count", entity_type: "metric", filter: { property: "designation", value: "north_star" }, comparison: "zero" } }
+      ]
+    },
+    why_it_matters: "A function with no north-star metric cannot be steered, prioritised, or rolled into the company metric tree. Operating work becomes activity without a measured target.",
+    remediation: "Add the one `metric` the function operates toward and mark it `designation: north_star`, then wire it to the company metric tree via `metric_decomposes_into_metric`.",
+    stages: ["concept", "validation", "build", "beta", "launch", "growth", "mature", "maintenance", "sunset"],
+    severity: "high",
+    source: { kind: "fundamental" }
+  },
+  {
+    id: "operating-function-without-operating-content",
+    since: "0.17.0",
+    name: "Operating function without operating content",
+    description: "An operating function graph has more than a few entities but none in any operating domain (sales, go-to-market, customer success, growth, marketing, business model, pricing). It carries direction and people but no operating substance: the work the function actually runs.",
+    structured_condition: {
+      operator: "and",
+      checks: [
+        { check: { type: "total_entity_count", comparison: "gt", threshold: 3 } },
+        { check: { type: "domain_population", domain_id: "sales", comparison: "zero" } },
+        { check: { type: "domain_population", domain_id: "go_to_market", comparison: "zero" } },
+        { check: { type: "domain_population", domain_id: "customer_success", comparison: "zero" } },
+        { check: { type: "domain_population", domain_id: "growth", comparison: "zero" } },
+        { check: { type: "domain_population", domain_id: "marketing", comparison: "zero" } },
+        { check: { type: "domain_population", domain_id: "business_model", comparison: "zero" } },
+        { check: { type: "domain_population", domain_id: "pricing", comparison: "zero" } }
+      ]
+    },
+    why_it_matters: "A function graph that is all strategy and org chart with no operating domain is a stub: it states intent but models none of the work the function runs, so it answers no operating questions.",
+    remediation: "Populate at least one operating domain appropriate to the function (e.g. Field \u2192 `sales` / `go_to_market` / `customer_success`; Finance \u2192 `business_model` / `pricing`). Start from the matching template via `/upg-new-from-template`.",
+    stages: ["concept", "validation", "build", "beta", "launch", "growth", "mature", "maintenance", "sunset"],
+    severity: "medium",
+    source: { kind: "fundamental" }
+  },
   // ── Foundations layer (0.9.13): portfolio-scoped, registry-aware ──────────
   // These read the shared registry + cross-product edges, so they are evaluated
   // by portfolio_validate, not the single-graph evaluator. They carry no
@@ -26335,6 +26389,23 @@ var UPG_ANTI_PATTERNS = [
     stages: ["build", "beta", "launch", "growth", "mature"],
     severity: "low",
     source: { kind: "fundamental" }
+  },
+  // ── Operating-function org link (0.17.0): portfolio-scoped ─────────────────
+  // Cross-product detector (in portfolio_validate): an operating_function graph
+  // should reference the org unit it operates under, which lives once in the
+  // rollup's team_org map. Carries no structured_condition — the org link is a
+  // cross-product edge in portfolio.upg, not a single-graph shape.
+  {
+    id: "operating-function-without-org-link",
+    since: "0.17.0",
+    scope: "portfolio",
+    name: "Operating function without an org link",
+    description: "An operating_function graph does not reference the org unit it operates under. The department/team hierarchy lives once in the rollup (org_rollup) as team_org entities; a function should point its spine at the department or team that owns it (node_owned_by_department / node_owned_by_team), so the operating layer hangs off the canonical org map rather than re-stating it.",
+    why_it_matters: "A function with no org link floats free of the org chart: its work cannot be rolled up by department, and the single source of truth for who owns what is bypassed.",
+    remediation: "Add a cross-product node_owned_by_department (or node_owned_by_team) edge from the function spine to its department/team in the rollup. Mint the org unit once in the org_rollup graph; functions reference it.",
+    stages: ["concept", "validation", "build", "beta", "launch", "growth", "mature", "maintenance", "sunset"],
+    severity: "medium",
+    source: { kind: "fundamental" }
   }
 ];
 function getAntiPatternById(id) {
@@ -26347,6 +26418,45 @@ function getAntiPatternsBySeverity(severity) {
   return UPG_ANTI_PATTERNS.filter((ap) => ap.severity === severity);
 }
 
+// src/intelligence/validation-profiles.ts
+var UPG_ANTI_PATTERN_CONCERNS = {
+  // universal — kind-independent graph hygiene + strategy discipline
+  "objective-without-key-results": "universal",
+  "single-domain-graph": "universal",
+  "orphan-loose-thoughts": "universal",
+  // operating — only evaluated for operating_function graphs
+  "operating-function-without-north-star": "operating",
+  "operating-function-without-operating-content": "operating"
+  // everything else defaults to 'product_spine'
+};
+function concernFor(antiPatternId) {
+  return UPG_ANTI_PATTERN_CONCERNS[antiPatternId] ?? "product_spine";
+}
+var UPG_VALIDATION_PROFILES = {
+  product: { evaluate_concerns: ["product_spine", "universal"], gating_concerns: ["product_spine", "universal"] },
+  watched: { evaluate_concerns: ["product_spine", "universal"], gating_concerns: [] },
+  org_rollup: { evaluate_concerns: ["product_spine", "universal"], gating_concerns: ["universal"] },
+  operating_function: { evaluate_concerns: ["universal", "operating"], gating_concerns: ["universal", "operating"] }
+};
+function validationProfileFor(kind) {
+  return UPG_VALIDATION_PROFILES[kind ?? "product"] ?? UPG_VALIDATION_PROFILES.product;
+}
+function concernEvaluatedFor(kind, concern) {
+  return validationProfileFor(kind).evaluate_concerns.includes(concern);
+}
+function concernGatesFor(kind, concern) {
+  return validationProfileFor(kind).gating_concerns.includes(concern);
+}
+var COVERAGE_ANTI_PATTERNS = /* @__PURE__ */ new Set([
+  "single-domain-graph",
+  "persona-count-below-stage-benchmark",
+  "competitors-missing-past-validation"
+]);
+var THIN_GRAPH_THRESHOLD = 8;
+function isThinCoverageAdvisory(antiPatternId, totalEntityCount) {
+  return COVERAGE_ANTI_PATTERNS.has(antiPatternId) && totalEntityCount < THIN_GRAPH_THRESHOLD;
+}
+
 // src/intelligence/evaluator.ts
 var SEVERITY_ORDER = {
   high: 0,
@@ -26364,8 +26474,10 @@ function evaluateAntiPatterns(inputs, options) {
     if (inputs.productStage && !ap.stages.includes(inputs.productStage)) {
       continue;
     }
+    const concern = concernFor(ap.id);
+    if (!concernEvaluatedFor(inputs.memberKind, concern)) continue;
     if (evaluateCondition(ap.structured_condition, inputs)) {
-      fires.push(buildViolation(ap));
+      fires.push(buildViolation(ap, concern));
     }
   }
   fires.sort((a, b) => {
@@ -26434,11 +26546,12 @@ function compareNumber(value, comparison, threshold) {
   }
 }
 function evaluateEntityCount(check, inputs) {
-  const statusFilter = check.filter && typeof check.filter.status === "string" ? check.filter.status : void 0;
+  const filter = check.filter;
   let count = 0;
-  if (statusFilter) {
-    const byStatus = inputs.countsByTypeAndStatus?.[check.entity_type];
-    count = byStatus?.[statusFilter] ?? 0;
+  if (filter && typeof filter.property === "string" && typeof filter.value === "string") {
+    count = inputs.countsByTypeAndProperty?.[check.entity_type]?.[filter.property]?.[filter.value] ?? 0;
+  } else if (filter && typeof filter.status === "string") {
+    count = inputs.countsByTypeAndStatus?.[check.entity_type]?.[filter.status] ?? 0;
   } else {
     count = inputs.countsByType[check.entity_type] ?? 0;
   }
@@ -26505,11 +26618,12 @@ function evaluateDomainPopulation(check, inputs) {
 function evaluateOrphanCount(check, inputs) {
   return compareNumber(inputs.orphanCount, check.comparison, check.threshold);
 }
-function buildViolation(ap) {
+function buildViolation(ap, concern) {
   return {
     anti_pattern_id: ap.id,
     name: ap.name,
     severity: ap.severity,
+    concern,
     target_entities: collectTargetEntities(ap.structured_condition),
     description: ap.description,
     why_it_matters: ap.why_it_matters,
@@ -29337,7 +29451,7 @@ function serializeSingleWithHeader(doc, opts) {
   const summary = deriveSummary(product.description);
   if (summary) header.summary = summary;
   header.counts = { nodes: doc.nodes?.length ?? 0, edges: doc.edges?.length ?? 0 };
-  if (doc.member_kind === "org_rollup" || doc.member_kind === "watched") {
+  if (doc.member_kind === "org_rollup" || doc.member_kind === "watched" || doc.member_kind === "operating_function") {
     header.member_kind = doc.member_kind;
   }
   header.provenance = buildProvenance(doc, opts);
@@ -29363,10 +29477,12 @@ function serializePortfolioWithHeader(doc, opts) {
   const memberKindOf = (p) => p.member_kind ?? "product";
   const watchedCount = members.filter((p) => memberKindOf(p) === "watched").length;
   const rollupCount = members.filter((p) => memberKindOf(p) === "org_rollup").length;
+  const operatingFunctionCount = members.filter((p) => memberKindOf(p) === "operating_function").length;
   header.counts = {
     products: members.filter((p) => memberKindOf(p) === "product").length,
     ...watchedCount > 0 ? { watched_products: watchedCount } : {},
     ...rollupCount > 0 ? { org_rollups: rollupCount } : {},
+    ...operatingFunctionCount > 0 ? { operating_functions: operatingFunctionCount } : {},
     product_areas: doc.product_areas?.length ?? 0,
     portfolios: doc.portfolios?.length ?? 0,
     cross_edges: doc.cross_edges?.length ?? 0
@@ -29425,7 +29541,9 @@ function normalizeDocument(obj) {
     edges: raw.edges ?? []
   };
   const memberKind = header?.member_kind ?? raw.member_kind;
-  if (memberKind === "org_rollup" || memberKind === "watched") out.member_kind = memberKind;
+  if (memberKind === "org_rollup" || memberKind === "watched" || memberKind === "operating_function") {
+    out.member_kind = memberKind;
+  }
   if (_integrity) out._integrity = _integrity;
   return out;
 }
@@ -29438,7 +29556,7 @@ function isCanonical(text) {
 }
 
 // src/index.ts
-var UPG_VERSION = "0.16.2";
+var UPG_VERSION = "0.17.1";
 var UPG_FORMAT_VERSION = "0.4.0";
 var MARKDOWN_FORMAT_VERSION = "0.1";
 var UPG_TYPES = getTypes();
@@ -29508,6 +29626,7 @@ export {
   BUSINESS_MARKETING_AUDIENCE_FIRST_PLAYBOOK,
   CLASSIFICATION_EDGE_PROPERTY_SCHEMA,
   CONTENT_DEPTH_WARNING_RULES,
+  COVERAGE_ANTI_PATTERNS,
   DEFAULT_ENTITY_EMOJI,
   DEFERRED_PROPOSED_BY_CONTRACT,
   DISCOVERY_RESEARCH_VALIDATION_PLAYBOOK,
@@ -29527,8 +29646,10 @@ export {
   REFLECT_MODES,
   REGISTRY_PRODUCT_ID,
   STRATEGY_OUTCOMES_PLAYBOOK,
+  THIN_GRAPH_THRESHOLD,
   UPG_ACTIVE_TYPES,
   UPG_ANTI_PATTERNS,
+  UPG_ANTI_PATTERN_CONCERNS,
   UPG_APPROACHES,
   UPG_APPROACHES_BY_ID,
   UPG_AREA_TAXONOMY,
@@ -29567,6 +29688,7 @@ export {
   UPG_MIGRATIONS,
   UPG_PLAYBOOKS,
   UPG_POLYMORPHIC_EDGE_KEYS,
+  UPG_PORTFOLIO_KINDS,
   UPG_PRODUCT_STAGES,
   UPG_PRODUCT_STAGE_COERCION_MAP,
   UPG_PROPERTY_MIGRATIONS,
@@ -29589,6 +29711,7 @@ export {
   UPG_TYPE_LABELS,
   UPG_TYPE_LABELS_MAP,
   UPG_TYPE_NAMES,
+  UPG_VALIDATION_PROFILES,
   UPG_VALID_CHILDREN,
   UPG_VERSION,
   UPG_WILDCARD_ENDPOINT,
@@ -29601,6 +29724,9 @@ export {
   collectSlugsForType,
   compareVersions,
   computeBodyChecksum,
+  concernEvaluatedFor,
+  concernFor,
+  concernGatesFor,
   describeTreePattern,
   edgeCarriesProperties,
   evaluateAntiPatterns,
@@ -29675,6 +29801,7 @@ export {
   isRegisteredPolymorphicEdge,
   isRuntimeStateShapedProperty,
   isSubSequenceStep,
+  isThinCoverageAdvisory,
   isUPGDocument,
   listPropertiesByModifier,
   listStatusMigrations,
@@ -29700,6 +29827,7 @@ export {
   validateProductStageStrict,
   validateUPGDocument,
   validateUPGFramework,
+  validationProfileFor,
   walkMigrationChainToCanonical
 };
 //# sourceMappingURL=index.js.map