@unifan/pi-review-zh 1.0.3 → 1.0.4

package/agents/perf-review.md

@@ -0,0 +1,67 @@
+---
+name: perf-review
+package: pi-review
+description: 性能与基准测试审查专家：专项排查内存泄漏、高频GC分配、算法复杂度退化、锁竞争，并主动探测执行基准测试(Benchmark)。
+tools: read, grep, bash
+systemPromptMode: replace
+inheritProjectContext: false
+inheritSkills: false
+---
+你是**性能与基准测试审查专家（Performance & Benchmark Reviewer）**。你的任务是专项深度排查本次代码改动中的性能瓶颈、内存分配压力与并发隐患，并主动寻找和执行基准测试（Benchmark）。
+
+## 核心审查维度（跨语言与全栈）
+
+1. **内存与 GC 分配（Memory & Allocation Pressure）**：
+   - **高频循环堆分配**：检查循环（Update / Tick / 帧循环 / 高频事件处理器）中是否存在 `new` 对象、隐式闭包分配、Lambda 捕获外部变量、LINQ、装箱/拆箱。
+   - **集合与缓冲区**：集合未预设初始容量导致的频繁扩容与重分配、频繁的数组拷贝、低效字符串拼接（应使用 StringBuilder / Span）。
+   - **内存泄漏**：未注销的事件监听（Event）、未释放的非托管资源/句柄/流/GPU 纹理、长生命周期单例持有大对象强引用。
+
+2. **CPU 与算法复杂度（CPU & Complexity）**：
+   - **复杂度退化**：高频热点中 $O(N^2)$ 或更高复杂度的嵌套循环与线性查找（应替换为 Dictionary/HashMap/HashSet 索引）。
+   - **昂贵反射与深拷贝**：热点路径中频繁反射（Reflection）、动态解析、低效序列化。
+   - **主线程阻塞**：UI 线程或渲染主线程中执行同步大文件读取或阻塞性 I/O。
+
+3. **并发与锁竞争（Concurrency & Contention）**：
+   - 锁粒度过大、在锁内执行耗时 I/O、无界队列、死锁与假共享（False Sharing）。
+
+4. **基准测试探索与执行（Benchmark Runner）**：
+   - **自动探测**：主动检查工作区是否存在基准测试套件（如 `BenchmarkDotNet`、`go test -bench`、`cargo bench`、`pytest-benchmark`、`vitest bench` 等）。
+   - **有条件执行**：若存在现成的基准测试且安全可运行，使用 `bash` 运行一次并提取关键指标（单次耗时、单次分配字节数）。
+   - **基准代码生成**：若当前改动属于核心热点但缺乏 Benchmark，在报告中给出一段针对该场景的标准基准测试代码建议。
+
+## 执行步骤
+1. 读取任务中的 diff 文件与 manifest 清单。
+2. 重点分析改动中涉及性能与资源管理的关键代码，必要时读取上下文文件。
+3. 检查并运行基准测试（如适用）。
+4. 输出格式规范的 Markdown 报告并在最末尾附带 JSON 块。
+
+## 输出格式（必须使用中文撰写总结与描述）
+
+请以 Markdown 格式输出最终回复：
+
+## Summary
+一句话中文性能总结（评定本次修改的性能影响：优秀 / 无明显影响 / 存在性能隐患 / 严重性能退化）。
+
+## Findings
+每个发现一行：`- [SEVERITY|category|confidence] 文件路径:行号 — 中文问题描述、分配分析与优化建议`。无问题写 `No findings.`。
+
+## Benchmark Analysis
+说明工作区中基准测试探测结果与运行数据。若无基准测试，可针对改动热点提供一段简短的 Benchmark 编写建议。
+
+## Coverage
+- Files checked: 检查的文件
+- Commands run: 执行的基准测试或检查命令
+- Limitations: 局限说明
+
+然后在最末尾严格输出一个被 ```json 代码块包裹的 JSON：
+
+```json
+{
+  "status": "ok",
+  "issues": [
+    { "file": "src/Manager.cs", "line": 42, "category": "perf", "severity": "major", "confidence": 9, "evidence": "Update 循环中存在 new GC 堆分配，且高频调用 LINQ 查询", "fingerprint": "src/Manager.cs:42:perf:a1b2c3" }
+  ],
+  "summary": "中文一句话性能总结",
+  "coverage": { "filesChecked": ["src/Manager.cs"], "commandsRun": [], "limitations": [] }
+}
+```

package/index.ts

@@ -25,18 +25,21 @@ export default function (pi: ExtensionAPI) {
 	registerReviewReportTool(pi);
 	registerPiReviewRenderer(pi);
 	pi.registerCommand("review", {
-		description: "启动 AI 并发代码审查 (支持多专家子代理 + 门禁总裁判系统)。--lite = 极速单专家审查。",
+		description: "启动 AI 并发代码审查 (支持多专家子代理 + 门禁总裁判系统)。--lite = 极速单专家审查，--perf = 性能与基准测试审查。",
 		getArgumentCompletions: (prefix: string) => {
+			const options = [
+				{ value: "--lite", label: "--lite", description: "极速单专家审查 (无门禁，低延迟省 Token)" },
+				{ value: "--perf", label: "--perf", description: "专项性能与基准测试审查 (GC/内存分配/CPU/Benchmark)" },
+				{ value: "--gate-model", label: "--gate-model", description: "指定当前审查的门禁裁判模型" },
+			];
 			const trimmed = prefix.trimStart();
+			if (!trimmed) return options;
 			const tokens = trimmed.split(/\s+/).filter(Boolean);
 			const last = tokens[tokens.length - 1] ?? "";
 			if (last.startsWith("--")) {
-				return [
-					{ value: "--lite", label: "--lite", description: "极速单专家审查 (无门禁，低延迟省 Token)" },
-					{ value: "--gate-model", label: "--gate-model", description: "指定当前审查的门禁裁判模型" },
-				].filter((o) => o.value.startsWith(last));
+				return options.filter((o) => o.value.startsWith(last));
 			}
-			return null;
+			return options;
 		},
 		handler: async (args, ctx) => {
 			const notify = (msg: string, level: "info" | "warning" | "error" = "info") => {
@@ -61,7 +64,13 @@ export default function (pi: ExtensionAPI) {
 					return;
 				}
 
-				const prepared = await prepareRun({ cwd: ctx.cwd, input: parsed.input, lite: parsed.lite, gateModel: parsed.gateModel });
+				const prepared = await prepareRun({
+					cwd: ctx.cwd,
+					input: parsed.input,
+					lite: parsed.lite,
+					perf: parsed.perf,
+					gateModel: parsed.gateModel,
+				});
 				if (!prepared) {
 					notify("没有检测到需要审查的内容 (未找到修改、PR 或非 Git 仓库)。", "info");
 					return;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@unifan/pi-review-zh",
-  "version": "1.0.3",
+  "version": "1.0.4",
   "description": "Pi AI 并发代码审查扩展（多专家子代理并发 + 门禁裁判系统，中文增强版）",
   "type": "module",
   "license": "MIT",

package/src/cli-args.ts

@@ -1,18 +1,5 @@
 /**
  * Parse `/review` command arguments.
- *
- * Surface is intentionally minimal:
- *   - `--lite`      fast single-agent review (no fan-out, no gate)
- *   - `--no-spawn`  hidden dry-run (prints the resolved plan, no subprocess)
- *   - trailing freeform text → user review request (focus / requirements /
- *     PR url / context), injected into reviewers and gate via target.userContext
- *     (see src/prep.ts and src/git-input.ts)
- *
- * Removed flags (--threshold / --reviewer / --score-per-issue / --diff) are
- * accepted-but-ignored for graceful degradation of old invocations: a valued
- * legacy flag also consumes its next token so its value does not leak into
- * `input`. Those capabilities now live in config.json (`/review-config`).
- * `--gate-model <id>` remains an active per-run override.
  */
 
 export interface ParsedReviewArgs {
@@ -22,11 +9,12 @@ export interface ParsedReviewArgs {
 	noSpawn: boolean;
 	/** Single-agent fast mode: one reviewer, no gate. */
 	lite: boolean;
+	/** Dedicated performance review mode: perf-reviewer with benchmark capabilities. */
+	perf: boolean;
 	/** Override the gate model for this run (otherwise config.gate.model). */
 	gateModel?: string;
 }
 
-/** Removed valued flags — silently skip flag + value to keep input clean. */
 const LEGACY_VALUED_FLAGS = new Set([
 	"--threshold",
 	"--reviewer",
@@ -36,13 +24,13 @@ const LEGACY_VALUED_FLAGS = new Set([
 
 export function parseReviewArgs(raw: string): ParsedReviewArgs {
 	const tokens = tokenize(raw);
-	const result: ParsedReviewArgs = { noSpawn: false, lite: false };
+	const result: ParsedReviewArgs = { noSpawn: false, lite: false, perf: false };
 	const inputParts: string[] = [];
 
 	for (let i = 0; i < tokens.length; i++) {
 		const t = tokens[i];
 		if (LEGACY_VALUED_FLAGS.has(t)) {
-			i++; // consume the value too
+			i++;
 			continue;
 		}
 		if (t === "--no-spawn") {
@@ -53,13 +41,17 @@ export function parseReviewArgs(raw: string): ParsedReviewArgs {
 			result.lite = true;
 			continue;
 		}
+		if (t === "--perf" || t === "--performance") {
+			result.perf = true;
+			continue;
+		}
 		if (t === "--gate-model") {
 			const id = tokens[++i];
 			if (id) result.gateModel = id;
 			continue;
 		}
 		if (t.startsWith("-")) {
-			continue; // ignore other legacy / unknown flags
+			continue;
 		}
 		inputParts.push(t);
 	}
@@ -72,7 +64,6 @@ export function parseReviewArgs(raw: string): ParsedReviewArgs {
 	return result;
 }
 
-/** Split on whitespace preserving quoted segments. */
 function tokenize(raw: string): string[] {
 	const out: string[] = [];
 	let cur = "";
@@ -102,4 +93,4 @@ function tokenize(raw: string): string[] {
 	}
 	if (cur.length > 0) out.push(cur);
 	return out;
-}
+}

package/src/directive.ts

@@ -22,6 +22,7 @@ export interface ReviewDirectiveInput {
 	threshold: number;
 	verdictPolicy?: "strict" | "legacy";
 	lite: boolean;
+	perf?: boolean;
 	gateEnabled?: boolean;
 	cwd: string;
 	workspacePath: string;
@@ -32,21 +33,24 @@ export interface ReviewDirectiveInput {
 }
 
 export function buildReviewDirective(input: ReviewDirectiveInput): string {
-	const { target, reviewers, gateModel, gateThinking, threshold, lite, cwd, workspacePath, manifestPath, diffPath, workflowPath } = input;
+	const { target, reviewers, gateModel, gateThinking, threshold, lite, perf, cwd, workspacePath, manifestPath, diffPath, workflowPath } = input;
+	const isSingle = lite || Boolean(perf);
 	const policy = input.verdictPolicy ?? "strict";
-	const gateOn = !lite && input.gateEnabled !== false;
+	const gateOn = !isSingle && input.gateEnabled !== false;
 	const budgets = input.budgets ?? resolveLeanBudgets();
 	const gateModelWithThinking = withThinkingSuffix(gateModel, gateThinking);
 	const blocks: string[] = [];
 
-	blocks.push("# 代码审查流程 (极简 Token 模式)");
+	const modeLabel = perf ? " (性能与基准测试专属模式)" : lite ? " (极速单兵模式)" : "";
+
+	blocks.push(`# 代码审查流程${modeLabel}`);
 	blocks.push("");
 	if (target.userContext?.trim()) {
 		blocks.push(`**用户指令/侧重点:** ${target.userContext.trim()}`);
 		blocks.push("");
 	}
 	blocks.push(
-		`请对本次代码改动 (${target.label}) 进行审查。插件已准备好目标工作区、diff 文件及运行清单。你需要执行一次 workflowScript 启动 ${reviewers.length} 个并发审查专家${lite ? " (极速单兵模式)" : ""}${gateOn ? " + 门禁裁判长" : ""}，随后调用 \`pi_review_report\` 工具完成报告渲染与归档。切勿在聊天中直接重复书写未加工的原始问题细节。`,
+		`请对本次代码改动 (${target.label}) 进行审查。插件已准备好目标工作区、diff 文件及运行清单。你需要执行一次 workflowScript 启动 ${reviewers.length} 个审查专家${modeLabel}${gateOn ? " + 门禁裁判长" : ""}，随后调用 \`pi_review_report\` 工具完成报告渲染与归档。切勿在聊天中直接重复书写未加工的原始问题细节。`,
 	);
 	blocks.push("");
 	blocks.push("## 硬性规则（严禁违反）");
@@ -54,8 +58,8 @@ export function buildReviewDirective(input: ReviewDirectiveInput): string {
 	blocks.push("- **语言要求**：所有面向用户的输出（包括工作流待办清单、状态汇报、问题总结与回复）**必须使用纯正中文**。");
 	blocks.push("- 在本次审查中**只能且必须调用一次** `subagent` 工具：即第 2 步的 workflowScript 调用。");
 	blocks.push(
-		lite
-			? "- 第 2 步必须是**单次** `subagent({ workflowScript, async:false, ... })` 调用，通过 `runs.all([...])` 并发执行单兵审查专家——严禁多次调用。"
+		isSingle
+			? "- 第 2 步必须是**单次** `subagent({ workflowScript, async:false, ... })` 调用，通过 `runs.all([...])` 并发执行专家——严禁多次调用。"
 			: gateOn
 				? "- 第 2 步必须是**单次** `subagent({ workflowScript, async:false, ... })` 调用，通过 `runs.all([...])` 并发执行**所有**专家，并通过 `runs.run(\"gate\", ...)` 运行门禁裁判长——严禁每个专家单独调用一次，严禁串行多波次调用。"
 				: "- 第 2 步必须是**单次** `subagent({ workflowScript, async:false, ... })` 调用，通过 `runs.all([...])` 并发执行**所有**专家——严禁多波次单独调用。",
@@ -89,11 +93,13 @@ export function buildReviewDirective(input: ReviewDirectiveInput): string {
 	const todoSteps = [
 		`确认插件准备的运行清单可读: ${manifestPath}`,
 		`确认目标工作区可读: ${workspacePath}`,
-		lite
-			? "执行 workflowScript: 启动单兵极速审查专家 (单次 subagent 调用)"
-			: gateOn
-				? `执行 workflowScript: 启动 ${reviewers.length} 个并发审查专家 + 门禁裁判长 (单次 subagent 调用)`
-				: `执行 workflowScript: 启动 ${reviewers.length} 个并发审查专家 (单次 subagent 调用)`,
+		perf
+			? "执行 workflowScript: 启动专项性能与基准测试审查专家 (单次 subagent 调用)"
+			: lite
+				? "执行 workflowScript: 启动单兵极速审查专家 (单次 subagent 调用)"
+				: gateOn
+					? `执行 workflowScript: 启动 ${reviewers.length} 个并发审查专家 + 门禁裁判长 (单次 subagent 调用)`
+					: `执行 workflowScript: 启动 ${reviewers.length} 个并发审查专家 (单次 subagent 调用)`,
 		"调用 `pi_review_report` 工具提交审查结果并生成中文报告",
 	];
 	for (const s of todoSteps) blocks.push(`- [ ] ${s}`);
@@ -124,7 +130,7 @@ export function buildReviewDirective(input: ReviewDirectiveInput): string {
 		gateThinking,
 		gateModel,
 		budgets,
-		lite,
+		lite: isSingle,
 		gateEnabled: gateOn,
 		threshold,
 		verdictPolicy: policy,
@@ -159,8 +165,8 @@ export function buildReviewDirective(input: ReviewDirectiveInput): string {
 	blocks.push("## 第 2 步 — 执行代码审查（仅调用一次 subagent workflowScript）");
 	blocks.push("");
 	blocks.push(
-		lite
-			? "该脚本会启动单兵极速审查专家，输出包含 JSON 块的 Markdown 报告。"
+		isSingle
+			? "该脚本会启动审查专家，输出包含 JSON 块的 Markdown 报告。"
 			: gateOn
 				? "该脚本会并发启动各个审查专家，随后将报告汇总给门禁裁判长，裁判长输出裁决报告与 JSON 块。"
 				: "该脚本会并发启动各个审查专家，输出 Markdown 报告。",
@@ -229,7 +235,7 @@ export function buildWorkflowScript(input: {
 	const gateOn = !lite && gateEnabled;
 
 	const READ_ONLY_PREFIX =
-		"只读任务（READ-ONLY）——仅执行审查分析。严禁写入或修改任何文件。仅返回审查发现。所有分析总结、问题描述与建议必须使用纯正中文。";
+		"只读任务（READ-ONLY）——仅执行审查分析与基准测试。严禁修改源码文件。仅返回审查发现。所有分析总结、问题描述与建议必须使用纯正中文。";
 
 	const lines: string[] = [];
 	lines.push("");
@@ -266,6 +272,11 @@ export function buildWorkflowScript(input: {
 				"若 change-profile.docsOnly 为 true，返回跳过状态：SKIPPED: docs-only。否则优先从 diff 本身分析，最多只读取 3 个额外上下文文件。",
 			);
 		}
+		if (r.id === "perf-review") {
+			taskParts.push(
+				"重点排查循环内高频GC分配、算法复杂度、锁竞争、内存泄漏，并主动探测和执行工作区中的Benchmark基准测试。",
+			);
+		}
 		if (userContext?.trim()) {
 			taskParts.push(`用户需求: ${userContext.trim()}`);
 		}

package/src/review-run.ts

@@ -47,6 +47,8 @@ export interface PrepareRunInput {
 	input?: string;
 	/** Support `--lite` single-agent mode. */
 	lite?: boolean;
+	/** Support `--perf` performance & benchmark mode. */
+	perf?: boolean;
 	/** Optional per-run gate model override. */
 	gateModel?: string;
 	/** Set false for dry-runs — pruning is a side effect a dry run must not have. */
@@ -143,9 +145,12 @@ export async function prepareRun(input: PrepareRunInput): Promise<PreparedRun |
 		rulePaths,
 		historyAvailable: workspaceResult.historyAvailable,
 	};
-	const reviewers = input.lite
-		? [{ id: "lite-review", label: "Lite Review", enabled: true, model: "inherit" }]
-		: reviewersForRouting(target, config, profile);
+	const isSingle = input.lite || input.perf;
+	const reviewers = input.perf
+		? [{ id: "perf-review", label: "Performance Review", enabled: true, model: "inherit" }]
+		: input.lite
+			? [{ id: "lite-review", label: "Lite Review", enabled: true, model: "inherit" }]
+			: reviewersForRouting(target, config, profile);
 	const skippedReasons = adaptiveSkips(profile);
 	// The report tool uses this to reject findings that did not come from this
 	// run's roster (stale-artifact contamination guard).
@@ -165,11 +170,12 @@ export async function prepareRun(input: PrepareRunInput): Promise<PreparedRun |
 		target,
 		reviewers,
 		gateModel,
-		gateThinking: input.lite ? undefined : config.gate.thinking,
+		gateThinking: isSingle ? undefined : config.gate.thinking,
 		gateEnabled: config.gate.enabled,
 		threshold: config.gate.threshold,
 		verdictPolicy: config.gate.verdictPolicy,
 		lite: Boolean(input.lite),
+		perf: Boolean(input.perf),
 		cwd,
 		workspacePath,
 		manifestPath,
@@ -179,7 +185,7 @@ export async function prepareRun(input: PrepareRunInput): Promise<PreparedRun |
 	});
 	// Remember which lanes adaptive routing dropped so the report can surface
 	// them as coverage rather than letting users wonder where a reviewer went.
-	if (!input.lite && config.routing.mode === "adaptive" && skippedReasons.length > 0) {
+	if (!isSingle && config.routing.mode === "adaptive" && skippedReasons.length > 0) {
 		const skippedByRouting: Array<{ id: string; reason: string }> = [];
 		for (const [id, reason] of skippedReasons) {
 			if (!reviewers.some((r) => r.id === id)) skippedByRouting.push({ id, reason });