@unicitylabs/sphere-sdk 0.11.7 → 0.11.8

package/dist/impl/shared/wallet-api/index.cjs

@@ -1485,16 +1485,19 @@ var WalletApiClient = class _WalletApiClient {
   /**
    * Retry transient REST failures with bounded exponential backoff + jitter:
    * - a thrown transient `NETWORK` failure (dropped/reset connection, DNS blip)
-   *   retries on **idempotent GETs only** — a lost-response retry of a write
-   *   could double-apply;
+   *   retries on **idempotent requests** — every GET, plus a write the caller
+   *   marked `idempotentWrite` (the server replays it as a no-op, so a
+   *   lost-response retry cannot double-apply; today only `inventory/apply`,
+   *   idempotent by transferId — #664). A non-idempotent write is single-attempt;
    * - a `429` response retries on **any** method (a 429 is rejected before the
    *   handler runs — the write never executed), honoring the server `Retry-After`;
-   * - a `503` response retries on **GETs only** (a write may have started).
+   * - a `503` response retries on **idempotent requests only** (a non-idempotent
+   *   write may have started).
    * Every other outcome (2xx, or a non-retryable status) is returned to the
    * caller, which maps a non-2xx to a typed {@link WalletApiError}.
    */
-  async rawFetchWithRetry(method, path, body, jwt) {
-    const idempotent = method === "GET";
+  async rawFetchWithRetry(method, path, body, jwt, idempotentWrite = false) {
+    const idempotent = method === "GET" || idempotentWrite;
     for (let attempt = 1; ; attempt += 1) {
       let res;
       try {
@@ -1517,8 +1520,8 @@ var WalletApiClient = class _WalletApiClient {
   }
   /**
    * Delay before retrying a non-2xx response, or `null` to not retry. `429`
-   * retries on any method (rejected before execution); `503` on idempotent GETs.
-   * Honors a capped `Retry-After` when present, else falls back to backoff.
+   * retries on any method (rejected before execution); `503` on idempotent
+   * requests only. Honors a capped `Retry-After` when present, else backoff.
    */
   retryDelayForStatus(res, idempotent, attempt) {
     const retryable = res.status === 429 || res.status === 503 && idempotent;
@@ -1542,16 +1545,18 @@ var WalletApiClient = class _WalletApiClient {
    * Authenticated JSON request. A 401 triggers one silent re-auth
    * (refresh → challenge fallback) and one retry; {@link rawFetchWithRetry}
    * additionally rides out transient failures — a dropped connection on an
-   * idempotent GET, or a `429`/`503` with `Retry-After` — so a single blip or a
-   * brief rate-limit window doesn't fail the call.
+   * idempotent request (any GET, or a write flagged `opts.idempotent`), or a
+   * `429`/`503` with `Retry-After` — so a single blip or a brief rate-limit
+   * window doesn't fail the call.
    */
-  async requestJson(method, path, body) {
+  async requestJson(method, path, body, opts) {
+    const idempotent = opts?.idempotent ?? false;
     if (!this.jwt) await this.signIn();
-    let res = await this.rawFetchWithRetry(method, path, body, this.jwt);
+    let res = await this.rawFetchWithRetry(method, path, body, this.jwt, idempotent);
     if (res.status === 401) {
       this.jwt = null;
       await this.signIn();
-      res = await this.rawFetchWithRetry(method, path, body, this.jwt);
+      res = await this.rawFetchWithRetry(method, path, body, this.jwt, idempotent);
     }
     if (res.status === 204) return null;
     if (!res.ok) throw await this.toError(res, `${method} ${path}`);
@@ -1583,12 +1588,20 @@ var WalletApiClient = class _WalletApiClient {
    */
   async applyInventoryDelta(req) {
     const cursor = parseApplyResult(
-      await this.requestJson("POST", "/v1/inventory/apply", {
-        transferId: req.transferId,
-        spent: req.spent,
-        added: req.added,
-        ...req.externalDelivery !== void 0 ? { externalDelivery: req.externalDelivery } : {}
-      })
+      await this.requestJson(
+        "POST",
+        "/v1/inventory/apply",
+        {
+          transferId: req.transferId,
+          spent: req.spent,
+          added: req.added,
+          ...req.externalDelivery !== void 0 ? { externalDelivery: req.externalDelivery } : {}
+        },
+        // Idempotent by transferId — the server replays a re-applied transferId
+        // to the same cursor (beginApplied), so a lost-response retry on a flaky
+        // link is safe and won't double-apply (#664).
+        { idempotent: true }
+      )
     );
     await this.setLocalIntentStatus(req.transferId, "completed");
     return cursor;