@unerr-ai/unerr 0.1.6 → 0.1.7

package/dist/__tests__/sprint-s7-persistent.test.js

@@ -1,263 +0,0 @@
-/**
- * Sprint S7: Wire Persistent Context (Layer 2) — Integration Tests.
- *
- * Verifies:
- *   - S7.1: Auto-snapshot triggers fire on test_pass and pre_critical_change
- *   - S7.2+S7.3: Session resume generates structured greeting from ledger
- *   - S7.4: Resume context injected as _context.session_resume on first response
- *   - S7.5: Durability scorer wired into entity responses (< 0.5 warning)
- *   - S7.6: Negative knowledge anti-patterns injected before agent touches code
- *   - S7.7: Timeline fork created on rewind
- *   - S7.8: Durability data feeds into session health monitor
- */
-import { describe, expect, it } from "vitest";
-import { createDurabilityScorer } from "../intelligence/durability-scorer.js";
-import { detectInstableEntities } from "../intelligence/negative-knowledge.js";
-import { orderContextFields, } from "../intelligence/query-router.js";
-import { generateSessionResume } from "../proxy/session-resume.js";
-import { shouldAutoSnapshot } from "../tracking/auto-snapshot-triggers.js";
-import { createTimelineFork } from "../tracking/timeline-fork.js";
-function makeLedgerEntry(overrides) {
-    return {
-        id: overrides.id ?? `e${Math.random().toString(36).slice(2, 10)}`,
-        ts: overrides.ts ?? new Date().toISOString(),
-        tool: overrides.tool ?? "get_function",
-        args_summary: overrides.args_summary ?? {},
-        result_summary: overrides.result_summary ?? { found: true },
-        branch: overrides.branch ?? "main",
-        session_id: overrides.session_id ?? "sess-1",
-    };
-}
-describe("Sprint S7: Wire Persistent Context", () => {
-    describe("S7.1: Auto-snapshot triggers in proxy lifecycle", () => {
-        it("triggers on test_pass result", () => {
-            const result = shouldAutoSnapshot("run_command", { command: "npm test" }, { exitCode: 0 });
-            expect(result).toBeTruthy();
-            expect(result.type).toBe("test_pass");
-        });
-        it("triggers on high fan_in threshold (pre-critical change)", () => {
-            const result = shouldAutoSnapshot("sync_local_diff", { file: "src/core.ts", entity_key: "src/core.ts::processPayment" }, { fan_in: 50 }, 50);
-            expect(result).toBeTruthy();
-            expect(result.type).toBe("pre_critical_change");
-        });
-        it("does not trigger on normal tool call", () => {
-            const result = shouldAutoSnapshot("search_code", { query: "hello" }, { count: 5 });
-            expect(result).toBeFalsy();
-        });
-    });
-    describe("S7.2+S7.3: Session resume from ledger", () => {
-        it("generates resume context from ledger entries", () => {
-            const entries = [
-                makeLedgerEntry({
-                    tool: "get_function",
-                    args_summary: { key: "src/auth.ts::login" },
-                    ts: "2026-05-01T10:00:00Z",
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/auth.ts"] },
-                    ts: "2026-05-01T10:01:00Z",
-                }),
-                makeLedgerEntry({
-                    tool: "get_callers",
-                    args_summary: { key: "src/auth.ts::login" },
-                    ts: "2026-05-01T10:02:00Z",
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/db.ts"] },
-                    ts: "2026-05-01T10:03:00Z",
-                }),
-            ];
-            const resume = generateSessionResume(entries);
-            expect(resume).not.toBeNull();
-            expect(resume.summary).toBeDefined();
-            expect(resume.filesModified.length).toBeGreaterThan(0);
-        });
-        it("returns null for empty entries", () => {
-            const resume = generateSessionResume([]);
-            expect(resume).toBeNull();
-        });
-    });
-    describe("S7.4: Context ordering includes session_resume", () => {
-        it("orders session_resume between corrections and reminder", () => {
-            const ctx = {
-                session_resume: {
-                    summary: "Last session modified auth.ts",
-                    filesModified: ["src/auth.ts"],
-                    incompleteEntities: ["login"],
-                },
-                blast_radius: "14 callers",
-                conventions: ["naming: camelCase"],
-            };
-            const ordered = orderContextFields(ctx);
-            const keys = Object.keys(ordered);
-            expect(keys.indexOf("blast_radius")).toBeLessThan(keys.indexOf("session_resume"));
-            expect(keys.indexOf("session_resume")).toBeLessThan(keys.indexOf("conventions"));
-        });
-    });
-    describe("S7.5: Durability scorer wired into entity responses", () => {
-        it("computes durability scores from ledger entries", () => {
-            const baseTime = Date.now();
-            // Fragile: modified 4 times rapidly, stable: modified once early
-            const entries = [
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/stable.ts"] },
-                    ts: new Date(baseTime).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/fragile.ts"] },
-                    ts: new Date(baseTime + 10000).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/fragile.ts"] },
-                    ts: new Date(baseTime + 20000).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/fragile.ts"] },
-                    ts: new Date(baseTime + 30000).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/fragile.ts"] },
-                    ts: new Date(baseTime + 600000).toISOString(),
-                }),
-            ];
-            const scorer = createDurabilityScorer();
-            scorer.computeScores(entries);
-            const fragile = scorer.getScore("src/fragile.ts");
-            expect(fragile).not.toBeNull();
-            expect(fragile.modificationCount).toBe(4);
-            const stable = scorer.getScore("src/stable.ts");
-            expect(stable).not.toBeNull();
-            expect(stable.modificationCount).toBe(1);
-            // Fragile should have lower or equal durability (more churn = less stable)
-            expect(fragile.score).toBeLessThanOrEqual(stable.score);
-        });
-        it("getTopUnstable returns most fragile entities", () => {
-            const baseTime = Date.now();
-            const entries = [
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/a.ts"] },
-                    ts: new Date(baseTime).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/a.ts"] },
-                    ts: new Date(baseTime + 1000).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/a.ts"] },
-                    ts: new Date(baseTime + 2000).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/b.ts"] },
-                    ts: new Date(baseTime).toISOString(),
-                }),
-            ];
-            const scorer = createDurabilityScorer();
-            scorer.computeScores(entries);
-            const unstable = scorer.getTopUnstable(2);
-            expect(unstable.length).toBeGreaterThan(0);
-            expect(unstable[0].entityKey).toBe("src/a.ts");
-        });
-    });
-    describe("S7.6: Negative knowledge anti-pattern injection", () => {
-        it("detects instable entities from rapid modifications", () => {
-            const baseTime = Date.now();
-            const entries = [
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/flaky.ts"] },
-                    ts: new Date(baseTime).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/flaky.ts"] },
-                    ts: new Date(baseTime + 30000).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/flaky.ts"] },
-                    ts: new Date(baseTime + 60000).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/flaky.ts"] },
-                    ts: new Date(baseTime + 90000).toISOString(),
-                }),
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/flaky.ts"] },
-                    ts: new Date(baseTime + 120000).toISOString(),
-                }),
-            ];
-            const corrections = detectInstableEntities(entries, 10 * 60 * 1000);
-            expect(corrections.length).toBeGreaterThan(0);
-            expect(corrections[0].entityKey).toBe("src/flaky.ts");
-            expect(corrections[0].pattern).toBeDefined();
-            expect(corrections[0].reason).toBeDefined();
-        });
-        it("does not flag entities modified only once", () => {
-            const entries = [
-                makeLedgerEntry({
-                    tool: "sync_local_diff",
-                    args_summary: { files: ["src/once.ts"] },
-                    ts: new Date().toISOString(),
-                }),
-            ];
-            const corrections = detectInstableEntities(entries);
-            const forOnce = corrections.filter((c) => c.entityKey === "src/once.ts");
-            expect(forOnce.length).toBe(0);
-        });
-    });
-    describe("S7.7: Timeline fork on rewind", () => {
-        it("creates timeline fork with abandoned entities", () => {
-            const fork = createTimelineFork("snap-123", ["processPayment", "validateOrder"], ["fix the payment flow"], "Approach failed — infinite loop");
-            expect(fork.forkPoint).toBe("snap-123");
-            expect(fork.abandonedBranch.entityChanges).toContain("processPayment");
-            expect(fork.abandonedBranch.entityChanges).toContain("validateOrder");
-            expect(fork.abandonedBranch.promptsTried).toContain("fix the payment flow");
-            expect(fork.abandonedBranch.failureReason).toBe("Approach failed — infinite loop");
-            expect(fork.newBranch.timelineId).toBeGreaterThan(fork.abandonedBranch.timelineId);
-        });
-        it("deduplicates abandoned entities", () => {
-            const fork = createTimelineFork("snap-456", ["entity1", "entity1", "entity2", "entity2"], []);
-            expect(fork.abandonedBranch.entityChanges).toEqual([
-                "entity1",
-                "entity2",
-            ]);
-        });
-    });
-    describe("S7.8: Durability feeds into session health monitor", () => {
-        it("context ordering places durability_warning with high priority", () => {
-            const ctx = {
-                durability_warning: "FRAGILE: entity has durability 0.3",
-                conventions: ["naming: camelCase"],
-                blast_radius: "14 callers",
-            };
-            const ordered = orderContextFields(ctx);
-            const keys = Object.keys(ordered);
-            // durability_warning should come after blast_radius but before conventions
-            expect(keys.indexOf("blast_radius")).toBeLessThan(keys.indexOf("durability_warning"));
-            expect(keys.indexOf("durability_warning")).toBeLessThan(keys.indexOf("conventions"));
-        });
-        it("anti_patterns ordered with high priority", () => {
-            const ctx = {
-                anti_patterns: ["ANTI-PATTERN: repeated modification without test"],
-                conventions: ["naming: camelCase"],
-                blast_radius: "14 callers",
-            };
-            const ordered = orderContextFields(ctx);
-            const keys = Object.keys(ordered);
-            expect(keys.indexOf("anti_patterns")).toBeLessThan(keys.indexOf("conventions"));
-        });
-    });
-});

package/dist/__tests__/sprint-s8-value.test.js

@@ -1,167 +0,0 @@
-/**
- * Sprint S8: Value Surfacing — Tests
- *
- * S8.1: Guard fires once when threshold crossed
- * S8.2: Per-response _meta has optimization + powered_by
- * S8.3: Scorecard formats correctly
- * S8.4: Weekly accumulator persists and resets
- * S8.7: Counterfactual explanation format
- */
-import { describe, expect, it } from "vitest";
-import { assembleValueMeta, createValueGuard, formatCounterfactual, formatScorecard, } from "../config/value-surfacing.js";
-import { formatStatsReport, loadStats, } from "../tracking/weekly-accumulator.js";
-// ── S8.1: Value Guard ──────────────────────────────────────────────
-describe("S8.1: Value Guard", () => {
-    it("does not fire below threshold", () => {
-        const guard = createValueGuard(1.0);
-        expect(guard.check(0.49)).toBeNull();
-        expect(guard.hasFired()).toBe(false);
-    });
-    it("fires once when threshold crossed", () => {
-        const guard = createValueGuard(0.5);
-        const msg = guard.check(0.75);
-        expect(msg).toContain("$0.75");
-        expect(guard.hasFired()).toBe(true);
-    });
-    it("does not fire a second time", () => {
-        const guard = createValueGuard(0.5);
-        guard.check(0.6); // fires
-        expect(guard.check(1.0)).toBeNull(); // already fired
-    });
-    it("resets correctly", () => {
-        const guard = createValueGuard(0.5);
-        guard.check(0.6);
-        guard.reset();
-        expect(guard.hasFired()).toBe(false);
-        const msg = guard.check(0.8);
-        expect(msg).toContain("$0.80");
-    });
-});
-// ── S8.2: Per-response _meta ───────────────────────────────────────
-describe("S8.2: Value Meta Assembly", () => {
-    it("assembles basic meta fields", () => {
-        const meta = assembleValueMeta(1500, 0.009);
-        expect(meta.tokens_saved).toBe(1500);
-        expect(meta.dollar_savings).toBe(0.009);
-        expect(meta.powered_by).toContain("unerr");
-        expect(meta.optimization).toBeUndefined();
-    });
-    it("includes optimization description when provided", () => {
-        const meta = assembleValueMeta(3000, 0.018, "blast_radius served 7 files");
-        expect(meta.optimization).toBe("blast_radius served 7 files");
-    });
-    it("rounds dollar savings to 6 decimal places", () => {
-        const meta = assembleValueMeta(100, 0.0001234567);
-        expect(meta.dollar_savings).toBe(0.000123);
-    });
-});
-// ── S8.3: Session Scorecard ────────────────────────────────────────
-describe("S8.3: Session Scorecard", () => {
-    it("formats basic scorecard", () => {
-        const input = {
-            toolCalls: 47,
-            tokensSaved: 45200,
-            dollarsSaved: 0.27,
-            efficiency: 73,
-            durationMs: 12 * 60_000,
-            blastRadiusComputed: 4,
-            conventionsInjected: 3,
-            outputsCompressed: 12,
-            correctionsApplied: 2,
-            wrongApproachesPrevented: 0,
-        };
-        const sc = formatScorecard(input);
-        expect(sc.toolCalls).toBe(47);
-        expect(sc.tokensSaved).toBe("45.2K");
-        expect(sc.dollarsSaved).toBe("$0.27");
-        expect(sc.efficiency).toBe("73%");
-        expect(sc.duration).toBe("12 min");
-        expect(sc.intelligenceApplied).toContain("4 blast radius computations");
-        expect(sc.intelligenceApplied).toContain("3 convention injections");
-        expect(sc.intelligenceApplied).toContain("12 outputs compressed");
-        expect(sc.intelligenceApplied).toContain("2 corrections applied");
-    });
-    it("handles zero duration", () => {
-        const input = {
-            toolCalls: 3,
-            tokensSaved: 500,
-            dollarsSaved: 0.003,
-            efficiency: 50,
-            durationMs: 20_000,
-            blastRadiusComputed: 0,
-            conventionsInjected: 0,
-            outputsCompressed: 0,
-            correctionsApplied: 0,
-            wrongApproachesPrevented: 0,
-        };
-        const sc = formatScorecard(input);
-        expect(sc.duration).toBe("<1 min");
-        expect(sc.intelligenceApplied).toHaveLength(0);
-    });
-    it("formats million tokens", () => {
-        const input = {
-            toolCalls: 200,
-            tokensSaved: 1_500_000,
-            dollarsSaved: 9.0,
-            efficiency: 85,
-            durationMs: 45 * 60_000,
-            blastRadiusComputed: 10,
-            conventionsInjected: 5,
-            outputsCompressed: 30,
-            correctionsApplied: 4,
-            wrongApproachesPrevented: 2,
-        };
-        const sc = formatScorecard(input);
-        expect(sc.tokensSaved).toBe("1.5M");
-        expect(sc.intelligenceApplied).toContain("2 wrong approaches prevented");
-    });
-});
-// ── S8.4: Weekly Accumulator ───────────────────────────────────────
-describe("S8.4: Weekly Accumulator", () => {
-    it("loadStats returns valid empty structure", () => {
-        const stats = loadStats();
-        expect(stats.version).toBe(1);
-        expect(stats.weekly.sessions).toBeGreaterThanOrEqual(0);
-        expect(stats.allTime.totalSessions).toBeGreaterThanOrEqual(0);
-        expect(stats.lastUpdated).toBeDefined();
-    });
-    it("formatStatsReport produces readable output", () => {
-        const stats = loadStats();
-        // Seed some data for formatting
-        stats.weekly.sessions = 5;
-        stats.weekly.tokensSaved = 280_000;
-        stats.weekly.dollarsSaved = 1.68;
-        stats.weekly.avgEfficiency = 73;
-        stats.weekly.violationsCaught = 12;
-        stats.allTime.totalSessions = 20;
-        stats.allTime.totalTokensSaved = 1_200_000;
-        stats.allTime.totalDollarsSaved = 7.2;
-        stats.allTime.totalViolationsCaught = 45;
-        const report = formatStatsReport(stats);
-        expect(report).toContain("This week:");
-        expect(report).toContain("All time:");
-        expect(report).toContain("$1.68");
-        expect(report).toContain("280.0K");
-        expect(report).toContain("73%");
-        expect(report).toContain("1.2M");
-    });
-});
-// ── S8.7: Counterfactual Explanation ───────────────────────────────
-describe("S8.7: Counterfactual Explanation", () => {
-    it("formats basic counterfactual", () => {
-        const result = formatCounterfactual(100_000, 35_000);
-        expect(result).toContain("Without unerr: ~100.0K tokens");
-        expect(result).toContain("with unerr: 35.0K tokens");
-        expect(result).toContain("65% reduction");
-    });
-    it("handles zero tokens without", () => {
-        const result = formatCounterfactual(0, 0);
-        expect(result).toContain("0% reduction");
-    });
-    it("formats millions", () => {
-        const result = formatCounterfactual(2_000_000, 600_000);
-        expect(result).toContain("2.0M");
-        expect(result).toContain("600.0K");
-        expect(result).toContain("70% reduction");
-    });
-});

package/dist/__tests__/sprint-s9-behavioral.test.js

@@ -1,179 +0,0 @@
-/**
- * Sprint S9: Day 1 Behavioral Hooks — Tests
- *
- * S9.1: Circuit breaker fires after 4 retries on same entity
- * S9.2: Health-triggered circuit break (health < 0.3)
- * S9.3: Caught event counter increments
- * S9.4: Halt message format
- * S9.5: Convention violations wire into caught counter
- * S9.6: Caught counter feeds value counter (every 3rd event)
- */
-import { beforeEach, describe, expect, it } from "vitest";
-import { SessionContext } from "../intelligence/session-context.js";
-import { createSessionEvents, totalCaughtEvents, } from "../proxy/session-stats.js";
-import { LedgerCircuitBreaker, formatHaltMessage, } from "../tracking/circuit-breaker.js";
-// ── S9.1: Circuit Breaker fires after 4 retries ───────────────────
-describe("S9.1: Circuit Breaker — entity retry detection", () => {
-    let breaker;
-    beforeEach(() => {
-        breaker = new LedgerCircuitBreaker();
-    });
-    it("does not fire with fewer than 4 violation attempts", () => {
-        breaker.recordAttempt("src/core.ts::processPayment", true);
-        breaker.recordAttempt("src/core.ts::processPayment", true);
-        breaker.recordAttempt("src/core.ts::processPayment", true);
-        const result = breaker.check(["src/core.ts::processPayment"]);
-        expect(result).toBeNull();
-    });
-    it("fires after 4 consecutive violation attempts", () => {
-        const entity = "src/core.ts::processPayment";
-        breaker.recordAttempt(entity, true);
-        breaker.recordAttempt(entity, true);
-        breaker.recordAttempt(entity, true);
-        breaker.recordAttempt(entity, true);
-        const result = breaker.check([entity]);
-        expect(result).not.toBeNull();
-        expect(result?.triggered).toBe(true);
-        expect(result?.entity).toBe(entity);
-        expect(result?.attempts).toBe(4);
-    });
-    it("does not fire if attempts have no violations", () => {
-        const entity = "src/utils.ts::formatDate";
-        breaker.recordAttempt(entity, false);
-        breaker.recordAttempt(entity, false);
-        breaker.recordAttempt(entity, false);
-        breaker.recordAttempt(entity, false);
-        const result = breaker.check([entity]);
-        expect(result).toBeNull();
-    });
-    it("does not fire if violations are interspersed with successes", () => {
-        const entity = "src/api.ts::handleRequest";
-        breaker.recordAttempt(entity, true);
-        breaker.recordAttempt(entity, true);
-        breaker.recordAttempt(entity, false); // success breaks the streak
-        breaker.recordAttempt(entity, true);
-        breaker.recordAttempt(entity, true);
-        const result = breaker.check([entity]);
-        expect(result).toBeNull();
-    });
-    it("remains halted on subsequent checks", () => {
-        const entity = "src/core.ts::processPayment";
-        for (let i = 0; i < 4; i++)
-            breaker.recordAttempt(entity, true);
-        breaker.check([entity]); // trips it
-        // Subsequent check should still show halted
-        const result = breaker.check([entity]);
-        expect(result).not.toBeNull();
-        expect(result?.triggered).toBe(true);
-    });
-    it("resets correctly for a specific entity", () => {
-        const entity = "src/core.ts::processPayment";
-        for (let i = 0; i < 4; i++)
-            breaker.recordAttempt(entity, true);
-        breaker.check([entity]);
-        breaker.reset(entity);
-        expect(breaker.isHalted(entity)).toBe(false);
-        const result = breaker.check([entity]);
-        expect(result).toBeNull();
-    });
-    it("tracks multiple entities independently", () => {
-        const entity1 = "src/a.ts::foo";
-        const entity2 = "src/b.ts::bar";
-        for (let i = 0; i < 4; i++)
-            breaker.recordAttempt(entity1, true);
-        breaker.recordAttempt(entity2, true);
-        breaker.recordAttempt(entity2, true);
-        const result1 = breaker.check([entity1]);
-        const result2 = breaker.check([entity2]);
-        expect(result1).not.toBeNull();
-        expect(result2).toBeNull();
-    });
-});
-// ── S9.3: Caught Event Counter ─────────────────────────────────────
-describe("S9.3: Caught event counter", () => {
-    it("increments convention violations", () => {
-        const events = createSessionEvents();
-        events.conventionViolationsCaught += 3;
-        expect(totalCaughtEvents(events)).toBe(3);
-    });
-    it("increments chokepoint warnings", () => {
-        const events = createSessionEvents();
-        events.chokepointWarningsIssued += 2;
-        expect(totalCaughtEvents(events)).toBe(2);
-    });
-    it("increments circular deps", () => {
-        const events = createSessionEvents();
-        events.circularDepsDetected += 1;
-        expect(totalCaughtEvents(events)).toBe(1);
-    });
-    it("sums all caught categories", () => {
-        const events = createSessionEvents();
-        events.conventionViolationsCaught = 2;
-        events.chokepointWarningsIssued = 3;
-        events.circularDepsDetected = 1;
-        events.signaturePreservations = 1;
-        events.deadCodeReferences = 2;
-        expect(totalCaughtEvents(events)).toBe(9);
-    });
-});
-// ── S9.4: Halt Message Formatter ───────────────────────────────────
-describe("S9.4: Halt message formatter", () => {
-    it("includes entity name", () => {
-        const msg = formatHaltMessage("src/core.ts::processPayment", 4);
-        expect(msg).toContain("src/core.ts::processPayment");
-    });
-    it("includes attempt count", () => {
-        const msg = formatHaltMessage("src/api.ts::handleAuth", 6);
-        expect(msg).toContain("6 times");
-    });
-    it("starts with Stop", () => {
-        const msg = formatHaltMessage("entity", 4);
-        expect(msg).toMatch(/^Stop\./);
-    });
-    it("suggests different approach", () => {
-        const msg = formatHaltMessage("entity", 5);
-        expect(msg).toContain("different approach");
-    });
-});
-// ── S9.6: Value Counter integration ────────────────────────────────
-describe("S9.6: Value counter fires on caught events", () => {
-    it("fires at every 3rd caught event after 10 tool calls", () => {
-        const ctx = new SessionContext();
-        const events = createSessionEvents();
-        // Record 11 tool calls (value counter only fires after 10)
-        for (let i = 0; i < 11; i++)
-            ctx.recordToolCall();
-        // 1st and 2nd caught event — no fire
-        events.conventionViolationsCaught = 1;
-        expect(ctx.getValueCounter(events)).toBeUndefined();
-        events.conventionViolationsCaught = 2;
-        expect(ctx.getValueCounter(events)).toBeUndefined();
-        // 3rd caught event — fires
-        events.conventionViolationsCaught = 3;
-        const msg = ctx.getValueCounter(events);
-        expect(msg).toContain("3 issues");
-    });
-    it("does not fire before 10 tool calls", () => {
-        const ctx = new SessionContext();
-        const events = createSessionEvents();
-        for (let i = 0; i < 5; i++)
-            ctx.recordToolCall();
-        events.conventionViolationsCaught = 3;
-        expect(ctx.getValueCounter(events)).toBeUndefined();
-    });
-    it("fires again at 6th caught event", () => {
-        const ctx = new SessionContext();
-        const events = createSessionEvents();
-        for (let i = 0; i < 11; i++)
-            ctx.recordToolCall();
-        events.conventionViolationsCaught = 3;
-        ctx.getValueCounter(events); // fires at 3
-        events.conventionViolationsCaught = 4;
-        expect(ctx.getValueCounter(events)).toBeUndefined();
-        events.conventionViolationsCaught = 5;
-        expect(ctx.getValueCounter(events)).toBeUndefined();
-        events.conventionViolationsCaught = 6;
-        const msg = ctx.getValueCounter(events);
-        expect(msg).toContain("6 issues");
-    });
-});