@underactive/pi-topping-web-tools 0.1.0 → 0.2.0

package/src/web-browser/permissions.ts

@@ -7,7 +7,8 @@
  */
 
 import type { ExtensionContext } from "@earendil-works/pi-coding-agent";
-import { isPreapprovedHost } from "../permissions.ts";
+import { isPreapprovedHost, permissionKey } from "../permissions.ts";
+import { requestHostPermission } from "../permission-prompt.ts";
 
 export const MAX_URL_LENGTH = 2000;
 
@@ -44,6 +45,37 @@ export function validateURL(url: string): boolean {
 	return parsed.protocol === "http:" || parsed.protocol === "https:";
 }
 
+function isPrivateIpv4Octets(octets: number[]): boolean {
+	if (octets.some((n) => n > 255)) {
+		return false;
+	}
+	const [a, b] = octets;
+	return (
+		a === 127 ||
+		a === 0 ||
+		a === 10 ||
+		(a === 172 && b >= 16 && b <= 31) ||
+		(a === 192 && b === 168) ||
+		(a === 169 && b === 254)
+	);
+}
+
+function mappedIpv4Octets(suffix: string): number[] | undefined {
+	// Dotted-quad form: ::ffff:10.0.0.1
+	const dotted = /^(\d{1,3}(?:\.\d{1,3}){3})$/.exec(suffix);
+	if (dotted) {
+		return dotted[1].split(".").map((part) => Number.parseInt(part, 10));
+	}
+	// Two hex groups form: ::ffff:a00:1
+	const hex = /^([0-9a-f]{1,4}):([0-9a-f]{1,4})$/i.exec(suffix);
+	if (hex) {
+		const high = Number.parseInt(hex[1], 16);
+		const low = Number.parseInt(hex[2], 16);
+		return [high >> 8, high & 0xff, low >> 8, low & 0xff];
+	}
+	return undefined;
+}
+
 export function isLocalOrPrivateHost(hostname: string): boolean {
 	const host =
 		hostname.startsWith("[") && hostname.endsWith("]") ? hostname.slice(1, -1) : hostname;
@@ -54,28 +86,23 @@ export function isLocalOrPrivateHost(hostname: string): boolean {
 	if (host.endsWith(".local")) {
 		return true;
 	}
-	if (/^(fc|fd|fe80:)/i.test(host) || /^::ffff:7f/i.test(host)) {
+	if (/^(fc|fd|fe80:)/i.test(host)) {
 		return true;
 	}
 
-	if (!/^\d{1,3}(?:\.\d{1,3}){3}$/.test(host)) {
-		return false;
+	const mapped = /^::ffff:(.+)$/i.exec(host);
+	if (mapped) {
+		const octets = mappedIpv4Octets(mapped[1]);
+		if (octets && isPrivateIpv4Octets(octets)) {
+			return true;
+		}
 	}
 
-	const octets = host.split(".").map((part) => Number.parseInt(part, 10));
-	if (octets.some((n) => n > 255)) {
+	if (!/^\d{1,3}(?:\.\d{1,3}){3}$/.test(host)) {
 		return false;
 	}
 
-	const [a, b] = octets;
-	if (a === 127) return true;
-	if (a === 0) return true;
-	if (a === 10) return true;
-	if (a === 172 && b >= 16 && b <= 31) return true;
-	if (a === 192 && b === 168) return true;
-	if (a === 169 && b === 254) return true;
-
-	return false;
+	return isPrivateIpv4Octets(host.split(".").map((part) => Number.parseInt(part, 10)));
 }
 
 export function upgradeHttpToHttps(url: string): string {
@@ -91,18 +118,6 @@ export function upgradeHttpToHttps(url: string): string {
 	return url;
 }
 
-export function permissionKey(url: string): string {
-	try {
-		const parsed = new URL(url);
-		if (parsed.protocol === "file:") {
-			return `file://${parsed.pathname}`;
-		}
-		return `${parsed.protocol}//${parsed.host}`;
-	} catch {
-		return url;
-	}
-}
-
 export type PermissionResult = "allow" | `block:${string}`;
 
 export async function checkUrlPermission(
@@ -131,32 +146,19 @@ export async function checkUrlPermission(
 	}
 
 	const key = permissionKey(url);
-	const sessionDecision = sessionPermissions.get(key);
-	if (sessionDecision === "allow") {
+	const isDurable = protocol !== "file:";
+	const label = isDurable ? `Allow web_browser to ${hostname}?` : `Allow web_browser to local file ${pathname}?`;
+
+	const result = await requestHostPermission(ctx, {
+		scope: "web_browser",
+		label,
+		key,
+		sessionPermissions,
+		durable: isDurable,
+	});
+
+	if (result.allowed) {
 		return "allow";
 	}
-	if (sessionDecision === "deny") {
-		return `block:Denied by user for ${key}`;
-	}
-
-	if (!ctx.hasUI) {
-		return `block:web_browser to ${key} blocked (no UI for confirmation)`;
-	}
-
-	const label = protocol === "file:" ? `Allow web_browser to local file ${pathname}?` : `Allow web_browser to ${hostname}?`;
-	const choice = await ctx.ui.select(label, ["Allow once", "Allow for this session", "Deny"]);
-
-	if (choice === "Allow for this session") {
-		sessionPermissions.set(key, "allow");
-		return "allow";
-	}
-	if (choice === "Deny") {
-		sessionPermissions.set(key, "deny");
-		return `block:Denied by user for ${key}`;
-	}
-	if (choice === "Allow once") {
-		return "allow";
-	}
-
-	return `block:Denied by user for ${key}`;
+	return `block:${result.reason}`;
 }

package/src/web-permissions.ts

@@ -0,0 +1,73 @@
+/**
+ * /web-permissions — list and revoke saved web-tool host permissions.
+ *
+ * Shows all active durable grants from the permission store.
+ * Users can select entries to revoke them. Bundled preapproved hosts
+ * (from the shared allowlist) are not listed and cannot be deleted here.
+ */
+
+import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import { listGrants, removeGrant, type Grant } from "./permission-store.ts";
+
+function formatRemaining(expiresAt: number): string {
+	const ms = expiresAt - Date.now();
+	if (ms <= 0) return "expired";
+	const hours = Math.floor(ms / (60 * 60 * 1000));
+	const days = Math.floor(hours / 24);
+	const remHours = hours % 24;
+	if (days > 0) return `${days}d ${remHours}h`;
+	return `${hours}h`;
+}
+
+function formatEntry(grant: Grant): string {
+	return `${grant.origin} \u2014 ${grant.scope} \u2014 expires in ${formatRemaining(grant.expiresAt)}`;
+}
+
+export default function (pi: ExtensionAPI) {
+	pi.registerCommand("web-permissions", {
+		description: "List and revoke saved web-tool host permissions",
+		handler: async (_args, ctx) => {
+			if (!ctx.hasUI) {
+				ctx.ui.notify("The /web-permissions command requires an interactive session.", "warning");
+				return;
+			}
+
+			while (true) {
+				const grants = listGrants();
+
+				if (grants.length === 0) {
+					ctx.ui.notify(
+						"No saved host permissions. Bundled preapproved hosts still apply.",
+						"info",
+					);
+					return;
+				}
+
+				grants.sort((a, b) => a.origin.localeCompare(b.origin) || a.scope.localeCompare(b.scope));
+
+				const options = [...grants.map(formatEntry), "Done"];
+				const choice = await ctx.ui.select("Saved host permissions:", options);
+
+				if (choice === "Done" || choice === undefined) {
+					return;
+				}
+
+				// Find the selected grant by matching the formatted entry.
+				const index = grants.findIndex((g) => formatEntry(g) === choice);
+				if (index === -1) continue;
+
+				const grant = grants[index];
+				const confirmed = await ctx.ui.confirm(
+					"Remove permission?",
+					`${grant.scope} \u2192 ${grant.origin}`,
+				);
+
+				if (confirmed) {
+					await removeGrant(grant.scope, grant.origin);
+					ctx.ui.notify(`Removed permission for ${grant.origin}`, "info");
+				}
+				// Loop back to show updated list.
+			}
+		},
+	});
+}