@unchainedshop/plugins 4.0.0-rc.8 → 4.0.0

package/src/payment/postfinance-checkout/handler-express.ts

@@ -3,7 +3,7 @@ import { createLogger } from '@unchainedshop/logger';
 import { WebhookData } from './types.js';
 import { getTransaction, getTransactionCompletion } from './api.js';
 
-const logger = createLogger('unchained:core-payment:postfinance-checkout:handler');
+const logger = createLogger('unchained:postfinance-checkout:handler');
 
 export const postfinanceCheckoutHandler = async (req, res) => {
   const context = req.unchainedContext as Context;
@@ -26,19 +26,19 @@ export const postfinanceCheckoutHandler = async (req, res) => {
           transactionId: transactionCompletion.linkedTransaction,
         },
       });
+
+      if (!order) throw new Error(`Order with id ${orderPayment.orderId} not found`);
+
       logger.info(
-        `Transaction ${transactionCompletion.linkedTransaction} marked order payment ID ${transaction.metaData.orderPaymentId} as paid`,
+        `Transaction ${transactionCompletion.linkedTransaction} marked order payment ID ${transaction.metaData?.orderPaymentId} as paid`,
       );
-      res.writeHead(200);
-      res.end(`Order marked as paid: ${order.orderNumber}`);
+      res.status(200).send(`Order marked as paid: ${order.orderNumber}`);
     } catch (e) {
       logger.error(e);
-      res.writeHead(500);
-      res.end(JSON.stringify({ name: e.name, code: e.code, message: e.message }));
+      res.status(500).send({ name: e.name, code: e.code, message: e.message });
     }
   } else {
     logger.error(`Received unknown listenerEntityTechnicalName ${data.listenerEntityTechnicalName}`);
-    res.writeHead(404);
-    res.end();
+    res.status(404).end();
   }
 };

package/src/payment/postfinance-checkout/handler-fastify.ts

@@ -4,7 +4,7 @@ import { WebhookData } from './types.js';
 import { getTransaction, getTransactionCompletion } from './api.js';
 import { FastifyRequest, RouteHandlerMethod } from 'fastify';
 
-const logger = createLogger('unchained:core-payment:postfinance-checkout:handler');
+const logger = createLogger('unchained:postfinance-checkout:handler');
 
 export const postfinanceCheckoutHandler: RouteHandlerMethod = async (
   req: FastifyRequest & {
@@ -32,15 +32,18 @@ export const postfinanceCheckoutHandler: RouteHandlerMethod = async (
           transactionId: transaction.id,
         },
       });
+
+      if (!order) throw new Error(`Order with id ${orderPayment.orderId} not found`);
+
       logger.info(
-        `Transaction ${transaction.id} marked order payment ID ${transaction.metaData.orderPaymentId} as paid`,
+        `Transaction ${transaction.id} marked order payment ID ${transaction.metaData?.orderPaymentId} as paid`,
       );
       reply.status(200);
-      return reply.send(`Order marked as paid: ${order.orderNumber}`);
+      return reply.send({ success: true, orderNumber: order.orderNumber });
     } catch (e) {
       logger.error(e);
       reply.status(500);
-      return reply.send({ name: e.name, code: e.code, message: e.message });
+      return reply.send({ success: false, name: e.name, code: e.code, message: e.message });
     }
   } else {
     logger.error(`Received unknown listenerEntityTechnicalName ${data.listenerEntityTechnicalName}`);

package/src/payment/postfinance-checkout/index.ts

@@ -40,7 +40,7 @@ const {
   PFCHECKOUT_FAILED_URL,
 } = process.env;
 
-const logger = createLogger('unchained:core-payment:postfinance-checkout');
+const logger = createLogger('unchained:postfinance-checkout');
 
 const newError = ({ code, message }: { code: string; message: string }) => {
   const error = new Error(message);
@@ -104,6 +104,10 @@ const PostfinanceCheckout: IPaymentAdapter = {
       sign: async (transactionContext: any = {}) => {
         const { orderPayment, order } = context;
 
+        if (!order) throw new Error('No order in context, can only sign with order context');
+        if (!orderPayment)
+          throw new Error('No order payment in context, can only sign with order payment context');
+
         const { integrationMode = IntegrationModes.PaymentPage }: { integrationMode: IntegrationModes } =
           transactionContext;
         const completionMode = adapter.getCompletionMode();
@@ -146,7 +150,10 @@ const PostfinanceCheckout: IPaymentAdapter = {
         }
 
         const transactionId = await createTransaction(transaction);
-        let location = null;
+
+        if (!transactionId) throw new Error('Could not create transaction');
+
+        let location: string | null = null;
         if (integrationMode === IntegrationModes.PaymentPage) {
           location = await getPaymentPageUrl(transactionId);
         } else if (integrationMode === IntegrationModes.Lightbox) {
@@ -185,7 +192,11 @@ const PostfinanceCheckout: IPaymentAdapter = {
           });
         }
 
-        const isPaid = await orderIsPaid(context.order, transaction);
+        const { order, orderPayment } = context;
+        if (!orderPayment) throw new Error('No order payment in context, cannot charge payment');
+        if (!order) throw new Error('No order in context, can only sign with order context');
+
+        const isPaid = await orderIsPaid(order, transaction);
         if (!isPaid) {
           logger.error(`Transaction #${transactionId}: Invalid state / Amount incorrect`);
           throw newError({
@@ -194,7 +205,7 @@ const PostfinanceCheckout: IPaymentAdapter = {
           });
         }
 
-        if (transaction.metaData.orderPaymentId !== context.orderPayment._id) {
+        if (transaction.metaData?.orderPaymentId !== orderPayment._id) {
           logger.error(`Transaction #${transactionId}: Invalid state / Amount incorrect`);
           throw newError({
             code: `TRANSACTION_ALREADY_USED`,
@@ -216,10 +227,11 @@ const PostfinanceCheckout: IPaymentAdapter = {
 
       cancel: async () => {
         const { orderPayment, order } = context;
-        const { transactionId } = orderPayment;
-        if (!transactionId) {
+        if (!order) throw new Error('No order in context, can only cancel with order context');
+        if (!orderPayment?.transactionId) {
           return false;
         }
+        const { transactionId } = orderPayment;
         const transaction = await getTransaction(transactionId);
         const refund = transaction.state === TransactionState.FULFILL;
         const pricing = OrderPricingSheet({
@@ -237,10 +249,10 @@ const PostfinanceCheckout: IPaymentAdapter = {
 
       confirm: async () => {
         const { orderPayment } = context;
-        const { transactionId } = orderPayment;
-        if (!transactionId) {
+        if (!orderPayment?.transactionId) {
           return false;
         }
+        const { transactionId } = orderPayment;
         const transaction = await getTransaction(transactionId);
         if (transaction.state === TransactionState.AUTHORIZED) {
           return confirmDeferredTransaction(transactionId);

package/src/payment/saferpay/adapter.ts

@@ -133,8 +133,8 @@ export const WordlineSaferpay: IPaymentAdapter = {
           saferpayTransactionId,
         );
 
-        paymentPageInitInput.Notification.SuccessNotifyUrl = addTransactionId(
-          paymentPageInitInput.Notification.SuccessNotifyUrl,
+        paymentPageInitInput.Notification!.SuccessNotifyUrl = addTransactionId(
+          paymentPageInitInput.Notification!.SuccessNotifyUrl,
           saferpayTransactionId,
         );
 
@@ -166,6 +166,10 @@ export const WordlineSaferpay: IPaymentAdapter = {
           mongodb.ObjectId.createFromHexString(transactionId),
         );
 
+        if (!saferpayTransaction?.token) {
+          throw new Error('No initialized transaction Token');
+        }
+
         const api = createSaferPayClient();
         const paymentPageAssert = await api.paymentPageAssert(orderPayment, {
           Token: saferpayTransaction.token,
@@ -205,6 +209,10 @@ export const WordlineSaferpay: IPaymentAdapter = {
           mongodb.ObjectId.createFromHexString(transactionId),
         );
 
+        if (!saferpayTransaction?.token) {
+          throw new Error('No initialized transaction Token');
+        }
+
         const api = createSaferPayClient();
         const paymentPageAssert = await api.paymentPageAssert(orderPayment, {
           Token: saferpayTransaction.token,
@@ -236,6 +244,10 @@ export const WordlineSaferpay: IPaymentAdapter = {
           mongodb.ObjectId.createFromHexString(transactionId),
         );
 
+        if (!saferpayTransaction?.token) {
+          throw new Error('No initialized transaction Token');
+        }
+
         const api = createSaferPayClient();
         const paymentPageAssert = await api.paymentPageAssert(orderPayment, {
           Token: saferpayTransaction.token,

package/src/payment/saferpay/handler-express.ts

@@ -3,7 +3,7 @@ import { createLogger } from '@unchainedshop/logger';
 import { buildSignature } from './buildSignature.js';
 import { SaferpayTransactionsModule } from './module.js';
 
-const logger = createLogger('unchained:core-payment:saferpay:handler');
+const logger = createLogger('unchained:saferpay:handler');
 
 export const saferpayHandler = async (request, response) => {
   const resolvedContext = request.unchainedContext as Context & {
@@ -22,8 +22,7 @@ export const saferpayHandler = async (request, response) => {
 
   if ((request.method !== 'GET' && request.method !== 'HEAD') || !isValidRequest) {
     logger.warn(`unhandled http method ${request.method} or orderPaymentId missing in query`);
-    response.writeHead(404);
-    response.end();
+    response.status(404).end();
     return;
   }
 
@@ -47,24 +46,26 @@ export const saferpayHandler = async (request, response) => {
         transactionId,
       },
     });
+
+    if (!order) throw new Error(`Order with id ${orderPayment.orderId} not found`);
+
     logger.info(`checkout successful`, {
       orderPaymentId,
       orderId: order._id,
     });
-    response.writeHead(200);
-    response.end(
-      JSON.stringify({
-        message: 'checkout successful',
-        orderPaymentId,
-        orderId: order._id,
-      }),
-    );
+    response.status(200).send({
+      message: 'checkout successful',
+      orderPaymentId,
+      orderId: order._id,
+    });
   } catch (error) {
     logger.error(error, {
       orderPaymentId,
       transactionId,
     });
-    response.writeHead(500);
-    response.end(error.message);
+    response.status(500).send({
+      message: error.message,
+      name: error.name,
+    });
   }
 };

package/src/payment/saferpay/handler-fastify.ts

@@ -4,7 +4,7 @@ import { buildSignature } from './buildSignature.js';
 import { SaferpayTransactionsModule } from './module.js';
 import { FastifyRequest, RouteHandlerMethod } from 'fastify';
 
-const logger = createLogger('unchained:core-payment:saferpay:handler');
+const logger = createLogger('unchained:saferpay:handler');
 
 export const saferpayHandler: RouteHandlerMethod = async (
   request: FastifyRequest & {
@@ -52,24 +52,29 @@ export const saferpayHandler: RouteHandlerMethod = async (
         transactionId,
       },
     });
+
+    if (!order) throw new Error(`Order with id ${orderPayment.orderId} not found`);
+
     logger.info(`checkout successful`, {
       orderPaymentId,
       orderId: order._id,
     });
     reply.status(200);
-    return reply.send(
-      JSON.stringify({
-        message: 'checkout successful',
-        orderPaymentId,
-        orderId: order._id,
-      }),
-    );
+    return reply.send({
+      success: true,
+      orderPaymentId,
+      orderId: order._id,
+    });
   } catch (error) {
     logger.error(error, {
       orderPaymentId,
       transactionId,
     });
     reply.status(500);
-    return reply.send(error.message);
+    return reply.send({
+      success: false,
+      message: error.message,
+      name: error.name,
+    });
   }
 };

package/src/payment/stripe/handler-express.ts

@@ -2,7 +2,7 @@ import { Context } from '@unchainedshop/api';
 import { createLogger } from '@unchainedshop/logger';
 import stripeClient from './stripe.js';
 
-const logger = createLogger('unchained:core-payment:stripe:handler');
+const logger = createLogger('unchained:stripe:handler');
 
 export const WebhookEventTypes = {
   PAYMENT_INTENT_SUCCEEDED: 'payment_intent.succeeded',
@@ -18,11 +18,19 @@ export const stripeHandler = async (request, response) => {
   try {
     const stripe = stripeClient();
     const sig = request.headers['stripe-signature'];
+    if (!sig) {
+      throw new Error('stripe-signature header was not provided for webhook');
+    }
+    if (!process.env.STRIPE_ENDPOINT_SECRET) {
+      throw new Error('env STRIPE_ENDPOINT_SECRET is required for webhook handling');
+    }
     event = stripe.webhooks.constructEvent(request.body, sig, process.env.STRIPE_ENDPOINT_SECRET);
   } catch (err) {
     logger.error(`Error constructing event: ${err.message}`);
-    response.writeHead(400);
-    response.end(err.message);
+    response.status(400).send({
+      message: err.message,
+      name: err.name,
+    });
     return;
   }
 
@@ -30,13 +38,10 @@ export const stripeHandler = async (request, response) => {
     logger.info(`unhandled event type`, {
       type: event.type,
     });
-    response.writeHead(200);
-    response.end(
-      JSON.stringify({
-        ignored: true,
-        message: `Unhandled event type: ${event.type}. Supported types: ${Object.values(WebhookEventTypes).join(', ')}`,
-      }),
-    );
+    response.status(200).send({
+      ignored: true,
+      message: `Unhandled event type: ${event.type}. Supported types: ${Object.values(WebhookEventTypes).join(', ')}`,
+    });
     return;
   }
 
@@ -47,13 +52,10 @@ export const stripeHandler = async (request, response) => {
       type: event.type,
       environment: environmentInMetadata,
     });
-    response.writeHead(200);
-    response.end(
-      JSON.stringify({
-        ignored: true,
-        message: `Unhandled event environment: ${environmentInMetadata}. Supported environment: ${environmentInEnv}`,
-      }),
-    );
+    response.status(200).send({
+      ignored: true,
+      message: `Unhandled event environment: ${environmentInMetadata}. Supported environment: ${environmentInEnv}`,
+    });
     return;
   }
 
@@ -84,18 +86,17 @@ export const stripeHandler = async (request, response) => {
         },
       });
 
+      if (!order) throw new Error(`Order with id ${orderPayment.orderId} not found`);
+
       logger.info(`checkout successful`, {
         orderPaymentId,
         orderId: order._id,
         type: event.type,
       });
-      response.writeHead(200);
-      response.end(
-        JSON.stringify({
-          message: 'checkout successful',
-          orderId: order._id,
-        }),
-      );
+      response.status(200).send({
+        message: 'checkout successful',
+        orderId: order._id,
+      });
     } else if (event.type === WebhookEventTypes.SETUP_INTENT_SUCCEEDED) {
       const setupIntent = event.data.object;
       const { paymentProviderId, userId } = setupIntent.metadata || {};
@@ -118,19 +119,18 @@ export const stripeHandler = async (request, response) => {
         paymentCredentialsId: paymentCredentials?._id,
         type: event.type,
       });
-      response.writeHead(200);
-      response.end(
-        JSON.stringify({
-          message: 'payment credentials registration successful',
-          paymentCredentialsId: paymentCredentials?._id,
-        }),
-      );
+      response.status(200).send({
+        message: 'payment credentials registration successful',
+        paymentCredentialsId: paymentCredentials?._id,
+      });
     }
   } catch (error) {
     logger.error(error, {
       type: event.type,
     });
-    response.writeHead(500);
-    response.end(error.message);
+    response.status(500).send({
+      message: error.message,
+      name: error.name,
+    });
   }
 };

package/src/payment/stripe/handler-fastify.ts

@@ -3,7 +3,7 @@ import { createLogger } from '@unchainedshop/logger';
 import stripeClient from './stripe.js';
 import { FastifyRequest, RouteHandlerMethod } from 'fastify';
 
-const logger = createLogger('unchained:core-payment:stripe:handler');
+const logger = createLogger('unchained:stripe:handler');
 
 export const WebhookEventTypes = {
   PAYMENT_INTENT_SUCCEEDED: 'payment_intent.succeeded',
@@ -24,11 +24,21 @@ export const stripeHandler: RouteHandlerMethod = async (
   try {
     const stripe = stripeClient();
     const sig = req.headers['stripe-signature'];
+    if (!process.env.STRIPE_ENDPOINT_SECRET) {
+      throw new Error('env STRIPE_ENDPOINT_SECRET is required for webhook handling');
+    }
+    if (!sig) {
+      throw new Error('stripe-signature header was not provided for webhook');
+    }
     event = stripe.webhooks.constructEvent(req.body as string, sig, process.env.STRIPE_ENDPOINT_SECRET);
   } catch (err) {
     logger.error(`Error constructing event: ${err.message}`);
     reply.status(400);
-    return reply.send(err.message);
+    return reply.send({
+      success: false,
+      message: err.message,
+      name: err.name,
+    });
   }
 
   if (!Object.values(WebhookEventTypes).includes(event.type)) {
@@ -36,12 +46,12 @@ export const stripeHandler: RouteHandlerMethod = async (
       type: event.type,
     });
     reply.status(200);
-    return reply.send(
-      JSON.stringify({
-        ignored: true,
-        message: `Unhandled event type: ${event.type}. Supported types: ${Object.values(WebhookEventTypes).join(', ')}`,
-      }),
-    );
+    return reply.send({
+      success: false,
+      ignored: true,
+      name: 'UNHANDLED_EVENT_TYPE',
+      message: `Unhandled event type: ${event.type}. Supported types: ${Object.values(WebhookEventTypes).join(', ')}`,
+    });
   }
 
   const environmentInMetadata = event.data?.object?.metadata?.environment || '';
@@ -52,12 +62,12 @@ export const stripeHandler: RouteHandlerMethod = async (
       environment: environmentInMetadata,
     });
     reply.status(200);
-    return reply.send(
-      JSON.stringify({
-        ignored: true,
-        message: `Unhandled event environment: ${environmentInMetadata}. Supported environment: ${environmentInEnv}`,
-      }),
-    );
+    return reply.send({
+      success: false,
+      ignored: true,
+      name: 'UNHANDLED_EVENT_ENVIRONMENT',
+      message: `Unhandled event environment: ${environmentInMetadata}. Supported environment: ${environmentInEnv}`,
+    });
   }
 
   logger.info(`Processing event`, {
@@ -87,18 +97,18 @@ export const stripeHandler: RouteHandlerMethod = async (
         },
       });
 
+      if (!order) throw new Error(`Order with id ${orderPayment.orderId} not found`);
+
       logger.info(`checkout successful`, {
         orderPaymentId,
         orderId: order._id,
         type: event.type,
       });
       reply.status(200);
-      return reply.send(
-        JSON.stringify({
-          message: 'checkout successful',
-          orderId: order._id,
-        }),
-      );
+      return reply.send({
+        success: true,
+        orderId: order._id,
+      });
     } else if (event.type === WebhookEventTypes.SETUP_INTENT_SUCCEEDED) {
       const setupIntent = event.data.object;
       const { paymentProviderId, userId } = setupIntent.metadata || {};
@@ -122,18 +132,21 @@ export const stripeHandler: RouteHandlerMethod = async (
         type: event.type,
       });
       reply.status(200);
-      return reply.send(
-        JSON.stringify({
-          message: 'payment credentials registration successful',
-          paymentCredentialsId: paymentCredentials?._id,
-        }),
-      );
+      return reply.send({
+        success: true,
+        message: 'payment credentials registration successful',
+        paymentCredentialsId: paymentCredentials?._id,
+      });
     }
   } catch (error) {
     logger.error(error, {
       type: event.type,
     });
     reply.status(500);
-    return reply.send(error.message);
+    return reply.send({
+      success: false,
+      message: error.message,
+      name: error.name,
+    });
   }
 };

package/src/payment/stripe/index.ts

@@ -8,7 +8,7 @@ import {
   PaymentError,
 } from '@unchainedshop/core';
 
-const logger = createLogger('unchained:core-payment:stripe');
+const logger = createLogger('unchained:stripe');
 
 const Stripe: IPaymentAdapter = {
   ...PaymentAdapter,
@@ -24,13 +24,14 @@ const Stripe: IPaymentAdapter = {
   actions: (config, context) => {
     const { modules } = context;
 
-    const descriptorPrefix = config.find(({ key }) => key === 'descriptorPrefix')?.value;
+    const descriptorPrefix = config.find(({ key }) => key === 'descriptorPrefix')?.value || '';
 
-    const getUserData = async (forcedUserId) => {
+    const assertUserData = async (forcedUserId) => {
       const userId = forcedUserId || context?.userId;
       const user = await modules.users.findUserById(userId);
+      if (!user) throw new Error('User not found');
       const email = modules.users.primaryEmail(user)?.address;
-      const name = user.profile.displayName || user.username || email;
+      const name = user.profile?.displayName || user.username || email;
       return {
         email,
         name,
@@ -41,8 +42,9 @@ const Stripe: IPaymentAdapter = {
       ...PaymentAdapter.actions(config, context),
 
       configurationError() {
-        const stripe = stripeClient();
-        if (!stripe) {
+        try {
+          stripeClient();
+        } catch {
           return PaymentError.INCOMPLETE_CONFIGURATION;
         }
         return null;
@@ -86,13 +88,13 @@ const Stripe: IPaymentAdapter = {
 
       sign: async (transactionContext = {}) => {
         const { orderPayment, order, paymentProviderId } = context;
-
+        const { userId, name, email } = await assertUserData(order?.userId);
         if (orderPayment) {
+          if (!order) throw new Error('order not found in context');
           const pricing = OrderPricingSheet({
-            calculation: order.calculation,
-            currencyCode: order.currencyCode,
+            calculation: order?.calculation,
+            currencyCode: order?.currencyCode,
           });
-          const { userId, name, email } = await getUserData(order?.userId);
           const paymentIntent = await createOrderPaymentIntent(
             { userId, name, email, order, orderPayment, pricing, descriptorPrefix },
             transactionContext,
@@ -100,7 +102,6 @@ const Stripe: IPaymentAdapter = {
           return paymentIntent.client_secret;
         }
 
-        const { userId, name, email } = await getUserData(order?.userId);
         const paymentIntent = await createRegistrationIntent(
           { userId, name, email, paymentProviderId, descriptorPrefix },
           transactionContext,
@@ -114,11 +115,12 @@ const Stripe: IPaymentAdapter = {
           throw new Error('You have to provide paymentIntentId or paymentCredentials');
         }
 
-        const { order } = context;
-        const orderPayment = await modules.orders.payments.findOrderPayment({
-          orderPaymentId: order.paymentId,
-        });
-        const { userId, name, email } = await getUserData(order?.userId);
+        const { order, orderPayment } = context;
+
+        if (!order) throw new Error('order not found in context');
+        if (!orderPayment) throw new Error('orderPayment not found in context');
+
+        const { userId, name, email } = await assertUserData(order?.userId);
         const pricing = OrderPricingSheet({
           calculation: order.calculation,
           currencyCode: order.currencyCode,