@unbound-app/rollup-plugin-hermes 3.0.2 → 3.0.3

package/dist/index.d.mts

@@ -28,10 +28,10 @@ export type BundleEntry = {
 export type HermesPlugin = {
   name: string;
   generateBundle(this: HermesContext, options: OutputOptions, bundle: Record<string, BundleEntry>, isWrite: boolean): Promise<void>;
-  buildEnd(this: HermesContext): Promise<void>;
 };
 /**
  * @description Compiles the bundle's output file to Hermes bytecode, once per held hermesc version, as `<name>.<version>.bundle` beside it.
+ * Each build uses its own temporary folder, so builds running side by side never delete each other's files.
  * @param options A fixed hermesc directory, or which of npm's bytecode versions to hold; plus extra hermesc flags.
  * @returns The rollup plugin, which rolldown also accepts.
  */

package/dist/index.mjs

@@ -1,14 +1,13 @@
 import { hermescBinary, resolveHermesTargets } from "./manifest.mjs";
-import { mkdir, readFile, rm, writeFile } from "node:fs/promises";
+import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
 import { spawn } from "node:child_process";
 import { randomBytes } from "node:crypto";
 import { existsSync } from "node:fs";
 import { tmpdir } from "node:os";
-import { join } from "node:path";
+import { dirname, join } from "node:path";
 // src/index.ts
-const temp = join(tmpdir(), "hermesc");
-function tempFile(extension) {
-	return join(temp, `${randomBytes(8).readUint32LE(0)}${extension}`);
+function tempFile(directory, extension) {
+	return join(directory, `${randomBytes(8).readUint32LE(0)}${extension}`);
 }
 async function compile(ctx, dir, js, flags) {
 	const binary = hermescBinary(dir);
@@ -16,7 +15,7 @@ async function compile(ctx, dir, js, flags) {
 		ctx.warn(`hermesc is unsupported on this platform or missing at ${binary}, skipping it.`);
 		return;
 	}
-	const bytecode = tempFile(".bundle");
+	const bytecode = tempFile(dirname(js), ".bundle");
 	const args = [
 		"--emit-binary",
 		"--out",
@@ -58,8 +57,40 @@ async function compile(ctx, dir, js, flags) {
 		map
 	};
 }
+async function compileTargets(ctx, targets, flags, { directory, file, name, outputFile, code }) {
+	const js = tempFile(directory, ".js");
+	await writeFile(js, code, "utf-8");
+	for (const target of targets) {
+		if (!target.dir) {
+			ctx.warn(`hermesc for bytecode ${target.version} could not be downloaded, skipping it.`);
+			continue;
+		}
+		const fileName = target.version === null ? `${name}.bundle` : `${name}.${target.version}.bundle`;
+		ctx.info(`${outputFile} -> ${outputFile.replace(file, fileName)}...`);
+		const compiled = await compile(ctx, target.dir, js, flags);
+		if (!compiled) continue;
+		ctx.emitFile({
+			type: "asset",
+			fileName,
+			source: compiled.bytecode
+		});
+		if (compiled.map) {
+			const map = {
+				...JSON.parse(compiled.map),
+				sources: [file]
+			};
+			ctx.emitFile({
+				type: "asset",
+				fileName: `${fileName}.map`,
+				source: JSON.stringify(map)
+			});
+		}
+		ctx.info(`( ͡° ͜ʖ ͡°) Bytecode compiled to ${fileName}`);
+	}
+}
 /**
 * @description Compiles the bundle's output file to Hermes bytecode, once per held hermesc version, as `<name>.<version>.bundle` beside it.
+* Each build uses its own temporary folder, so builds running side by side never delete each other's files.
 * @param options A fixed hermesc directory, or which of npm's bytecode versions to hold; plus extra hermesc flags.
 * @returns The rollup plugin, which rolldown also accepts.
 */
@@ -68,52 +99,31 @@ function hermes(options = {}) {
 	return {
 		name: "hermesc",
 		async generateBundle(output, bundle) {
-			const file = output.file?.split("/").pop();
-			if (!output.file || !file) return;
+			const outputFile = output.file;
+			const file = outputFile?.split("/").pop();
+			if (!outputFile || !file) return;
 			const chunk = bundle[file];
 			if (typeof chunk?.code !== "string") return;
-			const name = file.split(".")[0];
+			const name = file.split(".")[0] ?? file;
 			targets ??= options.hermesc ? [{
 				version: null,
 				dir: options.hermesc
 			}] : await resolveHermesTargets(this, options);
-			if (!existsSync(temp)) await mkdir(temp);
-			const js = tempFile(".js");
-			await writeFile(js, chunk.code, "utf-8");
-			for (const target of targets) {
-				if (!target.dir) {
-					this.warn(`hermesc for bytecode ${target.version} could not be downloaded, skipping it.`);
-					continue;
-				}
-				const fileName = target.version === null ? `${name}.bundle` : `${name}.${target.version}.bundle`;
-				this.info(`${output.file} -> ${output.file.replace(file, fileName)}...`);
-				const compiled = await compile(this, target.dir, js, options.flags ?? []);
-				if (!compiled) continue;
-				this.emitFile({
-					type: "asset",
-					fileName,
-					source: compiled.bytecode
+			const directory = await mkdtemp(join(tmpdir(), "hermesc-"));
+			try {
+				await compileTargets(this, targets, options.flags ?? [], {
+					directory,
+					file,
+					name,
+					outputFile,
+					code: chunk.code
+				});
+			} finally {
+				await rm(directory, {
+					recursive: true,
+					force: true
 				});
-				if (compiled.map) {
-					const map = {
-						...JSON.parse(compiled.map),
-						sources: [file]
-					};
-					this.emitFile({
-						type: "asset",
-						fileName: `${fileName}.map`,
-						source: JSON.stringify(map)
-					});
-				}
-				this.info(`( ͡° ͜ʖ ͡°) Bytecode compiled to ${fileName}`);
 			}
-			await rm(js, { force: true });
-		},
-		async buildEnd() {
-			await rm(temp, {
-				recursive: true,
-				force: true
-			});
 		}
 	};
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@unbound-app/rollup-plugin-hermes",
-	"version": "3.0.2",
+	"version": "3.0.3",
 	"description": "Compiles rollup and rolldown bundles to Hermes bytecode with every hermesc version Discord may run.",
 	"author": {
 		"name": "Mario P.",