@umsai/ums-code 0.0.14-v2 → 0.1.4-v2

package/dist/src/ui/hooks/useSlashCompletion.test.js

@@ -7,7 +7,105 @@
 import { describe, it, expect, vi } from 'vitest';
 import { renderHook, waitFor } from '@testing-library/react';
 import { useSlashCompletion } from './useSlashCompletion.js';
+import { CommandKind } from '../commands/types.js';
 import { useState } from 'react';
+function createTestCommand(command) {
+    return {
+        kind: CommandKind.BUILT_IN, // default for tests
+        ...command,
+    };
+}
+// Track AsyncFzf constructor calls for cache testing
+let asyncFzfConstructorCalls = 0;
+const resetConstructorCallCount = () => {
+    asyncFzfConstructorCalls = 0;
+};
+const getConstructorCallCount = () => asyncFzfConstructorCalls;
+// Centralized fuzzy matching simulation logic
+// Note: This is a simplified reimplementation that may diverge from real fzf behavior.
+// Integration tests in useSlashCompletion.integration.test.ts use the real fzf library
+// to catch any behavioral differences and serve as our "canary in a coal mine."
+function simulateFuzzyMatching(items, query) {
+    const results = [];
+    if (query) {
+        const lowerQuery = query.toLowerCase();
+        for (const item of items) {
+            const lowerItem = item.toLowerCase();
+            // Exact match gets highest score
+            if (lowerItem === lowerQuery) {
+                results.push({
+                    item,
+                    positions: [],
+                    score: 100,
+                    start: 0,
+                    end: item.length,
+                });
+                continue;
+            }
+            // Prefix match gets high score
+            if (lowerItem.startsWith(lowerQuery)) {
+                results.push({
+                    item,
+                    positions: [],
+                    score: 80,
+                    start: 0,
+                    end: query.length,
+                });
+                continue;
+            }
+            // Fuzzy matching: check if query chars appear in order
+            let queryIndex = 0;
+            let score = 0;
+            for (let i = 0; i < lowerItem.length && queryIndex < lowerQuery.length; i++) {
+                if (lowerItem[i] === lowerQuery[queryIndex]) {
+                    queryIndex++;
+                    score += 10 - i; // Earlier matches get higher scores
+                }
+            }
+            // If all query characters were found in order, include this item
+            if (queryIndex === lowerQuery.length) {
+                results.push({
+                    item,
+                    positions: [],
+                    score,
+                    start: 0,
+                    end: query.length,
+                });
+            }
+        }
+    }
+    // Sort by score descending (better matches first)
+    results.sort((a, b) => b.score - a.score);
+    return Promise.resolve(results);
+}
+// Mock the fzf module to provide a working fuzzy search implementation for tests
+vi.mock('fzf', async () => {
+    const actual = await vi.importActual('fzf');
+    return {
+        ...actual,
+        AsyncFzf: vi.fn().mockImplementation((items, _options) => {
+            asyncFzfConstructorCalls++;
+            return {
+                find: vi
+                    .fn()
+                    .mockImplementation((query) => simulateFuzzyMatching(items, query)),
+                // eslint-disable-next-line @typescript-eslint/no-explicit-any
+            };
+        }),
+    };
+});
+// Default mock behavior helper - now uses centralized logic
+const createDefaultAsyncFzfMock = () => (items, _options) => {
+    asyncFzfConstructorCalls++;
+    return {
+        find: vi
+            .fn()
+            .mockImplementation((query) => simulateFuzzyMatching(items, query)),
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    };
+};
+// Export test utilities
+export { resetConstructorCallCount, getConstructorCallCount, createDefaultAsyncFzfMock, };
 // Test harness to capture the state from the hook's callbacks.
 function useTestHarnessForSlashCompletion(enabled, query, slashCommands, commandContext) {
     const [suggestions, setSuggestions] = useState([]);
@@ -36,19 +134,25 @@ describe('useSlashCompletion', () => {
     describe('Top-Level Commands', () => {
         it('should suggest all top-level commands for the root slash', async () => {
             const slashCommands = [
-                { name: 'help', altNames: ['?'], description: 'Show help' },
-                {
+                createTestCommand({
+                    name: 'help',
+                    altNames: ['?'],
+                    description: 'Show help',
+                }),
+                createTestCommand({
                     name: 'stats',
                     altNames: ['usage'],
                     description: 'check session stats. Usage: /stats [model|tools]',
-                },
-                { name: 'clear', description: 'Clear the screen' },
-                {
+                }),
+                createTestCommand({ name: 'clear', description: 'Clear the screen' }),
+                createTestCommand({
                     name: 'memory',
                     description: 'Manage memory',
-                    subCommands: [{ name: 'show', description: 'Show memory' }],
-                },
-                { name: 'chat', description: 'Manage chat history' },
+                    subCommands: [
+                        createTestCommand({ name: 'show', description: 'Show memory' }),
+                    ],
+                }),
+                createTestCommand({ name: 'chat', description: 'Manage chat history' }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/', slashCommands, mockCommandContext));
             expect(result.current.suggestions.length).toBe(slashCommands.length);
@@ -56,133 +160,190 @@ describe('useSlashCompletion', () => {
         });
         it('should filter commands based on partial input', async () => {
             const slashCommands = [
-                { name: 'memory', description: 'Manage memory' },
+                createTestCommand({ name: 'memory', description: 'Manage memory' }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/mem', slashCommands, mockCommandContext));
-            expect(result.current.suggestions).toEqual([
-                { label: 'memory', value: 'memory', description: 'Manage memory' },
-            ]);
+            await waitFor(() => {
+                expect(result.current.suggestions).toEqual([
+                    {
+                        label: 'memory',
+                        value: 'memory',
+                        description: 'Manage memory',
+                        commandKind: CommandKind.BUILT_IN,
+                    },
+                ]);
+            });
         });
         it('should suggest commands based on partial altNames', async () => {
             const slashCommands = [
-                {
+                createTestCommand({
                     name: 'stats',
                     altNames: ['usage'],
                     description: 'check session stats. Usage: /stats [model|tools]',
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/usag', slashCommands, mockCommandContext));
-            expect(result.current.suggestions).toEqual([
-                {
-                    label: 'stats',
-                    value: 'stats',
-                    description: 'check session stats. Usage: /stats [model|tools]',
-                },
-            ]);
+            await waitFor(() => {
+                expect(result.current.suggestions).toEqual([
+                    {
+                        label: 'stats',
+                        value: 'stats',
+                        description: 'check session stats. Usage: /stats [model|tools]',
+                        commandKind: CommandKind.BUILT_IN,
+                    },
+                ]);
+            });
         });
         it('should NOT provide suggestions for a perfectly typed command that is a leaf node', async () => {
             const slashCommands = [
-                { name: 'clear', description: 'Clear the screen', action: vi.fn() },
+                createTestCommand({
+                    name: 'clear',
+                    description: 'Clear the screen',
+                    action: vi.fn(),
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/clear', slashCommands, mockCommandContext));
             expect(result.current.suggestions).toHaveLength(0);
         });
         it.each([['/?'], ['/usage']])('should not suggest commands when altNames is fully typed', async (query) => {
             const mockSlashCommands = [
-                {
+                createTestCommand({
                     name: 'help',
                     altNames: ['?'],
                     description: 'Show help',
                     action: vi.fn(),
-                },
-                {
+                }),
+                createTestCommand({
                     name: 'stats',
                     altNames: ['usage'],
                     description: 'check session stats. Usage: /stats [model|tools]',
                     action: vi.fn(),
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, query, mockSlashCommands, mockCommandContext));
             expect(result.current.suggestions).toHaveLength(0);
         });
         it('should not provide suggestions for a fully typed command that has no sub-commands or argument completion', async () => {
             const slashCommands = [
-                { name: 'clear', description: 'Clear the screen' },
+                createTestCommand({ name: 'clear', description: 'Clear the screen' }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/clear ', slashCommands, mockCommandContext));
             expect(result.current.suggestions).toHaveLength(0);
         });
         it('should not provide suggestions for an unknown command', async () => {
             const slashCommands = [
-                { name: 'help', description: 'Show help' },
+                createTestCommand({ name: 'help', description: 'Show help' }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/unknown-command', slashCommands, mockCommandContext));
             expect(result.current.suggestions).toHaveLength(0);
         });
+        it('should not suggest hidden commands', async () => {
+            const slashCommands = [
+                createTestCommand({
+                    name: 'visible',
+                    description: 'A visible command',
+                }),
+                createTestCommand({
+                    name: 'hidden',
+                    description: 'A hidden command',
+                    hidden: true,
+                }),
+            ];
+            const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/', slashCommands, mockCommandContext));
+            expect(result.current.suggestions.length).toBe(1);
+            expect(result.current.suggestions[0].label).toBe('visible');
+        });
     });
     describe('Sub-Commands', () => {
         it('should suggest sub-commands for a parent command', async () => {
             const slashCommands = [
-                {
+                createTestCommand({
                     name: 'memory',
                     description: 'Manage memory',
                     subCommands: [
-                        { name: 'show', description: 'Show memory' },
-                        { name: 'add', description: 'Add to memory' },
+                        createTestCommand({ name: 'show', description: 'Show memory' }),
+                        createTestCommand({ name: 'add', description: 'Add to memory' }),
                     ],
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/memory', slashCommands, mockCommandContext));
             expect(result.current.suggestions).toHaveLength(2);
             expect(result.current.suggestions).toEqual(expect.arrayContaining([
-                { label: 'show', value: 'show', description: 'Show memory' },
-                { label: 'add', value: 'add', description: 'Add to memory' },
+                {
+                    label: 'show',
+                    value: 'show',
+                    description: 'Show memory',
+                    commandKind: CommandKind.BUILT_IN,
+                },
+                {
+                    label: 'add',
+                    value: 'add',
+                    description: 'Add to memory',
+                    commandKind: CommandKind.BUILT_IN,
+                },
             ]));
         });
         it('should suggest all sub-commands when the query ends with the parent command and a space', async () => {
             const slashCommands = [
-                {
+                createTestCommand({
                     name: 'memory',
                     description: 'Manage memory',
                     subCommands: [
-                        { name: 'show', description: 'Show memory' },
-                        { name: 'add', description: 'Add to memory' },
+                        createTestCommand({ name: 'show', description: 'Show memory' }),
+                        createTestCommand({ name: 'add', description: 'Add to memory' }),
                     ],
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/memory ', slashCommands, mockCommandContext));
             expect(result.current.suggestions).toHaveLength(2);
             expect(result.current.suggestions).toEqual(expect.arrayContaining([
-                { label: 'show', value: 'show', description: 'Show memory' },
-                { label: 'add', value: 'add', description: 'Add to memory' },
+                {
+                    label: 'show',
+                    value: 'show',
+                    description: 'Show memory',
+                    commandKind: CommandKind.BUILT_IN,
+                },
+                {
+                    label: 'add',
+                    value: 'add',
+                    description: 'Add to memory',
+                    commandKind: CommandKind.BUILT_IN,
+                },
             ]));
         });
         it('should filter sub-commands by prefix', async () => {
             const slashCommands = [
-                {
+                createTestCommand({
                     name: 'memory',
                     description: 'Manage memory',
                     subCommands: [
-                        { name: 'show', description: 'Show memory' },
-                        { name: 'add', description: 'Add to memory' },
+                        createTestCommand({ name: 'show', description: 'Show memory' }),
+                        createTestCommand({ name: 'add', description: 'Add to memory' }),
                     ],
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/memory a', slashCommands, mockCommandContext));
-            expect(result.current.suggestions).toEqual([
-                { label: 'add', value: 'add', description: 'Add to memory' },
-            ]);
+            await waitFor(() => {
+                expect(result.current.suggestions).toEqual([
+                    {
+                        label: 'add',
+                        value: 'add',
+                        description: 'Add to memory',
+                        commandKind: CommandKind.BUILT_IN,
+                    },
+                ]);
+            });
         });
         it('should provide no suggestions for an invalid sub-command', async () => {
             const slashCommands = [
-                {
+                createTestCommand({
                     name: 'memory',
                     description: 'Manage memory',
                     subCommands: [
-                        { name: 'show', description: 'Show memory' },
-                        { name: 'add', description: 'Add to memory' },
+                        createTestCommand({ name: 'show', description: 'Show memory' }),
+                        createTestCommand({ name: 'add', description: 'Add to memory' }),
                     ],
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/memory dothisnow', slashCommands, mockCommandContext));
             expect(result.current.suggestions).toHaveLength(0);
@@ -199,21 +360,27 @@ describe('useSlashCompletion', () => {
                 .fn()
                 .mockImplementation(async (_context, partialArg) => availableTags.filter((tag) => tag.startsWith(partialArg)));
             const slashCommands = [
-                {
+                createTestCommand({
                     name: 'chat',
                     description: 'Manage chat history',
                     subCommands: [
-                        {
+                        createTestCommand({
                             name: 'resume',
                             description: 'Resume a saved chat',
                             completion: mockCompletionFn,
-                        },
+                        }),
                     ],
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/chat resume my-ch', slashCommands, mockCommandContext));
             await waitFor(() => {
-                expect(mockCompletionFn).toHaveBeenCalledWith(mockCommandContext, 'my-ch');
+                expect(mockCompletionFn).toHaveBeenCalledWith(expect.objectContaining({
+                    invocation: {
+                        raw: '/chat resume my-ch',
+                        name: 'resume',
+                        args: 'my-ch',
+                    },
+                }), 'my-ch');
             });
             await waitFor(() => {
                 expect(result.current.suggestions).toEqual([
@@ -227,21 +394,27 @@ describe('useSlashCompletion', () => {
                 .fn()
                 .mockResolvedValue(['my-chat-tag-1', 'my-chat-tag-2', 'my-channel']);
             const slashCommands = [
-                {
+                createTestCommand({
                     name: 'chat',
                     description: 'Manage chat history',
                     subCommands: [
-                        {
+                        createTestCommand({
                             name: 'resume',
                             description: 'Resume a saved chat',
                             completion: mockCompletionFn,
-                        },
+                        }),
                     ],
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/chat resume ', slashCommands, mockCommandContext));
             await waitFor(() => {
-                expect(mockCompletionFn).toHaveBeenCalledWith(mockCommandContext, '');
+                expect(mockCompletionFn).toHaveBeenCalledWith(expect.objectContaining({
+                    invocation: {
+                        raw: '/chat resume',
+                        name: 'resume',
+                        args: '',
+                    },
+                }), '');
             });
             await waitFor(() => {
                 expect(result.current.suggestions).toHaveLength(3);
@@ -250,17 +423,17 @@ describe('useSlashCompletion', () => {
         it('should handle completion function that returns null', async () => {
             const completionFn = vi.fn().mockResolvedValue(null);
             const slashCommands = [
-                {
+                createTestCommand({
                     name: 'chat',
                     description: 'Manage chat history',
                     subCommands: [
-                        {
+                        createTestCommand({
                             name: 'resume',
                             description: 'Resume a saved chat',
                             completion: completionFn,
-                        },
+                        }),
                     ],
-                },
+                }),
             ];
             const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/chat resume ', slashCommands, mockCommandContext));
             await waitFor(() => {
@@ -268,5 +441,157 @@ describe('useSlashCompletion', () => {
             });
         });
     });
+    describe('Command Kind Information', () => {
+        it('should include commandKind for MCP commands in suggestions', async () => {
+            const slashCommands = [
+                {
+                    name: 'summarize',
+                    description: 'Summarize content',
+                    kind: CommandKind.MCP_PROMPT,
+                    action: vi.fn(),
+                },
+                {
+                    name: 'help',
+                    description: 'Show help',
+                    kind: CommandKind.BUILT_IN,
+                    action: vi.fn(),
+                },
+            ];
+            const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/', slashCommands, mockCommandContext));
+            expect(result.current.suggestions).toEqual(expect.arrayContaining([
+                {
+                    label: 'summarize',
+                    value: 'summarize',
+                    description: 'Summarize content',
+                    commandKind: CommandKind.MCP_PROMPT,
+                },
+                {
+                    label: 'help',
+                    value: 'help',
+                    description: 'Show help',
+                    commandKind: CommandKind.BUILT_IN,
+                },
+            ]));
+        });
+        it('should include commandKind when filtering MCP commands by prefix', async () => {
+            const slashCommands = [
+                {
+                    name: 'summarize',
+                    description: 'Summarize content',
+                    kind: CommandKind.MCP_PROMPT,
+                    action: vi.fn(),
+                },
+                {
+                    name: 'settings',
+                    description: 'Open settings',
+                    kind: CommandKind.BUILT_IN,
+                    action: vi.fn(),
+                },
+            ];
+            const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/summ', slashCommands, mockCommandContext));
+            await waitFor(() => {
+                expect(result.current.suggestions).toEqual([
+                    {
+                        label: 'summarize',
+                        value: 'summarize',
+                        description: 'Summarize content',
+                        commandKind: CommandKind.MCP_PROMPT,
+                    },
+                ]);
+            });
+        });
+        it('should include commandKind for sub-commands', async () => {
+            const slashCommands = [
+                {
+                    name: 'memory',
+                    description: 'Manage memory',
+                    kind: CommandKind.BUILT_IN,
+                    subCommands: [
+                        {
+                            name: 'show',
+                            description: 'Show memory',
+                            kind: CommandKind.BUILT_IN,
+                            action: vi.fn(),
+                        },
+                        {
+                            name: 'add',
+                            description: 'Add to memory',
+                            kind: CommandKind.MCP_PROMPT,
+                            action: vi.fn(),
+                        },
+                    ],
+                },
+            ];
+            const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/memory', slashCommands, mockCommandContext));
+            expect(result.current.suggestions).toEqual(expect.arrayContaining([
+                {
+                    label: 'show',
+                    value: 'show',
+                    description: 'Show memory',
+                    commandKind: CommandKind.BUILT_IN,
+                },
+                {
+                    label: 'add',
+                    value: 'add',
+                    description: 'Add to memory',
+                    commandKind: CommandKind.MCP_PROMPT,
+                },
+            ]));
+        });
+        it('should include commandKind for file commands', async () => {
+            const slashCommands = [
+                {
+                    name: 'custom-script',
+                    description: 'Run custom script',
+                    kind: CommandKind.FILE,
+                    action: vi.fn(),
+                },
+            ];
+            const { result } = renderHook(() => useTestHarnessForSlashCompletion(true, '/custom', slashCommands, mockCommandContext));
+            await waitFor(() => {
+                expect(result.current.suggestions).toEqual([
+                    {
+                        label: 'custom-script',
+                        value: 'custom-script',
+                        description: 'Run custom script',
+                        commandKind: CommandKind.FILE,
+                    },
+                ]);
+            });
+        });
+    });
+    it('should not call shared callbacks when disabled', () => {
+        const mockSetSuggestions = vi.fn();
+        const mockSetIsLoadingSuggestions = vi.fn();
+        const mockSetIsPerfectMatch = vi.fn();
+        const slashCommands = [
+            createTestCommand({
+                name: 'help',
+                description: 'Show help',
+            }),
+        ];
+        const { rerender } = renderHook(({ enabled, query }) => useSlashCompletion({
+            enabled,
+            query,
+            slashCommands,
+            commandContext: mockCommandContext,
+            setSuggestions: mockSetSuggestions,
+            setIsLoadingSuggestions: mockSetIsLoadingSuggestions,
+            setIsPerfectMatch: mockSetIsPerfectMatch,
+        }), {
+            initialProps: { enabled: false, query: '@src/file' },
+        });
+        // Clear any initial calls
+        mockSetSuggestions.mockClear();
+        mockSetIsLoadingSuggestions.mockClear();
+        mockSetIsPerfectMatch.mockClear();
+        // Change query while disabled (simulating @ completion typing)
+        rerender({ enabled: false, query: '@src/file.ts' });
+        rerender({ enabled: false, query: '@src/file.tsx' });
+        // Should not have called shared callbacks during @ completion typing
+        expect(mockSetSuggestions).not.toHaveBeenCalled();
+        expect(mockSetIsLoadingSuggestions).not.toHaveBeenCalled();
+        expect(mockSetIsPerfectMatch).not.toHaveBeenCalled();
+    });
 });
 //# sourceMappingURL=useSlashCompletion.test.js.map